On 18 August 2016 at 16:18, Marcin Wojtas mw@semihalf.com wrote:
Hi Leif,
2016-08-18 15:58 GMT+02:00 Leif Lindholm leif.lindholm@linaro.org:
On Fri, Aug 12, 2016 at 06:30:40PM +0200, Marcin Wojtas wrote:
From: Bartosz Szczepanek bsz@semihalf.com
This patch introduces an OS-independent library with the configuration routines of new PP2 NIC, whose support will be added in following commits. The library is obtained from Marvell.
This patch violates many of the code style rules - the most obvious one being the use of TAB characters, but also the use of various special typedefs (defined only in 2/3), use of 'static' rather than 'STATIC' functions and so on.
Ok, all of this will be re-checked.
I appreciate that this is some external piece of code being imported, but I would like to see some statement as to the plans for how to deal with this in future:
Are we expecting to update these two files frequently directly from new vendor releases?
- If so, should we deal with this more like the way EDK2 deals with OpenSSL? (have a look in CryptoPkg/Library/OpensslLib/)
- If not, could we convert this driver to something that would be acceptable in an EDK2 tree without any special treatment?
Unless you're happy to do the latter, I would actually be quite keen to move this discussion to edk2-devel to ensure we don't encure unexpected extra effort at a future migration of OpenPlatformPkg code into an official Tianocore repository.
Do you think that following solution is acceptable - leave 'import patch' as is and add 'adjust to edk2 style' on top of it?
So how are we going to track upstream changes to this library? If it builds ok, I really don't see the point of whitespace changes and s/static/STATIC/g just for the sake of adhering to the (slightly quirky) EDK2 coding style, since it will only make our lives more difficult if bugs are fixed upstream.
In fact, if there is a public upstream that carries this code, I'd like the git commit hash of the version that we imported in the commit log of this patch.