Re: [Linaro-uefi] [PATCH V2 03/12] Refactor get_parent_handle for sharing

...

...

On 22.07.14 at 02:43, roy.franz@linaro.org wrote:

Refactor get_parent_handle() to return NULL on error rather than directly exiting, as the exit cleanup code is arch specific.

Is it? Not at this point at least.

Having the common code reference the architecture specific code causes pre-linking to fail.

Which certainly could be addressed if you told us details.

@@ -706,6 +720,9 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) /* Get the file system interface. */ dir_handle = get_parent_handle(loaded_image, &file_name);

• if ( !dir_handle )

Please avoid the rather pointless blank line above the if().

•    blexit(L"EFI get_parent_handle failed.");
  

And please don't issue meaningless messages - the called function already prints messages on all failure paths.

Jan