On 11 April 2017 at 19:32, Leif Lindholm leif.lindholm@linaro.org wrote:
On Mon, Apr 10, 2017 at 05:22:08PM +0100, Ard Biesheuvel wrote:
Replace the elaborate but awkward FdtPlatformDxe with the new DtPlatformDxe, which supports embedded DTBs only.
So, this is technically correct (which as we all know is the best kind of correct), but then the first two hunks actually insert new references to FdtPlatformDxe.
What this code actually does is replaces FdtPlatformDxe with DtPlatformDxe in the common include files and makes the FdtPlatformDxe/DtPlatformDxe selection platform specific.
So, suggested change: "Replace the elaborate but awkward FdtPlatformDxe with the new DtPlatformDxe, which supports embedded DTBs only, for FVP platforms. This is done by removing the FdtPlatformDxe reference from ArmVExpress.dsc.inc and making it a platform-specific decision."
With that (or something like it) folded in - for the series: Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
Both parts pushed to edk2 and opp, respectively.