Remove any remaining references to the ARM BDS. For convenience, this also involves moving FVP an TC2 to the generic BDS. (Juno still uses the Intel BDS)
Ard Biesheuvel (5): Platforms/ARM/VExpress: set terminal type to TTY Platforms/ARM/VExpress: make BdsLib dependencies explicit Platforms/ARM/VExpress: add generic BDS/UiApp dependencies Platforms/ARM/ArmVExpress-CTA15-A7: switch to generic BDS Platform/ARM/FVP: switch to generic BDS
Platforms/ARM/Juno/ArmJuno.dsc | 5 ++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 13 +++++-- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 +- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 17 +++++---- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 7 ++-- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 36 ++++++++++++++------ 6 files changed, 55 insertions(+), 26 deletions(-)
This givers us a working backspace key, but it happens to be a prerequisite for using the ArmPkg implementation for PlatformBootManagerLib (used by the generic BDS) so now is a good time to make this change.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org --- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 823c934f3159..3526da121c43 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -430,6 +430,9 @@ gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } !endif
+ # use the TTY terminal type (which has a working backspace) + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 + !ifdef EDK2_ENABLE_SMSC_91X # Ethernet (SMSC 91C111) gLan91xDxeTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x1A000000
On Tue, Oct 25, 2016 at 06:15:32PM +0100, Ard Biesheuvel wrote:
This givers us a working backspace key, but it happens to be a prerequisite for using the ArmPkg implementation for PlatformBootManagerLib (used by the generic BDS) so now is a good time to make this change.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 823c934f3159..3526da121c43 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -430,6 +430,9 @@ gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } !endif
- # use the TTY terminal type (which has a working backspace)
If you add "in the default behaviour of most Linux terminal emulators" or equivalent to the above, including the commit message (or just there and delete the "working backspace" comment here): Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
- gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
!ifdef EDK2_ENABLE_SMSC_91X # Ethernet (SMSC 91C111) gLan91xDxeTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x1A000000 -- 2.7.4
On 25 October 2016 at 18:15, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
This givers us a working backspace key, but it happens to be a prerequisite for using the ArmPkg implementation for PlatformBootManagerLib (used by the generic BDS) so now is a good time to make this change.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 823c934f3159..3526da121c43 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -430,6 +430,9 @@ gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } !endif
- # use the TTY terminal type (which has a working backspace)
- gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
!ifdef EDK2_ENABLE_SMSC_91X # Ethernet (SMSC 91C111) gLan91xDxeTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x1A000000 -- 2.7.4
Note to self, more than anything else: you need to erase your env vars in NOR for this to make any difference ;-)
Before moving to the generic BDS, copy the global BdsLib resolution to the respective clients so we can drop it later. That way, no new code will inadvertently bind to it, and it is more obvious which modules still need to be brought into the 21st century.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org --- Platforms/ARM/Juno/ArmJuno.dsc | 5 ++++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 5 ++++- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 5 ++++- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 15 ++++++++++++--- 4 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc index 69a2e4392c1c..d5f06c2b4211 100644 --- a/Platforms/ARM/Juno/ArmJuno.dsc +++ b/Platforms/ARM/Juno/ArmJuno.dsc @@ -313,7 +313,10 @@ # # Juno platform driver # - ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf + ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf { + <LibraryClasses> + BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + } SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf { <LibraryClasses> # DO NOT USE THIS LIBRARY FOR PRODUCTION DEVICES diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc index e95a3c1cd1bc..1a0fba9e6e2a 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -257,7 +257,10 @@ # # Platform # - ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.inf + ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.inf { + <LibraryClasses> + BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + }
# # Filesystems diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index 60df45dca276..d019b09f6456 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -298,7 +298,10 @@ # # Platform Driver # - ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.inf + ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.inf { + <LibraryClasses> + BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + } OvmfPkg/VirtioBlkDxe/VirtioBlk.inf
# diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 3526da121c43..a78046d016e0 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -479,7 +479,10 @@ # # Android Fastboot # - EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf + EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf { + <LibraryClasses> + BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + } EmbeddedPkg/Drivers/AndroidFastbootTransportUsbDxe/FastbootTransportUsbDxe.inf ArmPlatformPkg/ArmVExpressPkg/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf
@@ -489,7 +492,10 @@ # # FDT installation # - EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf + EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf { + <LibraryClasses> + BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + }
# # UEFI application (Shell Embedded Boot Loader) @@ -512,4 +518,7 @@
[Components.ARM] # Legacy Linux Loader - ArmPkg/Application/LinuxLoader/LinuxLoader.inf + ArmPkg/Application/LinuxLoader/LinuxLoader.inf { + <LibraryClasses> + BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + }
On Tue, Oct 25, 2016 at 06:15:33PM +0100, Ard Biesheuvel wrote:
Before moving to the generic BDS, copy the global BdsLib resolution to the respective clients so we can drop it later. That way, no new code will inadvertently bind to it, and it is more obvious which modules still need to be brought into the 21st century.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Hah, I reviewed this last night, but forgot to actually send the email: Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
Platforms/ARM/Juno/ArmJuno.dsc | 5 ++++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 5 ++++- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 5 ++++- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 15 ++++++++++++--- 4 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc index 69a2e4392c1c..d5f06c2b4211 100644 --- a/Platforms/ARM/Juno/ArmJuno.dsc +++ b/Platforms/ARM/Juno/ArmJuno.dsc @@ -313,7 +313,10 @@ # # Juno platform driver #
- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf {
<LibraryClasses>
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf- } SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf {
<LibraryClasses> # DO NOT USE THIS LIBRARY FOR PRODUCTION DEVICES
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc index e95a3c1cd1bc..1a0fba9e6e2a 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -257,7 +257,10 @@ # # Platform #
- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.inf
- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmHwDxe.inf {
<LibraryClasses>
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf- }
# # Filesystems diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index 60df45dca276..d019b09f6456 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -298,7 +298,10 @@ # # Platform Driver #
- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.inf
- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressDxe/ArmFvpDxe.inf {
<LibraryClasses>
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf- } OvmfPkg/VirtioBlkDxe/VirtioBlk.inf
# diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 3526da121c43..a78046d016e0 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -479,7 +479,10 @@ # # Android Fastboot #
- EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf
- EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf {
<LibraryClasses>
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf- } EmbeddedPkg/Drivers/AndroidFastbootTransportUsbDxe/FastbootTransportUsbDxe.inf ArmPlatformPkg/ArmVExpressPkg/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf
@@ -489,7 +492,10 @@ # # FDT installation #
- EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf
- EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.inf {
<LibraryClasses>
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf- }
# # UEFI application (Shell Embedded Boot Loader) @@ -512,4 +518,7 @@ [Components.ARM] # Legacy Linux Loader
- ArmPkg/Application/LinuxLoader/LinuxLoader.inf
- ArmPkg/Application/LinuxLoader/LinuxLoader.inf {
<LibraryClasses>
BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf- }
-- 2.7.4
Add generic BDS/UiApp library resolutions that will be shared between FVP and TC2 to the shared .dsc include file.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org --- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index a78046d016e0..99d97c8995ca 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -120,6 +120,8 @@
# BDS Libraries BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf + UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf + PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
AcpiLib|EmbeddedPkg/Library/AcpiLib/AcpiLib.inf FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf @@ -234,6 +236,11 @@ MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
+ # UiApp dependencies + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf + FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf + [LibraryClasses.common.UEFI_DRIVER] ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf @@ -445,6 +452,9 @@ gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04 !endif
+ # GUID of the UI app + gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } + [Components.common] MdeModulePkg/Universal/PCD/Dxe/Pcd.inf { <LibraryClasses>
On Tue, Oct 25, 2016 at 06:15:34PM +0100, Ard Biesheuvel wrote:
Add generic BDS/UiApp library resolutions that will be shared between FVP and TC2 to the shared .dsc include file.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index a78046d016e0..99d97c8995ca 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -120,6 +120,8 @@ # BDS Libraries BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
- UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
- PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
AcpiLib|EmbeddedPkg/Library/AcpiLib/AcpiLib.inf FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf @@ -234,6 +236,11 @@ MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
- # UiApp dependencies
- ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
- FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
- DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
If you OCD sort the added lines before commit (within each hunk): Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
(Or explain to me why this definition order is the optimal one :)
[LibraryClasses.common.UEFI_DRIVER] ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf @@ -445,6 +452,9 @@ gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04 !endif
- # GUID of the UI app
- gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
[Components.common] MdeModulePkg/Universal/PCD/Dxe/Pcd.inf { <LibraryClasses> -- 2.7.4
Use the generic BDS instead of the Intel one. They should be mostly identical in terms of base functionality, but the generic one will be kept free of x86 specific legacy.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org --- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc index 1a0fba9e6e2a..b56e2885ac31 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -293,4 +293,10 @@ MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf + MdeModulePkg/Application/UiApp/UiApp.inf { + <LibraryClasses> + NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf + NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf + NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf + } diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf index 76c924958b0e..7f4f786644db 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076-a94af1890243 INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf + INF MdeModulePkg/Application/UiApp/UiApp.inf
# # TianoCore logo (splash screen)
On Tue, Oct 25, 2016 at 06:15:35PM +0100, Ard Biesheuvel wrote:
Use the generic BDS instead of the Intel one. They should be mostly identical in terms of base functionality, but the generic one will be kept free of x86 specific legacy.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
\o/
Unless Ryan (or Evan) screams: Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc index 1a0fba9e6e2a..b56e2885ac31 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -293,4 +293,10 @@ MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
- MdeModulePkg/Application/UiApp/UiApp.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.infNULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.infNULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf- }
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf index 76c924958b0e..7f4f786644db 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076-a94af1890243 INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
- INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
- INF MdeModulePkg/Application/UiApp/UiApp.inf
#
# TianoCore logo (splash screen)
2.7.4
I don't know of any problem with this, and the change seems beneficial, so fine with us.
Evan
-----Original Message----- From: Leif Lindholm [mailto:leif.lindholm@linaro.org] Sent: 25 October 2016 18:54 To: ard.biesheuvel@linaro.org Cc: linaro-uefi@lists.linaro.org; ryan.harkin@linaro.org; Evan Lloyd Subject: Re: [PATCH 4/5] Platforms/ARM/ArmVExpress-CTA15-A7: switch to generic BDS
On Tue, Oct 25, 2016 at 06:15:35PM +0100, Ard Biesheuvel wrote:
Use the generic BDS instead of the Intel one. They should be mostly identical in terms of base functionality, but the generic one will be kept free of x86 specific legacy.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
\o/
Unless Ryan (or Evan) screams: Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc
b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc
index 1a0fba9e6e2a..b56e2885ac31 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -293,4 +293,10 @@ MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
- MdeModulePkg/Application/UiApp/UiApp.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.in f
NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaint enanceManagerUiLib.inf
- }
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf
b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf
index 76c924958b0e..7f4f786644db 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076-
a94af1890243
INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
INF MdeModulePkg/Application/UiApp/UiApp.inf
# # TianoCore logo (splash screen)
-- 2.7.4
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
On 26 October 2016 at 10:59, Evan Lloyd Evan.Lloyd@arm.com wrote:
I don't know of any problem with this, and the change seems beneficial, so fine with us.
Evan
-----Original Message----- From: Leif Lindholm [mailto:leif.lindholm@linaro.org] Sent: 25 October 2016 18:54 To: ard.biesheuvel@linaro.org Cc: linaro-uefi@lists.linaro.org; ryan.harkin@linaro.org; Evan Lloyd Subject: Re: [PATCH 4/5] Platforms/ARM/ArmVExpress-CTA15-A7: switch to generic BDS
On Tue, Oct 25, 2016 at 06:15:35PM +0100, Ard Biesheuvel wrote:
Use the generic BDS instead of the Intel one. They should be mostly identical in terms of base functionality, but the generic one will be kept free of x86 specific legacy.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
\o/
Unless Ryan (or Evan) screams: Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
I'll test the series today, but I'm happy to see it go in if it works! I expect it will work just fine.
Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc
b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc
index 1a0fba9e6e2a..b56e2885ac31 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -293,4 +293,10 @@ MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
- MdeModulePkg/Application/UiApp/UiApp.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.in f
NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaint enanceManagerUiLib.inf
- }
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf
b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf
index 76c924958b0e..7f4f786644db 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076-
a94af1890243
INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
INF MdeModulePkg/Application/UiApp/UiApp.inf
# # TianoCore logo (splash screen)
-- 2.7.4
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Drop the USE_ARM_BDS define, and replace both the ARM and Intel BDSs with the generic BDS.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org --- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 12 +++++++----- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 7 ++----- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 8 -------- 3 files changed, 9 insertions(+), 18 deletions(-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index d019b09f6456..cf4b803096f1 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -315,10 +315,12 @@ # Bds # MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf -!if $(USE_ARM_BDS) == TRUE - ArmPlatformPkg/Bds/Bds.inf -!else MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf -!endif + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf + MdeModulePkg/Application/UiApp/UiApp.inf { + <LibraryClasses> + NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf + NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf + NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf + } diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf index 74cc18fc012e..2ace4d8e04c3 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf @@ -162,12 +162,10 @@ FvNameGuid = 87940482-fc81-41c3-87e6-399cf85ac8a0 # Bds # INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf -!if $(USE_ARM_BDS) == TRUE - INF ArmPlatformPkg/Bds/Bds.inf -!else INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf + INF MdeModulePkg/Application/UiApp/UiApp.inf
# # TianoCore logo (splash screen) @@ -175,7 +173,6 @@ FvNameGuid = 87940482-fc81-41c3-87e6-399cf85ac8a0 FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { SECTION RAW = MdeModulePkg/Logo/Logo.bmp } -!endif
# FV Filesystem INF MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 99d97c8995ca..56f22a01f69b 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -12,7 +12,6 @@ #
[Defines] - USE_ARM_BDS = FALSE SECURE_BOOT_ENABLE = FALSE
[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] @@ -119,7 +118,6 @@ SemihostLib|ArmPkg/Library/SemihostLib/SemihostLib.inf
# BDS Libraries - BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
@@ -151,12 +149,8 @@ !endif VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
-!if $(USE_ARM_BDS) == FALSE CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf - GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf - PlatformBdsLib|ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf -!endif
[LibraryClasses.common.SEC] ArmPlatformSecExtraActionLib|ArmPlatformPkg/Library/DebugSecExtraActionLib/DebugSecExtraActionLib.inf @@ -432,10 +426,8 @@ # Shell. gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
-!if $(USE_ARM_BDS) == FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } -!endif
# use the TTY terminal type (which has a working backspace) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
On Tue, Oct 25, 2016 at 06:15:36PM +0100, Ard Biesheuvel wrote:
Drop the USE_ARM_BDS define, and replace both the ARM and Intel BDSs with the generic BDS.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Same as last one - I'd prefer non-screams from Ryan/Evan, but: Reviewed-by: Leif Lindholm leif.lindholm@linaro.org
Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 12 +++++++----- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 7 ++----- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 8 -------- 3 files changed, 9 insertions(+), 18 deletions(-)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index d019b09f6456..cf4b803096f1 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -315,10 +315,12 @@ # Bds # MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf -!if $(USE_ARM_BDS) == TRUE
- ArmPlatformPkg/Bds/Bds.inf
-!else MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
-!endif
- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
- MdeModulePkg/Application/UiApp/UiApp.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.infNULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.infNULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf- }
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf index 74cc18fc012e..2ace4d8e04c3 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf @@ -162,12 +162,10 @@ FvNameGuid = 87940482-fc81-41c3-87e6-399cf85ac8a0 # Bds # INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf -!if $(USE_ARM_BDS) == TRUE
- INF ArmPlatformPkg/Bds/Bds.inf
-!else INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
- INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
- INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
- INF MdeModulePkg/Application/UiApp/UiApp.inf
# # TianoCore logo (splash screen) @@ -175,7 +173,6 @@ FvNameGuid = 87940482-fc81-41c3-87e6-399cf85ac8a0 FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { SECTION RAW = MdeModulePkg/Logo/Logo.bmp } -!endif # FV Filesystem INF MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 99d97c8995ca..56f22a01f69b 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -12,7 +12,6 @@ # [Defines]
- USE_ARM_BDS = FALSE SECURE_BOOT_ENABLE = FALSE
[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] @@ -119,7 +118,6 @@ SemihostLib|ArmPkg/Library/SemihostLib/SemihostLib.inf # BDS Libraries
- BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
@@ -151,12 +149,8 @@ !endif VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf -!if $(USE_ARM_BDS) == FALSE CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
- GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
- PlatformBdsLib|ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
-!endif [LibraryClasses.common.SEC] ArmPlatformSecExtraActionLib|ArmPlatformPkg/Library/DebugSecExtraActionLib/DebugSecExtraActionLib.inf @@ -432,10 +426,8 @@ # Shell. gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE -!if $(USE_ARM_BDS) == FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } -!endif # use the TTY terminal type (which has a working backspace) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 -- 2.7.4
Hi Ard,
On 25 October 2016 at 18:15, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
Remove any remaining references to the ARM BDS. For convenience, this also involves moving FVP an TC2 to the generic BDS.
This sounds great so far...
(Juno still uses the Intel BDS)
But why exclude Juno?
Ard Biesheuvel (5): Platforms/ARM/VExpress: set terminal type to TTY Platforms/ARM/VExpress: make BdsLib dependencies explicit Platforms/ARM/VExpress: add generic BDS/UiApp dependencies Platforms/ARM/ArmVExpress-CTA15-A7: switch to generic BDS Platform/ARM/FVP: switch to generic BDS
Platforms/ARM/Juno/ArmJuno.dsc | 5 ++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 13 +++++-- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 +- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 17 +++++---- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 7 ++-- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 36 ++++++++++++++------ 6 files changed, 55 insertions(+), 26 deletions(-)
-- 2.7.4
On 26 October 2016 at 11:06, Ryan Harkin ryan.harkin@linaro.org wrote:
Hi Ard,
On 25 October 2016 at 18:15, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
Remove any remaining references to the ARM BDS. For convenience, this also involves moving FVP an TC2 to the generic BDS.
This sounds great so far...
(Juno still uses the Intel BDS)
But why exclude Juno?
Because I don't have one, so it is difficult to test.
On 26 October 2016 at 11:08, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 26 October 2016 at 11:06, Ryan Harkin ryan.harkin@linaro.org wrote:
Hi Ard,
On 25 October 2016 at 18:15, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
Remove any remaining references to the ARM BDS. For convenience, this also involves moving FVP an TC2 to the generic BDS.
This sounds great so far...
(Juno still uses the Intel BDS)
But why exclude Juno?
Because I don't have one, so it is difficult to test.
Good :-) I'm glad there isn't another reason to block it. I can test a patch for you or I can push one to be applied on top of your series if you prefer.
On 25 October 2016 at 18:15, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
Remove any remaining references to the ARM BDS. For convenience, this also involves moving FVP an TC2 to the generic BDS. (Juno still uses the Intel BDS)
Ard Biesheuvel (5): Platforms/ARM/VExpress: set terminal type to TTY Platforms/ARM/VExpress: make BdsLib dependencies explicit Platforms/ARM/VExpress: add generic BDS/UiApp dependencies Platforms/ARM/ArmVExpress-CTA15-A7: switch to generic BDS Platform/ARM/FVP: switch to generic BDS
Platforms/ARM/Juno/ArmJuno.dsc | 5 ++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 13 +++++-- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 +- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 17 +++++---- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 7 ++-- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 36 ++++++++++++++------ 6 files changed, 55 insertions(+), 26 deletions(-)
-- 2.7.4
For the whole series, with "[PATCH] Platforms/ARM/Juno: switch to generic BDS" stacked on top, tested on Juno R0/1/2, TC2 and FVP AEMv8 and Foundation models.
Tested-by: Ryan Harkin ryan.harkin@linaro.org
-
Ard Biesheuvel -
Evan Lloyd -
Leif Lindholm -
Ryan Harkin