hi Leif,
Sorry for replying late.
I have modified the commit message according your comments.
Please find the patch at: ssh://git@git.linaro.org/people/heyi.guo/OpenPlatformPkg.git
branch: rp-17.04-01
thanks.
Regards,
Chenhui
在 2017/3/14 19:45, Heyi Guo 写道:
-------- 转发的消息 -------- 主题: Re: [Linaro-uefi v1] Hisilicon/D02: update FVMAIN_SEC.fv 日期: Wed, 1 Mar 2017 15:19:22 +0000 发件人: Leif Lindholm leif.lindholm@linaro.org 收件人: Heyi Guo heyi.guo@linaro.org 抄送: linaro-uefi@lists.linaro.org, ard.biesheuvel@linaro.org, graeme.gregory@linaro.org, sunchenhui@huawei.com, wanghuiqiang@huawei.com
Hi Heyi, Chenhui,
Apologies for slow reaction time.
OK, this makes sense. Can you update this patch and:
- Add the statement "Resolves incompatibility introduced by 0df0c147"? to the commit message.
- Add the Contributed-under: tag
- Ensure that a Signed-off-by: from the patch Author is present. (I don't really care if you do that by changing the Author such that the patch contains a From: tag or by adding Signed-off-by: from both of you.)
Regards,
Leif
On Wed, Feb 15, 2017 at 08:52:22AM +0800, Heyi Guo wrote:
Hi Leif,
Yes, the FVMAIN_SEC.fv need to be rebuilt after enlarging FVMAIN_COMPACT.
Regards
在 2017/2/13 22:03, Leif Lindholm 写道:
Are you saying that this resolves a bug introduced by 0df0c147?
Regards,
Leif
On Mon, Feb 13, 2017 at 04:48:51PM +0800, Heyi Guo wrote:
Hi Leif,
Could you help to review this patch?
The FVMAIN_SEC.fv also could be found in my branch: hisi-wip-08, thanks.
Regards,
Heyi
在 2017/2/13 16:37, Chenhui Sun 写道:
From: Heyi Guoheyi.guo@linaro.org
We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed.
Signed-off-by: Chenhui Sunsunchenhui@huawei.com
Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
Pushed as c6cdf9e2.
It would probably be a good idea for you to subscribe to linaro-uefi@lists.linaro.org. https://lists.linaro.org/mailman/listinfo/linaro-uefi
Regards,
Leif
On Tue, Mar 14, 2017 at 07:58:52PM +0800, Chenhui Sun wrote:
hi Leif,
Sorry for replying late.
I have modified the commit message according your comments.
Please find the patch at: ssh://git@git.linaro.org/people/heyi.guo/OpenPlatformPkg.git
branch: rp-17.04-01
thanks.
Regards,
Chenhui
在 2017/3/14 19:45, Heyi Guo 写道:
-------- 转发的消息 -------- 主题: Re: [Linaro-uefi v1] Hisilicon/D02: update FVMAIN_SEC.fv 日期: Wed, 1 Mar 2017 15:19:22 +0000 发件人: Leif Lindholm leif.lindholm@linaro.org 收件人: Heyi Guo heyi.guo@linaro.org 抄送: linaro-uefi@lists.linaro.org, ard.biesheuvel@linaro.org, graeme.gregory@linaro.org, sunchenhui@huawei.com, wanghuiqiang@huawei.com
Hi Heyi, Chenhui,
Apologies for slow reaction time.
OK, this makes sense. Can you update this patch and:
- Add the statement "Resolves incompatibility introduced by 0df0c147"? to the commit message.
- Add the Contributed-under: tag
- Ensure that a Signed-off-by: from the patch Author is present. (I don't really care if you do that by changing the Author such that the patch contains a From: tag or by adding Signed-off-by: from both of you.)
Regards,
Leif
On Wed, Feb 15, 2017 at 08:52:22AM +0800, Heyi Guo wrote:
Hi Leif,
Yes, the FVMAIN_SEC.fv need to be rebuilt after enlarging FVMAIN_COMPACT.
Regards
在 2017/2/13 22:03, Leif Lindholm 写道:
Are you saying that this resolves a bug introduced by 0df0c147?
Regards,
Leif
On Mon, Feb 13, 2017 at 04:48:51PM +0800, Heyi Guo wrote:
Hi Leif,
Could you help to review this patch?
The FVMAIN_SEC.fv also could be found in my branch: hisi-wip-08, thanks.
Regards,
Heyi
在 2017/2/13 16:37, Chenhui Sun 写道:
From: Heyi Guoheyi.guo@linaro.org
We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed.
Signed-off-by: Chenhui Sunsunchenhui@huawei.com
Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
Ok, thanks.
在 2017/3/14 23:59, Leif Lindholm 写道:
Pushed as c6cdf9e2.
It would probably be a good idea for you to subscribe to linaro-uefi@lists.linaro.org. https://lists.linaro.org/mailman/listinfo/linaro-uefi
Regards,
Leif
On Tue, Mar 14, 2017 at 07:58:52PM +0800, Chenhui Sun wrote:
hi Leif,
Sorry for replying late.
I have modified the commit message according your comments.
Please find the patch at: ssh://git@git.linaro.org/people/heyi.guo/OpenPlatformPkg.git
branch: rp-17.04-01
thanks.
Regards,
Chenhui
在 2017/3/14 19:45, Heyi Guo 写道:
-------- 转发的消息 -------- 主题: Re: [Linaro-uefi v1] Hisilicon/D02: update FVMAIN_SEC.fv 日期: Wed, 1 Mar 2017 15:19:22 +0000 发件人: Leif Lindholm leif.lindholm@linaro.org 收件人: Heyi Guo heyi.guo@linaro.org 抄送: linaro-uefi@lists.linaro.org, ard.biesheuvel@linaro.org, graeme.gregory@linaro.org, sunchenhui@huawei.com, wanghuiqiang@huawei.com
Hi Heyi, Chenhui,
Apologies for slow reaction time.
OK, this makes sense. Can you update this patch and:
- Add the statement "Resolves incompatibility introduced by 0df0c147"? to the commit message.
- Add the Contributed-under: tag
- Ensure that a Signed-off-by: from the patch Author is present. (I don't really care if you do that by changing the Author such that the patch contains a From: tag or by adding Signed-off-by: from both of you.)
Regards,
Leif
On Wed, Feb 15, 2017 at 08:52:22AM +0800, Heyi Guo wrote:
Hi Leif,
Yes, the FVMAIN_SEC.fv need to be rebuilt after enlarging FVMAIN_COMPACT.
Regards
在 2017/2/13 22:03, Leif Lindholm 写道:
Are you saying that this resolves a bug introduced by 0df0c147?
Regards,
Leif
On Mon, Feb 13, 2017 at 04:48:51PM +0800, Heyi Guo wrote:
Hi Leif,
Could you help to review this patch?
The FVMAIN_SEC.fv also could be found in my branch: hisi-wip-08, thanks.
Regards,
Heyi
在 2017/2/13 16:37, Chenhui Sun 写道: > From: Heyi Guoheyi.guo@linaro.org > > We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, > because the fv size and trustfirmware located base address changed. > > Signed-off-by: Chenhui Sunsunchenhui@huawei.com > --- > Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes > 1 file changed, 0 insertions(+), 0 deletions(-) > > diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv > index bac8767..49b61aa 100644 > Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
-
Chenhui Sun -
Leif Lindholm