From: Heyi Guo heyi.guo@linaro.org
We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed.
Signed-off-by: Chenhui Sun sunchenhui@huawei.com --- Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
Hi Leif,
Could you help to review this patch?
The FVMAIN_SEC.fv also could be found in my branch: hisi-wip-08, thanks.
Regards,
Heyi
在 2017/2/13 16:37, Chenhui Sun 写道:
From: Heyi Guo heyi.guo@linaro.org
We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed.
Signed-off-by: Chenhui Sun sunchenhui@huawei.com
Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
Are you saying that this resolves a bug introduced by 0df0c147?
Regards,
Leif
On Mon, Feb 13, 2017 at 04:48:51PM +0800, Heyi Guo wrote:
Hi Leif,
Could you help to review this patch?
The FVMAIN_SEC.fv also could be found in my branch: hisi-wip-08, thanks.
Regards,
Heyi
在 2017/2/13 16:37, Chenhui Sun 写道:
From: Heyi Guo heyi.guo@linaro.org
We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed.
Signed-off-by: Chenhui Sun sunchenhui@huawei.com
Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
Hi Leif,
Yes, the FVMAIN_SEC.fv need to be rebuilt after enlarging FVMAIN_COMPACT.
Regards
在 2017/2/13 22:03, Leif Lindholm 写道:
Are you saying that this resolves a bug introduced by 0df0c147?
Regards,
Leif
On Mon, Feb 13, 2017 at 04:48:51PM +0800, Heyi Guo wrote:
Hi Leif,
Could you help to review this patch?
The FVMAIN_SEC.fv also could be found in my branch: hisi-wip-08, thanks.
Regards,
Heyi
在 2017/2/13 16:37, Chenhui Sun 写道:
From: Heyi Guo heyi.guo@linaro.org
We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed.
Signed-off-by: Chenhui Sun sunchenhui@huawei.com
Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
Hi Heyi, Chenhui,
Apologies for slow reaction time.
OK, this makes sense. Can you update this patch and: 1) Add the statement "Resolves incompatibility introduced by 0df0c147"? to the commit message. 2) Add the Contributed-under: tag 3) Ensure that a Signed-off-by: from the patch Author is present. (I don't really care if you do that by changing the Author such that the patch contains a From: tag or by adding Signed-off-by: from both of you.)
Regards,
Leif
On Wed, Feb 15, 2017 at 08:52:22AM +0800, Heyi Guo wrote:
Hi Leif,
Yes, the FVMAIN_SEC.fv need to be rebuilt after enlarging FVMAIN_COMPACT.
Regards
在 2017/2/13 22:03, Leif Lindholm 写道:
Are you saying that this resolves a bug introduced by 0df0c147?
Regards,
Leif
On Mon, Feb 13, 2017 at 04:48:51PM +0800, Heyi Guo wrote:
Hi Leif,
Could you help to review this patch?
The FVMAIN_SEC.fv also could be found in my branch: hisi-wip-08, thanks.
Regards,
Heyi
在 2017/2/13 16:37, Chenhui Sun 写道:
From: Heyi Guo heyi.guo@linaro.org
We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed.
Signed-off-by: Chenhui Sun sunchenhui@huawei.com
Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ
-
Chenhui Sun -
Heyi Guo
-
Leif Lindholm