Leif and Ard,
I have the branch "rfranz-backspace" on http://git.linaro.org/people/roy.franz/uefi-next.git that I'd like to get you to try to make sure it works with other setups. This should also fix the delete key. I still need to look more at how EDK2 determines which console type to use, and if I need to conditionalize any of this based on terminal type.
The backspace 'fix' is to treat both 0x8(^H) and 0x7f(^?) as backspace. This is done by changing 0x7f values to 0x8 during the console input processing. This is similar to how u-boot treats both values as backspace - delete doesn't work.
Fixing the delete key is a big more involved, many (most?) linux terminals use the vt220 escape sequence [3~ to do delete. Right now EDK2 only handlings 2 byte escape sequences, so the state machine needed to be extended. This is a very 'linuxy' change, so I don't know how popular it will be.
I need to try the patches with a windows based terminal emulator, and I suspect I'll end up with the delete key being backspace, and there really being no delete.
Thanks, Roy
Saying as neither delete nor backspace work properly at the moment, I'd be happy with a simple backspace fix. Nobody *needs* delete in a bootloader anyway.
On 7 May 2015 at 05:43, Roy Franz roy.franz@linaro.org wrote:
Leif and Ard,
I have the branch "rfranz-backspace" on http://git.linaro.org/people/roy.franz/uefi-next.git that I'd like to get you to try to make sure it works with other setups. This should also fix the delete key. I still need to look more at how EDK2 determines which console type to use, and if I need to conditionalize any of this based on terminal type.
The backspace 'fix' is to treat both 0x8(^H) and 0x7f(^?) as backspace. This is done by changing 0x7f values to 0x8 during the console input processing. This is similar to how u-boot treats both values as backspace - delete doesn't work.
Fixing the delete key is a big more involved, many (most?) linux terminals use the vt220 escape sequence [3~ to do delete. Right now EDK2 only handlings 2 byte escape sequences, so the state machine needed to be extended. This is a very 'linuxy' change, so I don't know how popular it will be.
I need to try the patches with a windows based terminal emulator, and I suspect I'll end up with the delete key being backspace, and there really being no delete.
Thanks, Roy _______________________________________________ Linaro-uefi mailing list Linaro-uefi@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-uefi
On 7 May 2015 at 06:43, Roy Franz roy.franz@linaro.org wrote:
Leif and Ard,
I have the branch "rfranz-backspace" on http://git.linaro.org/people/roy.franz/uefi-next.git that I'd like to get you to try to make sure it works with other setups. This should also fix the delete key. I still need to look more at how EDK2 determines which console type to use, and if I need to conditionalize any of this based on terminal type.
The backspace 'fix' is to treat both 0x8(^H) and 0x7f(^?) as backspace. This is done by changing 0x7f values to 0x8 during the console input processing. This is similar to how u-boot treats both values as backspace - delete doesn't work.
Fixing the delete key is a big more involved, many (most?) linux terminals use the vt220 escape sequence [3~ to do delete. Right now EDK2 only handlings 2 byte escape sequences, so the state machine needed to be extended. This is a very 'linuxy' change, so I don't know how popular it will be.
I need to try the patches with a windows based terminal emulator, and I suspect I'll end up with the delete key being backspace, and there really being no delete.
It works fine for me with QEMU+KVM. I agree with Ryan though that the Delete changes are not as important as the Backspace changes, and I agree that the state machine changes are a bit risky given the heterogeneous environment that Tianocore is supposed to run in.
But having a normal backspace is great!
Thanks Roy! This issue is really annoying...
-----Original Message----- From: Linaro-uefi [mailto:linaro-uefi-bounces@lists.linaro.org] On Behalf Of Roy Franz Sent: 07 May 2015 05:44 To: Leif Lindholm; Ard Biesheuvel; Linaro UEFI Mailman List Subject: [Linaro-uefi] backspace branch to try
Leif and Ard,
I have the branch "rfranz-backspace" on http://git.linaro.org/people/roy.franz/uefi-next.git that I'd like to get you to try to make sure it works with other setups. This should also fix the delete key. I still need to look more at how EDK2 determines which console type to use, and if I need to conditionalize any of this based on terminal type.
The backspace 'fix' is to treat both 0x8(^H) and 0x7f(^?) as backspace. This is done by changing 0x7f values to 0x8 during the console input processing. This is similar to how u-boot treats both values as backspace - delete doesn't work.
Fixing the delete key is a big more involved, many (most?) linux terminals use the vt220 escape sequence [3~ to do delete. Right now EDK2 only handlings 2 byte escape sequences, so the state machine needed to be extended. This is a very 'linuxy' change, so I don't know how popular it will be.
I need to try the patches with a windows based terminal emulator, and I suspect I'll end up with the delete key being backspace, and there really being no delete.
Thanks, Roy _______________________________________________ Linaro-uefi mailing list Linaro-uefi@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-uefi
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
-
Ard Biesheuvel -
Olivier Martin -
Roy Franz -
Ryan Harkin