This fixes the builds for ARM and AARCH64, which currently fail at link time with an error like this:
arm-linux-gnueabi-ld: section .note.gnu.build-id loaded at [0000000000000000,0000000000000023] overlaps section .text loaded at [0000000000000000,00000000000064cf]
Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org --- gnuefi/elf_aarch64_efi.lds | 1 + gnuefi/elf_arm_efi.lds | 1 + 2 files changed, 2 insertions(+)
diff --git a/gnuefi/elf_aarch64_efi.lds b/gnuefi/elf_aarch64_efi.lds index 6494e593025c..886475720260 100644 --- a/gnuefi/elf_aarch64_efi.lds +++ b/gnuefi/elf_aarch64_efi.lds @@ -50,6 +50,7 @@ SECTIONS . = ALIGN(4096); .dynstr : { *(.dynstr) } . = ALIGN(4096); + .note.gnu.build-id : { *(.note.gnu.build-id) } /DISCARD/ : { *(.rel.reloc) diff --git a/gnuefi/elf_arm_efi.lds b/gnuefi/elf_arm_efi.lds index 63d31beb2014..a2f1b01138bd 100644 --- a/gnuefi/elf_arm_efi.lds +++ b/gnuefi/elf_arm_efi.lds @@ -50,6 +50,7 @@ SECTIONS . = ALIGN(4096); .dynstr : { *(.dynstr) } . = ALIGN(4096); + .note.gnu.build-id : { *(.note.gnu.build-id) } /DISCARD/ : { *(.rel.reloc)
Hello Ard,
I went ahead and pushed these three changes to the git tree on SF.net.
I am unable to test the changes, as I don't have any ARM hardware. Let me know how your testing goes and if there are any more issues.
Thanks for the patches !
-Nigel
Branch: master From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH] Add ARM .note.gnu.build-id input section to a dedicated output section This fixes the builds for ARM and AARCH64, which currently fail at link time with an error like this: arm-linux-gnueabi-ld: section .note.gnu.build-id loaded at [0000000000000000,0000000000000023] overlaps section .text loaded at [0000000000000000,00000000000064cf] Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:38 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 2/2] Replace ARM arithmetic support routines with EDK2 versions. Replace the incomplete GPL licensed ARM arithmetic support routines with the ones from the EDK2 project. These cover long long multiplication and long long logical shift as well. Also remove the special case for small dividends in DivU64x32: we can simply let the compiler handle this, and emit calls to the support routines where appropriate. Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:33 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 1/2] Relicense ARM and AARCH64 source files as both BSD and GPL This updates the licenses of the files authored by me under lib/arm and lib/aarch64 to be both 2-clause BSD and GPL v2+ Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:19 View Changes
On 23 December 2015 at 15:00, Croxon, Nigel nigel.croxon@hpe.com wrote:
Hello Ard,
I went ahead and pushed these three changes to the git tree on SF.net.
I am unable to test the changes, as I don't have any ARM hardware. Let me know how your testing goes and if there are any more issues.
Looking fine, although I'd like to test the new setjmp stuff you added, since it looks broken to me on ARM. However, that is unrelated to these changes, and the apps that used to work before still work now.
Cheers, Ard.
Branch: master From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH] Add ARM .note.gnu.build-id input section to a dedicated output section This fixes the builds for ARM and AARCH64, which currently fail at link time with an error like this: arm-linux-gnueabi-ld: section .note.gnu.build-id loaded at [0000000000000000,0000000000000023] overlaps section .text loaded at [0000000000000000,00000000000064cf] Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:38 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 2/2] Replace ARM arithmetic support routines with EDK2 versions. Replace the incomplete GPL licensed ARM arithmetic support routines with the ones from the EDK2 project. These cover long long multiplication and long long logical shift as well. Also remove the special case for small dividends in DivU64x32: we can simply let the compiler handle this, and emit calls to the support routines where appropriate. Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:33 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 1/2] Relicense ARM and AARCH64 source files as both BSD and GPL This updates the licenses of the files authored by me under lib/arm and lib/aarch64 to be both 2-clause BSD and GPL v2+ Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:19 View Changes
Hello Ard,
I verified your recent patches on some aarch64 hardware today. I built it natively and tested the apps on the uefi shell. All passed.
-Nigel
-----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Wednesday, December 23, 2015 9:38 AM To: Croxon, Nigel Cc: linaro-uefi@lists.linaro.org; jak@debian.org; leif.lindholm@linaro.org Subject: Re: [PATCH] Add ARM .note.gnu.build-id input section to a dedicated output section
On 23 December 2015 at 15:00, Croxon, Nigel nigel.croxon@hpe.com wrote:
Hello Ard,
I went ahead and pushed these three changes to the git tree on SF.net.
I am unable to test the changes, as I don't have any ARM hardware. Let me know how your testing goes and if there are any more issues.
Looking fine, although I'd like to test the new setjmp stuff you added, since it looks broken to me on ARM. However, that is unrelated to these changes, and the apps that used to work before still work now.
Cheers, Ard.
Branch: master From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH] Add ARM .note.gnu.build-id input section to a dedicated output section This fixes the builds for ARM and AARCH64, which currently fail at link time with an error like this: arm-linux-gnueabi-ld: section .note.gnu.build-id loaded at [0000000000000000,0000000000000023] overlaps section .text loaded at [0000000000000000,00000000000064cf] Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:38 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 2/2] Replace ARM arithmetic support routines with EDK2 versions. Replace the incomplete GPL licensed ARM arithmetic support routines with the ones from the EDK2 project. These cover long long multiplication and long long logical shift as well. Also remove the special case for small dividends in DivU64x32: we can simply let the compiler handle this, and emit calls to the support routines where appropriate. Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:33 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 1/2] Relicense ARM and AARCH64 source files as both BSD and GPL This updates the licenses of the files authored by me under lib/arm and lib/aarch64 to be both 2-clause BSD and GPL v2+ Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:19 View Changes
On 6 January 2016 at 21:52, Croxon, Nigel nigel.croxon@hpe.com wrote:
Hello Ard,
I verified your recent patches on some aarch64 hardware today. I built it natively and tested the apps on the uefi shell. All passed.
Thanks!
There should be one patch remaining in your queue, regarding C99 typedefs with -std=gnu90. Any chance you could take a look at it? (v2 was sen out on the 31st)
Thanks, Ard.
-----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Wednesday, December 23, 2015 9:38 AM To: Croxon, Nigel Cc: linaro-uefi@lists.linaro.org; jak@debian.org; leif.lindholm@linaro.org Subject: Re: [PATCH] Add ARM .note.gnu.build-id input section to a dedicated output section
On 23 December 2015 at 15:00, Croxon, Nigel nigel.croxon@hpe.com wrote:
Hello Ard,
I went ahead and pushed these three changes to the git tree on SF.net.
I am unable to test the changes, as I don't have any ARM hardware. Let me know how your testing goes and if there are any more issues.
Looking fine, although I'd like to test the new setjmp stuff you added, since it looks broken to me on ARM. However, that is unrelated to these changes, and the apps that used to work before still work now.
Cheers, Ard.
Branch: master From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH] Add ARM .note.gnu.build-id input section to a dedicated output section This fixes the builds for ARM and AARCH64, which currently fail at link time with an error like this: arm-linux-gnueabi-ld: section .note.gnu.build-id loaded at [0000000000000000,0000000000000023] overlaps section .text loaded at [0000000000000000,00000000000064cf] Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:38 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 2/2] Replace ARM arithmetic support routines with EDK2 versions. Replace the incomplete GPL licensed ARM arithmetic support routines with the ones from the EDK2 project. These cover long long multiplication and long long logical shift as well. Also remove the special case for small dividends in DivU64x32: we can simply let the compiler handle this, and emit calls to the support routines where appropriate. Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:33 View Changes ________________________________________ From: Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [PATCH 1/2] Relicense ARM and AARCH64 source files as both BSD and GPL This updates the licenses of the files authored by me under lib/arm and lib/aarch64 to be both 2-clause BSD and GPL v2+ Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org Signed-off-by: Nigel Croxon nigel.croxon@hpe.com By Nigel Croxon on 12/23/2015 13:19 View Changes
-
Ard Biesheuvel -
Croxon, Nigel