Excellent, thanks.

Evan, could you resubmit with updated sign-off (or even just reply saying what the sign-off should be)?

Regards,

Leif

On Thu, Mar 17, 2016 at 01:10:18PM +0000, G Gregory wrote:

Hi Leif,

Yes change is correct otherwise size in header does not take into account the number of platform timers which is platform dependent so EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLES is defined per platform.

Graeme

On 16 March 2016 at 17:34, Leif Lindholm leif.lindholm@linaro.org wrote:

...

Graeme?

On Thu, Mar 03, 2016 at 08:54:25PM +0000, evan.lloyd@arm.com wrote:

...

From: Sami Mujawar sami.mujawar@arm.com

The wrong type name is used in the definition of the GTDT, causing the header to have an incorrect size value. EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE is changed to EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLES to rectify this.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Evan Lloyd evan.lloyd@arm.com

---

Platforms/ARM/Juno/AcpiTables/Gtdt.aslc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc index c0e3f5f..1c258fc 100644 --- a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc +++ b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc @@ -1,7 +1,7 @@ /** @file

• Generic Timer Description Table (GTDT)

-* Copyright (c) 2012 - 2014, ARM Limited. All rights reserved. +* Copyright (c) 2012 - 2016, ARM Limited. All rights reserved.

• This program and the accompanying materials
• are licensed and made available under the terms and conditions of the BSD License

@@ -70,7 +70,7 @@ { ARM_ACPI_HEADER( EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE,

•    EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE,
  

•    EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLES,
     EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE_REVISION
   ),
   SYSTEM_TIMER_BASE_ADDRESS,                    // UINT64  PhysicalAddress
  

-- 2.7.0