Hi Leif,
I am planning to upstream ZTE/Sanchip UEFI platform code to OpenPlatformPkg. Are you compiling below master branch of below OpenPlatformPkg tree with mainline edk2? My work is based on 96boards-hikey repo currently. Do you prefer to add all initial code to one patch, or split to platform/driver/bds patches? Or you have other plan for new platform? https://git.linaro.org/uefi/OpenPlatformPkg.git
Thanks! Jun
On Wed, Jul 05, 2017 at 08:00:03PM +0800, Jun Nie wrote:
Hi Leif,
I am planning to upstream ZTE/Sanchip UEFI platform code to OpenPlatformPkg. Are you compiling below master branch of below OpenPlatformPkg tree with mainline edk2? My work is based on 96boards-hikey repo currently.
I am confused. Why would you do that?
Do you prefer to add all initial code to one patch, or split to platform/driver/bds patches?
I guess that depends a bit on how much code it is.
Or you have other plan for new platform? https://git.linaro.org/uefi/OpenPlatformPkg.git
We are working on migrating all the platforms in OpenPlatformPkg into the official TianoCore github repositories.
Current state is held in https://github.com/tianocore/edk2-platforms/tree/devel-OpenPlatformPkg which also contains some usage documentation.
So I would prefer to see the platform port merged in this state in the end.
But ... I would be quite happy to have a look at what you have in OpenPlatformPkg format. As long as it is working with the current https://github.com/tianocore/edk2 HEAD.
Best Regards,
Leif
2017-07-05 21:37 GMT+08:00 Leif Lindholm leif.lindholm@linaro.org:
On Wed, Jul 05, 2017 at 08:00:03PM +0800, Jun Nie wrote:
Hi Leif,
I am planning to upstream ZTE/Sanchip UEFI platform code to OpenPlatformPkg. Are you compiling below master branch of below OpenPlatformPkg tree with mainline edk2? My work is based on 96boards-hikey repo currently.
I am confused. Why would you do that?
I only have hikey board for reference and cross test.
Do you prefer to add all initial code to one patch, or split to platform/driver/bds patches?
I guess that depends a bit on how much code it is.
Or you have other plan for new platform? https://git.linaro.org/uefi/OpenPlatformPkg.git
We are working on migrating all the platforms in OpenPlatformPkg into the official TianoCore github repositories.
Current state is held in https://github.com/tianocore/edk2-platforms/tree/devel-OpenPlatformPkg which also contains some usage documentation.
So I would prefer to see the platform port merged in this state in the end.
I am porting to edk2-platforms and just finish the work. But the platform depends on AndroidBootApp as explained below.
But ... I would be quite happy to have a look at what you have in OpenPlatformPkg format. As long as it is working with the current https://github.com/tianocore/edk2 HEAD.
As I am referencing hikey, I also depends on the AndroidBootApp BDS, which is added in edk2 master branch but not merged yet. So I shall work on AndroidBootApp upstream first if needed. I am not sure why AndroidBootApp patch is not commented in mail list in my search.
I do not know whether Flash Start OS and ESL Start OS can be a candidate to boot Android because I cannot find the related code. Do you have any comments? Thanks for your suggestion!
Jun
Best Regards,
Leif
On Thu, Jul 06, 2017 at 06:41:22PM +0800, Jun Nie wrote:
I am planning to upstream ZTE/Sanchip UEFI platform code to OpenPlatformPkg. Are you compiling below master branch of below OpenPlatformPkg tree with mainline edk2? My work is based on 96boards-hikey repo currently.
I am confused. Why would you do that?
I only have hikey board for reference and cross test.
Ah, OK. Well, it shouldn't make much difference for OpenPlatformPkg, but the sitution you mention below is problematic.
Do you prefer to add all initial code to one patch, or split to platform/driver/bds patches?
I guess that depends a bit on how much code it is.
Or you have other plan for new platform? https://git.linaro.org/uefi/OpenPlatformPkg.git
We are working on migrating all the platforms in OpenPlatformPkg into the official TianoCore github repositories.
Current state is held in https://github.com/tianocore/edk2-platforms/tree/devel-OpenPlatformPkg which also contains some usage documentation.
So I would prefer to see the platform port merged in this state in the end.
I am porting to edk2-platforms and just finish the work. But the platform depends on AndroidBootApp as explained below.
But ... I would be quite happy to have a look at what you have in OpenPlatformPkg format. As long as it is working with the current https://github.com/tianocore/edk2 HEAD.
As I am referencing hikey, I also depends on the AndroidBootApp BDS, which is added in edk2 master branch but not merged yet. So I shall work on AndroidBootApp upstream first if needed. I am not sure why AndroidBootApp patch is not commented in mail list in my search.
This is probably my fault, in combination with Haojian being a bit on the timid side. I went on holiday in April and I saw Ard comment on some of the patches, so I considered them dealt with.
I do not know whether Flash Start OS and ESL Start OS can be a candidate to boot Android because I cannot find the related code. Do you have any comments? Thanks for your suggestion!
I have no objection to merging AndroidBootApp - but I tend to be juggling a few more tasks than I can keep track of. Most recently, the migration to edk2-platforms has been a lot of distraction, but that is mostly complete now. I'd be happy to have another look if someone sent out the patches again.
This is also why it is problematic when people start new ports against non-upstream: it reduces the pressure to actually upstream the required bits.
/ Leif
-
Jun Nie -
Leif Lindholm