On Tue, Jun 28, 2016 at 07:58:59PM +0100, evan.lloyd@arm.com wrote:

From: Sami Mujawar sami.mujawar@arm.com

The wrong type name is used in the definition of the GTDT, causing the header to have an incorrect size value. EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE is changed to EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLES to rectify this.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sami Mujawar sami.mujawar@arm.com Signed-off-by: Evan Lloyd evan.lloyd@arm.com

Thanks, pushed.

However, could you consider renaming the local structure? It strongly gives the impression of being a global definition.

Regards,

Leif

---

Notes: GTDT_v3: - No code update, resubmit with Link [Leif Lindholm]

Code available at: https://github.com/EvanLloyd/OpenPlatformPkg/tree/GTDT_v3

Platforms/ARM/Juno/AcpiTables/Gtdt.aslc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc index c0e3f5fc11203ed4cc41dddf4aecb6dc600f38d0..1c258fcfe2489601a3fa55bbdddc5bff686b0c4a 100644 --- a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc +++ b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc @@ -1,7 +1,7 @@ /** @file

• Generic Timer Description Table (GTDT)

-* Copyright (c) 2012 - 2014, ARM Limited. All rights reserved. +* Copyright (c) 2012 - 2016, ARM Limited. All rights reserved.

• This program and the accompanying materials
• are licensed and made available under the terms and conditions of the BSD License

@@ -70,7 +70,7 @@ { ARM_ACPI_HEADER( EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE,

•    EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE,
  

•    EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLES,
     EFI_ACPI_5_1_GENERIC_TIMER_DESCRIPTION_TABLE_REVISION
   ),
   SYSTEM_TIMER_BASE_ADDRESS,                    // UINT64  PhysicalAddress
  

-- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")