From: Dandan Bi dandan.bi@intel.com
Dandan submitted this patch to the EDK2 Mailing list for review before FVP was moved to OpenPlatformPkg:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg07113.html
His original commit message:
ArmPlatformPkg: Add FileExplorerLib.inf to the dsc file
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear.
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build.
Cc: Leif Lindholm leif.lindholm@linaro.org Cc: Ard Biesheuvel ard.biesheuvel@linaro.org Cc: Ryan.Harkin ryan.harkin@linaro.org Cc: Eric Dong eric.dong@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan.bi@intel.com Reviewed-by: Ryan Harkin ryan.har...@linaro.org --- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index 265c5d7..78330d6 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -54,6 +54,9 @@ [LibraryClasses.common] # Virtio Support VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf +!if $(SECURE_BOOT_ENABLE) == TRUE + FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf +!endif
[LibraryClasses.common.SEC] ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf
On 31 March 2016 at 15:10, Ryan Harkin ryan.harkin@linaro.org wrote:
From: Dandan Bi dandan.bi@intel.com
Dandan submitted this patch to the EDK2 Mailing list for review before FVP was moved to OpenPlatformPkg:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg07113.html
His original commit message:
ArmPlatformPkg: Add FileExplorerLib.inf to the dsc file
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear.
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build.
Cc: Leif Lindholm leif.lindholm@linaro.org Cc: Ard Biesheuvel ard.biesheuvel@linaro.org Cc: Ryan.Harkin ryan.harkin@linaro.org Cc: Eric Dong eric.dong@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan.bi@intel.com Reviewed-by: Ryan Harkin ryan.har...@linaro.org
Acked-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index 265c5d7..78330d6 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -54,6 +54,9 @@ [LibraryClasses.common] # Virtio Support VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf +!if $(SECURE_BOOT_ENABLE) == TRUE
- FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
+!endif
[LibraryClasses.common.SEC] ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf -- 2.5.0
On Thu, Mar 31, 2016 at 03:13:22PM +0200, Ard Biesheuvel wrote:
On 31 March 2016 at 15:10, Ryan Harkin ryan.harkin@linaro.org wrote:
From: Dandan Bi dandan.bi@intel.com
Dandan submitted this patch to the EDK2 Mailing list for review before FVP was moved to OpenPlatformPkg:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg07113.html
His original commit message:
ArmPlatformPkg: Add FileExplorerLib.inf to the dsc file
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear.
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build.
Cc: Leif Lindholm leif.lindholm@linaro.org Cc: Ard Biesheuvel ard.biesheuvel@linaro.org Cc: Ryan.Harkin ryan.harkin@linaro.org Cc: Eric Dong eric.dong@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan.bi@intel.com Reviewed-by: Ryan Harkin ryan.har...@linaro.org
Acked-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Happy for this to go in, but shouldn't there be a Signed-off-by: Ryan in there as well?
/ Leif
Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index 265c5d7..78330d6 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -54,6 +54,9 @@ [LibraryClasses.common] # Virtio Support VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf +!if $(SECURE_BOOT_ENABLE) == TRUE
- FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
+!endif
[LibraryClasses.common.SEC] ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf -- 2.5.0
On 5 April 2016 at 09:49, Leif Lindholm leif.lindholm@linaro.org wrote:
On Thu, Mar 31, 2016 at 03:13:22PM +0200, Ard Biesheuvel wrote:
On 31 March 2016 at 15:10, Ryan Harkin ryan.harkin@linaro.org wrote:
From: Dandan Bi dandan.bi@intel.com
Dandan submitted this patch to the EDK2 Mailing list for review before FVP was moved to OpenPlatformPkg:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg07113.html
His original commit message:
ArmPlatformPkg: Add FileExplorerLib.inf to the dsc file
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear.
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build.
Cc: Leif Lindholm leif.lindholm@linaro.org Cc: Ard Biesheuvel ard.biesheuvel@linaro.org Cc: Ryan.Harkin ryan.harkin@linaro.org Cc: Eric Dong eric.dong@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan.bi@intel.com Reviewed-by: Ryan Harkin ryan.har...@linaro.org
Acked-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Happy for this to go in, but shouldn't there be a Signed-off-by: Ryan in there as well?
Good point. I added my Reviewed-by, but not that. I'm happy for you to add it when you push, if you like. Or I can push it after adding. It's up to you...
/ Leif
Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc index 265c5d7..78330d6 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc @@ -54,6 +54,9 @@ [LibraryClasses.common] # Virtio Support VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf +!if $(SECURE_BOOT_ENABLE) == TRUE
- FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
+!endif
[LibraryClasses.common.SEC] ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf -- 2.5.0
On Tue, Apr 05, 2016 at 10:50:56AM +0100, Ryan Harkin wrote:
On 5 April 2016 at 09:49, Leif Lindholm leif.lindholm@linaro.org wrote:
On Thu, Mar 31, 2016 at 03:13:22PM +0200, Ard Biesheuvel wrote:
On 31 March 2016 at 15:10, Ryan Harkin ryan.harkin@linaro.org wrote:
From: Dandan Bi dandan.bi@intel.com
Dandan submitted this patch to the EDK2 Mailing list for review before FVP was moved to OpenPlatformPkg:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg07113.html
His original commit message:
ArmPlatformPkg: Add FileExplorerLib.inf to the dsc file
V3: Add FileExplorerLib when SECURE_BOOT_ENABLE == TRUE, so when to use FileExplorerLib is clear.
Because SecureBootConfigDxe use FileExplorerLib now, but FileExplorerLib is not in the dsc file of the package that use SecureBootConfigDxe. Now add it to pass build.
Cc: Leif Lindholm leif.lindholm@linaro.org Cc: Ard Biesheuvel ard.biesheuvel@linaro.org Cc: Ryan.Harkin ryan.harkin@linaro.org Cc: Eric Dong eric.dong@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan.bi@intel.com Reviewed-by: Ryan Harkin ryan.har...@linaro.org
Acked-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Happy for this to go in, but shouldn't there be a Signed-off-by: Ryan in there as well?
Good point. I added my Reviewed-by, but not that. I'm happy for you to add it when you push, if you like. Or I can push it after adding. It's up to you...
Added and pushed, thanks!
/ Leif
-
Ard Biesheuvel -
Leif Lindholm -
Ryan Harkin