Dear validation team,
kindly review the patch for 0xbench for lava_test_shell, let me know if anything to be done
Thanks and Regards, HariGopal G
------Original message------ From: Harigopal Gollamudi harigopal.gollamudi@linaro.org To: linaro-validation@lists.linaro.org Date: Sunday, March 17, 2013 10:25:00 PM GMT+0530 Subject: Fwd: Pushing to 0xbench stuff to git
Kindly review this and let me know, what to be done next?
---------- Forwarded message ---------- From: Harigopal Gollamudi harigopal.gollamudi@linaro.org Date: 8 March 2013 14:15 Subject: Pushing to 0xbench stuff to git To: Senthil Kumaran S senthil.kumaran@linaro.org
Hi Senthil,
how can I push 0xbench code to git? As there is one change in portion of code for pumping the output to Stdout. This change in code can pushed to android.git.linaro.org once it is reviewed.
please find the attached file
Dear validation team,
Please find the 0xbench patch attached, as per the review comments.
Thanks and Regards, HariGopal G
On 20 March 2013 12:41, harigopal.gollamudi@linaro.org wrote:
Dear validation team,
kindly review the patch for 0xbench for lava_test_shell, let me know if anything to be done
Thanks and Regards, HariGopal G
------Original message------ From: Harigopal Gollamudi harigopal.gollamudi@linaro.org To: linaro-validation@lists.linaro.org Date: Sunday, March 17, 2013 10:25:00 PM GMT+0530 Subject: Fwd: Pushing to 0xbench stuff to git
Kindly review this and let me know, what to be done next?
---------- Forwarded message ---------- From: Harigopal Gollamudi harigopal.gollamudi@linaro.org Date: 8 March 2013 14:15 Subject: Pushing to 0xbench stuff to git To: Senthil Kumaran S senthil.kumaran@linaro.org
Hi Senthil,
how can I push 0xbench code to git? As there is one change in portion of code for pumping the output to Stdout. This change in code can pushed to android.git.linaro.org once it is reviewed.
please find the attached file
-- Thanks and Regards, HariGopal G Android Engineer
-- Thanks and Regards, HariGopal G Android Engineer
Hi Hari,
On Wednesday 20 March 2013 04:53 PM, Harigopal Gollamudi wrote:
Please find the 0xbench patch attached, as per the review comments.
I just pushed your changes to git repository - http://git.linaro.org/gitweb?p=qa/test-definitions.git%3Ba=blob%3Bf=android/...
I also tested the test definition by running it here - http://validation.linaro.org/lava-server/scheduler/job/50011
Looks like the parse pattern is wrong. I fixed a small glitch in the YAML file where you missed a quote. I request you to fix the parse pattern and revert with a new patch.
Thank You.
Hi Senthil,
When I got the updated .yaml from git, It is already updated with ' " ' symbol.
Do you find any other problem apart from this ' " ' in parse pattern.
Thanks and Regards, HariGopal G
On 21 March 2013 08:08, Senthil Kumaran senthil.kumaran@linaro.org wrote:
Hi Hari,
On Wednesday 20 March 2013 04:53 PM, Harigopal Gollamudi wrote:
Please find the 0xbench patch attached, as per the review comments.
I just pushed your changes to git repository - http://git.linaro.org/gitweb?**p=qa/test-definitions.git%3Ba=** blob;f=android/0xbench.yamlhttp://git.linaro.org/gitweb?p=qa/test-definitions.git;a=blob;f=android/0xbench.yaml
I also tested the test definition by running it here - http://validation.linaro.org/**lava-server/scheduler/job/**50011http://validation.linaro.org/lava-server/scheduler/job/50011
Looks like the parse pattern is wrong. I fixed a small glitch in the YAML file where you missed a quote. I request you to fix the parse pattern and revert with a new patch.
Thank You.
Senthil Kumaran S http://www.stylesen.org/ http://www.sasenthilkumaran.**com/ http://www.sasenthilkumaran.com/
Hi Senthil,
Please find the patch with updated parse pattern.
Thanks and Regards, HariGopal G
On 21 March 2013 08:08, Senthil Kumaran senthil.kumaran@linaro.org wrote:
Hi Hari,
On Wednesday 20 March 2013 04:53 PM, Harigopal Gollamudi wrote:
Please find the 0xbench patch attached, as per the review comments.
I just pushed your changes to git repository - http://git.linaro.org/gitweb?**p=qa/test-definitions.git%3Ba=** blob;f=android/0xbench.yamlhttp://git.linaro.org/gitweb?p=qa/test-definitions.git;a=blob;f=android/0xbench.yaml
I also tested the test definition by running it here - http://validation.linaro.org/**lava-server/scheduler/job/**50011http://validation.linaro.org/lava-server/scheduler/job/50011
Looks like the parse pattern is wrong. I fixed a small glitch in the YAML file where you missed a quote. I request you to fix the parse pattern and revert with a new patch.
Thank You.
Senthil Kumaran S http://www.stylesen.org/ http://www.sasenthilkumaran.**com/ http://www.sasenthilkumaran.com/
Hi Hari,
On Thursday 21 March 2013 04:45 PM, Harigopal Gollamudi wrote:
Please find the patch with updated parse pattern.
I shall check and revert shortly.
Thank You.
Hi Hari,
On Thursday 21 March 2013 04:45 PM, Harigopal Gollamudi wrote:
Please find the patch with updated parse pattern.
I went through the pattern just now. It is still wrong. You cannot use the regex directly as you do in python, you must double escape stuff for example, like (please look at other parse patterns from different test definitions):
\s ==> \s \S ==> \S
Since all the required scripts are available in the git repository, I suggest you to have the YAML file on some public URL (people.linaro.org?) and refer it from your JSON file, that way you can test it out.
Thank You.
Hi Senthil,
please find the attached patch. Kindly review this and update me
Thanks and Regards, HariGopal G
On 21 March 2013 17:32, Senthil Kumaran senthil.kumaran@linaro.org wrote:
Hi Hari,
On Thursday 21 March 2013 04:45 PM, Harigopal Gollamudi wrote:
Please find the patch with updated parse pattern.
I went through the pattern just now. It is still wrong. You cannot use the regex directly as you do in python, you must double escape stuff for example, like (please look at other parse patterns from different test definitions):
\s ==> \s \S ==> \S
Since all the required scripts are available in the git repository, I suggest you to have the YAML file on some public URL (people.linaro.org?) and refer it from your JSON file, that way you can test it out.
Thank You.
Senthil Kumaran S http://www.stylesen.org/ http://www.sasenthilkumaran.**com/ http://www.sasenthilkumaran.com/
Hi Hari,
On Sat, 2013-03-23 at 00:52 +0530, Harigopal Gollamudi wrote:
please find the attached patch. Kindly review this and update me
I went through your new patch. What I found was, the new pattern you have put in does not relate to the old parse pattern!
- pattern: "^(?P<test_case_id>*?)\s+(?P<measurement>[\d.]+)\s +(?P<units>\S+)\s+(?P<result>(pass|fail))\s*$" + pattern: "^(?P<test_case_id>\S*\s*\S*)\s+(?P<measurement>\d +.\d+)\s+(?P<units>\S+)\s+(?P<result>\S+)$"
The new change is not the equivalent of the old and it is not correct (I am concerned about the regex here). I request you to fix the above and run a sample job in validation.linaro.org with the 0xbench yaml file. Please include link to the sample run in your next email.
Thank You.
Hi Senthil,
Please find the patch for the 0xbench.yaml with updated parsing pattern, that get passed.
yaml is placed @ http://staging.people.linaro.org/~harigopal.gollamudi/0xbench.yaml and tested this in validation server @ http://validation.linaro.org/lava-server/scheduler/job/50358
and also verified the pattern with the output, refer the attached sample script file 'test.py'
Thanks and Regards, HariGopal G
On 26 March 2013 19:49, Senthil Kumaran senthil.kumaran@linaro.org wrote:
Hi Hari,
On Sat, 2013-03-23 at 00:52 +0530, Harigopal Gollamudi wrote:
please find the attached patch. Kindly review this and update me
I went through your new patch. What I found was, the new pattern you have put in does not relate to the old parse pattern!
- pattern: "^(?P<test_case_id>*?)\s+(?P<measurement>[\d.]+)\s
+(?P<units>\S+)\s+(?P<result>(pass|fail))\s*$"
- pattern: "^(?P<test_case_id>\S*\s*\S*)\s+(?P<measurement>\d
+.\d+)\s+(?P<units>\S+)\s+(?P<result>\S+)$"
The new change is not the equivalent of the old and it is not correct (I am concerned about the regex here). I request you to fix the above and run a sample job in validation.linaro.org with the 0xbench yaml file. Please include link to the sample run in your next email.
Thank You.
Senthil Kumaran http://www.stylesen.org/ http://www.sasenthilkumaran.com/
Hi Hari,
On Wed, 2013-03-27 at 19:33 +0530, Harigopal Gollamudi wrote:
yaml is placed @ http://staging.people.linaro.org/~harigopal.gollamudi/0xbench.yaml and tested this in validation server @ http://validation.linaro.org/lava-server/scheduler/job/50358
Looking at http://validation.linaro.org/lava-server/dashboard/attachment/265562/view
and
http://validation.linaro.org/lava-server/dashboard/streams/anonymous/stylese...
I could see the test results are wrong. There is no pass/fail reported on the bundle. Secondly, the shell script did not run.
Thank You.
linaro-validation@lists.linaro.org