Hi,
message: Add sudo so that the ifconfig command do not fail when "lava-deployment-tool setup" is executed as non-privileged user.
I must not push because: I am not member of your team, I do not know what your patch policy is and I am not sure the patch is right. That is because I am sending the patch via email.
I will look at the rest of LAVA projects code in the next eight days. If you have some task which you want to work out, please let me know it. I will carry out it.
Regards --- $ bzr diff -r209..208 === modified file 'lava-deployment-tool' --- lava-deployment-tool 2012-10-02 14:32:21 +0000 +++ lava-deployment-tool 2012-09-14 21:11:54 +0000 @@ -759,7 +759,7 @@ echo "" echo "Here is the list of network device on this host"
- sudo ifconfig | grep 'Ethernet|inet addr' + ifconfig | grep 'Ethernet|inet addr'
while true; do
Actually so:
- ifconfig | grep 'Ethernet|inet addr' + sudo ifconfig | grep 'Ethernet|inet addr'
Sorry
W dniu 03.10.2012 12:09, davi@gnu.org pisze:
Actually so:
- ifconfig | grep 'Ethernet|inet addr'
- sudo ifconfig | grep 'Ethernet|inet addr'
Are you using a redhat based system? I recall they put ifconfig in /usr/sbin (it was a while since I last used any)
Thanks ZK
Zygmunt Krynicki wrote:
W dniu 03.10.2012 12:09, davi@gnu.org pisze:
Actually so:
- ifconfig | grep 'Ethernet|inet addr'
- sudo ifconfig | grep 'Ethernet|inet addr'
Are you using a redhat based system? I recall they put ifconfig in /usr/sbin (it was a while since I last used any)
I am using Ubuntu Precise, but the server one, not the desktop one. Maybe that is the cause.
On this Ubuntu Precise (server), the ifconfig command is at /sbin/ifconfig
Regards
I am using Ubuntu Precise, but the server one, not the desktop one. Maybe that is the cause.
On this Ubuntu Precise (server), the ifconfig command is at /sbin/ifconfig
I though adding "sudo" would help in my case, and at the same time would not harm on the usual Ubuntu desktop case.
Also note sudo if already being used on other parts of that script.
Regards
davi@gnu.org escreveu:
I am using Ubuntu Precise, but the server one, not the desktop one. Maybe that is the cause.
On this Ubuntu Precise (server), the ifconfig command is at /sbin/ifconfig
I though adding "sudo" would help in my case, and at the same time would not harm on the usual Ubuntu desktop case.
Also note sudo if already being used on other parts of that script.
For some reason in my development machine /sbin is the the PATH, even for the non-root user. But when I created a fresh user with `adduser`, then that new user does not have /sbin in $PATH. Weird - I did some investigation, but didn't find out why.
Maybe the best solution is to use ip, which is under /bin _and_ has much more parseable output. I just made a merge proposal:
https://code.launchpad.net/~terceiro/lava-deployment-tool/replace-ifconfig/+...
BTW the usual procedure for submitting patches is documented at https://wiki.linaro.org/Resources/HowTo/BZR
Antonio Terceiro wrote:
BTW the usual procedure for submitting patches is documented at https://wiki.linaro.org/Resources/HowTo/BZR
Thanks.
W dniu 03.10.2012 18:36, Antonio Terceiro pisze:
davi@gnu.org escreveu:
I am using Ubuntu Precise, but the server one, not the desktop one. Maybe that is the cause.
On this Ubuntu Precise (server), the ifconfig command is at /sbin/ifconfig
I though adding "sudo" would help in my case, and at the same time would not harm on the usual Ubuntu desktop case.
Also note sudo if already being used on other parts of that script.
For some reason in my development machine /sbin is the the PATH, even for the non-root user. But when I created a fresh user with `adduser`, then that new user does not have /sbin in $PATH. Weird - I did some investigation, but didn't find out why.
The user that installs the system gains more permissions (like being in sudoers and in the adm group). I suspect that it's related.
ZK
linaro-validation@lists.linaro.org
-
Antonio Terceiro -
davi＠gnu.org -
Zygmunt Krynicki