When hard_reset_command is the empty string, it's supposed to fall through and send the hardreset command through as a conmux command (e.g. ~$hardreset). However, the check for the existence of a hard_reset_command also fails for the empty string, so it never falls through.

Signed-off-by: Kevin Hilman khilman@linaro.org --- Suggestion: Since nobody seems to actually be using this feature except me, maybe the hard_reset_commmand (and power_off_command etc.) should be generalize so that if the string starts with "console:", then it sends the command over the serial console instead of runs it at the shell. e.g.

hard_reset_command = console: ~$hardreset power_off_cmd = console: ~$off

I started to implement but it didn't work as expected (see other post from me today on the linaro-validation list.)

lava_dispatcher/device/bootloader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lava_dispatcher/device/bootloader.py b/lava_dispatcher/device/bootloader.py index 529ad8048356..c784e8e8b1f9 100644 --- a/lava_dispatcher/device/bootloader.py +++ b/lava_dispatcher/device/bootloader.py @@ -332,7 +332,7 @@ class BootloaderTarget(MasterImageTarget): def _boot_linaro_image(self): self.proc.empty_buffer() if self._is_bootloader() and not self._booted: - if self.config.hard_reset_command: + if self.config.hard_reset_command or self.config.hard_reset_command == "": self._hard_reboot(self.proc) self._run_boot() else: