Hi all,
I found a parameter error in /lava_dispatcher/device/target.py In function def _load_boot_cmds
boot_cmds = self.config.cp.get('main', boot_cmds) should be fixed to boot_cmds = self.config.cp.get('main', 'boot_cmds')
Please check it, thank you.
-----Original Message----- From: linaro-validation-bounces@lists.linaro.org [mailto:linaro-validation-bounces@lists.linaro.org] On Behalf Of linaro-validation-request@lists.linaro.org Sent: Wednesday, October 22, 2014 20:00 To: linaro-validation@lists.linaro.org Subject: linaro-validation Digest, Vol 34, Issue 7
Send linaro-validation mailing list submissions to linaro-validation@lists.linaro.org
To subscribe or unsubscribe via the World Wide Web, visit http://lists.linaro.org/mailman/listinfo/linaro-validation or, via email, send a message with subject or body 'help' to linaro-validation-request@lists.linaro.org
You can reach the person managing the list at linaro-validation-owner@lists.linaro.org
When replying, please edit your Subject line so it is more specific than "Re: Contents of linaro-validation digest..."
Today's Topics:
1. [Activity] Week #42 (Georgy Redkozubov)
----------------------------------------------------------------------
Message: 1 Date: Wed, 22 Oct 2014 14:08:38 +0400 From: Georgy Redkozubov georgy.redkozubov@linaro.org To: linaro-validation@lists.linaro.org Subject: [Linaro-validation] [Activity] Week #42 Message-ID: 54478226.7010703@linaro.org Content-Type: text/plain; charset="utf-8"
# Progress #
* Cards * LAVA-1381 (https://cards.linaro.org/browse/LAVA-1381) Basic functionality works. Issue with job being incomplete is not reproducible anymore. Going to discuss with Senthil how to proceed further.
* Bugs * #349 (https://bugs.linaro.org/show_bug.cgi?id=349) Fixes based on review
* Code reviews
# Plan #
* LAVA-1381 *LAVA-1408 * Bugs
-- WBR, Georgy Redkozubov
Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#%21/linaroorg
On Fri, 24 Oct 2014 02:09:21 +0000 "Wu, Songjun" Songjun.Wu@atmel.com wrote:
Hi all,
I found a parameter error in /lava_dispatcher/device/target.py In function def _load_boot_cmds
boot_cmds = self.config.cp.get('main', boot_cmds) should be fixed to boot_cmds = self.config.cp.get('main', 'boot_cmds')
Please check it, thank you.
A patch is much easier to verify - there are two lines matching your description in that function and both of those actual lines are: boot_cmds = self.config.cp.get('__main__', boot_cmds)
Note the __main__.
However, the get() function here is the python default dict.get() which is using the boot_cmds variable as the default assignment if the 'main' key does not exist.
http://www.tutorialspoint.com/python/dictionary_get.htm
The variable boot_cmds is set earlier in the function: # Set the default boot commands if default is None: boot_cmds = self.deployment_data['boot_cmds'] else: boot_cmds = default
Please see the documentation on ways to contribute patches for LAVA: https://validation.linaro.org/static/docs/development.html#contributing-upst...
Hi Williams,
Both the two lines need to be fixed. I have verified it in the local LAVA server.
-----Original Message----- From: Neil Williams [mailto:codehelp@debian.org] Sent: Friday, October 24, 2014 16:00 To: linaro-validation@lists.linaro.org; Wu, Songjun Subject: Re: [Linaro-validation] A parameter error in file target.py
On Fri, 24 Oct 2014 02:09:21 +0000 "Wu, Songjun" Songjun.Wu@atmel.com wrote:
Hi all,
I found a parameter error in /lava_dispatcher/device/target.py In function def _load_boot_cmds
boot_cmds = self.config.cp.get('main', boot_cmds) should be fixed to boot_cmds = self.config.cp.get('main', 'boot_cmds')
Please check it, thank you.
A patch is much easier to verify - there are two lines matching your description in that function and both of those actual lines are: boot_cmds = self.config.cp.get('__main__', boot_cmds)
Note the __main__.
However, the get() function here is the python default dict.get() which is using the boot_cmds variable as the default assignment if the 'main' key does not exist.
http://www.tutorialspoint.com/python/dictionary_get.htm
The variable boot_cmds is set earlier in the function: # Set the default boot commands if default is None: boot_cmds = self.deployment_data['boot_cmds'] else: boot_cmds = default
Please see the documentation on ways to contribute patches for LAVA: https://validation.linaro.org/static/docs/development.html#contributing-upst...
linaro-validation@lists.linaro.org
-
Neil Williams -
Wu, Songjun