Hi YongQin,
On Thu, 2013-03-28 at 09:37 +0800, YongQin Liu wrote:
Sorry, seems validation@linaro.org does not exist now, just forward again.
It is linaro-validation@lists.linaro.org
Android team is doing a work to add the waiting in disablesuspend.sh script which has been integrated into the build already, so if this change get merge, then there should be no need to change on lava side I think. http://review.android.git.linaro.org/#change,3386
Please keep us posted on this, so that we will close the BP. This makes more sense to me since we need not maintain image specific code in lava.
Thank You.
Hi, All
The latest disablesuspend.sh has been merged. And it should be in the build created from tomorrow.
I checked it with this job: https://validation.linaro.org/lava-server/scheduler/job/50415/log_file
You can delete the wait home screen logic in LAVA(keep it as now has no problem), but I think it''s better to keep the interface for specifying if do the waiting home screen in lava. may be in some case we don't need to wait home screen, but still need to disable suspend.
You can pass the interface to disablesuspend.sh with --no-wait option.
by default disablesuspend.sh will wait for the home screen, and if you pass --no-wait option to it, like disablesuspend.sh --no-wait option then it will not wait for the home screen, and just do the disable suspend feature.
Thanks, Yongqin Liu
On 28 March 2013 11:45, Senthil Kumaran senthil.kumaran@linaro.org wrote:
Hi YongQin,
On Thu, 2013-03-28 at 09:37 +0800, YongQin Liu wrote:
Sorry, seems validation@linaro.org does not exist now, just forward again.
It is linaro-validation@lists.linaro.org
Android team is doing a work to add the waiting in disablesuspend.sh script which has been integrated into the build already, so if this change get merge, then there should be no need to change on lava side I think. http://review.android.git.linaro.org/#change,3386
Please keep us posted on this, so that we will close the BP. This makes more sense to me since we need not maintain image specific code in lava.
Thank You.
Senthil Kumaran http://www.stylesen.org/ http://www.sasenthilkumaran.com/
Hi,
On Thu, 2013-03-28 at 17:09 +0800, YongQin Liu wrote:
The latest disablesuspend.sh has been merged. And it should be in the build created from tomorrow.
I just marked the BP - https://blueprints.launchpad.net/lava-dispatcher/+spec/wait-for-homescreen as implemented, with a comment on the whiteboard explaining how it was achieved. I shall remove the homescreen.yaml and related scripts from git repository shortly.
Thank You.
linaro-validation@lists.linaro.org