Kindly review this and let me know, what to be done next?
---------- Forwarded message ---------- From: Harigopal Gollamudi harigopal.gollamudi@linaro.org Date: 8 March 2013 14:15 Subject: Pushing to 0xbench stuff to git To: Senthil Kumaran S senthil.kumaran@linaro.org
Hi Senthil,
how can I push 0xbench code to git? As there is one change in portion of code for pumping the output to Stdout. This change in code can pushed to android.git.linaro.org once it is reviewed.
please find the attached file
Hi Hari,
On Sunday 17 March 2013 10:25 PM, Harigopal Gollamudi wrote:
Kindly review this and let me know, what to be done next?
See attached YAML file for the changes I have made. In the shell script I could see lots of lines that are commented out. For example the following:
<snip> #pid=`ps |grep org.zeroxlab.zeroxbenchmark|tr -s " "|cut -d' ' -f2` #kill $pid </snip>
If they aren't required please remove it from the shell script to make things clean in the repository.
The json file which you have attached is good, but this is not required for the git repository.
I request you to send a patch by doing a 'git diff' against the repository instead of sending the files within a tarball. That way it will be easy for us to review the files via email with quotes.
Please make the changes mentioned above and send us a new patch.
Thank You.
linaro-validation@lists.linaro.org
-
Harigopal Gollamudi -
Senthil Kumaran