July 2023 - Linux-stable-mirror

[PATCH V6 net] net: mana: Fix MANA VF unload when hardware is

by Souradeep Chakrabarti

When unloading the MANA driver, mana_dealloc_queues() waits for the MANA hardware to complete any inflight packets and set the pending send count to zero. But if the hardware has failed, mana_dealloc_queues() could wait forever. Fix this by adding a timeout to the wait. Set the timeout to 120 seconds, which is a somewhat arbitrary value that is more than long enough for functional hardware to complete any sends. Cc: stable(a)vger.kernel.org Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Signed-off-by: Souradeep Chakrabarti <schakrabarti(a)linux.microsoft.com> --- V5 -> V6: * Added pcie_flr to reset the pci after timeout. * Fixed the position of changelog. * Removed unused variable like cq. V4 -> V5: * Added fixes tag * Changed the usleep_range from static to incremental value. * Initialized timeout in the begining. V3 -> V4: * Removed the unnecessary braces from mana_dealloc_queues(). V2 -> V3: * Removed the unnecessary braces from mana_dealloc_queues(). V1 -> V2: * Added net branch * Removed the typecasting to (struct mana_context*) of void pointer * Repositioned timeout variable in mana_dealloc_queues() * Repositioned vf_unload_timeout in mana_context struct, to utilise the 6 bytes hole --- drivers/net/ethernet/microsoft/mana/mana_en.c | 38 +++++++++++++++++-- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index a499e460594b..ea039e2d4c4b 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -8,6 +8,7 @@ #include <linux/ethtool.h> #include <linux/filter.h> #include <linux/mm.h> +#include <linux/pci.h> #include <net/checksum.h> #include <net/ip6_checksum.h> @@ -2345,9 +2346,12 @@ int mana_attach(struct net_device *ndev) static int mana_dealloc_queues(struct net_device *ndev) { struct mana_port_context *apc = netdev_priv(ndev); + unsigned long timeout = jiffies + 120 * HZ; struct gdma_dev *gd = apc->ac->gdma_dev; struct mana_txq *txq; + struct sk_buff *skb; int i, err; + u32 tsleep; if (apc->port_is_up) return -EINVAL; @@ -2363,15 +2367,41 @@ static int mana_dealloc_queues(struct net_device *ndev) * to false, but it doesn't matter since mana_start_xmit() drops any * new packets due to apc->port_is_up being false. * - * Drain all the in-flight TX packets + * Drain all the in-flight TX packets. + * A timeout of 120 seconds for all the queues is used. + * This will break the while loop when h/w is not responding. + * This value of 120 has been decided here considering max + * number of queues. */ + for (i = 0; i < apc->num_queues; i++) { txq = &apc->tx_qp[i].txq; - - while (atomic_read(&txq->pending_sends) > 0) - usleep_range(1000, 2000); + tsleep = 1000; + while (atomic_read(&txq->pending_sends) > 0 && + time_before(jiffies, timeout)) { + usleep_range(tsleep, tsleep + 1000); + tsleep <<= 1; + } + if (atomic_read(&txq->pending_sends)) { + err = pcie_flr(to_pci_dev(gd->gdma_context->dev)); + if (err) { + netdev_err(ndev, "flr failed %d with %d pkts pending in txq %u\n", + err, atomic_read(&txq->pending_sends), + txq->gdma_txq_id); + } + break; + } } + for (i = 0; i < apc->num_queues; i++) { + txq = &apc->tx_qp[i].txq; + while (atomic_read(&txq->pending_sends)) { + skb = skb_dequeue(&txq->pending_skbs); + mana_unmap_skb(skb, apc); + dev_consume_skb_any(skb); + atomic_sub(1, &txq->pending_sends); + } + } /* We're 100% sure the queues can no longer be woken up, because * we're sure now mana_poll_tx_cq() can't be running. */ -- 2.34.1

1 year, 8 months

4
3
0 0

[PATCH] dt-bindings: clock: xlnx,versal-clk: drop select:false

by Krzysztof Kozlowski

select:false makes the schema basically ignored and not effective, which is clearly not what we want for a device binding. Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver") Cc: <stable(a)vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- Cc: Shubhrajyoti Datta <shubhrajyoti.datta(a)amd.com> --- Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml index e9cf747bf89b..04ea327d5313 100644 --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml @@ -14,8 +14,6 @@ description: | reads required input clock frequencies from the devicetree and acts as clock provider for all clock consumers of PS clocks. -select: false - properties: compatible: oneOf: -- 2.34.1

1 year, 8 months

4
3
0 0

[PATCH 6.4 000/227] 6.4.7-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.4.7 release. There are 227 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 27 Jul 2023 10:44:26 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.4.7-rc1.… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.4.7-rc1 Wayne Lin <wayne.lin(a)amd.com> drm/amd/display: Add polling method to handle MST reply packet Srinivasan Shanmugam <srinivasan.shanmugam(a)amd.com> drm/amd/display: Clean up errors & warnings in amdgpu_dm.c Yu Kuai <yukuai3(a)huawei.com> scsi: sg: Fix checking return value of blk_get_queue() Yu Kuai <yukuai3(a)huawei.com> scsi/sg: don't grab scsi host module reference Abe Kohandel <abe.kohandel(a)intel.com> spi: dw: Remove misleading comment for Mount Evans SoC Yunxiang Li <Yunxiang.Li(a)amd.com> drm/ttm: fix bulk_move corruption when adding a entry Mohamed Khalfella <mkhalfella(a)purestorage.com> tracing/histograms: Return an error if we fail to add histogram to hist_vars list Miguel Ojeda <ojeda(a)kernel.org> kbuild: rust: avoid creating temporary files Zhang Yi <yi.zhang(a)huawei.com> jbd2: recheck chechpointing non-dirty buffer Vladimir Oltean <vladimir.oltean(a)nxp.com> net: phy: prevent stale pointer dereference in phy_init() Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around fastopenq.max_qlen Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around icsk->icsk_user_timeout Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tp->notsent_lowat Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around rskq_defer_accept Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tp->linger2 Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around icsk->icsk_syn_retries Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tp->keepalive_probes Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tp->keepalive_intvl Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tp->keepalive_time Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tp->tsoffset Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tp->tcp_tx_delay Tomasz Moń <tomasz.mon(a)nordicsemi.no> Bluetooth: btusb: Fix bluetooth on Intel Macbook 2014 Pauli Virtanen <pav(a)iki.fi> Bluetooth: SCO: fix sco_conn related locking and validity issues Siddh Raman Pant <code(a)siddh.me> Bluetooth: hci_conn: return ERR_PTR instead of NULL when there is no link Douglas Anderson <dianders(a)chromium.org> Bluetooth: hci_sync: Avoid use-after-free in dbg for hci_remove_adv_monitor() Pauli Virtanen <pav(a)iki.fi> Bluetooth: ISO: fix iso_conn related locking and validity issues Pauli Virtanen <pav(a)iki.fi> Bluetooth: hci_event: call disconnect callback before deleting conn Pauli Virtanen <pav(a)iki.fi> Bluetooth: use RCU for hci_conn_params and iterate safely in hci_sync Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_tables: skip bound chain on rule flush Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nf_tables: skip bound chain in netns release path Florian Westphal <fw(a)strlen.de> netfilter: nft_set_pipapo: fix improper element removal Florian Westphal <fw(a)strlen.de> netfilter: nf_tables: can't schedule in nft_chain_validate Florian Westphal <fw(a)strlen.de> netfilter: nf_tables: fix spurious set element insertion failure Vitaly Rodionov <vitalyr(a)opensource.cirrus.com> ALSA: hda/realtek: Fix generic fixup definition for cs35l41 amp Kuniyuki Iwashima <kuniyu(a)amazon.com> llc: Don't drop packet from non-root netns. Zhang Shurong <zhang_shurong(a)foxmail.com> fbdev: au1200fb: Fix missing IRQ check in au1200fb_drv_probe Daniel Golle <daniel(a)makrotopia.org> net: ethernet: mtk_eth_soc: always mtk_get_ib1_pkt_type Kuniyuki Iwashima <kuniyu(a)amazon.com> Revert "tcp: avoid the lookup process failing to get sk in ehash table" Yuanjun Gong <ruc_gongyuanjun(a)163.com> net:ipv6: check return value of pskb_trim() Wang Ming <machel(a)vivo.com> net: ipv4: Use kfree_sensitive instead of kfree Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tcp_rsk(req)->ts_recent Eric Dumazet <edumazet(a)google.com> tcp: annotate data-races around tcp_rsk(req)->txhash Antoine Tenart <atenart(a)kernel.org> net: ipv4: use consistent txhash in TIME_WAIT and SYN_RECV Florian Kauer <florian.kauer(a)linutronix.de> igc: Prevent garbled TX queue with XDP ZEROCOPY Kurt Kanzenbach <kurt(a)linutronix.de> igc: Avoid transmit queue timeout for XDP Alexander Duyck <alexanderduyck(a)fb.com> bpf, arm64: Fix BTI type used for freplace attached functions Kumar Kartikeya Dwivedi <memxor(a)gmail.com> bpf: Repeat check_max_stack_depth for async callbacks Kumar Kartikeya Dwivedi <memxor(a)gmail.com> bpf: Fix subprog idx logic in check_max_stack_depth Geetha sowjanya <gakula(a)marvell.com> octeontx2-pf: Dont allocate BPIDs for LBK interfaces Ido Schimmel <idosch(a)nvidia.com> vrf: Fix lockdep splat in output path Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> security: keys: Modify mismatched function name Ahmed Zaki <ahmed.zaki(a)intel.com> iavf: fix reset task race with iavf_remove() Ahmed Zaki <ahmed.zaki(a)intel.com> iavf: fix a deadlock caused by rtnl and driver's lock circular dependencies Marcin Szycik <marcin.szycik(a)linux.intel.com> iavf: Wait for reset in callbacks which trigger it Przemek Kitszel <przemyslaw.kitszel(a)intel.com> iavf: make functions static where possible Ahmed Zaki <ahmed.zaki(a)intel.com> iavf: use internal state to free traffic IRQs Ding Hui <dinghui(a)sangfor.com.cn> iavf: Fix out-of-bounds when setting channels on remove Ding Hui <dinghui(a)sangfor.com.cn> iavf: Fix use-after-free in free_netdev Andrzej Hajda <andrzej.hajda(a)intel.com> drm/i915/perf: add sentinel to xehp_oa_b_counters Heiner Kallweit <hkallweit1(a)gmail.com> r8169: fix ASPM-related problem for chip version 42 and 43 Tristram Ha <Tristram.Ha(a)microchip.com> net: dsa: microchip: correct KSZ8795 static MAC table access Victor Nogueira <victor(a)mojatatu.com> net: sched: cls_bpf: Undo tcf_bind_filter in case of an error Victor Nogueira <victor(a)mojatatu.com> net: sched: cls_u32: Undo refcount decrement in case update failed Victor Nogueira <victor(a)mojatatu.com> net: sched: cls_u32: Undo tcf_bind_filter if u32_replace_hw_knode Victor Nogueira <victor(a)mojatatu.com> net: sched: cls_matchall: Undo tcf_bind_filter in case of failure after mall_set_parms Martin Fuzzey <martin.fuzzey(a)flowbird.group> regulator: da9063: fix null pointer deref with partial DT config Dan Carpenter <dan.carpenter(a)linaro.org> ASoC: SOF: ipc3-dtrace: uninitialized data in dfsentry_trace_filter_write() Michal Swiatkowski <michal.swiatkowski(a)linux.intel.com> ice: prevent NULL pointer deref during reload Petr Oros <poros(a)redhat.com> ice: Unregister netdev and devlink_port only once Shyam Prasad N <nspmangalore(a)gmail.com> cifs: fix mid leak during reconnection after timeout threshold Dan Carpenter <error27(a)gmail.com> iommu/sva: Fix signedness bug in iommu_sva_alloc_pasid() Yan Zhai <yan(a)cloudflare.com> gso: fix dodgy bit handling for GSO_UDP_L4 Daniel Golle <daniel(a)makrotopia.org> net: ethernet: mtk_eth_soc: handle probe deferral Kuniyuki Iwashima <kuniyu(a)amazon.com> bridge: Add extack warning when enabling STP in netns. Tanmay Patil <t-patil(a)ti.com> net: ethernet: ti: cpsw_ale: Fix cpsw_ale_get_field()/cpsw_ale_set_field() Linus Walleij <linus.walleij(a)linaro.org> dsa: mv88e6xxx: Do a final check before timing out Marc Zyngier <maz(a)kernel.org> arm64: Fix HFGxTR_EL2 field naming Paulo Alcantara <pc(a)manguebit.com> smb: client: fix missed ses refcounting Yonghong Song <yhs(a)fb.com> kallsyms: strip LTO-only suffixes from promoted global functions Jaewon Kim <jaewon02.kim(a)samsung.com> spi: s3c64xx: clear loopback bit after loopback test Christoph Hellwig <hch(a)lst.de> btrfs: be a bit more careful when setting mirror_num_ret in btrfs_map_block James Clark <james.clark(a)arm.com> perf build: Fix library not found error when using CSLIBS Yangtao Li <frank.li(a)vivo.com> fbdev: imxfb: Removed unneeded release_mem_region Martin Kaiser <martin(a)kaiser.cx> fbdev: imxfb: warn about invalid left/right margin Jonas Gorski <jonas.gorski(a)gmail.com> spi: bcm63xx: fix max prepend length Biju Das <biju.das.jz(a)bp.renesas.com> pinctrl: renesas: rzg2l: Handle non-unique subnode names Geert Uytterhoeven <geert+renesas(a)glider.be> pinctrl: renesas: rzv2m: Handle non-unique subnode names Suren Baghdasaryan <surenb(a)google.com> sched/psi: use kernfs polling functions for PSI trigger polling Miaohe Lin <linmiaohe(a)huawei.com> sched/fair: Use recent_used_cpu to test p->cpus_ptr Peter Zijlstra <peterz(a)infradead.org> iov_iter: Mark copy_iovec_from_user() noclone Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> ASoC: qcom: q6apm: do not close GPR port before closing graph Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> ASoC: codecs: wcd938x: fix dB range for HPHL and HPHR Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd938x: fix mbhc impedance loglevel Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> ASoC: amd: acp: fix for invalid dai id handling in acp_get_byte_count() Hao Chen <chenhao418(a)huawei.com> net: hns3: fix strncpy() not using dest-buf length as length issue Ying Hsu <yinghsu(a)chromium.org> igb: Fix igb_down hung on surprise removal Yi Kuo <yi(a)yikuo.dev> wifi: iwlwifi: pcie: add device id 51F1 for killer 1675 Johannes Berg <johannes.berg(a)intel.com> wifi: iwlwifi: mvm: avoid baid size integer overflow Mukesh Sisodiya <mukesh.sisodiya(a)intel.com> wifi: iwlwifi: Add support for new PCI Id Gustavo A. R. Silva <gustavoars(a)kernel.org> wifi: wext-core: Fix -Wstringop-overflow warning in ioctl_standard_iw_point() Mukesh Sisodiya <mukesh.sisodiya(a)intel.com> wifi: iwlwifi: mvm: Add NULL check before dereferencing the pointer Petr Oros <poros(a)redhat.com> devlink: report devlink_port_type_warn source device Jisheng Zhang <jszhang(a)kernel.org> net: ethernet: litex: add support for 64 bit stats Gregory Greenman <gregory.greenman(a)intel.com> wifi: iwlwifi: mvm: fix potential array out of bounds access P Praneesh <quic_ppranees(a)quicinc.com> wifi: ath11k: fix memory leak in WMI firmware stats Balamurugan S <quic_bselvara(a)quicinc.com> wifi: ath12k: Avoid NULL pointer access during management transmit cleanup Abe Kohandel <abe.kohandel(a)intel.com> spi: dw: Add compatible for Intel Mount Evans SoC Ilan Peer <ilan.peer(a)intel.com> wifi: mac80211_hwsim: Fix possible NULL dereference Wen Gong <quic_wgong(a)quicinc.com> wifi: ath11k: add support default regdb while searching board-2.bin for WCN6855 Jakub Kicinski <kuba(a)kernel.org> devlink: make health report on unregistered instance warn just once Yonghong Song <yhs(a)fb.com> bpf: Silence a warning in btf_type_id_size() Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> wifi: rtw88: sdio: Check the HISR RX_REQUEST bit in rtw_sdio_rx_isr() Aditi Ghag <aditi.ghag(a)isovalent.com> bpf: tcp: Avoid taking fast sock lock in iterator Andrii Nakryiko <andrii(a)kernel.org> bpf: drop unnecessary user-triggerable WARN_ONCE in verifierl log Brad Larson <blarson(a)amd.com> spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC Martin KaFai Lau <martin.lau(a)kernel.org> bpf: Address KCSAN report on bpf_lru_list Kui-Feng Lee <thinker.li(a)gmail.com> bpf: Print a warning only if writing to unprivileged_bpf_disabled. Maxime Bizon <mbizon(a)freebox.fr> wifi: ath11k: fix registration of 6Ghz-only phy without the full channel range Yicong Yang <yangyicong(a)hisilicon.com> sched/fair: Don't balance task to its current running CPU Thomas Weißschuh <linux(a)weissschuh.net> tools/nolibc: ensure stack protector guard is never zero Paul E. McKenney <paulmck(a)kernel.org> rcu: Mark additional concurrent load from ->cpu_no_qs.b.exp Shigeru Yoshida <syoshida(a)redhat.com> rcu-tasks: Avoid pr_info() with spin lock in cblist_init_generic() Hans de Goede <hdegoede(a)redhat.com> ACPI: video: Add backlight=native DMI quirk for Dell Studio 1569 Mark Rutland <mark.rutland(a)arm.com> arm64: mm: fix VA-range sanity check Youngmin Nam <youngmin.nam(a)samsung.com> arm64: set __exception_irq_entry with __irq_entry as a default Mario Limonciello <mario.limonciello(a)amd.com> ACPI: resource: Remove "Zen" specific match and quirks Hans de Goede <hdegoede(a)redhat.com> ACPI: video: Add backlight=native DMI quirk for Lenovo ThinkPad X131e (3371 AMD version) Hans de Goede <hdegoede(a)redhat.com> ACPI: video: Add backlight=native DMI quirk for Apple iMac11,3 Hans de Goede <hdegoede(a)redhat.com> ACPI: x86: Add ACPI_QUIRK_UART1_SKIP for Lenovo Yoga Book yb1-x90f/l Hans de Goede <hdegoede(a)redhat.com> ACPI: button: Add lid disable DMI quirk for Nextbook Ares 8A Hans de Goede <hdegoede(a)redhat.com> ACPI: x86: Add skip i2c clients quirk for Nextbook Ares 8A Sandeep Dhavale <dhavale(a)google.com> erofs: Fix detection of atomic context Filipe Manana <fdmanana(a)suse.com> btrfs: abort transaction at update_ref_for_cow() when ref count is zero Christoph Hellwig <hch(a)lst.de> btrfs: don't check PageError in __extent_writepage David Sterba <dsterba(a)suse.com> btrfs: add xxhash to fast checksum implementations Thomas Gleixner <tglx(a)linutronix.de> posix-timers: Ensure timer ID search-loop limit is valid Ming Lei <ming.lei(a)redhat.com> blk-mq: fix NULL dereference on q->elevator in blk_mq_elv_switch_none Yu Kuai <yukuai3(a)huawei.com> scsi: sg: fix blktrace debugfs entries leakage Yu Kuai <yukuai3(a)huawei.com> md/raid10: prevent soft lockup while flush writes Yu Kuai <yukuai3(a)huawei.com> md: fix data corruption for raid456 when reshape restart while grow up Immad Mir <mirimmad17(a)gmail.com> FS: JFS: Check for read-only mounted filesystem in txBegin Immad Mir <mirimmad17(a)gmail.com> FS: JFS: Fix null-ptr-deref Read in txBegin Gustavo A. R. Silva <gustavoars(a)kernel.org> MIPS: dec: prom: Address -Warray-bounds warning Yogesh <yogi.kernel(a)gmail.com> fs: jfs: Fix UBSAN: array-index-out-of-bounds in dbAllocDmapLev Matthew Anderson <ruinairas1992(a)gmail.com> ALSA: hda/realtek: Add quirks for ROG ALLY CS35l41 audio Jan Kara <jack(a)suse.cz> udf: Fix uninitialized array access for some pathnames Christian Brauner <brauner(a)kernel.org> ovl: check type and offset of struct vfsmount in ovl_entry Marco Morandini <marco.morandini(a)polimi.it> HID: add quirk for 03f0:464a HP Elite Presenter Mouse Ye Bin <yebin10(a)huawei.com> quota: fix warning in dqgrab() Jan Kara <jack(a)suse.cz> quota: Properly disable quotas when add_dquot_ref() fails Oswald Buddenhagen <oswald.buddenhagen(a)gmx.de> ALSA: emu10k1: roll up loops in DSP setup code for Audigy hackyzh002 <hackyzh002(a)gmail.com> drm/radeon: Fix integer overflow in radeon_cs_parser_init Eric Whitney <enwlinux(a)gmail.com> ext4: correct inline offset when handling xattrs in inode body Marc Zyngier <maz(a)kernel.org> KVM: arm64: vgic-v4: Make the doorbell request robust w.r.t preemption Marc Zyngier <maz(a)kernel.org> KVM: arm64: Disable preemption in kvm_arch_hardware_enable() Oliver Upton <oliver.upton(a)linux.dev> KVM: arm64: Correctly handle page aging notifiers for unaligned memslot Marc Zyngier <maz(a)kernel.org> KVM: arm64: timers: Use CNTHCTL_EL2 when setting non-CNTKCTL_EL1 bits Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd938x: fix soundwire initialisation race Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd938x: fix codec initialisation race Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd934x: fix resource leaks on component remove Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd938x: fix missing mbhc init error handling Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd938x: fix resource leaks on component remove Sheetal <sheetal(a)nvidia.com> ASoC: tegra: Fix AMX byte map Johan Hovold <johan+linaro(a)kernel.org> ASoC: qdsp6: audioreach: fix topology probe deferral Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd-mbhc-v2: fix resource leaks on component remove Nathan Chancellor <nathan(a)kernel.org> ASoC: cs35l45: Select REGMAP_IRQ Johan Hovold <johan+linaro(a)kernel.org> ASoC: codecs: wcd938x: fix missing clsh ctrl error handling Thomas Petazzoni <thomas.petazzoni(a)bootlin.com> ASoC: cs42l51: fix driver to properly autoload with automatic module loading Sameer Pujar <spujar(a)nvidia.com> ASoC: rt5640: Fix sleep in atomic context Sheetal <sheetal(a)nvidia.com> ASoC: tegra: Fix ADX byte map Fabio Estevam <festevam(a)denx.de> ASoC: fsl_sai: Revert "ASoC: fsl_sai: Enable MCTL_MCLK_EN bit for master mode" Matus Gajdos <matuszpd(a)gmail.com> ASoC: fsl_sai: Disable bit clock with transmitter Nicholas Kazlauskas <nicholas.kazlauskas(a)amd.com> drm/amd/display: Keep PHY active for DP displays on DCN31 Taimur Hassan <syed.hassan(a)amd.com> drm/amd/display: check TG is non-null before checking if enabled Zhikai Zhai <zhikai.zhai(a)amd.com> drm/amd/display: Disable MPC split by default on special asic Simon Ser <contact(a)emersion.fr> drm/amd/display: only accept async flips for fast updates Jocelyn Falempe <jfalempe(a)redhat.com> drm/client: Fix memory leak in drm_client_modeset_probe Jocelyn Falempe <jfalempe(a)redhat.com> drm/client: Fix memory leak in drm_client_target_cloned Ben Skeggs <bskeggs(a)redhat.com> drm/nouveau/i2c: fix number of aux event slots Ben Skeggs <bskeggs(a)redhat.com> drm/nouveau/kms/nv50-: init hpd_irq_lock for PIOR DP Ben Skeggs <bskeggs(a)redhat.com> drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts Alex Deucher <alexander.deucher(a)amd.com> drm/amdgpu/pm: make mclk consistent for smu 13.0.7 Alex Deucher <alexander.deucher(a)amd.com> drm/amdgpu/pm: make gfxclock consistent for sienna cichlid Guchun Chen <guchun.chen(a)amd.com> drm/amdgpu/vkms: relax timer deactivation by hrtimer_try_to_cancel Ville Syrjälä <ville.syrjala(a)linux.intel.com> dma-buf/dma-resv: Stop leaking on krealloc() failure Dan Carpenter <dan.carpenter(a)linaro.org> accel/qaic: Add consistent integer overflow checks Dan Carpenter <dan.carpenter(a)linaro.org> accel/qaic: tighten bounds checking in decode_message() Dan Carpenter <dan.carpenter(a)linaro.org> accel/qaic: tighten bounds checking in encode_message() Matthieu Baerts <matthieu.baerts(a)tessares.net> selftests: tc: add ConnTrack procfs kconfig Heiner Kallweit <hkallweit1(a)gmail.com> Revert "r8169: disable ASPM during NAPI poll" Marc Kleine-Budde <mkl(a)pengutronix.de> can: gs_usb: fix time stamp counter initialization Marc Kleine-Budde <mkl(a)pengutronix.de> can: gs_usb: gs_can_open(): improve error handling YueHaibing <yuehaibing(a)huawei.com> can: bcm: Fix UAF in bcm_proc_show() Fedor Ross <fedor.ross(a)ifm.com> can: mcp251xfd: __mcp251xfd_chip_set_mode(): increase poll timeout Mark Brown <broonie(a)kernel.org> arm64/fpsimd: Ensure SME storage is allocated after SVE VL changes Helge Deller <deller(a)gmx.de> ia64: mmap: Consider pgoff when searching for free mapping Mark Brown <broonie(a)kernel.org> regmap: Account for register length in SMBus I/O limits Rob Herring <robh(a)kernel.org> of: Preserve "of-display" device name for compatibility Harald Freudenberger <freude(a)linux.ibm.com> s390/zcrypt: fix reply buffer calculations for CCA replies Mark Brown <broonie(a)kernel.org> regmap: Drop initial version of maximum transfer length fixes Matthieu Baerts <matthieu.baerts(a)tessares.net> selftests: tc: add 'ct' action kconfig dep Dan Carpenter <dan.carpenter(a)linaro.org> accel/qaic: Fix a leak in map_user_pages() Matthieu Baerts <matthieu.baerts(a)tessares.net> selftests: tc: set timeout to 15 minutes Josef Bacik <josef(a)toxicpanda.com> btrfs: fix race between balance and cancel/pause Miklos Szeredi <mszeredi(a)redhat.com> fuse: ioctl: translate ENOSYS in outarg Filipe Manana <fdmanana(a)suse.com> btrfs: zoned: fix memory leak after finding block group with super blocks Filipe Manana <fdmanana(a)suse.com> btrfs: fix double iput() on inode after an error during orphan cleanup Josef Bacik <josef(a)toxicpanda.com> btrfs: set_page_extent_mapped after read_folio in btrfs_cont_expand Qu Wenruo <wqu(a)suse.com> btrfs: raid56: always verify the P/Q contents for scrub Bernd Schubert <bschubert(a)ddn.com> fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT Miklos Szeredi <mszeredi(a)redhat.com> fuse: add feature flag for expire-only Miklos Szeredi <mszeredi(a)redhat.com> fuse: revalidate: don't invalidate if interrupted Filipe Manana <fdmanana(a)suse.com> btrfs: fix warning when putting transaction with qgroups enabled after abort Filipe Manana <fdmanana(a)suse.com> btrfs: fix iput() on error pointer after error during orphan cleanup Georg Müller <georgmueller(a)gmx.net> perf probe: Read DWARF files from the correct CU Georg Müller <georgmueller(a)gmx.net> perf probe: Add test for regression introduced by switch to die_get_decl_file() Miguel Ojeda <ojeda(a)kernel.org> prctl: move PR_GET_AUXV out of PR_MCE_KILL Petr Pavlu <petr.pavlu(a)suse.com> keys: Fix linking a duplicate key to a keyring's assoc_array Colin Ian King <colin.i.king(a)gmail.com> selftests/mm: mkdirty: fix incorrect position of #endif Liam R. Howlett <Liam.Howlett(a)oracle.com> maple_tree: fix node allocation testing on 32 bit Liam R. Howlett <Liam.Howlett(a)oracle.com> mm/mlock: fix vma iterator conversion of apply_vma_lock_flags() Peng Zhang <zhangpeng.00(a)bytedance.com> maple_tree: set the node limit when creating a new root node Luka Guzenko <l.guzenko(a)web.de> ALSA: hda/realtek: Enable Mute LED on HP Laptop 15s-eq2xxx Christoffer Sandberg <cs(a)tuxedo.de> ALSA: hda/realtek: Add quirk for Clevo NS70AU Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - remove 3k pull low procedure Helge Deller <deller(a)gmx.de> io_uring: Fix io_uring mmap() by using architecture-provided get_unmapped_area() Jens Axboe <axboe(a)kernel.dk> io_uring: treat -EAGAIN for REQ_F_NOWAIT as final for io-wq ------------- Diffstat: Makefile | 4 +- arch/arm64/include/asm/exception.h | 5 - arch/arm64/include/asm/kvm_host.h | 2 + arch/arm64/include/asm/kvm_pgtable.h | 26 +-- arch/arm64/kernel/fpsimd.c | 33 ++- arch/arm64/kvm/arch_timer.c | 6 +- arch/arm64/kvm/arm.c | 19 +- arch/arm64/kvm/hyp/pgtable.c | 47 +++- arch/arm64/kvm/mmu.c | 18 +- arch/arm64/kvm/vgic/vgic-v3.c | 2 +- arch/arm64/kvm/vgic/vgic-v4.c | 7 +- arch/arm64/mm/mmu.c | 4 +- arch/arm64/net/bpf_jit_comp.c | 8 +- arch/arm64/tools/sysreg | 12 +- arch/ia64/kernel/sys_ia64.c | 2 +- arch/mips/include/asm/dec/prom.h | 2 +- arch/parisc/kernel/sys_parisc.c | 15 +- block/blk-mq.c | 10 +- drivers/accel/qaic/qaic_control.c | 39 ++-- drivers/acpi/button.c | 9 + drivers/acpi/resource.c | 60 ----- drivers/acpi/video_detect.c | 24 ++ drivers/acpi/x86/utils.c | 26 ++- drivers/base/regmap/regmap-i2c.c | 8 +- drivers/base/regmap/regmap-spi-avmm.c | 2 +- drivers/base/regmap/regmap.c | 6 +- drivers/bluetooth/btusb.c | 1 + drivers/dma-buf/dma-resv.c | 13 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 5 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 256 +++++++++------------ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 12 + .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 110 +++++++++ .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.h | 11 + .../amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 5 + .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 +- .../drm/amd/display/dc/dcn303/dcn303_resource.c | 2 +- .../drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 8 +- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 2 +- drivers/gpu/drm/drm_client_modeset.c | 6 + drivers/gpu/drm/i915/i915_perf.c | 1 + drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 + drivers/gpu/drm/nouveau/include/nvkm/subdev/i2c.h | 4 +- drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c | 27 ++- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 11 +- drivers/gpu/drm/radeon/radeon_cs.c | 3 +- drivers/gpu/drm/ttm/ttm_resource.c | 5 +- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-quirks.c | 1 + drivers/iommu/iommu-sva.c | 3 +- drivers/md/md.c | 14 +- drivers/md/raid10.c | 2 + drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 10 +- drivers/net/can/spi/mcp251xfd/mcp251xfd.h | 1 + drivers/net/can/usb/gs_usb.c | 130 ++++++----- drivers/net/dsa/microchip/ksz8795.c | 8 +- drivers/net/dsa/microchip/ksz_common.c | 8 +- drivers/net/dsa/microchip/ksz_common.h | 7 + drivers/net/dsa/mv88e6xxx/chip.c | 7 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 33 ++- .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 29 ++- drivers/net/ethernet/intel/iavf/iavf.h | 16 +- drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 39 ++-- drivers/net/ethernet/intel/iavf/iavf_main.c | 223 ++++++++++++------ drivers/net/ethernet/intel/iavf/iavf_txrx.c | 43 ++-- drivers/net/ethernet/intel/iavf/iavf_txrx.h | 4 - drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 5 +- drivers/net/ethernet/intel/ice/ice_base.c | 2 + drivers/net/ethernet/intel/ice/ice_ethtool.c | 13 +- drivers/net/ethernet/intel/ice/ice_lib.c | 27 --- drivers/net/ethernet/intel/ice/ice_main.c | 10 +- drivers/net/ethernet/intel/igb/igb_main.c | 5 + drivers/net/ethernet/intel/igc/igc_main.c | 12 +- drivers/net/ethernet/litex/litex_liteeth.c | 19 +- .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 5 +- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 29 +-- drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c | 2 +- drivers/net/ethernet/realtek/r8169_main.c | 18 +- drivers/net/ethernet/ti/cpsw_ale.c | 24 +- drivers/net/phy/phy_device.c | 21 +- drivers/net/vrf.c | 12 +- drivers/net/wireless/ath/ath11k/core.c | 53 +++-- drivers/net/wireless/ath/ath11k/mac.c | 3 +- drivers/net/wireless/ath/ath11k/wmi.c | 5 + drivers/net/wireless/ath/ath12k/mac.c | 1 + drivers/net/wireless/intel/iwlwifi/mvm/mld-key.c | 9 +- drivers/net/wireless/intel/iwlwifi/mvm/power.c | 14 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 2 +- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 4 + drivers/net/wireless/realtek/rtw88/sdio.c | 24 +- drivers/net/wireless/virtual/mac80211_hwsim.c | 4 +- drivers/of/platform.c | 2 +- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 28 ++- drivers/pinctrl/renesas/pinctrl-rzv2m.c | 28 ++- drivers/regulator/da9063-regulator.c | 3 + drivers/s390/crypto/zcrypt_msgtype6.c | 33 ++- drivers/scsi/sg.c | 10 + drivers/spi/spi-bcm63xx.c | 2 +- drivers/spi/spi-cadence-quadspi.c | 19 ++ drivers/spi/spi-dw-mmio.c | 22 ++ drivers/spi/spi-s3c64xx.c | 2 + drivers/video/fbdev/au1200fb.c | 3 + drivers/video/fbdev/imxfb.c | 5 +- fs/btrfs/block-group.c | 1 + fs/btrfs/ctree.c | 10 +- fs/btrfs/disk-io.c | 3 + fs/btrfs/extent_io.c | 33 +-- fs/btrfs/inode.c | 35 +-- fs/btrfs/qgroup.c | 1 + fs/btrfs/raid56.c | 11 +- fs/btrfs/volumes.c | 17 +- fs/erofs/zdata.c | 2 +- fs/ext4/xattr.c | 14 ++ fs/fuse/dir.c | 2 +- fs/fuse/inode.c | 8 +- fs/fuse/ioctl.c | 21 +- fs/jbd2/checkpoint.c | 102 +++----- fs/jfs/jfs_dmap.c | 3 + fs/jfs/jfs_txnmgr.c | 5 + fs/jfs/namei.c | 5 + fs/overlayfs/ovl_entry.h | 9 + fs/quota/dquot.c | 5 +- fs/smb/client/connect.c | 19 +- fs/smb/client/dfs.c | 26 +-- fs/smb/client/smb2transport.c | 2 +- fs/udf/unicode.c | 2 +- include/kvm/arm_vgic.h | 2 +- include/linux/psi.h | 5 +- include/linux/psi_types.h | 3 + include/linux/sched/signal.h | 2 +- include/linux/tcp.h | 2 +- include/net/bluetooth/hci_core.h | 5 + include/net/ip.h | 2 +- include/net/tcp.h | 31 ++- include/uapi/linux/fuse.h | 3 + io_uring/io_uring.c | 52 ++--- kernel/bpf/bpf_lru_list.c | 21 +- kernel/bpf/bpf_lru_list.h | 7 +- kernel/bpf/btf.c | 23 +- kernel/bpf/log.c | 3 - kernel/bpf/syscall.c | 3 +- kernel/bpf/verifier.c | 32 ++- kernel/cgroup/cgroup.c | 2 +- kernel/kallsyms.c | 5 +- kernel/rcu/tasks.h | 5 +- kernel/rcu/tree_exp.h | 2 +- kernel/rcu/tree_plugin.h | 4 +- kernel/sched/fair.c | 4 +- kernel/sched/psi.c | 29 ++- kernel/sys.c | 10 +- kernel/time/posix-timers.c | 31 +-- kernel/trace/trace_events_hist.c | 3 +- lib/iov_iter.c | 2 +- lib/maple_tree.c | 3 +- mm/mlock.c | 9 +- net/bluetooth/hci_conn.c | 14 +- net/bluetooth/hci_core.c | 42 +++- net/bluetooth/hci_event.c | 15 +- net/bluetooth/hci_sync.c | 121 ++++++++-- net/bluetooth/iso.c | 55 +++-- net/bluetooth/mgmt.c | 26 +-- net/bluetooth/sco.c | 23 +- net/bridge/br_stp_if.c | 3 + net/can/bcm.c | 12 +- net/devlink/health.c | 2 +- net/devlink/leftover.c | 5 +- net/ipv4/esp4.c | 2 +- net/ipv4/inet_connection_sock.c | 2 +- net/ipv4/inet_hashtables.c | 17 +- net/ipv4/inet_timewait_sock.c | 8 +- net/ipv4/ip_output.c | 4 +- net/ipv4/tcp.c | 57 ++--- net/ipv4/tcp_fastopen.c | 6 +- net/ipv4/tcp_ipv4.c | 27 ++- net/ipv4/tcp_minisocks.c | 11 +- net/ipv4/tcp_output.c | 6 +- net/ipv4/udp_offload.c | 16 +- net/ipv6/ip6_gre.c | 3 +- net/ipv6/tcp_ipv6.c | 4 +- net/ipv6/udp_offload.c | 3 +- net/llc/llc_input.c | 3 - net/netfilter/nf_tables_api.c | 12 +- net/netfilter/nft_set_pipapo.c | 6 +- net/sched/cls_bpf.c | 99 ++++---- net/sched/cls_matchall.c | 35 +-- net/sched/cls_u32.c | 48 +++- net/wireless/wext-core.c | 6 + scripts/Makefile.build | 5 +- scripts/Makefile.host | 6 +- scripts/kallsyms.c | 6 +- security/keys/request_key.c | 35 ++- security/keys/trusted-keys/trusted_tpm2.c | 2 +- sound/pci/emu10k1/emufx.c | 112 +-------- sound/pci/hda/patch_realtek.c | 100 +++++++- sound/soc/amd/acp/amd.h | 7 +- sound/soc/codecs/Kconfig | 1 + sound/soc/codecs/cs42l51-i2c.c | 6 + sound/soc/codecs/cs42l51.c | 7 - sound/soc/codecs/cs42l51.h | 1 - sound/soc/codecs/rt5640.c | 12 +- sound/soc/codecs/wcd-mbhc-v2.c | 57 +++-- sound/soc/codecs/wcd934x.c | 12 + sound/soc/codecs/wcd938x.c | 86 ++++++- sound/soc/fsl/fsl_sai.c | 8 +- sound/soc/fsl/fsl_sai.h | 1 + sound/soc/qcom/qdsp6/q6apm.c | 7 +- sound/soc/qcom/qdsp6/topology.c | 4 +- sound/soc/sof/ipc3-dtrace.c | 9 +- sound/soc/tegra/tegra210_adx.c | 34 ++- sound/soc/tegra/tegra210_amx.c | 40 ++-- tools/include/nolibc/stackprotector.h | 5 +- tools/perf/Makefile.config | 4 +- .../tests/shell/test_uprobe_from_different_cu.sh | 77 +++++++ tools/perf/util/dwarf-aux.c | 4 +- tools/testing/radix-tree/maple.c | 6 +- tools/testing/selftests/mm/mkdirty.c | 2 +- tools/testing/selftests/tc-testing/config | 2 + tools/testing/selftests/tc-testing/settings | 1 + 218 files changed, 2462 insertions(+), 1482 deletions(-)

1 year, 8 months

18
278
0 0

Fwd: vmalloc error: btrfs-delalloc btrfs_work_helper [btrfs] in kernel 6.3.x

by Bagas Sanjaya

Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > after updating from 6.2.x to 6.3.x, vmalloc error messages started to appear in the dmesg > > > > # free > total used free shared buff/cache available > Mem: 16183724 1473068 205664 33472 14504992 14335700 > Swap: 16777212 703596 16073616 > > > (zswap enabled) See bugzilla for the full thread and attached dmesg. On the report, the reporter can't perform the required bisection, unfortunately. Anyway, I'm adding it to regzbot: #regzbot introduced: v6.2..v6.3 https://bugzilla.kernel.org/show_bug.cgi?id=217466 #regzbot title: btrfs_work_helper dealloc error in v6.3.x Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217466 -- An old man doll... just what I always wanted! - Clara

1 year, 8 months

5
14
0 0

[PATCH] drm/amdgpu: Always emit GDS switch when GDS/GWS/OA is used

by Friedrich Vock

During gfxoff, the per-VMID GDS registers are reset and not restored afterwards. The kernel needs to emit a GDS switch to manually update the GWS registers in this case. Since gfxoff can happen between any two submissions and the kernel has no way of knowing, emit the GDS switch before every submission. Fixes: 56b0989e29 ("drm/amdgpu: fix GDS/GWS/OA switch handling") Cc: stable(a)vger.kernel.org Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2530 Signed-off-by: Friedrich Vock <friedrich.vock(a)gmx.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 22 +++++++--------------- drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 ++++++++-- 3 files changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c index ff1ea99292fb..de73797e9279 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c @@ -165,24 +165,17 @@ bool amdgpu_vmid_had_gpu_reset(struct amdgpu_device *adev, atomic_read(&adev->gpu_reset_counter); } -/* Check if we need to switch to another set of resources */ -static bool amdgpu_vmid_gds_switch_needed(struct amdgpu_vmid *id, - struct amdgpu_job *job) -{ - return id->gds_base != job->gds_base || - id->gds_size != job->gds_size || - id->gws_base != job->gws_base || - id->gws_size != job->gws_size || - id->oa_base != job->oa_base || - id->oa_size != job->oa_size; -} - /* Check if the id is compatible with the job */ static bool amdgpu_vmid_compatible(struct amdgpu_vmid *id, struct amdgpu_job *job) { return id->pd_gpu_addr == job->vm_pd_addr && - !amdgpu_vmid_gds_switch_needed(id, job); + id->gds_base == job->gds_base && + id->gds_size == job->gds_size && + id->gws_base == job->gws_base && + id->gws_size == job->gws_size && + id->oa_base == job->oa_base && + id->oa_size == job->oa_size; } /** @@ -434,7 +427,6 @@ int amdgpu_vmid_grab(struct amdgpu_vm *vm, struct amdgpu_ring *ring, list_move_tail(&id->list, &id_mgr->ids_lru); } - job->gds_switch_needed = amdgpu_vmid_gds_switch_needed(id, job); if (job->vm_needs_flush) { id->flushed_updates = amdgpu_vm_tlb_seq(vm); dma_fence_put(id->last_flush); @@ -503,7 +495,7 @@ void amdgpu_vmid_free_reserved(struct amdgpu_device *adev, * @vmhub: vmhub type * @vmid: vmid number to use * - * Reset saved GDW, GWS and OA to force switch on next flush. + * Reset saved GDS, GWS and OA data. */ void amdgpu_vmid_reset(struct amdgpu_device *adev, unsigned vmhub, unsigned vmid) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h index a963a25ddd62..2898508b1ce4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.h @@ -53,7 +53,6 @@ struct amdgpu_job { uint32_t preamble_status; uint32_t preemption_status; bool vm_needs_flush; - bool gds_switch_needed; bool spm_update_needed; uint64_t vm_pd_addr; unsigned vmid; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 291977b93b1d..61856040cae2 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -557,6 +557,12 @@ void amdgpu_vm_check_compute_bug(struct amdgpu_device *adev) } } +/* Check if the job needs a GDS switch */ +static bool amdgpu_vm_need_gds_switch(struct amdgpu_job *job) +{ + return job->gds_size || job->gws_size || job->oa_size; +} + /** * amdgpu_vm_need_pipeline_sync - Check if pipe sync is needed for job. * @@ -579,7 +585,7 @@ bool amdgpu_vm_need_pipeline_sync(struct amdgpu_ring *ring, if (job->vm_needs_flush || ring->has_compute_vm_bug) return true; - if (ring->funcs->emit_gds_switch && job->gds_switch_needed) + if (ring->funcs->emit_gds_switch && amdgpu_vm_need_gds_switch(job)) return true; if (amdgpu_vmid_had_gpu_reset(adev, &id_mgr->ids[job->vmid])) @@ -609,7 +615,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, struct amdgpu_vmid *id = &id_mgr->ids[job->vmid]; bool spm_update_needed = job->spm_update_needed; bool gds_switch_needed = ring->funcs->emit_gds_switch && - job->gds_switch_needed; + amdgpu_vm_need_gds_switch(job); bool vm_flush_needed = job->vm_needs_flush; struct dma_fence *fence = NULL; bool pasid_mapping_needed = false; -- 2.41.0

1 year, 8 months

2
5
0 0

[PATCH 0/6] make vma locking more obvious

by Suren Baghdasaryan

During recent vma locking patch reviews Linus and Jann Horn noted a number of issues with vma locking and suggested improvements: 1. walk_page_range() does not have ability to write-lock a vma during the walk when it's done under mmap_write_lock. For example s390_reset_cmma(). 2. Vma locking is hidden inside vm_flags modifiers and is hard to follow. Suggestion is to change vm_flags_reset{_once} to assert that vma is write-locked and require an explicit locking. 3. Same issue with vma_prepare() hiding vma locking. 4. In userfaultfd vm_flags are modified after vma->vm_userfaultfd_ctx and page faults can operate on a context while it's changed. 5. do_brk_flags() and __install_special_mapping() not locking a newly created vma before adding it into the mm. While not strictly a problem, this is fragile if vma is modified after insertion, as in the mmap_region() case which was recently fixed. Suggestion is to always lock a new vma before inserting it and making it visible to page faults. 6. vma_assert_write_locked() for CONFIG_PER_VMA_LOCK=n would benefit from being mmap_assert_write_locked() instead of no-op and then any place which operates on a vma and calls mmap_assert_write_locked() can be converted into vma_assert_write_locked(). I CC'ed stable only on the first patch because others are cleanups and the bug in userfaultfd does not affect stable (lock_vma_under_rcu prevents uffds from being handled under vma lock protection). However I would be happy if the whole series is merged into stable 6.4 since it makes vma locking more maintainable. The patches apply cleanly over Linus' ToT and will conflict when applied over mm-unstable due to missing [1]. The conflict can be easily resolved by ignoring conflicting deletions but probably simpler to take [1] into mm-unstable and avoid later conflict. [1] commit 6c21e066f925 ("mm/mempolicy: Take VMA lock before replacing policy") Suren Baghdasaryan (6): mm: enable page walking API to lock vmas during the walk mm: for !CONFIG_PER_VMA_LOCK equate write lock assertion for vma and mmap mm: replace mmap with vma write lock assertions when operating on a vma mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once mm: always lock new vma before inserting into vma tree mm: move vma locking out of vma_prepare arch/powerpc/kvm/book3s_hv_uvmem.c | 1 + arch/powerpc/mm/book3s64/subpage_prot.c | 2 +- arch/riscv/mm/pageattr.c | 4 ++-- arch/s390/mm/gmap.c | 10 ++++----- drivers/infiniband/hw/hfi1/file_ops.c | 1 + fs/proc/task_mmu.c | 10 ++++----- fs/userfaultfd.c | 6 +++++ include/linux/mm.h | 13 +++++++---- include/linux/pagewalk.h | 6 ++--- mm/damon/vaddr.c | 4 ++-- mm/hmm.c | 2 +- mm/hugetlb.c | 2 +- mm/khugepaged.c | 5 +++-- mm/ksm.c | 16 +++++++------- mm/madvise.c | 13 +++++------ mm/memcontrol.c | 4 ++-- mm/memory-failure.c | 2 +- mm/memory.c | 2 +- mm/mempolicy.c | 12 ++++------ mm/migrate_device.c | 2 +- mm/mincore.c | 2 +- mm/mlock.c | 5 +++-- mm/mmap.c | 29 ++++++++++++++++--------- mm/mprotect.c | 3 ++- mm/pagewalk.c | 13 ++++++++--- mm/vmscan.c | 3 ++- 26 files changed, 100 insertions(+), 72 deletions(-) -- 2.41.0.487.g6d72f3e995-goog

1 year, 8 months

5
17
0 0

[PATCH] dmaengine: pl330: Return DMA_PAUSED when transaction is paused

by Ilpo Järvinen

pl330_pause() does not set anything to indicate paused condition which causes pl330_tx_status() to return DMA_IN_PROGRESS. This breaks 8250 DMA flush after the fix in commit 57e9af7831dc ("serial: 8250_dma: Fix DMA Rx rearm race"). The function comment for pl330_pause() claims pause is supported but resume is not which is enough for 8250 DMA flush to work as long as DMA status reports DMA_PAUSED when appropriate. Add PAUSED state for descriptor and mark BUSY descriptors with PAUSED in pl330_pause(). Return DMA_PAUSED from pl330_tx_status() when the descriptor is PAUSED. Reported-by: Richard Tresidder <rtresidd(a)electromag.com.au> Tested-by: Richard Tresidder <rtresidd(a)electromag.com.au> Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature") Cc: stable(a)vger.kernel.org Link: https://lore.kernel.org/linux-serial/f8a86ecd-64b1-573f-c2fa-59f541083f1a@e… Signed-off-by: Ilpo Järvinen <ilpo.jarvinen(a)linux.intel.com> --- $ diff -u <(git grep -l -e '\.device_pause' -e '->device_pause') <(git grep -l DMA_PAUSED) ...tells there might a few other drivers which do not properly return DMA_PAUSED status despite having a pause function. drivers/dma/pl330.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 0d9257fbdfb0..daad25f2c498 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -403,6 +403,12 @@ enum desc_status { * of a channel can be BUSY at any time. */ BUSY, + /* + * Pause was called while descriptor was BUSY. Due to hardware + * limitations, only termination is possible for descriptors + * that have been paused. + */ + PAUSED, /* * Sitting on the channel work_list but xfer done * by PL330 core @@ -2041,7 +2047,7 @@ static inline void fill_queue(struct dma_pl330_chan *pch) list_for_each_entry(desc, &pch->work_list, node) { /* If already submitted */ - if (desc->status == BUSY) + if (desc->status == BUSY || desc->status == PAUSED) continue; ret = pl330_submit_req(pch->thread, desc); @@ -2326,6 +2332,7 @@ static int pl330_pause(struct dma_chan *chan) { struct dma_pl330_chan *pch = to_pchan(chan); struct pl330_dmac *pl330 = pch->dmac; + struct dma_pl330_desc *desc; unsigned long flags; pm_runtime_get_sync(pl330->ddma.dev); @@ -2335,6 +2342,10 @@ static int pl330_pause(struct dma_chan *chan) _stop(pch->thread); spin_unlock(&pl330->lock); + list_for_each_entry(desc, &pch->work_list, node) { + if (desc->status == BUSY) + desc->status = PAUSED; + } spin_unlock_irqrestore(&pch->lock, flags); pm_runtime_mark_last_busy(pl330->ddma.dev); pm_runtime_put_autosuspend(pl330->ddma.dev); @@ -2425,7 +2436,7 @@ pl330_tx_status(struct dma_chan *chan, dma_cookie_t cookie, else if (running && desc == running) transferred = pl330_get_current_xferred_count(pch, desc); - else if (desc->status == BUSY) + else if (desc->status == BUSY || desc->status == PAUSED) /* * Busy but not running means either just enqueued, * or finished and not yet marked done @@ -2442,6 +2453,9 @@ pl330_tx_status(struct dma_chan *chan, dma_cookie_t cookie, case DONE: ret = DMA_COMPLETE; break; + case PAUSED: + ret = DMA_PAUSED; + break; case PREP: case BUSY: ret = DMA_IN_PROGRESS; -- 2.30.2

1 year, 8 months

3
4
0 0

[PATCH] fs/proc/kcore: reinstate bounce buffer for KCORE_TEXT regions

by Lorenzo Stoakes

Some architectures do not populate the entire range categorised by KCORE_TEXT, so we must ensure that the kernel address we read from is valid. Unfortunately there is no solution currently available to do so with a purely iterator solution so reinstate the bounce buffer in this instance so we can use copy_from_kernel_nofault() in order to avoid page faults when regions are unmapped. This change partly reverts commit 2e1c0170771e ("fs/proc/kcore: avoid bounce buffer for ktext data"), reinstating the bounce buffer, but adapts the code to continue to use an iterator. Fixes: 2e1c0170771e ("fs/proc/kcore: avoid bounce buffer for ktext data") Reported-by: Jiri Olsa <olsajiri(a)gmail.com> Closes: https://lore.kernel.org/all/ZHc2fm+9daF6cgCE@krava Cc: stable(a)vger.kernel.org Signed-off-by: Lorenzo Stoakes <lstoakes(a)gmail.com> --- fs/proc/kcore.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index 9cb32e1a78a0..3bc689038232 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c @@ -309,6 +309,8 @@ static void append_kcore_note(char *notes, size_t *i, const char *name, static ssize_t read_kcore_iter(struct kiocb *iocb, struct iov_iter *iter) { + struct file *file = iocb->ki_filp; + char *buf = file->private_data; loff_t *fpos = &iocb->ki_pos; size_t phdrs_offset, notes_offset, data_offset; size_t page_offline_frozen = 1; @@ -554,11 +556,22 @@ static ssize_t read_kcore_iter(struct kiocb *iocb, struct iov_iter *iter) fallthrough; case KCORE_VMEMMAP: case KCORE_TEXT: + /* + * Sadly we must use a bounce buffer here to be able to + * make use of copy_from_kernel_nofault(), as these + * memory regions might not always be mapped on all + * architectures. + */ + if (copy_from_kernel_nofault(buf, (void *)start, tsz)) { + if (iov_iter_zero(tsz, iter) != tsz) { + ret = -EFAULT; + goto out; + } /* * We use _copy_to_iter() to bypass usermode hardening * which would otherwise prevent this operation. */ - if (_copy_to_iter((char *)start, tsz, iter) != tsz) { + } else if (_copy_to_iter(buf, tsz, iter) != tsz) { ret = -EFAULT; goto out; } @@ -595,6 +608,10 @@ static int open_kcore(struct inode *inode, struct file *filp) if (ret) return ret; + filp->private_data = kmalloc(PAGE_SIZE, GFP_KERNEL); + if (!filp->private_data) + return -ENOMEM; + if (kcore_need_update) kcore_update_ram(); if (i_size_read(inode) != proc_root_kcore->size) { @@ -605,9 +622,16 @@ static int open_kcore(struct inode *inode, struct file *filp) return 0; } +static int release_kcore(struct inode *inode, struct file *file) +{ + kfree(file->private_data); + return 0; +} + static const struct proc_ops kcore_proc_ops = { .proc_read_iter = read_kcore_iter, .proc_open = open_kcore, + .proc_release = release_kcore, .proc_lseek = default_llseek, }; -- 2.41.0

1 year, 8 months

5
10
0 0

Kernel 6.1.y backports for "dma-buf: keep the signaling time of merged fences v3"

by Jindong Yue

Hi, Please help backport following two commits to 6.1.y f781f661e8c9 dma-buf: keep the signaling time of merged fences v3 00ae1491f970 dma-buf: fix an error pointer vs NULL bug The first one is to fix some Android CTS failures founded with android14-6.1 GKI kernel. run cts -m CtsDeqpTestCases -t dEQP-EGL.functional.get_frame_timestamps* The second patch is to fix the error introduced by the first one. Thanks!

1 year, 8 months

3
2
0 0

[PATCH] riscv: Handle zicsr/zifencei issue between gcc and binutils

by Mingzheng Xing

Binutils-2.38 and GCC-12.1.0 bumped[0][1] the default ISA spec to the newer 20191213 version which moves some instructions from the I extension to the Zicsr and Zifencei extensions. So if one of the binutils and GCC exceeds that version, we should explicitly specifying Zicsr and Zifencei via -march to cope with the new changes. but this only occurs when binutils >= 2.36 and GCC >= 11.1.0. It's a different story when binutils < 2.36. binutils-2.36 supports the Zifencei extension[2] and splits Zifencei and Zicsr from I[3]. GCC-11.1.0 is particular[4] because it add support Zicsr and Zifencei extension for -march. binutils-2.35 does not support the Zifencei extension, and does not need to specify Zicsr and Zifencei when working with GCC >= 12.1.0. To make our lives easier, let's relax the check to binutils >= 2.36 in CONFIG_TOOLCHAIN_NEEDS_EXPLICIT_ZICSR_ZIFENCEI. For the other two cases, where clang < 17 or GCC < 11.1.0, we will deal with them in CONFIG_TOOLCHAIN_NEEDS_OLD_ISA_SPEC. For more information, please refer to: commit 6df2a016c0c8 ("riscv: fix build with binutils 2.38") commit e89c2e815e76 ("riscv: Handle zicsr/zifencei issues between clang and binutils") Link: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=aed44286efa8ae871… [0] Link: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=98416dbb0a62579d4a7a4a76bab51… [1] Link: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=5a1b31e1e1cee6e9f… [2] Link: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=729a53530e86972d1… [3] Link: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b03be74bad08c382da47e048007a7… [4] Link: https://lore.kernel.org/all/20230308220842.1231003-1-conor@kernel.org Link: https://lore.kernel.org/all/20230223220546.52879-1-conor@kernel.org Cc: <stable(a)vger.kernel.org> Signed-off-by: Mingzheng Xing <xingmingzheng(a)iscas.ac.cn> --- arch/riscv/Kconfig | 32 +++++++++++++++----------- arch/riscv/kernel/compat_vdso/Makefile | 8 ++++++- 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 4c07b9189c86..10e7a7ad175a 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -570,24 +570,30 @@ config TOOLCHAIN_HAS_ZIHINTPAUSE config TOOLCHAIN_NEEDS_EXPLICIT_ZICSR_ZIFENCEI def_bool y # https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=aed44286efa8ae871… - depends on AS_IS_GNU && AS_VERSION >= 23800 - help - Newer binutils versions default to ISA spec version 20191213 which - moves some instructions from the I extension to the Zicsr and Zifencei - extensions. + # https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=98416dbb0a62579d4a7a4a76bab51… + depends on AS_IS_GNU && AS_VERSION >= 23600 + help + Binutils-2.38 and GCC-12.1.0 bumped the default ISA spec to the newer + 20191213 version, which moves some instructions from the I extension to + the Zicsr and Zifencei extensions. This requires explicitly specifying + Zicsr and Zifencei when binutils >= 2.38 or GCC >= 12.1.0. Zicsr + and Zifencei are supported in binutils from version 2.36 onwards. + To make life easier, and avoid forcing toolchains that default to a + newer ISA spec to version 2.2, relax the check to binutils >= 2.36. + For clang < 17 or GCC < 11.1.0, for which this is not possible, this is + dealt with in CONFIG_TOOLCHAIN_NEEDS_OLD_ISA_SPEC. config TOOLCHAIN_NEEDS_OLD_ISA_SPEC def_bool y depends on TOOLCHAIN_NEEDS_EXPLICIT_ZICSR_ZIFENCEI # https://github.com/llvm/llvm-project/commit/22e199e6afb1263c943c0c0d4498694… - depends on CC_IS_CLANG && CLANG_VERSION < 170000 - help - Certain versions of clang do not support zicsr and zifencei via -march - but newer versions of binutils require it for the reasons noted in the - help text of CONFIG_TOOLCHAIN_NEEDS_EXPLICIT_ZICSR_ZIFENCEI. This - option causes an older ISA spec compatible with these older versions - of clang to be passed to GAS, which has the same result as passing zicsr - and zifencei to -march. + # https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b03be74bad08c382da47e048007a7… + depends on (CC_IS_CLANG && CLANG_VERSION < 170000) || (CC_IS_GCC && GCC_VERSION < 110100) + help + Certain versions of clang and GCC do not support zicsr and zifencei via + -march. This option causes an older ISA spec compatible with these older + versions of clang and GCC to be passed to GAS, which has the same result + as passing zicsr and zifencei to -march. config FPU bool "FPU support" diff --git a/arch/riscv/kernel/compat_vdso/Makefile b/arch/riscv/kernel/compat_vdso/Makefile index 189345773e7e..b86e5e2c3aea 100644 --- a/arch/riscv/kernel/compat_vdso/Makefile +++ b/arch/riscv/kernel/compat_vdso/Makefile @@ -11,7 +11,13 @@ compat_vdso-syms += flush_icache COMPAT_CC := $(CC) COMPAT_LD := $(LD) -COMPAT_CC_FLAGS := -march=rv32g -mabi=ilp32 +# binutils 2.35 does not support the zifencei extension, but in the ISA +# spec 20191213, G stands for IMAFD_ZICSR_ZIFENCEI. +ifdef CONFIG_TOOLCHAIN_NEEDS_EXPLICIT_ZICSR_ZIFENCEI + COMPAT_CC_FLAGS := -march=rv32g -mabi=ilp32 +else + COMPAT_CC_FLAGS := -march=rv32imafd -mabi=ilp32 +endif COMPAT_LD_FLAGS := -melf32lriscv # Disable attributes, as they're useless and break the build. -- 2.34.1

1 year, 8 months

3
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2023