On Tue, Jun 28, 2022 at 10:29:04AM +0200, Alexander Gordeev wrote:
On Tue, Jun 28, 2022 at 09:09:05AM +0200, Greg Kroah-Hartman wrote:
This one breaks s390. You would also need to apply the following two commits:
cc02e6e21aa5 ("s390/crash: add missing iterator advance in copy_oldmem_page()") af2debd58bd7 ("s390/crash: make copy_oldmem_page() return number of bytes copied")
Both of them are also in the 5.18-rc queue here, right?
Yes, these are:
[PATCH 5.18 113/181] s390/crash: add missing iterator advance in copy_oldmem_page() Greg Kroah-Hartman
It's generally considered polite to cc the original author when you fix one of their patches. I wasn't aware of this patch.
While the code change looks right, the commit message is wrong; copy_oldmem_user() and copy_oldmem_kernel() need to GO AWAY. You need to be more like the other architectures and end up calling copy_to_iter(). I have no idea what this memcpy_hsa_kernel() and memcpy_hsa_user() are all about, but I was hoping that somebody from the s390 team would react to:
s390 needs more work to pass the iov_iter down further, or refactor, but I'd be more comfortable if someone who can test on s390 did that work.
Maybe you'll do it.