Total jobs: 232
Total errors: 79 (34.05%)
LAVA errors: 0 (0.00%)
Test errors: 67 (28.88%)
Job errors: 1 (0.43%)
Infra errors: 11 (4.74%)
Canceled jobs: 0 (0.00%)
Device type: qrb5165-rb5
Total jobs: 99
Total errors: 41 (41.41%)
Error type: Test
Error count: 31 (31.31%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 4 (4.04%)
IDs:
rb5-03:
8495314 8495438 8495468 8498586
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 10 (10.10%)
IDs:
rb5-01:
8495231 8495392 8495400 8495458 8498583
rb5-07:
8495346 8495415 8495567 8495617 8498585
Error: Device NOT found!
Count: 8 (8.08%)
IDs:
rb5-01:
8495229 8495341 8495349 8495461 8495488
8498532
rb5-07:
8495276 8495566
Error: No match for error type 'Test', message 'tradefed - adb device lost[d8a1879f]'
Count: 1 (1.01%)
IDs:
rb5-07:
8498531
Error: No match for error type 'Test', message 'tradefed - adb device lost[93dcfd96]'
Count: 2 (2.02%)
IDs:
rb5-01:
8495721 8497465
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 283 seconds'
Count: 1 (1.01%)
IDs:
rb5-07:
8495454
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 2 (2.02%)
IDs:
rb5-07:
8495332 8495397
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 296 seconds'
Count: 1 (1.01%)
IDs:
rb5-07:
8495393
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 1 (1.01%)
IDs:
rb5-06:
8495389
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 589 seconds'
Count: 1 (1.01%)
IDs:
rb5-07:
8495328
Error type: Infrastructure
Error count: 10 (10.10%)
Error: Connection closed
Count: 9 (9.09%)
IDs:
rb5-01:
8495345 8495390 8495395 8495398 8495439
8495542 8495678 8497108 8498483
Error: fastboot-flash-action timed out
Count: 1 (1.01%)
IDs:
rb5-07:
8495334
Device type: dragonboard-845c
Total jobs: 92
Total errors: 20 (21.74%)
Error type: Test
Error count: 18 (19.57%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[a6622a22]'
Count: 3 (3.26%)
IDs:
db845c-09:
8495371 8495428 8498581
Error: No match for error type 'Test', message 'tradefed - adb device lost[d966d3f5]'
Count: 4 (4.35%)
IDs:
db845c-03:
8495373 8495469 8495496 8498526
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 6 (6.52%)
IDs:
db845c-04:
8495376 8495453 8498474
db845c-06:
8495281
db845c-09:
8495339 8495481
Error: No match for error type 'Test', message 'tradefed - adb device lost[f3a58ae3]'
Count: 2 (2.17%)
IDs:
db845c-04:
8495421 8495430
Error: No match for error type 'Test', message 'tradefed - adb device lost[30e1e2ee]'
Count: 1 (1.09%)
IDs:
db845c-08:
8495353
Error: Device NOT found!
Count: 1 (1.09%)
IDs:
db845c-06:
8495257
Error: No match for error type 'Test', message 'tradefed - adb device lost[e875976d]'
Count: 1 (1.09%)
IDs:
db845c-06:
8495225
Error type: Job
Error count: 1 (1.09%)
Error: No match for error type 'Job', message 'login-action timed out after 687 seconds'
Count: 1 (1.09%)
IDs:
db845c-03:
8495372
Error type: Infrastructure
Error count: 1 (1.09%)
Error: Connection closed
Count: 1 (1.09%)
IDs:
db845c-04:
8495323
Device type: sm8550-hdk
Total jobs: 24
Total errors: 11 (45.83%)
Error type: Test
Error count: 11 (45.83%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[124d1c34]'
Count: 4 (16.67%)
IDs:
sm8550-hdk-01:
8495361 8495472 8495711 8498060
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 5 (20.83%)
IDs:
sm8550-hdk-01:
8495364 8495609 8495611 8495670 8495671
Error: Device NOT found!
Count: 2 (8.33%)
IDs:
sm8550-hdk-01:
8495413 8495667
Device type: rk3399-rock-pi-4b
Total jobs: 1
Total errors: 0 (0.00%)
Device type: juno-r2
Total jobs: 1
Total errors: 0 (0.00%)
Device type: x86
Total jobs: 3
Total errors: 0 (0.00%)
Device type: hi960-hikey
Total jobs: 12
Total errors: 7 (58.33%)
Error type: Test
Error count: 7 (58.33%)
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 5 (41.67%)
IDs:
hi960-hikey-01:
8495500
hi960-hikey-02:
8495683 8495712
hi960-hikey-04:
8495529 8495532
Error: Device NOT found!
Count: 1 (8.33%)
IDs:
hi960-hikey-01:
8495498
Error: No match for error type 'Test', message 'tradefed - adb device lost[7A25756801BA7C0B]'
Count: 1 (8.33%)
IDs:
hi960-hikey-02:
8495493
The overcommit test uses sum_total, the sum (memory and swap) to test
the overcommit settings.
This fixes two problems on 32-bit systems. The first is seen with a
integer overflow can occur when calculating sum_total * 2, if the
sum_total is larger than 2GB. The second is limited virtual address
space (2-3GB) means the test can fail from address space exhaustion
before overcommit has been tested.
Now the test runs correctly on low-memory 32-bit systems while avoiding
both the overflow bug and virtual address space issues.
Acked-by: Arnd Bergmann <arnd(a)arndb.de>
Reviewed-by: Petr Vorel <pvorel(a)suse.cz>
Signed-off-by: Ben Copeland <ben.copeland(a)linaro.org>
---
.../kernel/mem/tunable/overcommit_memory.c | 31 ++++++++++++++-----
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/testcases/kernel/mem/tunable/overcommit_memory.c b/testcases/kernel/mem/tunable/overcommit_memory.c
index 9b2cb479d..d4faaeee0 100644
--- a/testcases/kernel/mem/tunable/overcommit_memory.c
+++ b/testcases/kernel/mem/tunable/overcommit_memory.c
@@ -131,24 +131,41 @@ static void overcommit_memory_test(void)
TST_SYS_CONF_LONG_SET(OVERCOMMIT_MEMORY, 2, 1);
update_mem_commit();
- alloc_and_check(commit_left * 2, EXPECT_FAIL);
- alloc_and_check(commit_limit + total_batch_size, EXPECT_FAIL);
- update_mem_commit();
- alloc_and_check(commit_left / 2, EXPECT_PASS);
+ /* Skip tests that would overflow or exceed 32-bit address space */
+ if (tst_kernel_bits() == 64 || (unsigned long)commit_left <= TST_GB / TST_KB) {
+ alloc_and_check(commit_left * 2, EXPECT_FAIL);
+ alloc_and_check(commit_limit + total_batch_size, EXPECT_FAIL);
+ update_mem_commit();
+ alloc_and_check(commit_left / 2, EXPECT_PASS);
+ } else {
+ tst_res(TCONF, "Skipping large allocation tests due to address space limits");
+ }
/* start to test overcommit_memory=0 */
TST_SYS_CONF_LONG_SET(OVERCOMMIT_MEMORY, 0, 1);
update_mem();
alloc_and_check(free_total / 2, EXPECT_PASS);
- alloc_and_check(sum_total * 2, EXPECT_FAIL);
+ /* Skip if sum_total * 2 would exceed address space.
+ * On 32-bit, skip when sum_total > ULONG_MAX/4 (~1GB).
+ * Most 32-bit systems with <=1GB RAM can map 2x that in 3GB vaddr space.
+ * Systems with 2GB+ RAM likely cannot fit allocations in vaddr space. */
+ if (tst_kernel_bits() == 64 || (unsigned long)sum_total <= TST_GB / TST_KB) {
+ alloc_and_check(sum_total * 2, EXPECT_FAIL);
+ } else {
+ tst_res(TCONF, "Skipping large allocation test due to address space limits");
+ }
/* start to test overcommit_memory=1 */
TST_SYS_CONF_LONG_SET(OVERCOMMIT_MEMORY, 1, 1);
alloc_and_check(sum_total / 2, EXPECT_PASS);
- alloc_and_check(sum_total, EXPECT_PASS);
- alloc_and_check(sum_total * 2, EXPECT_PASS);
+ if (tst_kernel_bits() == 64 || (unsigned long)sum_total <= TST_GB / TST_KB) {
+ alloc_and_check(sum_total, EXPECT_PASS);
+ alloc_and_check(sum_total * 2, EXPECT_PASS);
+ } else {
+ tst_res(TCONF, "Skipping large allocation tests due to address space limits");
+ }
}
--
2.51.0
The alloc_mem() function is supposed to test out of memory conditions.
How it works is it calls mmap() on a giant chunk of memory.
It's either LENGTH (2GB) or "TESTMEM * 2 + TST_MB" (3GB) bytes.
This mmap() is generally supposed to succeed. Then at the bottom of
the alloc_mem() function when we actually try to use all the memory,
the thread is supposed to die with a SIGKILL.
The problem is that length is signed so on a 32-bit system it will be
negative. That means that at the bottom of the function when we loop
through the memory, the for loop is a no-op and there is no SIGKILL.
Fix this by changing the type to size_t which is unsigned.
Signed-off-by: Ben Copeland <ben.copeland(a)linaro.org>
---
testcases/kernel/mem/oom/oom.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/mem/oom/oom.h b/testcases/kernel/mem/oom/oom.h
index 41cc681f9..42ed181b0 100644
--- a/testcases/kernel/mem/oom/oom.h
+++ b/testcases/kernel/mem/oom/oom.h
@@ -62,13 +62,14 @@ static inline void set_global_mempolicy(int mempolicy)
static void set_global_mempolicy(int mempolicy LTP_ATTRIBUTE_UNUSED) { }
#endif
-static int alloc_mem(long int length, int testcase)
+static int alloc_mem(size_t length, int testcase)
{
char *s;
- long i, pagesz = getpagesize();
+ size_t i;
+ long pagesz = getpagesize();
int loop = 10;
- tst_res(TINFO, "thread (%lx), allocating %ld bytes.",
+ tst_res(TINFO, "thread (%lx), allocating %zu bytes.",
(unsigned long) pthread_self(), length);
s = mmap(NULL, length, PROT_READ | PROT_WRITE,
@@ -111,7 +112,7 @@ static void child_alloc(int testcase, int lite, int threads)
pthread_t *th;
if (lite) {
- int ret = alloc_mem(TESTMEM * 2 + TST_MB, testcase);
+ int ret = alloc_mem((size_t)TESTMEM * 2 + TST_MB, testcase);
exit(ret);
}
--
2.51.0