Following warnings and errors have been noticed while building i386 build
on stable-rc linux.4.19.y and linux.4.14.y.
Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
Build log:
==========
kernel/profile.c: In function 'profile_dead_cpu':
kernel/profile.c:346:27: warning: the comparison will always evaluate
as 'true' for the address of 'prof_cpu_mask' will never be NULL
[-Waddress]
346 | if (prof_cpu_mask != NULL)
| ^~
kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here
49 | static cpumask_var_t prof_cpu_mask;
| ^~~~~~~~~~~~~
kernel/profile.c: In function 'profile_online_cpu':
kernel/profile.c:383:27: warning: the comparison will always evaluate
as 'true' for the address of 'prof_cpu_mask' will never be NULL
[-Waddress]
383 | if (prof_cpu_mask != NULL)
| ^~
kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here
49 | static cpumask_var_t prof_cpu_mask;
| ^~~~~~~~~~~~~
kernel/profile.c: In function 'profile_tick':
kernel/profile.c:413:47: warning: the comparison will always evaluate
as 'true' for the address of 'prof_cpu_mask' will never be NULL
[-Waddress]
413 | if (!user_mode(regs) && prof_cpu_mask != NULL &&
| ^~
kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here
49 | static cpumask_var_t prof_cpu_mask;
| ^~~~~~~~~~~~~
arch/x86/kernel/head_32.S: Assembler messages:
arch/x86/kernel/head_32.S:126: Error: invalid character '(' in mnemonic
arch/x86/kernel/head_32.S:57: Info: macro invoked from here
arch/x86/kernel/head_32.S:128: Error: invalid character '(' in mnemonic
arch/x86/kernel/head_32.S:57: Info: macro invoked from here
make[3]: *** [scripts/Makefile.build:403: arch/x86/kernel/head_32.o] Error 1
make[3]: Target '__build' not remade because of errors.
make[2]: *** [scripts/Makefile.build:544: arch/x86/kernel] Error 2
Links:
- https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19…
--
Linaro LKFT
https://lkft.linaro.org
Total jobs: 96
Total errors: 16 (16.67%)
LAVA errors: 0 (0.00%)
Test errors: 16 (16.67%)
Job errors: 0 (0.00%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: qrb5165-rb5
Total jobs: 46
Total errors: 14 (30.43%)
Error type: Test
Error count: 14 (30.43%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 3 (6.52%)
IDs:
rb5-05:
6988927 6988936 6988981
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 596 seconds'
Count: 1 (2.17%)
IDs:
rb5-07:
6988968
Error: No match for error type 'Test', message 'tradefed - adb device lost[d8a1879f]'
Count: 3 (6.52%)
IDs:
rb5-07:
6988906 6988917 6988967
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 4 (8.70%)
IDs:
rb5-03:
6988405 6988905 6988915 6988956
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 2 (4.35%)
IDs:
rb5-03:
6988524
rb5-07:
6988946
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 1 (2.17%)
IDs:
rb5-06:
6988535
Device type: x86
Total jobs: 1
Total errors: 0 (0.00%)
Device type: dragonboard-845c
Total jobs: 48
Total errors: 2 (4.17%)
Error type: Test
Error count: 2 (4.17%)
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 597 seconds'
Count: 2 (4.17%)
IDs:
db845c-01:
6988929
db845c-07:
6988975
Device type: e850-96
Total jobs: 1
Total errors: 0 (0.00%)
Hi Greg,
I see the following build warning / errors everywhere on stable-rc 5.15 branch.
ld.lld: error: undefined symbol: kallsyms_on_each_symbol
>>> referenced by trace_kprobe.c
>>> trace/trace_kprobe.o:(create_local_trace_kprobe) in archive kernel/built-in.a
>>> referenced by trace_kprobe.c
>>> trace/trace_kprobe.o:(__trace_kprobe_create) in archive kernel/built-in.a
make[1]: *** [Makefile:1227: vmlinux] Error 1
Links,
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2XXALLRIZaXJVcqhff4Z…
- Naresh
Total jobs: 127
Total errors: 23 (18.11%)
LAVA errors: 0 (0.00%)
Test errors: 23 (18.11%)
Job errors: 0 (0.00%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: x15
Total jobs: 1
Total errors: 0 (0.00%)
Device type: dragonboard-845c
Total jobs: 64
Total errors: 4 (6.25%)
Error type: Test
Error count: 4 (6.25%)
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 3 (4.69%)
IDs:
db845c-02:
6988184
db845c-04:
6988245
db845c-08:
6988199
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 585 seconds'
Count: 1 (1.56%)
IDs:
db845c-09:
6987194
Device type: hi960-hikey
Total jobs: 11
Total errors: 2 (18.18%)
Error type: Test
Error count: 2 (18.18%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[279ABF68159019FF]'
Count: 1 (9.09%)
IDs:
hi960-hikey-03:
6988564
Error: No match for error type 'Test', message 'tradefed - adb device lost[57DD383701799F9A]'
Count: 1 (9.09%)
IDs:
hi960-hikey-05:
6988560
Device type: qrb5165-rb5
Total jobs: 51
Total errors: 17 (33.33%)
Error type: Test
Error count: 17 (33.33%)
Error: Device NOT found!
Count: 1 (1.96%)
IDs:
rb5-03:
6988394
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 593 seconds'
Count: 1 (1.96%)
IDs:
rb5-03:
6988392
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 5 (9.80%)
IDs:
rb5-03:
6987149 6987154 6987161 6988202 6988385
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 594 seconds'
Count: 1 (1.96%)
IDs:
rb5-06:
6988272
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 2 (3.92%)
IDs:
rb5-06:
6987150 6988264
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 3 (5.88%)
IDs:
rb5-05:
6987197 6987198 6988262
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 4 (7.84%)
IDs:
rb5-03:
6987148 6988211
rb5-05:
6988212
rb5-07:
6988256
This is the start of the stable review cycle for the 6.1.61 release.
There are 86 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu, 02 Nov 2023 16:59:03 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.61-rc1…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 6.1.61-rc1
John Sperbeck <jsperbeck(a)google.com>
objtool/x86: add missing embedded_insn check
Baokun Li <libaokun1(a)huawei.com>
ext4: avoid overlapping preallocations due to overflow
Baokun Li <libaokun1(a)huawei.com>
ext4: fix BUG in ext4_mb_new_inode_pa() due to overflow
Baokun Li <libaokun1(a)huawei.com>
ext4: add two helper functions extent_logical_end() and pa_logical_end()
David Lazar <dlazar(a)gmail.com>
platform/x86: Add s2idle quirk for more Lenovo laptops
Alessandro Carminati <alessandro.carminati(a)gmail.com>
clk: Sanitize possible_parent_show to Handle Return Value of of_clk_get_parent_name
Al Viro <viro(a)zeniv.linux.org.uk>
sparc32: fix a braino in fault handling in csum_and_copy_..._user()
Peter Zijlstra <peterz(a)infradead.org>
perf/core: Fix potential NULL deref
Tony Luck <tony.luck(a)intel.com>
x86/cpu: Add model number for Intel Arrow Lake mobile processor
Thomas Gleixner <tglx(a)linutronix.de>
x86/i8259: Skip probing when ACPI/MADT advertises PCAT compatibility
Peng Fan <peng.fan(a)nxp.com>
nvmem: imx: correct nregs for i.MX6UL
Peng Fan <peng.fan(a)nxp.com>
nvmem: imx: correct nregs for i.MX6SLL
Peng Fan <peng.fan(a)nxp.com>
nvmem: imx: correct nregs for i.MX6ULL
Ekansh Gupta <quic_ekangupt(a)quicinc.com>
misc: fastrpc: Unmap only if buffer is unmapped from DSP
Ekansh Gupta <quic_ekangupt(a)quicinc.com>
misc: fastrpc: Clean buffers on remote invocation failures
Ekansh Gupta <quic_ekangupt(a)quicinc.com>
misc: fastrpc: Free DMA handles for RPC calls with no arguments
Ekansh Gupta <quic_ekangupt(a)quicinc.com>
misc: fastrpc: Reset metadata buffer to avoid incorrect free
Yujie Liu <yujie.liu(a)intel.com>
tracing/kprobes: Fix the description of variable length arguments
Jian Zhang <zhangjian.3032(a)bytedance.com>
i2c: aspeed: Fix i2c bus hang in slave read
Alain Volmat <alain.volmat(a)foss.st.com>
i2c: stm32f7: Fix PEC handling in case of SMBUS transfers
Herve Codina <herve.codina(a)bootlin.com>
i2c: muxes: i2c-demux-pinctrl: Use of_get_i2c_adapter_by_node()
Herve Codina <herve.codina(a)bootlin.com>
i2c: muxes: i2c-mux-gpmux: Use of_get_i2c_adapter_by_node()
Herve Codina <herve.codina(a)bootlin.com>
i2c: muxes: i2c-mux-pinctrl: Use of_get_i2c_adapter_by_node()
Robert Hancock <robert.hancock(a)calian.com>
iio: adc: xilinx-xadc: Correct temperature offset/scale for UltraScale
Robert Hancock <robert.hancock(a)calian.com>
iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature thresholds
Marek Szyprowski <m.szyprowski(a)samsung.com>
iio: exynos-adc: request second interupt only when touchscreen mode is used
Linus Walleij <linus.walleij(a)linaro.org>
iio: afe: rescale: Accept only offset channels
Jens Axboe <axboe(a)kernel.dk>
io_uring/fdinfo: lock SQ thread while retrieving thread cpu/pid
Haibo Li <haibo.li(a)mediatek.com>
kasan: print the original fault addr when access invalid shadow
Khazhismel Kumykov <khazhy(a)chromium.org>
blk-throttle: check for overflow in calculate_bytes_allowed
Damien Le Moal <dlemoal(a)kernel.org>
scsi: sd: Introduce manage_shutdown device flag
Michal Schmidt <mschmidt(a)redhat.com>
iavf: in iavf_down, disable queues when removing the driver
Sui Jingfeng <suijingfeng(a)loongson.cn>
drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO
Ivan Vecera <ivecera(a)redhat.com>
i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR
Pablo Neira Ayuso <pablo(a)netfilter.org>
gtp: fix fragmentation needed check with gso
Pablo Neira Ayuso <pablo(a)netfilter.org>
gtp: uapi: fix GTPA_MAX
Fred Chen <fred.chenchen03(a)gmail.com>
tcp: fix wrong RTO timeout when received SACK reneging
Douglas Anderson <dianders(a)chromium.org>
r8152: Release firmware if we have an error in probe
Douglas Anderson <dianders(a)chromium.org>
r8152: Cancel hw_phy_work if we have an error in probe
Douglas Anderson <dianders(a)chromium.org>
r8152: Run the unload routine if we have errors during probe
Douglas Anderson <dianders(a)chromium.org>
r8152: Increase USB control msg timeout to 5000ms as per spec
Shigeru Yoshida <syoshida(a)redhat.com>
net: usb: smsc95xx: Fix uninit-value access in smsc95xx_read_reg
Christophe JAILLET <christophe.jaillet(a)wanadoo.fr>
net: ieee802154: adf7242: Fix some potential buffer overflow in adf7242_stats_show()
Dell Jin <dell.jin.code(a)outlook.com>
net: ethernet: adi: adin1110: Fix uninitialized variable
Sasha Neftin <sasha.neftin(a)intel.com>
igc: Fix ambiguity in the ethtool advertising
Eric Dumazet <edumazet(a)google.com>
neighbour: fix various data-races
Mateusz Palczewski <mateusz.palczewski(a)intel.com>
igb: Fix potential memory leak in igb_add_ethtool_nfc_entry
Kunwu Chan <chentao(a)kylinos.cn>
treewide: Spelling fix in comment
Ivan Vecera <ivecera(a)redhat.com>
i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value
Michal Schmidt <mschmidt(a)redhat.com>
iavf: initialize waitqueues before starting watchdog_task
Mirsad Goran Todorovac <mirsad.todorovac(a)alu.unizg.hr>
r8169: fix the KCSAN reported data race in rtl_rx while reading desc->opts1
Mirsad Goran Todorovac <mirsad.todorovac(a)alu.unizg.hr>
r8169: fix the KCSAN reported data-race in rtl_tx while reading TxDescArray[entry].opts1
Mirsad Goran Todorovac <mirsad.todorovac(a)alu.unizg.hr>
r8169: fix the KCSAN reported data-race in rtl_tx() while reading tp->cur_tx
Tony Lindgren <tony(a)atomide.com>
clk: ti: Fix missing omap5 mcbsp functional clock and aliases
Tony Lindgren <tony(a)atomide.com>
clk: ti: Fix missing omap4 mcbsp functional clock and aliases
Hao Ge <gehao(a)kylinos.cn>
firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels()
Randy Dunlap <rdunlap(a)infradead.org>
ARM: OMAP: timer32K: fix all kernel-doc warnings
Lukasz Majczak <lma(a)semihalf.com>
drm/dp_mst: Fix NULL deref in get_mst_branch_device_by_guid_helper()
Mario Limonciello <mario.limonciello(a)amd.com>
drm/amd: Disable ASPM for VI w/ all Intel systems
Umesh Nerlige Ramappa <umesh.nerlige.ramappa(a)intel.com>
drm/i915/pmu: Check if pmu is closed before stopping event
Al Viro <viro(a)zeniv.linux.org.uk>
nfsd: lock_rename() needs both directories to live on the same fs
Liam R. Howlett <Liam.Howlett(a)oracle.com>
maple_tree: add GFP_KERNEL to allocations in mas_expected_entries()
Rik van Riel <riel(a)surriel.com>
hugetlbfs: extend hugetlb_vma_lock to private VMAs
Gregory Price <gourry.memverge(a)gmail.com>
mm/migrate: fix do_pages_move for compat pointers
Kemeng Shi <shikemeng(a)huaweicloud.com>
mm/page_alloc: correct start page when guard page debug is enabled
Rik van Riel <riel(a)surriel.com>
hugetlbfs: clear resv_map pointer if mmap fails
Sebastian Ott <sebott(a)redhat.com>
mm: fix vm_brk_flags() to not bail out while holding lock
Christopher Obbard <chris.obbard(a)collabora.com>
arm64: dts: rockchip: Fix i2s0 pin conflict on ROCK Pi 4 boards
Christopher Obbard <chris.obbard(a)collabora.com>
arm64: dts: rockchip: Add i2s0-2ch-bus-bclk-off pins to RK3399
Eric Auger <eric.auger(a)redhat.com>
vhost: Allow null msg.size on VHOST_IOTLB_INVALIDATE
Alexandru Matei <alexandru.matei(a)uipath.com>
vsock/virtio: initialize the_virtio_vsock before using VQs
Xuan Zhuo <xuanzhuo(a)linux.alibaba.com>
virtio_pci: fix the common cfg map size
zhenwei pi <pizhenwei(a)bytedance.com>
virtio-crypto: handle config changed by work queue
Maximilian Heyne <mheyne(a)amazon.de>
virtio-mmio: fix memory leak of vm_dev
Gavin Shan <gshan(a)redhat.com>
virtio_balloon: Fix endless deflation and inflation on arm64
Rodríguez Barbarin, José Javier <JoseJavier.Rodriguez(a)duagon.com>
mcb-lpc: Reallocate memory region to avoid memory overlapping
Rodríguez Barbarin, José Javier <JoseJavier.Rodriguez(a)duagon.com>
mcb: Return actual parsed size when reading chameleon table
Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org>
pinctrl: qcom: lpass-lpi: fix concurrent register updates
Johan Hovold <johan+linaro(a)kernel.org>
ASoC: codecs: wcd938x: fix runtime PM imbalance on remove
Johan Hovold <johan+linaro(a)kernel.org>
ASoC: codecs: wcd938x: fix regulator leaks on probe errors
Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org>
ASoC: codecs: wcd938x: Simplify with dev_err_probe
Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
ASoC: codecs: wcd938x: Convert to platform remove callback returning void
Ulf Hansson <ulf.hansson(a)linaro.org>
mmc: core: Fix error propagation for some ioctl commands
Christian Loehle <CLoehle(a)hyperstone.com>
mmc: block: ioctl: do write error check for spi
Ulf Hansson <ulf.hansson(a)linaro.org>
mmc: core: Align to common busy polling behaviour for mmc ioctls
Roman Kagan <rkagan(a)amazon.de>
KVM: x86/pmu: Truncate counter value to allowed width on write
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/omap4-l4-abe.dtsi | 6 ++
arch/arm/boot/dts/omap4-l4.dtsi | 2 +
arch/arm/boot/dts/omap5-l4-abe.dtsi | 6 ++
arch/arm/mach-omap1/timer32k.c | 14 ++---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 +
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 +++
arch/sparc/lib/checksum_32.S | 2 +-
arch/x86/include/asm/i8259.h | 2 +
arch/x86/include/asm/intel-family.h | 2 +
arch/x86/kernel/acpi/boot.c | 3 +
arch/x86/kernel/i8259.c | 38 ++++++++---
arch/x86/kvm/pmu.h | 6 ++
arch/x86/kvm/svm/pmu.c | 2 +-
arch/x86/kvm/vmx/pmu_intel.c | 4 +-
block/blk-throttle.c | 6 ++
drivers/ata/libata-scsi.c | 5 +-
drivers/clk/clk.c | 21 ++++---
drivers/clk/ti/clk-44xx.c | 5 ++
drivers/clk/ti/clk-54xx.c | 4 ++
drivers/crypto/virtio/virtio_crypto_common.h | 3 +
drivers/crypto/virtio/virtio_crypto_core.c | 14 ++++-
drivers/firewire/sbp2.c | 1 +
drivers/firmware/imx/imx-dsp.c | 2 +-
drivers/gpu/drm/amd/amdgpu/vi.c | 2 +-
drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +-
drivers/gpu/drm/i915/i915_pmu.c | 9 +++
drivers/gpu/drm/logicvc/Kconfig | 2 +
drivers/i2c/busses/i2c-aspeed.c | 3 +-
drivers/i2c/busses/i2c-stm32f7.c | 9 ++-
drivers/i2c/muxes/i2c-demux-pinctrl.c | 2 +-
drivers/i2c/muxes/i2c-mux-gpmux.c | 2 +-
drivers/i2c/muxes/i2c-mux-pinctrl.c | 2 +-
drivers/iio/adc/exynos_adc.c | 24 ++++---
drivers/iio/adc/xilinx-xadc-core.c | 39 +++++-------
drivers/iio/adc/xilinx-xadc.h | 2 +
drivers/iio/afe/iio-rescale.c | 19 ++++--
drivers/mcb/mcb-lpc.c | 35 +++++++++--
drivers/mcb/mcb-parse.c | 15 +++--
drivers/misc/fastrpc.c | 34 +++++-----
drivers/mmc/core/block.c | 38 ++++++++---
drivers/mmc/core/mmc_ops.c | 1 +
drivers/net/ethernet/adi/adin1110.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
drivers/net/ethernet/intel/iavf/iavf_main.c | 7 ++-
drivers/net/ethernet/intel/igb/igb_ethtool.c | 6 +-
drivers/net/ethernet/intel/igc/igc_ethtool.c | 35 ++++++++---
drivers/net/ethernet/realtek/r8169_main.c | 6 +-
drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +-
drivers/net/gtp.c | 5 +-
drivers/net/ieee802154/adf7242.c | 5 +-
drivers/net/usb/r8152.c | 11 +++-
drivers/net/usb/smsc95xx.c | 4 +-
drivers/nvmem/imx-ocotp.c | 6 +-
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 17 +++--
drivers/platform/x86/thinkpad_acpi.c | 73 ++++++++++++++++++++++
drivers/scsi/sd.c | 39 +++++++++++-
drivers/vhost/vhost.c | 4 +-
drivers/virtio/virtio_balloon.c | 6 +-
drivers/virtio/virtio_mmio.c | 19 ++++--
drivers/virtio/virtio_pci_modern_dev.c | 2 +-
fs/ext4/mballoc.c | 51 +++++++--------
fs/ext4/mballoc.h | 14 +++++
fs/nfsd/vfs.c | 12 ++--
include/linux/hugetlb.h | 6 ++
include/linux/kasan.h | 6 +-
include/scsi/scsi_device.h | 20 +++++-
include/uapi/linux/gtp.h | 2 +-
io_uring/fdinfo.c | 18 ++++--
kernel/events/core.c | 3 +-
kernel/trace/trace_kprobe.c | 4 +-
lib/maple_tree.c | 2 +-
lib/test_maple_tree.c | 35 +++++++----
mm/hugetlb.c | 48 +++++++++++---
mm/kasan/report.c | 4 +-
mm/migrate.c | 14 ++++-
mm/mmap.c | 6 +-
mm/page_alloc.c | 2 +-
net/core/neighbour.c | 67 ++++++++++----------
net/ipv4/tcp_input.c | 9 +--
net/vmw_vsock/virtio_transport.c | 18 +++++-
sound/soc/codecs/wcd938x.c | 51 ++++++++-------
tools/include/linux/rwsem.h | 40 ++++++++++++
tools/objtool/check.c | 2 +-
85 files changed, 789 insertions(+), 305 deletions(-)
Hi Greg,
I see following build warnings / errors on stable-rc 5.4 branch.
arch/arm/mach-omap2/timer.c:51:10: fatal error: plat/counter-32k.h: No
such file or directory
51 | #include <plat/counter-32k.h>
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
Link:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2XXAJIrAB4GOy6jEODeH…
- Naresh
On Sun, 29 Oct 2023 at 02:16, Steven Rostedt <rostedt(a)goodmis.org> wrote:
>
> From: "Steven Rostedt (Google)" <rostedt(a)goodmis.org>
>
> The eventfs_inode (ei) is protected by SRCU, but the ei->dentry is not. It
> is protected by the eventfs_mutex. Anytime the eventfs_mutex is released,
> and access to the ei->dentry needs to be done, it should first check if
> ei->is_freed is set under the eventfs_mutex. If it is, then the ei->dentry
> is invalid and must not be used. The ei->dentry must only be accessed
> under the eventfs_mutex and after checking if ei->is_freed is set.
>
> When the ei is being freed, it will (under the eventfs_mutex) set is_freed
> and at the same time move the dentry to a free list to be cleared after
> the eventfs_mutex is released. This means that any access to the
> ei->dentry must check first if ei->is_freed is set, because if it is, then
> the dentry is on its way to be freed.
>
> Also add comments to describe this better.
>
> Link: https://lore.kernel.org/all/CA+G9fYt6pY+tMZEOg=SoEywQOe19fGP3uR15SGowkdK+_X…
> Link: https://lore.kernel.org/all/CA+G9fYuDP3hVQ3t7FfrBAjd_WFVSurMgCepTxunSJf=MTe…
>
> Fixes: 5790b1fb3d672 ("eventfs: Remove eventfs_file and just use eventfs_inode")
> Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
> Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org>
> Reported-by: Beau Belgrave <beaub(a)linux.microsoft.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt(a)goodmis.org>
Following build errors have been noticed.
fs/tracefs/event_inode.c:348:1: error: return type defaults to 'int'
[-Werror=implicit-int]
348 | create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei,
| ^~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/kasan-checks.h:5,
from include/asm-generic/rwonce.h:26,
from ./arch/x86/include/generated/asm/rwonce.h:1,
from include/linux/compiler.h:251,
from include/linux/build_bug.h:5,
from include/linux/bits.h:21,
from include/linux/bitops.h:6,
from include/linux/radix-tree.h:11,
from include/linux/idr.h:15,
from include/linux/fsnotify_backend.h:13,
from include/linux/fsnotify.h:15,
from fs/tracefs/event_inode.c:17:
fs/tracefs/event_inode.c: In function 'create_dir_dentry':
include/linux/stddef.h:8:14: error: returning 'void *' from a function
with return type 'int' makes integer from pointer without a cast
[-Werror=int-conversion]
8 | #define NULL ((void *)0)
| ^
fs/tracefs/event_inode.c:357:24: note: in expansion of macro 'NULL'
357 | return NULL;
| ^~~~
fs/tracefs/event_inode.c:366:24: error: returning 'struct dentry *'
from a function with return type 'int' makes integer from pointer
without a cast [-Werror=int-conversion]
366 | return dentry;
| ^~~~~~
fs/tracefs/event_inode.c:394:24: error: returning 'struct dentry *'
from a function with return type 'int' makes integer from pointer
without a cast [-Werror=int-conversion]
394 | return dentry;
| ^~~~~~
fs/tracefs/event_inode.c:416:34: error: returning 'struct dentry *'
from a function with return type 'int' makes integer from pointer
without a cast [-Werror=int-conversion]
416 | return invalidate ? NULL : dentry;
| ~~~~~~~~~~~~~~~~~~^~~~~~~~
fs/tracefs/event_inode.c: In function 'dcache_dir_open_wrapper':
fs/tracefs/event_inode.c:609:49: error: passing argument 2 of
'create_dir_dentry' from incompatible pointer type
[-Werror=incompatible-pointer-types]
609 | d = create_dir_dentry(ei_child, parent, false);
| ^~~~~~
| |
| struct dentry *
fs/tracefs/event_inode.c:348:68: note: expected 'struct eventfs_inode
*' but argument is of type 'struct dentry *'
348 | create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei,
| ~~~~~~~~~~~~~~~~~~~~~~^~
fs/tracefs/event_inode.c:609:21: error: too few arguments to function
'create_dir_dentry'
609 | d = create_dir_dentry(ei_child, parent, false);
| ^~~~~~~~~~~~~~~~~
fs/tracefs/event_inode.c:348:1: note: declared here
348 | create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei,
| ^~~~~~~~~~~~~~~~~
fs/tracefs/event_inode.c:625:19: error: assignment to 'struct dentry
*' from 'int' makes pointer from integer without a cast
[-Werror=int-conversion]
625 | d = create_dir_dentry(ei, ei_child, parent, false);
| ^
fs/tracefs/event_inode.c:626:46: error: left-hand operand of comma
expression has no effect [-Werror=unused-value]
626 | parent, name, mode,
cdata, fops, false);
| ^
fs/tracefs/event_inode.c:626:52: error: left-hand operand of comma
expression has no effect [-Werror=unused-value]
626 | parent, name, mode,
cdata, fops, false);
| ^
fs/tracefs/event_inode.c:626:58: error: left-hand operand of comma
expression has no effect [-Werror=unused-value]
626 | parent, name, mode,
cdata, fops, false);
| ^
fs/tracefs/event_inode.c:626:65: error: left-hand operand of comma
expression has no effect [-Werror=unused-value]
626 | parent, name, mode,
cdata, fops, false);
| ^
fs/tracefs/event_inode.c:626:71: error: left-hand operand of comma
expression has no effect [-Werror=unused-value]
626 | parent, name, mode,
cdata, fops, false);
| ^
fs/tracefs/event_inode.c:626:71: error: statement with no effect
[-Werror=unused-value]
fs/tracefs/event_inode.c:626:78: error: expected ';' before ')' token
626 | parent, name, mode,
cdata, fops, false);
|
^
|
;
fs/tracefs/event_inode.c:626:78: error: expected statement before ')' token
fs/tracefs/event_inode.c: In function 'eventfs_remove_dir':
fs/tracefs/event_inode.c:921:1: error: invalid use of void expression
921 | + call_srcu(&eventfs_srcu, &ei->rcu, free_rcu_ei);
| ^
cc1: all warnings being treated as errors
Links:
- https://storage.tuxsuite.com/public/linaro/naresh/builds/2XQUK9V1Fm5uX0Gdoa…
> ---
>
> Changes since v1: https://lore.kernel.org/all/20231028163749.0d3429a1@rorschach.local.home/
>
> - Add comment about ei->is_freed is a union along with ei->rcu and
> ei->del_list so that others can find where ei->is_freed is set and
> not get confused about why ei->dentry is being removed but ei->is_freed
> isn't mentioned.
>
> - And fixed change log to remove the double "Reported-by".
>
> fs/tracefs/event_inode.c | 65 +++++++++++++++++++++++++++++++++-------
> fs/tracefs/internal.h | 3 +-
> 2 files changed, 56 insertions(+), 12 deletions(-)
>
> diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
> index 4d2da7480e5f..45bddce7c747 100644
> --- a/fs/tracefs/event_inode.c
> +++ b/fs/tracefs/event_inode.c
> @@ -24,7 +24,20 @@
> #include <linux/delay.h>
> #include "internal.h"
>
> +/*
> + * eventfs_mutex protects the eventfs_inode (ei) dentry. Any access
> + * to the ei->dentry must be done under this mutex and after checking
> + * if ei->is_freed is not set. The ei->dentry is released under the
> + * mutex at the same time ei->is_freed is set. If ei->is_freed is set
> + * then the ei->dentry is invalid.
> + */
> static DEFINE_MUTEX(eventfs_mutex);
> +
> +/*
> + * The eventfs_inode (ei) itself is protected by SRCU. It is released from
> + * its parent's list and will have is_freed set (under eventfs_mutex).
> + * After the SRCU grace period is over, the ei may be freed.
> + */
> DEFINE_STATIC_SRCU(eventfs_srcu);
>
> static struct dentry *eventfs_root_lookup(struct inode *dir,
> @@ -234,6 +247,10 @@ create_file_dentry(struct eventfs_inode *ei, struct dentry **e_dentry,
> bool invalidate = false;
>
> mutex_lock(&eventfs_mutex);
> + if (ei->is_freed) {
> + mutex_unlock(&eventfs_mutex);
> + return NULL;
> + }
> /* If the e_dentry already has a dentry, use it */
> if (*e_dentry) {
> /* lookup does not need to up the ref count */
> @@ -307,6 +324,8 @@ static void eventfs_post_create_dir(struct eventfs_inode *ei)
> struct eventfs_inode *ei_child;
> struct tracefs_inode *ti;
>
> + lockdep_assert_held(&eventfs_mutex);
> +
> /* srcu lock already held */
> /* fill parent-child relation */
> list_for_each_entry_srcu(ei_child, &ei->children, list,
> @@ -320,6 +339,7 @@ static void eventfs_post_create_dir(struct eventfs_inode *ei)
>
> /**
> * create_dir_dentry - Create a directory dentry for the eventfs_inode
> + * @pei: The eventfs_inode parent of ei.
> * @ei: The eventfs_inode to create the directory for
> * @parent: The dentry of the parent of this directory
> * @lookup: True if this is called by the lookup code
> @@ -327,12 +347,17 @@ static void eventfs_post_create_dir(struct eventfs_inode *ei)
> * This creates and attaches a directory dentry to the eventfs_inode @ei.
> */
> static struct dentry *
> -create_dir_dentry(struct eventfs_inode *ei, struct dentry *parent, bool lookup)
> +create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei,
> + struct dentry *parent, bool lookup)
> {
> bool invalidate = false;
> struct dentry *dentry = NULL;
>
> mutex_lock(&eventfs_mutex);
> + if (pei->is_freed || ei->is_freed) {
> + mutex_unlock(&eventfs_mutex);
> + return NULL;
> + }
> if (ei->dentry) {
> /* If the dentry already has a dentry, use it */
> dentry = ei->dentry;
> @@ -435,7 +460,7 @@ static struct dentry *eventfs_root_lookup(struct inode *dir,
> */
> mutex_lock(&eventfs_mutex);
> ei = READ_ONCE(ti->private);
> - if (ei)
> + if (ei && !ei->is_freed)
> ei_dentry = READ_ONCE(ei->dentry);
> mutex_unlock(&eventfs_mutex);
>
> @@ -449,7 +474,7 @@ static struct dentry *eventfs_root_lookup(struct inode *dir,
> if (strcmp(ei_child->name, name) != 0)
> continue;
> ret = simple_lookup(dir, dentry, flags);
> - create_dir_dentry(ei_child, ei_dentry, true);
> + create_dir_dentry(ei, ei_child, ei_dentry, true);
> created = true;
> break;
> }
> @@ -583,7 +608,7 @@ static int dcache_dir_open_wrapper(struct inode *inode, struct file *file)
>
> list_for_each_entry_srcu(ei_child, &ei->children, list,
> srcu_read_lock_held(&eventfs_srcu)) {
> - d = create_dir_dentry(ei_child, parent, false);
> + d = create_dir_dentry(ei, ei_child, parent, false);
> if (d) {
> ret = add_dentries(&dentries, d, cnt);
> if (ret < 0)
> @@ -637,6 +662,13 @@ static int dcache_readdir_wrapper(struct file *file, struct dir_context *ctx)
> return ret;
> }
>
> +static void free_ei(struct eventfs_inode *ei)
> +{
> + kfree_const(ei->name);
> + kfree(ei->d_children);
> + kfree(ei);
> +}
> +
> /**
> * eventfs_create_dir - Create the eventfs_inode for this directory
> * @name: The name of the directory to create.
> @@ -700,12 +732,20 @@ struct eventfs_inode *eventfs_create_dir(const char *name, struct eventfs_inode
> ei->nr_entries = size;
> ei->data = data;
> INIT_LIST_HEAD(&ei->children);
> + INIT_LIST_HEAD(&ei->list);
>
> mutex_lock(&eventfs_mutex);
> - list_add_tail(&ei->list, &parent->children);
> - ei->d_parent = parent->dentry;
> + if (!parent->is_freed) {
> + list_add_tail(&ei->list, &parent->children);
> + ei->d_parent = parent->dentry;
> + }
> mutex_unlock(&eventfs_mutex);
>
> + /* Was the parent freed? */
> + if (list_empty(&ei->list)) {
> + free_ei(ei);
> + ei = NULL;
> + }
> return ei;
> }
>
> @@ -787,13 +827,11 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry
> return ERR_PTR(-ENOMEM);
> }
>
> -static void free_ei(struct rcu_head *head)
> +static void free_rcu_ei(struct rcu_head *head)
> {
> struct eventfs_inode *ei = container_of(head, struct eventfs_inode, rcu);
>
> - kfree_const(ei->name);
> - kfree(ei->d_children);
> - kfree(ei);
> + free_ei(ei);
> }
>
> /**
> @@ -880,7 +918,12 @@ void eventfs_remove_dir(struct eventfs_inode *ei)
> for (i = 0; i < ei->nr_entries; i++)
> unhook_dentry(&ei->d_children[i], &dentry_list);
> unhook_dentry(&ei->dentry, &dentry_list);
> - call_srcu(&eventfs_srcu, &ei->rcu, free_ei);
> + /*
> + * Note, ei->is_freed is a union along with ei->rcu
> + * and ei->del_list. When the ei is added to either
> + * of those lists, it automatically sets ei->is_freed.
> + */
> + call_srcu(&eventfs_srcu, &ei->rcu, free_rcu_ei);
> }
> mutex_unlock(&eventfs_mutex);
>
> diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
> index 64fde9490f52..21a1fa682b74 100644
> --- a/fs/tracefs/internal.h
> +++ b/fs/tracefs/internal.h
> @@ -30,7 +30,7 @@ struct eventfs_inode {
> const struct eventfs_entry *entries;
> const char *name;
> struct list_head children;
> - struct dentry *dentry;
> + struct dentry *dentry; /* Check is_freed to access */
> struct dentry *d_parent;
> struct dentry **d_children;
> void *data;
> @@ -39,6 +39,7 @@ struct eventfs_inode {
> * @del_list: list of eventfs_inode to delete
> * @rcu: eventfs_inode to delete in RCU
> * @is_freed: node is freed if one of the above is set
> + * Note if is_freed is set, then dentry is corrupted.
> */
> union {
> struct list_head del_list;
> --
> 2.42.0
>
Total jobs: 74
Total errors: 21 (28.38%)
LAVA errors: 0 (0.00%)
Test errors: 17 (22.97%)
Job errors: 4 (5.41%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: qrb5165-rb5
Total jobs: 37
Total errors: 6 (16.22%)
Error type: Test
Error count: 6 (16.22%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 2 (5.41%)
IDs:
rb5-06:
6979118 6980988
Error: Device NOT found!
Count: 1 (2.70%)
IDs:
rb5-03:
6979139
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 1 (2.70%)
IDs:
rb5-05:
6979130
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 1 (2.70%)
IDs:
rb5-03:
6979088
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 1 (2.70%)
IDs:
rb5-06:
6979086
Device type: dragonboard-845c
Total jobs: 36
Total errors: 14 (38.89%)
Error type: Test
Error count: 10 (27.78%)
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 8 (22.22%)
IDs:
db845c-01:
6980911
db845c-02:
6980782 6980912
db845c-04:
6980910
db845c-07:
6980996
db845c-08:
6980916
db845c-10:
6980783 6980892
Error: Device NOT found!
Count: 1 (2.78%)
IDs:
db845c-02:
6980936
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 589 seconds'
Count: 1 (2.78%)
IDs:
db845c-01:
6980780
Error type: Job
Error count: 4 (11.11%)
Error: auto-login action timed out
Count: 3 (8.33%)
IDs:
db845c-06:
6980778
db845c-08:
6980774
db845c-10:
6980771
Error: No match for error type 'Job', message 'login-action timed out after 870 seconds'
Count: 1 (2.78%)
IDs:
db845c-08:
6979093
Device type: hi6220-hikey-r2
Total jobs: 1
Total errors: 1 (100.00%)
Error type: Test
Error count: 1 (100.00%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[7B1579B5003E507A]'
Count: 1 (100.00%)
IDs:
hikey-6220-r2-05:
6980789
Total jobs: 105
Total errors: 19 (18.10%)
LAVA errors: 0 (0.00%)
Test errors: 16 (15.24%)
Job errors: 3 (2.86%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: dragonboard-845c
Total jobs: 50
Total errors: 8 (16.00%)
Error type: Test
Error count: 5 (10.00%)
Error: Device NOT found!
Count: 1 (2.00%)
IDs:
db845c-07:
6975915
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 3597 seconds'
Count: 1 (2.00%)
IDs:
db845c-01:
6974814
Error: No match for error type 'Test', message 'lava-test-interactive timed out after 600 seconds'
Count: 1 (2.00%)
IDs:
db845c-07:
6974741
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 263 seconds'
Count: 1 (2.00%)
IDs:
db845c-01:
6974739
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 3596 seconds'
Count: 1 (2.00%)
IDs:
db845c-10:
6974264
Error type: Job
Error count: 3 (6.00%)
Error: auto-login action timed out
Count: 3 (6.00%)
IDs:
db845c-01:
6975900
db845c-04:
6975902
db845c-10:
6975901
Device type: qrb5165-rb5
Total jobs: 54
Total errors: 11 (20.37%)
Error type: Test
Error count: 11 (20.37%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 5 (9.26%)
IDs:
rb5-06:
6972086 6972095 6973606 6973607 6974759
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 3 (5.56%)
IDs:
rb5-05:
6973485 6973613 6974745
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 2 (3.70%)
IDs:
rb5-03:
6973605 6973699
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 1 (1.85%)
IDs:
rb5-03:
6972104
Device type: e850-96
Total jobs: 1
Total errors: 0 (0.00%)
Total jobs: 145
Total errors: 29 (20.00%)
LAVA errors: 0 (0.00%)
Test errors: 27 (18.62%)
Job errors: 2 (1.38%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: qrb5165-rb5
Total jobs: 46
Total errors: 15 (32.61%)
Error type: Test
Error count: 15 (32.61%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 3 (6.52%)
IDs:
rb5-05:
6969915 6973712 6973714
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 4 (8.70%)
IDs:
rb5-06:
6969848 6969916 6972016 6972046
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 7 (15.22%)
IDs:
rb5-05:
6969862 6969863 6969876 6970927
rb5-06:
6972013 6972014 6972027
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 203 seconds'
Count: 1 (2.17%)
IDs:
rb5-06:
6969921
Device type: dragonboard-845c
Total jobs: 75
Total errors: 9 (12.00%)
Error type: Test
Error count: 7 (9.33%)
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 6 (8.00%)
IDs:
db845c-01:
6969907
db845c-04:
6972004
db845c-07:
6969881
db845c-08:
6971999
db845c-09:
6972053
db845c-10:
6972066
Error: No match for error type 'Test', message 'tradefed - adb device lost[b6b742b9]'
Count: 1 (1.33%)
IDs:
db845c-01:
6972038
Error type: Job
Error count: 2 (2.67%)
Error: No match for error type 'Job', message 'login-action timed out after 707 seconds'
Count: 1 (1.33%)
IDs:
db845c-10:
6972062
Error: No match for error type 'Job', message 'login-action timed out after 869 seconds'
Count: 1 (1.33%)
IDs:
db845c-09:
6972061
Device type: hi6220-hikey-r2
Total jobs: 22
Total errors: 4 (18.18%)
Error type: Test
Error count: 4 (18.18%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[7B1579B5003E507A]'
Count: 1 (4.55%)
IDs:
hikey-6220-r2-05:
6973473
Error: No match for error type 'Test', message 'tradefed - adb device lost[4595FE84003F72FC]'
Count: 1 (4.55%)
IDs:
hikey-6220-r2-04:
6972334
Error: No match for error type 'Test', message 'tradefed - adb device lost[8D6E5F00030E051]'
Count: 2 (9.09%)
IDs:
hikey-6220-r2-02:
6972269 6972280
Device type: x15
Total jobs: 1
Total errors: 0 (0.00%)
Device type: e850-96
Total jobs: 1
Total errors: 1 (100.00%)
Error type: Test
Error count: 1 (100.00%)
Error: lava-test-shell timed out
Count: 1 (100.00%)
IDs:
e850-96-01:
6941480
This is the start of the stable review cycle for the 4.19.297 release.
There are 98 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.297-r…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.19.297-rc1
Zhang Changzhong <zhangchangzhong(a)huawei.com>
xfrm6: fix inet6_dev refcount underflow problem
Kees Cook <keescook(a)chromium.org>
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name
Edward AD <twuufnxlz(a)gmail.com>
Bluetooth: hci_sock: fix slab oob read in create_monitor_event
Tony Lindgren <tony(a)atomide.com>
phy: mapphone-mdm6600: Fix runtime PM for remove
Dan Carpenter <dan.carpenter(a)linaro.org>
ASoC: pxa: fix a memory leak in probe()
Haibo Chen <haibo.chen(a)nxp.com>
gpio: vf610: set value before the direction to avoid a glitch
Niklas Schnelle <schnelle(a)linux.ibm.com>
s390/pci: fix iommu bitmap allocation
Peter Zijlstra <peterz(a)infradead.org>
perf: Disallow mis-matched inherited group reads
Puliang Lu <puliang.lu(a)fibocom.com>
USB: serial: option: add Fibocom to DELL custom modem FM101R-GL
Benoît Monin <benoit.monin(a)gmx.fr>
USB: serial: option: add entry for Sierra EM9191 with new firmware
Fabio Porcedda <fabio.porcedda(a)gmail.com>
USB: serial: option: add Telit LE910C4-WWX 0x1035 composition
Sunil V L <sunilvl(a)ventanamicro.com>
ACPI: irq: Fix incorrect return value in acpi_register_gsi()
Andy Shevchenko <andriy.shevchenko(a)linux.intel.com>
Revert "pinctrl: avoid unsafe code pattern in find_pinctrl()"
Avri Altman <avri.altman(a)wdc.com>
mmc: core: Capture correct oemid-bits for eMMC cards
Martin Kurbanov <mmkurbanov(a)sberdevices.ru>
mtd: spinand: micron: correct bitmask for ecc status
Bibek Kumar Patro <quic_bibekkum(a)quicinc.com>
mtd: rawnand: qcom: Unmap the right resource upon probe failure
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_event: Fix using memcmp when comparing keys
Josef Bacik <josef(a)toxicpanda.com>
btrfs: fix some -Wmaybe-uninitialized warnings in ioctl.c
Kai Uwe Broulik <foss-linux(a)broulik.de>
drm: panel-orientation-quirks: Add quirk for One Mix 2S
Kees Cook <keescook(a)chromium.org>
sky2: Make sure there is at least one frag_addr available
Benjamin Berg <benjamin.berg(a)intel.com>
wifi: cfg80211: avoid leaking stack data into trace
Wen Gong <quic_wgong(a)quicinc.com>
wifi: mac80211: allow transmitting EAPOL frames with tainted key
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_core: Fix build warnings
Ying Hsu <yinghsu(a)chromium.org>
Bluetooth: Avoid redundant authentication
Ma Ke <make_ruc2021(a)163.com>
HID: holtek: fix slab-out-of-bounds Write in holtek_kbd_input_event
Clément Léger <cleger(a)rivosinc.com>
tracing: relax trace_event_eval_update() execution with cond_resched()
Damien Le Moal <dlemoal(a)kernel.org>
ata: libata-eh: Fix compilation warning in ata_eh_link_report()
Chengfeng Ye <dg573847474(a)gmail.com>
gpio: timberdale: Fix potential deadlock on &tgpio->lock
Jeff Layton <jlayton(a)kernel.org>
overlayfs: set ctime when setting mtime and atime
Heiner Kallweit <hkallweit1(a)gmail.com>
i2c: mux: Avoid potential false error message in i2c_mux_add_adapter
Josef Bacik <josef(a)toxicpanda.com>
btrfs: initialize start_slot in btrfs_log_prealloc_extents
Filipe Manana <fdmanana(a)suse.com>
btrfs: return -EUCLEAN for delayed tree ref with a ref count not equals to 1
Tony Lindgren <tony(a)atomide.com>
ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone
Jordan Rife <jrife(a)google.com>
libceph: use kernel_connect()
Jeff Layton <jlayton(a)kernel.org>
libceph: fix unaligned accesses in ceph_entity_addr handling
Gavrilov Ilia <Ilia.Gavrilov(a)infotecs.ru>
net: pktgen: Fix interface flags printing
Pablo Neira Ayuso <pablo(a)netfilter.org>
netfilter: nft_set_rbtree: .deactivate fails if element has expired
Pedro Tammela <pctammela(a)mojatatu.com>
net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner curve
Michal Schmidt <mschmidt(a)redhat.com>
i40e: prevent crash on probe if hw registers have invalid values
Dan Carpenter <dan.carpenter(a)linaro.org>
net: usb: smsc95xx: Fix an error code in smsc95xx_reset()
Eric Dumazet <edumazet(a)google.com>
tcp: tsq: relax tcp_small_queue_check() when rtx queue contains a single skb
Neal Cardwell <ncardwell(a)google.com>
tcp: fix excessive TLP and RACK timeouts from HZ rounding
Josua Mayer <josua(a)solid-run.com>
net: rfkill: gpio: prevent value glitch during probe
Ma Ke <make_ruc2021(a)163.com>
net: ipv6: fix return value check in esp_remove_trailer
Ma Ke <make_ruc2021(a)163.com>
net: ipv4: fix return value check in esp_remove_trailer
Eric Dumazet <edumazet(a)google.com>
xfrm: interface: use DEV_STATS_INC()
Eric Dumazet <edumazet(a)google.com>
xfrm: fix a data-race in xfrm_gen_index()
Florian Westphal <fw(a)strlen.de>
netfilter: nft_payload: fix wrong mac header matching
Jim Mattson <jmattson(a)google.com>
KVM: x86: Mask LVTPC when handling a PMI
Johan Hovold <johan+linaro(a)kernel.org>
regmap: fix NULL deref on lookup
Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org>
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
Arnd Bergmann <arnd(a)arndb.de>
Bluetooth: avoid memcmp() out of bounds warning
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_event: Fix coding style
Arkadiusz Bokowy <arkadiusz.bokowy(a)gmail.com>
Bluetooth: vhci: Fix race when opening vhci device
Ziyang Xuan <william.xuanziyang(a)huawei.com>
Bluetooth: Fix a refcnt underflow problem for hci_conn
Lee, Chun-Yi <jlee(a)suse.com>
Bluetooth: Reject connection with the device which has same BD_ADDR
Lee, Chun-Yi <jlee(a)suse.com>
Bluetooth: hci_event: Ignore NULL link key
Ricardo Cañuelo <ricardo.canuelo(a)collabora.com>
usb: hub: Guard against accesses to uninitialized BOS descriptors
Nicolas Dichtel <nicolas.dichtel(a)6wind.com>
dev_forward_skb: do not scrub skb mark within the same name space
Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com>
x86/alternatives: Disable KASAN in apply_alternatives()
Christophe Leroy <christophe.leroy(a)csgroup.eu>
powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()
Krishna Kurapati <quic_kriskura(a)quicinc.com>
usb: gadget: ncm: Handle decoding of multiple NTB's in unwrap call
Piyush Mehta <piyush.mehta(a)amd.com>
usb: gadget: udc-xilinx: replace memcpy with memcpy_toio
Borislav Petkov (AMD) <bp(a)alien8.de>
x86/cpu: Fix AMD erratum #1485 on Zen4-based CPUs
Dmitry Torokhov <dmitry.torokhov(a)gmail.com>
pinctrl: avoid unsafe code pattern in find_pinctrl()
Michal Koutný <mkoutny(a)suse.com>
cgroup: Remove duplicates in cgroup v1 tasks file
Matthias Berndt <matthias_berndt(a)gmx.de>
Input: xpad - add PXN V900 support
Jeffery Miller <jefferymiller(a)google.com>
Input: psmouse - fix fast_reconnect function for PS/2 mode
Javier Carrasco <javier.carrasco.cruz(a)gmail.com>
Input: powermate - fix use-after-free in powermate_config_complete
Xiubo Li <xiubli(a)redhat.com>
ceph: fix incorrect revoked caps assert in ceph_fill_file_size()
Jorge Sanjuan Garcia <jorge.sanjuangarcia(a)duagon.com>
mcb: remove is_added flag from mcb_device struct
Alexander Zangerl <az(a)breathe-safe.com>
iio: pressure: ms5611: ms5611_prom_is_valid false negative bug
Phil Elwell <phil(a)raspberrypi.com>
iio: pressure: bmp280: Fix NULL pointer exception
Xingxing Luo <xingxing.luo(a)unisoc.com>
usb: musb: Modify the "HWVers" register address
Xingxing Luo <xingxing.luo(a)unisoc.com>
usb: musb: Get the musb_qh poniter after musb_giveback
Thinh Nguyen <Thinh.Nguyen(a)synopsys.com>
usb: dwc3: Soft reset phy on probe for host
Javier Carrasco <javier.carrasco.cruz(a)gmail.com>
net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read
Wesley Cheng <quic_wcheng(a)quicinc.com>
usb: xhci: xhci-ring: Use sysdev for mapping bounce buffer
Amelie Delaunay <amelie.delaunay(a)foss.st.com>
dmaengine: stm32-mdma: abort resume if no ongoing transfer
Peter Zijlstra <peterz(a)infradead.org>
sched,idle,rcu: Push rcu_idle deeper into the idle path
Waiman Long <longman(a)redhat.com>
workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()
Jeremy Cline <jeremy(a)jcline.org>
nfc: nci: assert requested protocol is valid
Eric Dumazet <edumazet(a)google.com>
net: nfc: fix races in nfc_llcp_sock_get() and nfc_llcp_sock_get_sn()
Dan Carpenter <dan.carpenter(a)linaro.org>
ixgbe: fix crash with empty VF macvlan list
Konstantin Meskhidze <konstantin.meskhidze(a)huawei.com>
drm/vmwgfx: fix typo of sizeof argument
Roger Pau Monne <roger.pau(a)citrix.com>
xen-netback: use default TX queue size for vifs
Dinghao Liu <dinghao.liu(a)zju.edu.cn>
ieee802154: ca8210: Fix a potential UAF in ca8210_probe
Abhinav Kumar <quic_abhinavk(a)quicinc.com>
drm/msm/dsi: skip the wait for video mode done if not applicable
Martin Fuzzey <martin.fuzzey(a)flowbird.group>
drm: etvnaviv: fix bad backport leading to warning
Jordan Rife <jrife(a)google.com>
net: prevent address rewrite in kernel_bind()
Jan Kara <jack(a)suse.cz>
quota: Fix slow quotaoff
Hans de Goede <hdegoede(a)redhat.com>
HID: logitech-hidpp: Fix kernel crash on receiver USB disconnect
Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
platform/x86: hp-wmi:: Mark driver struct with __refdata to prevent section mismatch warning
Artem Chernyshev <artem.chernyshev(a)red-soft.ru>
RDMA/cxgb4: Check skb value for failure to allocate
Jordan Rife <jrife(a)google.com>
net: prevent rewrite of msg_name in sock_sendmsg()
Randy Dunlap <rdunlap(a)infradead.org>
net: fix kernel-doc warnings for socket.c
Paolo Abeni <pabeni(a)redhat.com>
net: use indirect calls helpers at the socket layer
Paolo Abeni <pabeni(a)redhat.com>
indirect call wrappers: helpers to speed-up indirect calls of builtin
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/omap4-droid4-xt894.dts | 1 +
arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +-
arch/s390/pci/pci_dma.c | 15 ++++-
arch/x86/include/asm/msr-index.h | 4 ++
arch/x86/kernel/alternative.c | 13 +++++
arch/x86/kernel/cpu/amd.c | 8 +++
arch/x86/kvm/lapic.c | 8 ++-
drivers/acpi/irq.c | 7 ++-
drivers/ata/libata-eh.c | 2 +-
drivers/base/regmap/regmap.c | 2 +-
drivers/bluetooth/hci_vhci.c | 3 +
drivers/cpuidle/cpuidle.c | 12 ++--
drivers/dma/stm32-mdma.c | 4 ++
drivers/gpio/gpio-timberdale.c | 5 +-
drivers/gpio/gpio-vf610.c | 4 +-
drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 ++++++
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
drivers/gpu/drm/msm/dsi/dsi_host.c | 12 ++++
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
drivers/hid/hid-holtek-kbd.c | 4 ++
drivers/hid/hid-logitech-hidpp.c | 3 +-
drivers/i2c/i2c-mux.c | 2 +-
drivers/iio/pressure/bmp280-core.c | 2 +-
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/infiniband/hw/cxgb4/cm.c | 3 +
drivers/input/joystick/xpad.c | 2 +
drivers/input/misc/powermate.c | 1 +
drivers/input/mouse/elantech.c | 1 +
drivers/input/mouse/synaptics.c | 1 +
drivers/mcb/mcb-core.c | 10 +---
drivers/mcb/mcb-parse.c | 2 -
drivers/mmc/core/mmc.c | 2 +-
drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
drivers/mtd/nand/spi/micron.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 5 +-
drivers/net/ethernet/marvell/sky2.h | 2 +-
drivers/net/ieee802154/ca8210.c | 17 +-----
drivers/net/usb/dm9601.c | 7 ++-
drivers/net/usb/smsc95xx.c | 2 +-
drivers/net/xen-netback/interface.c | 3 -
drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 +
drivers/platform/x86/hp-wmi.c | 8 ++-
drivers/usb/core/hub.c | 28 +++++++--
drivers/usb/core/hub.h | 2 +-
drivers/usb/dwc3/core.c | 39 ++++++++++++-
drivers/usb/gadget/function/f_ncm.c | 26 ++++++---
drivers/usb/gadget/udc/udc-xilinx.c | 20 ++++---
drivers/usb/host/xhci-ring.c | 4 +-
drivers/usb/musb/musb_debugfs.c | 2 +-
drivers/usb/musb/musb_host.c | 9 ++-
drivers/usb/serial/option.c | 7 +++
fs/btrfs/extent-tree.c | 6 +-
fs/btrfs/ioctl.c | 4 +-
fs/btrfs/tree-log.c | 2 +-
fs/ceph/inode.c | 4 +-
fs/overlayfs/copy_up.c | 2 +-
fs/quota/dquot.c | 66 ++++++++++++---------
include/linux/indirect_call_wrapper.h | 51 +++++++++++++++++
include/linux/mcb.h | 1 -
include/linux/netdevice.h | 2 +-
include/linux/perf_event.h | 1 +
include/linux/quota.h | 4 +-
include/linux/quotaops.h | 2 +-
include/net/bluetooth/hci_core.h | 2 +-
include/net/netns/xfrm.h | 1 +
include/net/tcp.h | 3 +
kernel/cgroup/cgroup-v1.c | 5 +-
kernel/events/core.c | 39 +++++++++++--
kernel/sched/idle.c | 22 +++----
kernel/trace/trace_events.c | 1 +
kernel/workqueue.c | 8 ++-
net/bluetooth/hci_conn.c | 72 ++++++++++++++---------
net/bluetooth/hci_core.c | 8 ++-
net/bluetooth/hci_event.c | 33 +++++++++--
net/bluetooth/hci_sock.c | 3 +-
net/ceph/messenger.c | 79 +++++++++++++-------------
net/core/pktgen.c | 14 ++---
net/ipv4/esp4.c | 4 +-
net/ipv4/tcp_output.c | 25 ++++++--
net/ipv4/tcp_recovery.c | 2 +-
net/ipv6/esp6.c | 4 +-
net/ipv6/xfrm6_policy.c | 4 +-
net/mac80211/tx.c | 3 +-
net/netfilter/ipvs/ip_vs_sync.c | 4 +-
net/netfilter/nft_payload.c | 2 +-
net/netfilter/nft_set_rbtree.c | 2 +
net/nfc/llcp_core.c | 30 ++++------
net/nfc/nci/core.c | 5 ++
net/nfc/nci/spi.c | 2 +
net/rds/tcp_connect.c | 2 +-
net/rds/tcp_listen.c | 2 +-
net/rfkill/rfkill-gpio.c | 4 +-
net/sched/sch_hfsc.c | 18 ++++--
net/socket.c | 77 ++++++++++++++++++-------
net/wireless/nl80211.c | 2 +-
net/xfrm/xfrm_interface_core.c | 22 ++++---
net/xfrm/xfrm_policy.c | 6 +-
sound/soc/pxa/pxa-ssp.c | 2 +-
100 files changed, 688 insertions(+), 320 deletions(-)
This is the start of the stable review cycle for the 4.14.328 release.
There are 66 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.328-r…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.14.328-rc1
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_event: Fix using memcmp when comparing keys
Kees Cook <keescook(a)chromium.org>
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name
Edward AD <twuufnxlz(a)gmail.com>
Bluetooth: hci_sock: fix slab oob read in create_monitor_event
Haibo Chen <haibo.chen(a)nxp.com>
gpio: vf610: set value before the direction to avoid a glitch
Niklas Schnelle <schnelle(a)linux.ibm.com>
s390/pci: fix iommu bitmap allocation
Peter Zijlstra <peterz(a)infradead.org>
perf: Disallow mis-matched inherited group reads
Puliang Lu <puliang.lu(a)fibocom.com>
USB: serial: option: add Fibocom to DELL custom modem FM101R-GL
Benoît Monin <benoit.monin(a)gmx.fr>
USB: serial: option: add entry for Sierra EM9191 with new firmware
Fabio Porcedda <fabio.porcedda(a)gmail.com>
USB: serial: option: add Telit LE910C4-WWX 0x1035 composition
Sunil V L <sunilvl(a)ventanamicro.com>
ACPI: irq: Fix incorrect return value in acpi_register_gsi()
Andy Shevchenko <andriy.shevchenko(a)linux.intel.com>
Revert "pinctrl: avoid unsafe code pattern in find_pinctrl()"
Avri Altman <avri.altman(a)wdc.com>
mmc: core: Capture correct oemid-bits for eMMC cards
Kees Cook <keescook(a)chromium.org>
sky2: Make sure there is at least one frag_addr available
Benjamin Berg <benjamin.berg(a)intel.com>
wifi: cfg80211: avoid leaking stack data into trace
Wen Gong <quic_wgong(a)quicinc.com>
wifi: mac80211: allow transmitting EAPOL frames with tainted key
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_core: Fix build warnings
Ying Hsu <yinghsu(a)chromium.org>
Bluetooth: Avoid redundant authentication
Ma Ke <make_ruc2021(a)163.com>
HID: holtek: fix slab-out-of-bounds Write in holtek_kbd_input_event
Clément Léger <cleger(a)rivosinc.com>
tracing: relax trace_event_eval_update() execution with cond_resched()
Damien Le Moal <dlemoal(a)kernel.org>
ata: libata-eh: Fix compilation warning in ata_eh_link_report()
Chengfeng Ye <dg573847474(a)gmail.com>
gpio: timberdale: Fix potential deadlock on &tgpio->lock
Jeff Layton <jlayton(a)kernel.org>
overlayfs: set ctime when setting mtime and atime
Heiner Kallweit <hkallweit1(a)gmail.com>
i2c: mux: Avoid potential false error message in i2c_mux_add_adapter
Josef Bacik <josef(a)toxicpanda.com>
btrfs: initialize start_slot in btrfs_log_prealloc_extents
Tony Lindgren <tony(a)atomide.com>
ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone
Michal Schmidt <mschmidt(a)redhat.com>
i40e: prevent crash on probe if hw registers have invalid values
Dan Carpenter <dan.carpenter(a)linaro.org>
net: usb: smsc95xx: Fix an error code in smsc95xx_reset()
Josua Mayer <josua(a)solid-run.com>
net: rfkill: gpio: prevent value glitch during probe
Ma Ke <make_ruc2021(a)163.com>
net: ipv6: fix return value check in esp_remove_trailer
Ma Ke <make_ruc2021(a)163.com>
net: ipv4: fix return value check in esp_remove_trailer
Eric Dumazet <edumazet(a)google.com>
xfrm: fix a data-race in xfrm_gen_index()
Florian Westphal <fw(a)strlen.de>
netfilter: nft_payload: fix wrong mac header matching
Jim Mattson <jmattson(a)google.com>
KVM: x86: Mask LVTPC when handling a PMI
Johan Hovold <johan+linaro(a)kernel.org>
regmap: fix NULL deref on lookup
Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org>
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
Arnd Bergmann <arnd(a)arndb.de>
Bluetooth: avoid memcmp() out of bounds warning
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_event: Fix coding style
Arkadiusz Bokowy <arkadiusz.bokowy(a)gmail.com>
Bluetooth: vhci: Fix race when opening vhci device
Ziyang Xuan <william.xuanziyang(a)huawei.com>
Bluetooth: Fix a refcnt underflow problem for hci_conn
Lee, Chun-Yi <jlee(a)suse.com>
Bluetooth: Reject connection with the device which has same BD_ADDR
Lee, Chun-Yi <jlee(a)suse.com>
Bluetooth: hci_event: Ignore NULL link key
Ricardo Cañuelo <ricardo.canuelo(a)collabora.com>
usb: hub: Guard against accesses to uninitialized BOS descriptors
Borislav Petkov (AMD) <bp(a)alien8.de>
x86/cpu: Fix AMD erratum #1485 on Zen4-based CPUs
Krishna Kurapati <quic_kriskura(a)quicinc.com>
usb: gadget: ncm: Handle decoding of multiple NTB's in unwrap call
Piyush Mehta <piyush.mehta(a)amd.com>
usb: gadget: udc-xilinx: replace memcpy with memcpy_toio
Dmitry Torokhov <dmitry.torokhov(a)gmail.com>
pinctrl: avoid unsafe code pattern in find_pinctrl()
Michal Koutný <mkoutny(a)suse.com>
cgroup: Remove duplicates in cgroup v1 tasks file
Matthias Berndt <matthias_berndt(a)gmx.de>
Input: xpad - add PXN V900 support
Javier Carrasco <javier.carrasco.cruz(a)gmail.com>
Input: powermate - fix use-after-free in powermate_config_complete
Xiubo Li <xiubli(a)redhat.com>
ceph: fix incorrect revoked caps assert in ceph_fill_file_size()
Jorge Sanjuan Garcia <jorge.sanjuangarcia(a)duagon.com>
mcb: remove is_added flag from mcb_device struct
Alexander Zangerl <az(a)breathe-safe.com>
iio: pressure: ms5611: ms5611_prom_is_valid false negative bug
Phil Elwell <phil(a)raspberrypi.com>
iio: pressure: bmp280: Fix NULL pointer exception
Xingxing Luo <xingxing.luo(a)unisoc.com>
usb: musb: Modify the "HWVers" register address
Xingxing Luo <xingxing.luo(a)unisoc.com>
usb: musb: Get the musb_qh poniter after musb_giveback
Javier Carrasco <javier.carrasco.cruz(a)gmail.com>
net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read
Wesley Cheng <quic_wcheng(a)quicinc.com>
usb: xhci: xhci-ring: Use sysdev for mapping bounce buffer
Waiman Long <longman(a)redhat.com>
workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()
Jeremy Cline <jeremy(a)jcline.org>
nfc: nci: assert requested protocol is valid
Dan Carpenter <dan.carpenter(a)linaro.org>
ixgbe: fix crash with empty VF macvlan list
Konstantin Meskhidze <konstantin.meskhidze(a)huawei.com>
drm/vmwgfx: fix typo of sizeof argument
Dinghao Liu <dinghao.liu(a)zju.edu.cn>
ieee802154: ca8210: Fix a potential UAF in ca8210_probe
Martin Fuzzey <martin.fuzzey(a)flowbird.group>
drm: etvnaviv: fix bad backport leading to warning
Hans de Goede <hdegoede(a)redhat.com>
HID: logitech-hidpp: Fix kernel crash on receiver USB disconnect
Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
platform/x86: hp-wmi:: Mark driver struct with __refdata to prevent section mismatch warning
Artem Chernyshev <artem.chernyshev(a)red-soft.ru>
RDMA/cxgb4: Check skb value for failure to allocate
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/omap4-droid4-xt894.dts | 1 +
arch/s390/pci/pci_dma.c | 15 +++++-
arch/x86/include/asm/msr-index.h | 4 ++
arch/x86/kernel/cpu/amd.c | 9 ++++
arch/x86/kvm/lapic.c | 8 ++-
drivers/acpi/irq.c | 7 ++-
drivers/ata/libata-eh.c | 2 +-
drivers/base/regmap/regmap.c | 2 +-
drivers/bluetooth/hci_vhci.c | 3 ++
drivers/gpio/gpio-timberdale.c | 5 +-
drivers/gpio/gpio-vf610.c | 4 +-
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
drivers/hid/hid-holtek-kbd.c | 4 ++
drivers/hid/hid-logitech-hidpp.c | 3 +-
drivers/i2c/i2c-mux.c | 2 +-
drivers/iio/pressure/bmp280-core.c | 2 +-
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/infiniband/hw/cxgb4/cm.c | 3 ++
drivers/input/joystick/xpad.c | 2 +
drivers/input/misc/powermate.c | 1 +
drivers/mcb/mcb-core.c | 10 ++--
drivers/mcb/mcb-parse.c | 2 -
drivers/mmc/core/mmc.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 5 +-
drivers/net/ethernet/marvell/sky2.h | 2 +-
drivers/net/ieee802154/ca8210.c | 17 ++----
drivers/net/usb/dm9601.c | 7 ++-
drivers/net/usb/smsc95xx.c | 2 +-
drivers/platform/x86/hp-wmi.c | 8 ++-
drivers/usb/core/hub.c | 28 ++++++++--
drivers/usb/core/hub.h | 2 +-
drivers/usb/gadget/function/f_ncm.c | 26 +++++++---
drivers/usb/gadget/udc/udc-xilinx.c | 20 ++++---
drivers/usb/host/xhci-ring.c | 4 +-
drivers/usb/musb/musb_debugfs.c | 2 +-
drivers/usb/musb/musb_host.c | 9 +++-
drivers/usb/serial/option.c | 7 +++
fs/btrfs/tree-log.c | 2 +-
fs/ceph/inode.c | 4 +-
fs/overlayfs/copy_up.c | 2 +-
include/linux/mcb.h | 1 -
include/linux/perf_event.h | 1 +
include/net/bluetooth/hci_core.h | 2 +-
include/net/netns/xfrm.h | 1 +
kernel/cgroup/cgroup-v1.c | 5 +-
kernel/events/core.c | 39 +++++++++++---
kernel/trace/trace_events.c | 1 +
kernel/workqueue.c | 8 ++-
net/bluetooth/hci_conn.c | 72 ++++++++++++++++----------
net/bluetooth/hci_core.c | 8 +--
net/bluetooth/hci_event.c | 33 +++++++++---
net/bluetooth/hci_sock.c | 3 +-
net/ipv4/esp4.c | 4 +-
net/ipv6/esp6.c | 4 +-
net/mac80211/tx.c | 3 +-
net/netfilter/nft_payload.c | 2 +-
net/nfc/nci/core.c | 5 ++
net/nfc/nci/spi.c | 2 +
net/rfkill/rfkill-gpio.c | 4 +-
net/wireless/nl80211.c | 2 +-
net/xfrm/xfrm_policy.c | 6 +--
64 files changed, 316 insertions(+), 142 deletions(-)
Total jobs: 108
Total errors: 22 (20.37%)
LAVA errors: 0 (0.00%)
Test errors: 19 (17.59%)
Job errors: 2 (1.85%)
Infra errors: 1 (0.93%)
Canceled jobs: 0 (0.00%)
Device type: dragonboard-845c
Total jobs: 54
Total errors: 7 (12.96%)
Error type: Test
Error count: 6 (11.11%)
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 4 (7.41%)
IDs:
db845c-04:
6966215 6967975
db845c-09:
6969834
db845c-10:
6966183
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 3595 seconds'
Count: 1 (1.85%)
IDs:
db845c-06:
6968622
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 3594 seconds'
Count: 1 (1.85%)
IDs:
db845c-01:
6968088
Error type: Job
Error count: 1 (1.85%)
Error: No match for error type 'Job', message 'login-action timed out after 870 seconds'
Count: 1 (1.85%)
IDs:
db845c-08:
6966199
Device type: qrb5165-rb5
Total jobs: 50
Total errors: 15 (30.00%)
Error type: Test
Error count: 13 (26.00%)
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 4 (8.00%)
IDs:
rb5-03:
6966158
rb5-05:
6969818
rb5-06:
6966177 6966188
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 1 (2.00%)
IDs:
rb5-05:
6969813
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 3 (6.00%)
IDs:
rb5-03:
6966172 6966214 6968621
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 5 (10.00%)
IDs:
rb5-06:
6966151 6966154 6966155 6966173 6967043
Error type: Infrastructure
Error count: 1 (2.00%)
Error: No match for error type 'Infrastructure', message 'Command '['docker', 'exec', 'lava-6969811-5.4-30286514-2cc3-4240-9e3b-d7ee6c8f1e5b', 'fastboot', '-s', 'f11b68eb', 'boot', '/var/lib/lava/dispatcher/tmp/6969811/fastboot-deploy-yasm5g3q/boot.img']' returned non-zero exit status 1.'
Count: 1 (2.00%)
IDs:
rb5-05:
6969811
Error type: Job
Error count: 1 (2.00%)
Error: Invalid job data
Count: 1 (2.00%)
IDs:
rb5-03:
6967051
Device type: x86
Total jobs: 1
Total errors: 0 (0.00%)
Device type: juno-r2
Total jobs: 2
Total errors: 0 (0.00%)
Device type: dragonboard-410c
Total jobs: 1
Total errors: 0 (0.00%)
This is the start of the stable review cycle for the 4.14.328 release.
There are 65 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu, 26 Oct 2023 08:32:31 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.328-r…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.14.328-rc2
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_event: Fix using memcmp when comparing keys
Kees Cook <keescook(a)chromium.org>
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name
Edward AD <twuufnxlz(a)gmail.com>
Bluetooth: hci_sock: fix slab oob read in create_monitor_event
Haibo Chen <haibo.chen(a)nxp.com>
gpio: vf610: set value before the direction to avoid a glitch
Niklas Schnelle <schnelle(a)linux.ibm.com>
s390/pci: fix iommu bitmap allocation
Peter Zijlstra <peterz(a)infradead.org>
perf: Disallow mis-matched inherited group reads
Puliang Lu <puliang.lu(a)fibocom.com>
USB: serial: option: add Fibocom to DELL custom modem FM101R-GL
Benoît Monin <benoit.monin(a)gmx.fr>
USB: serial: option: add entry for Sierra EM9191 with new firmware
Fabio Porcedda <fabio.porcedda(a)gmail.com>
USB: serial: option: add Telit LE910C4-WWX 0x1035 composition
Sunil V L <sunilvl(a)ventanamicro.com>
ACPI: irq: Fix incorrect return value in acpi_register_gsi()
Andy Shevchenko <andriy.shevchenko(a)linux.intel.com>
Revert "pinctrl: avoid unsafe code pattern in find_pinctrl()"
Avri Altman <avri.altman(a)wdc.com>
mmc: core: Capture correct oemid-bits for eMMC cards
Kees Cook <keescook(a)chromium.org>
sky2: Make sure there is at least one frag_addr available
Benjamin Berg <benjamin.berg(a)intel.com>
wifi: cfg80211: avoid leaking stack data into trace
Wen Gong <quic_wgong(a)quicinc.com>
wifi: mac80211: allow transmitting EAPOL frames with tainted key
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_core: Fix build warnings
Ying Hsu <yinghsu(a)chromium.org>
Bluetooth: Avoid redundant authentication
Ma Ke <make_ruc2021(a)163.com>
HID: holtek: fix slab-out-of-bounds Write in holtek_kbd_input_event
Clément Léger <cleger(a)rivosinc.com>
tracing: relax trace_event_eval_update() execution with cond_resched()
Damien Le Moal <dlemoal(a)kernel.org>
ata: libata-eh: Fix compilation warning in ata_eh_link_report()
Chengfeng Ye <dg573847474(a)gmail.com>
gpio: timberdale: Fix potential deadlock on &tgpio->lock
Jeff Layton <jlayton(a)kernel.org>
overlayfs: set ctime when setting mtime and atime
Heiner Kallweit <hkallweit1(a)gmail.com>
i2c: mux: Avoid potential false error message in i2c_mux_add_adapter
Josef Bacik <josef(a)toxicpanda.com>
btrfs: initialize start_slot in btrfs_log_prealloc_extents
Tony Lindgren <tony(a)atomide.com>
ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone
Michal Schmidt <mschmidt(a)redhat.com>
i40e: prevent crash on probe if hw registers have invalid values
Dan Carpenter <dan.carpenter(a)linaro.org>
net: usb: smsc95xx: Fix an error code in smsc95xx_reset()
Josua Mayer <josua(a)solid-run.com>
net: rfkill: gpio: prevent value glitch during probe
Ma Ke <make_ruc2021(a)163.com>
net: ipv6: fix return value check in esp_remove_trailer
Ma Ke <make_ruc2021(a)163.com>
net: ipv4: fix return value check in esp_remove_trailer
Eric Dumazet <edumazet(a)google.com>
xfrm: fix a data-race in xfrm_gen_index()
Florian Westphal <fw(a)strlen.de>
netfilter: nft_payload: fix wrong mac header matching
Jim Mattson <jmattson(a)google.com>
KVM: x86: Mask LVTPC when handling a PMI
Johan Hovold <johan+linaro(a)kernel.org>
regmap: fix NULL deref on lookup
Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org>
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
Arnd Bergmann <arnd(a)arndb.de>
Bluetooth: avoid memcmp() out of bounds warning
Luiz Augusto von Dentz <luiz.von.dentz(a)intel.com>
Bluetooth: hci_event: Fix coding style
Arkadiusz Bokowy <arkadiusz.bokowy(a)gmail.com>
Bluetooth: vhci: Fix race when opening vhci device
Ziyang Xuan <william.xuanziyang(a)huawei.com>
Bluetooth: Fix a refcnt underflow problem for hci_conn
Lee, Chun-Yi <jlee(a)suse.com>
Bluetooth: Reject connection with the device which has same BD_ADDR
Lee, Chun-Yi <jlee(a)suse.com>
Bluetooth: hci_event: Ignore NULL link key
Ricardo Cañuelo <ricardo.canuelo(a)collabora.com>
usb: hub: Guard against accesses to uninitialized BOS descriptors
Borislav Petkov (AMD) <bp(a)alien8.de>
x86/cpu: Fix AMD erratum #1485 on Zen4-based CPUs
Krishna Kurapati <quic_kriskura(a)quicinc.com>
usb: gadget: ncm: Handle decoding of multiple NTB's in unwrap call
Piyush Mehta <piyush.mehta(a)amd.com>
usb: gadget: udc-xilinx: replace memcpy with memcpy_toio
Dmitry Torokhov <dmitry.torokhov(a)gmail.com>
pinctrl: avoid unsafe code pattern in find_pinctrl()
Michal Koutný <mkoutny(a)suse.com>
cgroup: Remove duplicates in cgroup v1 tasks file
Matthias Berndt <matthias_berndt(a)gmx.de>
Input: xpad - add PXN V900 support
Javier Carrasco <javier.carrasco.cruz(a)gmail.com>
Input: powermate - fix use-after-free in powermate_config_complete
Xiubo Li <xiubli(a)redhat.com>
ceph: fix incorrect revoked caps assert in ceph_fill_file_size()
Jorge Sanjuan Garcia <jorge.sanjuangarcia(a)duagon.com>
mcb: remove is_added flag from mcb_device struct
Alexander Zangerl <az(a)breathe-safe.com>
iio: pressure: ms5611: ms5611_prom_is_valid false negative bug
Phil Elwell <phil(a)raspberrypi.com>
iio: pressure: bmp280: Fix NULL pointer exception
Xingxing Luo <xingxing.luo(a)unisoc.com>
usb: musb: Modify the "HWVers" register address
Xingxing Luo <xingxing.luo(a)unisoc.com>
usb: musb: Get the musb_qh poniter after musb_giveback
Javier Carrasco <javier.carrasco.cruz(a)gmail.com>
net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read
Wesley Cheng <quic_wcheng(a)quicinc.com>
usb: xhci: xhci-ring: Use sysdev for mapping bounce buffer
Waiman Long <longman(a)redhat.com>
workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()
Jeremy Cline <jeremy(a)jcline.org>
nfc: nci: assert requested protocol is valid
Dan Carpenter <dan.carpenter(a)linaro.org>
ixgbe: fix crash with empty VF macvlan list
Konstantin Meskhidze <konstantin.meskhidze(a)huawei.com>
drm/vmwgfx: fix typo of sizeof argument
Dinghao Liu <dinghao.liu(a)zju.edu.cn>
ieee802154: ca8210: Fix a potential UAF in ca8210_probe
Martin Fuzzey <martin.fuzzey(a)flowbird.group>
drm: etvnaviv: fix bad backport leading to warning
Hans de Goede <hdegoede(a)redhat.com>
HID: logitech-hidpp: Fix kernel crash on receiver USB disconnect
Artem Chernyshev <artem.chernyshev(a)red-soft.ru>
RDMA/cxgb4: Check skb value for failure to allocate
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/omap4-droid4-xt894.dts | 1 +
arch/s390/pci/pci_dma.c | 16 +++++-
arch/x86/include/asm/msr-index.h | 4 ++
arch/x86/kernel/cpu/amd.c | 9 ++++
arch/x86/kvm/lapic.c | 8 ++-
drivers/acpi/irq.c | 7 ++-
drivers/ata/libata-eh.c | 2 +-
drivers/base/regmap/regmap.c | 2 +-
drivers/bluetooth/hci_vhci.c | 3 ++
drivers/gpio/gpio-timberdale.c | 5 +-
drivers/gpio/gpio-vf610.c | 4 +-
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
drivers/hid/hid-holtek-kbd.c | 4 ++
drivers/hid/hid-logitech-hidpp.c | 3 +-
drivers/i2c/i2c-mux.c | 2 +-
drivers/iio/pressure/bmp280-core.c | 2 +-
drivers/iio/pressure/ms5611_core.c | 2 +-
drivers/infiniband/hw/cxgb4/cm.c | 3 ++
drivers/input/joystick/xpad.c | 2 +
drivers/input/misc/powermate.c | 1 +
drivers/mcb/mcb-core.c | 10 ++--
drivers/mcb/mcb-parse.c | 2 -
drivers/mmc/core/mmc.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 5 +-
drivers/net/ethernet/marvell/sky2.h | 2 +-
drivers/net/ieee802154/ca8210.c | 17 ++----
drivers/net/usb/dm9601.c | 7 ++-
drivers/net/usb/smsc95xx.c | 2 +-
drivers/usb/core/hub.c | 28 ++++++++--
drivers/usb/core/hub.h | 2 +-
drivers/usb/gadget/function/f_ncm.c | 26 +++++++---
drivers/usb/gadget/udc/udc-xilinx.c | 20 ++++---
drivers/usb/host/xhci-ring.c | 4 +-
drivers/usb/musb/musb_debugfs.c | 2 +-
drivers/usb/musb/musb_host.c | 9 +++-
drivers/usb/serial/option.c | 7 +++
fs/btrfs/tree-log.c | 2 +-
fs/ceph/inode.c | 4 +-
fs/overlayfs/copy_up.c | 2 +-
include/linux/mcb.h | 1 -
include/linux/perf_event.h | 1 +
include/net/bluetooth/hci_core.h | 2 +-
include/net/netns/xfrm.h | 1 +
kernel/cgroup/cgroup-v1.c | 5 +-
kernel/events/core.c | 39 +++++++++++---
kernel/trace/trace_events.c | 1 +
kernel/workqueue.c | 8 ++-
net/bluetooth/hci_conn.c | 72 ++++++++++++++++----------
net/bluetooth/hci_core.c | 8 +--
net/bluetooth/hci_event.c | 33 +++++++++---
net/bluetooth/hci_sock.c | 3 +-
net/ipv4/esp4.c | 4 +-
net/ipv6/esp6.c | 4 +-
net/mac80211/tx.c | 3 +-
net/netfilter/nft_payload.c | 2 +-
net/nfc/nci/core.c | 5 ++
net/nfc/nci/spi.c | 2 +
net/rfkill/rfkill-gpio.c | 4 +-
net/wireless/nl80211.c | 2 +-
net/xfrm/xfrm_policy.c | 6 +--
63 files changed, 310 insertions(+), 141 deletions(-)
We are seeing systemd hang on its autofs direct mount at
/proc/sys/fs/binfmt_misc.
Historically this was due to a mismatch in the communication structure
size between a 64 bit kernel and a 32 bit user space and was fixed by
making the pipe communication record oriented.
During autofs v5 development I decided to stay with the existing usage
instead of changing to a packed structure for autofs <=> user space
communications which turned out to be a mistake on my part.
Problems arose and they were fixed by allowing for the 64 bit to 32
bit size difference in the automount(8) code.
Along the way systemd started to use autofs and eventually encountered
this problem too. systemd refused to compensate for the length
difference insisting it be fixed in the kernel. Fortunately Linus
implemented the packetized pipe which resolved the problem in a
straight forward and simple way.
In the autofs mount api conversion series I inadvertatly dropped the
packet pipe flag settings when adding the autofs_parse_fd() function.
This patch fixes that omission.
Fixes: 546694b8f658 ("autofs: add autofs_parse_fd()")
Signed-off-by: Ian Kent <raven(a)themaw.net>
Cc: Bill O'Donnell <bodonnel(a)redhat.com>
Cc: Christian Brauner <brauner(a)kernel.org>
Cc: Arnd Bergmann <arnd(a)arndb.de>
Cc: Dan Carpenter <dan.carpenter(a)linaro.org>
Cc: Anders Roxell <anders.roxell(a)linaro.org>
Cc: Naresh Kamboju <naresh.kamboju(a)linaro.org>
Cc: Stephen Rothwell <sfr(a)canb.auug.org.au>
Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
Reported-by: Anders Roxell <anders.roxell(a)linaro.org>
---
fs/autofs/autofs_i.h | 13 +++++++++----
fs/autofs/inode.c | 2 ++
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/fs/autofs/autofs_i.h b/fs/autofs/autofs_i.h
index 244f18cdf23c..8c1d587b3eef 100644
--- a/fs/autofs/autofs_i.h
+++ b/fs/autofs/autofs_i.h
@@ -221,15 +221,20 @@ static inline int autofs_check_pipe(struct file *pipe)
return 0;
}
-static inline int autofs_prepare_pipe(struct file *pipe)
+static inline void autofs_set_packet_pipe_flags(struct file *pipe)
{
- int ret = autofs_check_pipe(pipe);
- if (ret < 0)
- return ret;
/* We want a packet pipe */
pipe->f_flags |= O_DIRECT;
/* We don't expect -EAGAIN */
pipe->f_flags &= ~O_NONBLOCK;
+}
+
+static inline int autofs_prepare_pipe(struct file *pipe)
+{
+ int ret = autofs_check_pipe(pipe);
+ if (ret < 0)
+ return ret;
+ autofs_set_packet_pipe_flags(pipe);
return 0;
}
diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c
index 6d2e01c9057d..a3d62acc293a 100644
--- a/fs/autofs/inode.c
+++ b/fs/autofs/inode.c
@@ -177,6 +177,8 @@ static int autofs_parse_fd(struct fs_context *fc, struct autofs_sb_info *sbi,
return -EBADF;
}
+ autofs_set_packet_pipe_flags(pipe);
+
if (sbi->pipe)
fput(sbi->pipe);
--
2.41.0