Total jobs: 281
Total errors: 101 (35.94%)
LAVA errors: 1 (0.36%)
Test errors: 73 (25.98%)
Job errors: 19 (6.76%)
Infra errors: 3 (1.07%)
Canceled jobs: 5 (1.78%)
Device type: sm8550-hdk
Total jobs: 19
Total errors: 19 (100.00%)
Error type: Job
Error count: 19 (100.00%)
Error: No match for error type 'Job', message 'login-action timed out after 875 seconds'
Count: 8 (42.11%)
IDs:
sm8550-hdk-01:
8015974 8015975 8015984 8016008 8016034
8017224 8017227 8017414
Error: wait for prompt timed out
Count: 5 (26.32%)
IDs:
sm8550-hdk-01:
8015983 8016023 8016324 8017223 8017402
Error: No match for error type 'Job', message 'login-action timed out after 868 seconds'
Count: 1 (5.26%)
IDs:
sm8550-hdk-01:
8017399
Error: No match for error type 'Job', message 'login-action timed out after 861 seconds'
Count: 1 (5.26%)
IDs:
sm8550-hdk-01:
8017226
Error: No match for error type 'Job', message 'login-action timed out after 860 seconds'
Count: 1 (5.26%)
IDs:
sm8550-hdk-01:
8017225
Error: No match for error type 'Job', message 'login-action timed out after 874 seconds'
Count: 2 (10.53%)
IDs:
sm8550-hdk-01:
8016004 8016022
Error: No match for error type 'Job', message 'login-action timed out after 851 seconds'
Count: 1 (5.26%)
IDs:
sm8550-hdk-01:
8016021
Device type: qrb5165-rb5
Total jobs: 78
Total errors: 17 (21.79%)
Error type: Test
Error count: 12 (15.38%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 1 (1.28%)
IDs:
rb5-05:
8017408
Error: Device NOT found!
Count: 1 (1.28%)
IDs:
rb5-03:
8017353
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 590 seconds'
Count: 1 (1.28%)
IDs:
rb5-03:
8017173
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 587 seconds'
Count: 1 (1.28%)
IDs:
rb5-07:
8016373
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 297 seconds'
Count: 1 (1.28%)
IDs:
rb5-03:
8016369
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 4 (5.13%)
IDs:
rb5-03:
8016340 8016343 8016356 8016367
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 1 (1.28%)
IDs:
rb5-06:
8015982
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 597 seconds'
Count: 1 (1.28%)
IDs:
rb5-03:
8015968
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 1 (1.28%)
IDs:
rb5-03:
8015920
Error type: Infrastructure
Error count: 2 (2.56%)
Error: Connection closed
Count: 1 (1.28%)
IDs:
rb5-05:
8016436
Error: No match for error type 'Infrastructure', message 'Unable to run: ['docker', 'exec', 'lava-8015998-3.1-63c4cc77-7251-45ac-a948-b6ee68e2f18e', 'fastboot', '-s', 'f11b68eb', 'oem', 'select-display-panel', 'hdmi']'
Count: 1 (1.28%)
IDs:
rb5-05:
8015998
Error type: Canceled
Error count: 2 (2.56%)
Error: The job was canceled
Count: 2 (2.56%)
IDs:
rb5-06:
8016001 8016017
Error type: Bug
Error count: 1 (1.28%)
Error: No match for error type 'Bug', message 'Failed to share device '/dev/bus/usb/002/033' to docker container lava-8015995-3.1-869b7f70-7ed4-4d42-85f8-ca9bb226c356'
Count: 1 (1.28%)
IDs:
rb5-05:
8015995
Device type: hi6220-hikey-r2
Total jobs: 71
Total errors: 47 (66.20%)
Error type: Test
Error count: 47 (66.20%)
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 36 (50.70%)
IDs:
hikey-6220-r2-01:
8016722 8016728 8016730 8016731 8016735
8016736 8016738 8017041 8017049 8017059
8017063 8017080 8017403 8017405
hikey-6220-r2-05:
8016737 8016743 8016746 8016748 8016749
8016750 8016752 8016755 8016757 8016785
8016786 8016801 8017043 8017050 8017062
8017067 8017086 8017087 8017367 8017372
8017379 8017383
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 597 seconds'
Count: 1 (1.41%)
IDs:
hikey-6220-r2-06:
8017375
Error: No match for error type 'Test', message 'tradefed - adb device lost[7B1579B5003E507A]'
Count: 3 (4.23%)
IDs:
hikey-6220-r2-05:
8016726 8017070 8017374
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 1 (1.41%)
IDs:
hikey-6220-r2-03:
8017363
Error: No match for error type 'Test', message 'tradefed - adb device lost[4595FE84003F72FC]'
Count: 2 (2.82%)
IDs:
hikey-6220-r2-04:
8016800 8016804
Error: Device NOT found!
Count: 2 (2.82%)
IDs:
hikey-6220-r2-03:
8016751
hikey-6220-r2-04:
8016803
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 586 seconds'
Count: 1 (1.41%)
IDs:
hikey-6220-r2-01:
8016733
Error: No match for error type 'Test', message 'tradefed - adb device lost[191FC75C003312EE]'
Count: 1 (1.41%)
IDs:
hikey-6220-r2-06:
8016723
Device type: dragonboard-845c
Total jobs: 101
Total errors: 18 (17.82%)
Error type: Test
Error count: 14 (13.86%)
Error: Device NOT found!
Count: 4 (3.96%)
IDs:
db845c-09:
8015810 8016350 8017079 8017167
Error: No match for error type 'Test', message 'tradefed - adb device lost[d966d3f5]'
Count: 1 (0.99%)
IDs:
db845c-03:
8016401
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 298 seconds'
Count: 2 (1.98%)
IDs:
db845c-01:
8015934
db845c-07:
8016393
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 4 (3.96%)
IDs:
db845c-09:
8015842 8015846 8015867 8016376
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 294 seconds'
Count: 1 (0.99%)
IDs:
db845c-07:
8015935
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 296 seconds'
Count: 1 (0.99%)
IDs:
db845c-03:
8015897
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 595 seconds'
Count: 1 (0.99%)
IDs:
db845c-09:
8015816
Error type: Infrastructure
Error count: 1 (0.99%)
Error: fastboot-flash-action timed out
Count: 1 (0.99%)
IDs:
db845c-07:
8016336
Error type: Canceled
Error count: 3 (2.97%)
Error: The job was canceled
Count: 3 (2.97%)
IDs:
db845c-03:
8015994
db845c-07:
8015997
db845c-09:
8016000
Device type: hi960-hikey
Total jobs: 11
Total errors: 0 (0.00%)
Device type: rk3399-rock-pi-4b
Total jobs: 1
Total errors: 0 (0.00%)
Tejun probably reads everything to linux-block, but let's CC him explicitly.
block/blk-iocost.c
2222 TRACE_IOCG_PATH(iocg_idle, iocg, now,
2223 atomic64_read(&iocg->active_period),
2224 atomic64_read(&ioc->cur_period), vtime);
2225 __propagate_weights(iocg, 0, 0, false, now);
^
Why is "active" zero? __propagate_weights() does a clamp() to 1 as minimum and
we've added new build time asserts so this breaks the build.
2226 list_del_init(&iocg->active_list);
The other way to solve this would be to something stupid like:
diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index 384aa15e8260..551edd2f661f 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -1094,7 +1094,7 @@ static void __propagate_weights(struct ioc_gq *iocg, u32 active, u32 inuse,
* @active. An active internal node's inuse is solely determined by the
* inuse to active ratio of its children regardless of @inuse.
*/
- if (list_empty(&iocg->active_list) && iocg->child_active_sum) {
+ if ((list_empty(&iocg->active_list) && iocg->child_active_sum) || active == 0) {
inuse = DIV64_U64_ROUND_UP(active * iocg->child_inuse_sum,
iocg->child_active_sum);
} else {
But that seems really stupid.
regards,
dan carpenter
On Wed, Dec 04, 2024 at 04:11:33PM +0000, David Laight wrote:
> From: Dan Carpenter <dan.carpenter(a)linaro.org>
> > Sent: 04 December 2024 14:39
> >
> > Let's add David to the Cc list because he's the expert on clamp().
>
> The traceback info misses the important point.
> I can't see the 'inlined from line 2225' message.
>
> We have (line 1084):
> static void __propagate_weights(struct ioc_gq *iocg, u32 active, u32 inuse,
> bool save, struct ioc_now *now)
> followed by:
> inuse = clamp_t(u32, inuse, 1, active);
>
> But line 2225 has:
> __propagate_weights(iocg, 0, 0, false, now);
>
> With aggressive inlining the compiler sees 'active == 0'
> and the lo > hi test correctly triggers.
>
> The previous version only verified 'lo <= hi' if it was a constant
> integer expression - which it isn't here.
>
> No idea what the code is trying to do, nor what value it expects
> clamp(val, 1, 0) to generate - likely to be 0 or 1 depending on
> the order of the comparisons.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)