On Mon, 04 Mar 2024, Thomas Zimmermann tzimmermann@suse.de wrote:
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the backlight header has recently been removed from <linux/fb.h>.
Reported-by: Naresh Kamboju naresh.kamboju@linaro.org Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFX... Signed-off-by: Thomas Zimmermann tzimmermann@suse.de Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") Cc: Thomas Zimmermann tzimmermann@suse.de Cc: Jani Nikula jani.nikula@intel.com Cc: Helge Deller deller@gmx.de Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org
I would've added the include in arch/powerpc/include/asm/backlight.h [1], but either way is fine by me.
Reviewed-by: Jani Nikula jani.nikula@intel.com
[1] https://lore.kernel.org/r/20240304095512.742348-1-jani.nikula@intel.com
drivers/video/fbdev/chipsfb.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c index b80711f13df8a..b16a905588fed 100644 --- a/drivers/video/fbdev/chipsfb.c +++ b/drivers/video/fbdev/chipsfb.c @@ -15,6 +15,7 @@ */ #include <linux/aperture.h> +#include <linux/backlight.h> #include <linux/module.h> #include <linux/kernel.h> #include <linux/errno.h>