On Mon, 17 Oct 2022 at 21:22, Serge Semin fancer.lancer@gmail.com wrote:
On Mon, Oct 17, 2022 at 09:43:24AM +0200, Anders Roxell wrote:
On Fri, 14 Oct 2022 at 16:06, Serge Semin Sergey.Semin@baikalelectronics.ru wrote:
On Fri, Oct 14, 2022 at 11:22:38AM +0200, Anders Roxell wrote:
On Fri, 14 Oct 2022 at 09:53, Damien Le Moal damien.lemoal@opensource.wdc.com wrote:
On 10/14/22 16:31, Arnd Bergmann wrote:
On Fri, Oct 14, 2022, at 2:22 AM, Damien Le Moal wrote: > On 10/14/22 07:07, Anders Roxell wrote: > [...] >>> 8) >>>> If reverting these patches restores the eSATA port on this board, then you need >>>> to fix the defconfig for that board. >>> >>> OTOH, >>> Anders, enabled the new config CONFIG_AHCI_DWC=y and tried but the >>> device failed to boot. >> >> I thought it would work with enabling CONFIG_AHCI_DWC=y, but it didn't... > > As mentioned in my previous reply to Naresh, this is a new driver added in > 6.1. Your board was working before so this should not be the driver needed > for it. > >> However, reverting patch 33629d35090f ("ata: ahci: Add DWC AHCI SATA >> controller support") >> from next-20221013 was a success, kernel booted and the 'mkfs.ext4' cmd was >> successful. > > Which is very strange... There is only one hunk in that commit that could > be considered suspicious: > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > index 9b56490ecbc3..8f5572a9f8f1 100644 > --- a/drivers/ata/ahci_platform.c > +++ b/drivers/ata/ahci_platform.c > @@ -80,9 +80,7 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_suspend, > static const struct of_device_id ahci_of_match[] = { > { .compatible = "generic-ahci", }, > /* Keep the following compatibles for device tree compatibility */ > - { .compatible = "snps,spear-ahci", }, > { .compatible = "ibm,476gtr-ahci", }, > - { .compatible = "snps,dwc-ahci", }, > { .compatible = "hisilicon,hisi-ahci", }, > { .compatible = "cavium,octeon-7130-ahci", }, > { /* sentinel */ } > > Is your board using one of these compatible string ?
The x15 uses "snps,dwc-ahci". I would expect it to detect the device with the new driver if that is loaded, but it's possible that the driver does not work on all versions of the dwc-ahci hardware.
Anders, can you provide the boot log from a boot with the new driver built in? There should be some messages from dwc-ahci about finding the device, but then not ultimately working.
Depending on which way it goes wrong, the safest fallback for 6.1 is probably to move the "snps,spear-ahci" and "snps,dwc-ahci" compatible strings back into the old driver, and leave the new one only for the "baikal,bt1-ahci" implementation of it, until it has been successfully verified on TI am5/dra7, spear13xx and exynos.
OK. So a fix patch until further tests/debug is completed would be this:
diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c index 8fb66860db31..7a0cbab00843 100644 --- a/drivers/ata/ahci_dwc.c +++ b/drivers/ata/ahci_dwc.c @@ -469,8 +469,6 @@ static struct ahci_dwc_plat_data ahci_bt1_plat = { };
static const struct of_device_id ahci_dwc_of_match[] = {
{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },{ .compatible = "snps,spear-ahci", &ahci_dwc_plat }, { .compatible = "baikal,bt1-ahci", &ahci_bt1_plat }, {},}; diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index 8f5572a9f8f1..9b56490ecbc3 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c @@ -80,7 +80,9 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_suspend, static const struct of_device_id ahci_of_match[] = { { .compatible = "generic-ahci", }, /* Keep the following compatibles for device tree compatibility */
{ .compatible = "snps,spear-ahci", }, { .compatible = "ibm,476gtr-ahci", },{ .compatible = "snps,dwc-ahci", }, { .compatible = "hisilicon,hisi-ahci", }, { .compatible = "cavium,octeon-7130-ahci", }, { /* sentinel */ }
FYI,
We have been noticing this problem [a] & [b] on Linux mainline master 6.1.0-rc7
Test error: mkfs.ext4 /dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190702A00D84 failed; job exit
Please suggest a way forward on this reported issue on arm32 TI BeagleBoard X15 device. Build and Kernel configs details provided in the metadata section.
metadata: git_ref: master git_repo: https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline git_sha: b7b275e60bcd5f89771e865a8239325f86d9927d git_describe: v6.1-rc7 kernel_version: 6.1.0-rc7 kernel-config: https://builds.tuxbuild.com/2I9I42JhhQqS9GOpFppfRiuqtRW/config build-url: https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline/-/pipelines/7... artifact-location: https://builds.tuxbuild.com/2I9I42JhhQqS9GOpFppfRiuqtRW toolchain: gcc-10
[a] https://lkft.validation.linaro.org/scheduler/job/5892099 [b] https://lore.kernel.org/all/20221017155246.zxal2cfehjgaajcu@mobilestation/
- Naresh