This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.234-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.19.234-rc1
Emmanuel Gil Peyrot linkmauve@linkmauve.fr ARM: fix build error when BPF_SYSCALL is disabled
Russell King (Oracle) rmk+kernel@armlinux.org.uk ARM: include unprivileged BPF status in Spectre V2 reporting
Russell King (Oracle) rmk+kernel@armlinux.org.uk ARM: Spectre-BHB workaround
Russell King (Oracle) rmk+kernel@armlinux.org.uk ARM: use LOADADDR() to get load address of sections
Russell King (Oracle) rmk+kernel@armlinux.org.uk ARM: early traps initialisation
Russell King (Oracle) rmk+kernel@armlinux.org.uk ARM: report Spectre v2 status through sysfs
Mark Rutland mark.rutland@arm.com arm/arm64: smccc/psci: add arm_smccc_1_1_get_conduit()
Steven Price steven.price@arm.com arm/arm64: Provide a wrapper for SMCCC 1.1 calls
Josh Poimboeuf jpoimboe@redhat.com x86/speculation: Warn about eIBRS + LFENCE + Unprivileged eBPF + SMT
Josh Poimboeuf jpoimboe@redhat.com x86/speculation: Warn about Spectre v2 LFENCE mitigation
Kim Phillips kim.phillips@amd.com x86/speculation: Update link to AMD speculation whitepaper
Kim Phillips kim.phillips@amd.com x86/speculation: Use generic retpoline by default on AMD
Josh Poimboeuf jpoimboe@redhat.com x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting
Peter Zijlstra peterz@infradead.org Documentation/hw-vuln: Update spectre doc
Peter Zijlstra peterz@infradead.org x86/speculation: Add eIBRS + Retpoline options
Peter Zijlstra (Intel) peterz@infradead.org x86/speculation: Rename RETPOLINE_AMD to RETPOLINE_LFENCE
Peter Zijlstra peterz@infradead.org x86,bugs: Unconditionally allow spectre_v2=retpoline,amd
Borislav Petkov bp@suse.de x86/speculation: Merge one test in spectre_v2_user_select_mitigation()
-------------
Diffstat:
Documentation/admin-guide/hw-vuln/spectre.rst | 48 ++++-- Documentation/admin-guide/kernel-parameters.txt | 8 +- Makefile | 4 +- arch/arm/include/asm/assembler.h | 10 ++ arch/arm/include/asm/spectre.h | 32 ++++ arch/arm/kernel/Makefile | 2 + arch/arm/kernel/entry-armv.S | 79 ++++++++- arch/arm/kernel/entry-common.S | 24 +++ arch/arm/kernel/spectre.c | 71 ++++++++ arch/arm/kernel/traps.c | 65 ++++++- arch/arm/kernel/vmlinux.lds.h | 35 +++- arch/arm/mm/Kconfig | 11 ++ arch/arm/mm/proc-v7-bugs.c | 200 +++++++++++++++++++--- arch/x86/include/asm/cpufeatures.h | 2 +- arch/x86/include/asm/nospec-branch.h | 16 +- arch/x86/kernel/cpu/bugs.c | 214 +++++++++++++++++------- drivers/firmware/psci.c | 15 ++ include/linux/arm-smccc.h | 74 ++++++++ include/linux/bpf.h | 11 ++ kernel/sysctl.c | 8 + tools/arch/x86/include/asm/cpufeatures.h | 2 +- 21 files changed, 796 insertions(+), 135 deletions(-)
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
On Wed, Mar 9, 2022 at 6:08 PM Sudip Mukherjee sudipm.mukherjee@gmail.com wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
And, lots of failures in arm builds also. Error: arch/arm/common/secure_cntvoff.S: Assembler messages: arch/arm/common/secure_cntvoff.S:24: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:27: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:29: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/common/secure_cntvoff.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/kernel/entry-common.S: Assembler messages: arch/arm/kernel/entry-common.S:178: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/kernel/entry-common.S:187: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/kernel/entry-common.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/mm/cache-v7.S: Assembler messages: arch/arm/mm/cache-v7.S:64: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:137: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:171: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:299: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/mm/cache-v7.o] Error 1
On Wed, Mar 09, 2022 at 06:15:08PM +0000, Sudip Mukherjee wrote:
On Wed, Mar 9, 2022 at 6:08 PM Sudip Mukherjee sudipm.mukherjee@gmail.com wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
And, lots of failures in arm builds also. Error: arch/arm/common/secure_cntvoff.S: Assembler messages: arch/arm/common/secure_cntvoff.S:24: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:27: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:29: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/common/secure_cntvoff.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/kernel/entry-common.S: Assembler messages: arch/arm/kernel/entry-common.S:178: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/kernel/entry-common.S:187: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/kernel/entry-common.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/mm/cache-v7.S: Assembler messages: arch/arm/mm/cache-v7.S:64: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:137: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:171: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:299: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/mm/cache-v7.o] Error 1
All clang builds for arm are known to fail, and some arm64 clang builds will also fail. I have seen initial patches for arm64, will let the clang developers come up with the arm fix as I have no idea how to handle that. This just mirrors Linus's tree right now :)
Unless this is gcc?
thanks,
greg k-h
On Thu, Mar 10, 2022 at 9:18 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Wed, Mar 09, 2022 at 06:15:08PM +0000, Sudip Mukherjee wrote:
On Wed, Mar 9, 2022 at 6:08 PM Sudip Mukherjee sudipm.mukherjee@gmail.com wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
And, lots of failures in arm builds also. Error: arch/arm/common/secure_cntvoff.S: Assembler messages: arch/arm/common/secure_cntvoff.S:24: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:27: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:29: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/common/secure_cntvoff.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/kernel/entry-common.S: Assembler messages: arch/arm/kernel/entry-common.S:178: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/kernel/entry-common.S:187: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/kernel/entry-common.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/mm/cache-v7.S: Assembler messages: arch/arm/mm/cache-v7.S:64: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:137: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:171: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:299: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/mm/cache-v7.o] Error 1
All clang builds for arm are known to fail, and some arm64 clang builds will also fail. I have seen initial patches for arm64, will let the clang developers come up with the arm fix as I have no idea how to handle that. This just mirrors Linus's tree right now :)
Unless this is gcc?
This is gcc version 11.2.1 20220301
Guenter has also reported the same: "Almost all arm builds, all branches from 4.9.y to 5.16.y:"
-- Regards Sudip
On Thu, Mar 10, 2022 at 09:41:18AM +0000, Sudip Mukherjee wrote:
On Thu, Mar 10, 2022 at 9:18 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Wed, Mar 09, 2022 at 06:15:08PM +0000, Sudip Mukherjee wrote:
On Wed, Mar 9, 2022 at 6:08 PM Sudip Mukherjee sudipm.mukherjee@gmail.com wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
And, lots of failures in arm builds also. Error: arch/arm/common/secure_cntvoff.S: Assembler messages: arch/arm/common/secure_cntvoff.S:24: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:27: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/common/secure_cntvoff.S:29: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/common/secure_cntvoff.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/kernel/entry-common.S: Assembler messages: arch/arm/kernel/entry-common.S:178: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/kernel/entry-common.S:187: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/kernel/entry-common.o] Error 1 make[1]: *** Waiting for unfinished jobs.... arch/arm/mm/cache-v7.S: Assembler messages: arch/arm/mm/cache-v7.S:64: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:137: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:171: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' arch/arm/mm/cache-v7.S:299: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[1]: *** [scripts/Makefile.build:403: arch/arm/mm/cache-v7.o] Error 1
All clang builds for arm are known to fail, and some arm64 clang builds will also fail. I have seen initial patches for arm64, will let the clang developers come up with the arm fix as I have no idea how to handle that. This just mirrors Linus's tree right now :)
Unless this is gcc?
This is gcc version 11.2.1 20220301
Guenter has also reported the same: "Almost all arm builds, all branches from 4.9.y to 5.16.y:"
Sorry, my email was stalled yesterday. The fix for this should now be in the queue, I'm doing some more build testing right now before I'll release -rc2 for all branches.
thanks,
greg k-h
On Wed, Mar 09, 2022 at 06:08:19PM +0000, Sudip Mukherjee wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
It's in a .h file, how can it be undefined? Must be a include path somewhere, let me dig...
On Thu, Mar 10, 2022 at 9:18 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Wed, Mar 09, 2022 at 06:08:19PM +0000, Sudip Mukherjee wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
It's in a .h file, how can it be undefined? Must be a include path somewhere, let me dig...
Looks like the problem is that both "static inline bool unprivileged_ebpf_enabled(void)" are in the "#ifdef CONFIG_BPF_SYSCALL" section of include/linux/bpf.h. I think the one returning false should be in the #else section.
On Thu, Mar 10, 2022 at 09:51:12AM +0000, Sudip Mukherjee wrote:
On Thu, Mar 10, 2022 at 9:18 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Wed, Mar 09, 2022 at 06:08:19PM +0000, Sudip Mukherjee wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
It's in a .h file, how can it be undefined? Must be a include path somewhere, let me dig...
Looks like the problem is that both "static inline bool unprivileged_ebpf_enabled(void)" are in the "#ifdef CONFIG_BPF_SYSCALL" section of include/linux/bpf.h. I think the one returning false should be in the #else section.
Ah, good catch!
I've fixed this up for 4.19 and 5.4 now, will do some build tests and then push out new -rc2 release for all branches as I think that should be all of the reported problems fixed.
Now on to the next new round of build failures! :)
thanks,
greg k-h
On 3/9/22 10:08, Sudip Mukherjee wrote:
Hi Greg,
On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
My tests are still running, but just an initial result for you,
x86_64 defconfig fails with: arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
# bad: [be15501ac1fff96964cb8880d44736bd1653295b] Linux 4.19.234-rc1 # good: [c2ea16582cfb89c5e3457a680d018f165cfdc208] Linux 4.19.233 git bisect start 'HEAD' 'v4.19.233' # bad: [69a4715b821de4cf973df10a935a0e3bcada38f5] x86/speculation: Warn about Spectre v2 LFENCE mitigation git bisect bad 69a4715b821de4cf973df10a935a0e3bcada38f5 # good: [e2982efb00a54d8f5e682cbf68ef9844040b5811] x86/speculation: Add eIBRS + Retpoline options git bisect good e2982efb00a54d8f5e682cbf68ef9844040b5811 # bad: [b799f7ac596fff0c36321428de9fd7c9aa8c4008] x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting git bisect bad b799f7ac596fff0c36321428de9fd7c9aa8c4008 # good: [ba81977a470c874ce83bdc96f1749c6d36ccfefd] Documentation/hw-vuln: Update spectre doc git bisect good ba81977a470c874ce83bdc96f1749c6d36ccfefd # first bad commit: [b799f7ac596fff0c36321428de9fd7c9aa8c4008] x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting
Hello!
On 09/03/22 09:59, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.234-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Regressions found.
The following Arm combinations failed to build: - arm-gcc-8-bcm2835_defconfig - arm-gcc-8-imx_v6_v7_defconfig - arm-gcc-8-omap2plus_defconfig - arm-gcc-9-bcm2835_defconfig - arm-gcc-9-imx_v6_v7_defconfig - arm-gcc-9-omap2plus_defconfig - arm-gcc-10-bcm2835_defconfig - arm-gcc-10-imx_v6_v7_defconfig - arm-gcc-10-omap2plus_defconfig - arm-gcc-11-bcm2835_defconfig - arm-gcc-11-imx_v6_v7_defconfig - arm-gcc-11-omap2plus_defconfig - arm-clang-11-allnoconfig - arm-clang-11-at91_dt_defconfig - arm-clang-11-axm55xx_defconfig - arm-clang-11-clps711x_defconfig - arm-clang-11-davinci_all_defconfig - arm-clang-11-defconfig - arm-clang-11-exynos_defconfig - arm-clang-11-footbridge_defconfig - arm-clang-11-imx_v4_v5_defconfig - arm-clang-11-imx_v6_v7_defconfig - arm-clang-11-integrator_defconfig - arm-clang-11-ixp4xx_defconfig - arm-clang-11-keystone_defconfig - arm-clang-11-lpc32xx_defconfig - arm-clang-11-mini2440_defconfig - arm-clang-11-multi_v5_defconfig - arm-clang-11-mxs_defconfig - arm-clang-11-nhk8815_defconfig - arm-clang-11-omap1_defconfig - arm-clang-11-omap2plus_defconfig - arm-clang-11-orion5x_defconfig - arm-clang-11-pxa910_defconfig - arm-clang-11-s3c2410_defconfig - arm-clang-11-s3c6400_defconfig - arm-clang-11-s5pv210_defconfig - arm-clang-11-sama5_defconfig - arm-clang-11-shmobile_defconfig - arm-clang-11-tinyconfig - arm-clang-11-u8500_defconfig - arm-clang-11-vexpress_defconfig - arm-clang-12-allnoconfig - arm-clang-12-at91_dt_defconfig - arm-clang-12-axm55xx_defconfig - arm-clang-12-clps711x_defconfig - arm-clang-12-davinci_all_defconfig - arm-clang-12-defconfig - arm-clang-12-exynos_defconfig - arm-clang-12-footbridge_defconfig - arm-clang-12-imx_v4_v5_defconfig - arm-clang-12-imx_v6_v7_defconfig - arm-clang-12-integrator_defconfig - arm-clang-12-ixp4xx_defconfig - arm-clang-12-keystone_defconfig - arm-clang-12-lpc32xx_defconfig - arm-clang-12-mini2440_defconfig - arm-clang-12-multi_v5_defconfig - arm-clang-12-mxs_defconfig - arm-clang-12-nhk8815_defconfig - arm-clang-12-omap1_defconfig - arm-clang-12-omap2plus_defconfig - arm-clang-12-orion5x_defconfig - arm-clang-12-pxa910_defconfig - arm-clang-12-s3c2410_defconfig - arm-clang-12-s3c6400_defconfig - arm-clang-12-s5pv210_defconfig - arm-clang-12-sama5_defconfig - arm-clang-12-shmobile_defconfig - arm-clang-12-tinyconfig - arm-clang-12-u8500_defconfig - arm-clang-12-vexpress_defconfig - arm-clang-13-allnoconfig - arm-clang-13-at91_dt_defconfig - arm-clang-13-axm55xx_defconfig - arm-clang-13-clps711x_defconfig - arm-clang-13-davinci_all_defconfig - arm-clang-13-defconfig - arm-clang-13-exynos_defconfig - arm-clang-13-footbridge_defconfig - arm-clang-13-imx_v4_v5_defconfig - arm-clang-13-imx_v6_v7_defconfig - arm-clang-13-integrator_defconfig - arm-clang-13-ixp4xx_defconfig - arm-clang-13-keystone_defconfig - arm-clang-13-lpc32xx_defconfig - arm-clang-13-mini2440_defconfig - arm-clang-13-multi_v5_defconfig - arm-clang-13-mxs_defconfig - arm-clang-13-nhk8815_defconfig - arm-clang-13-omap1_defconfig - arm-clang-13-omap2plus_defconfig - arm-clang-13-orion5x_defconfig - arm-clang-13-pxa910_defconfig - arm-clang-13-s3c2410_defconfig - arm-clang-13-s3c6400_defconfig - arm-clang-13-s5pv210_defconfig - arm-clang-13-sama5_defconfig - arm-clang-13-shmobile_defconfig - arm-clang-13-tinyconfig - arm-clang-13-u8500_defconfig - arm-clang-13-vexpress_defconfig - arm-clang-14-allnoconfig - arm-clang-14-at91_dt_defconfig - arm-clang-14-axm55xx_defconfig - arm-clang-14-bcm2835_defconfig - arm-clang-14-clps711x_defconfig - arm-clang-14-davinci_all_defconfig - arm-clang-14-defconfig - arm-clang-14-exynos_defconfig - arm-clang-14-footbridge_defconfig - arm-clang-14-imx_v4_v5_defconfig - arm-clang-14-imx_v6_v7_defconfig - arm-clang-14-integrator_defconfig - arm-clang-14-ixp4xx_defconfig - arm-clang-14-keystone_defconfig - arm-clang-14-lpc32xx_defconfig - arm-clang-14-mini2440_defconfig - arm-clang-14-multi_v5_defconfig - arm-clang-14-mxs_defconfig - arm-clang-14-nhk8815_defconfig - arm-clang-14-omap1_defconfig - arm-clang-14-omap2plus_defconfig - arm-clang-14-orion5x_defconfig - arm-clang-14-pxa910_defconfig - arm-clang-14-s3c2410_defconfig - arm-clang-14-s3c6400_defconfig - arm-clang-14-s5pv210_defconfig - arm-clang-14-sama5_defconfig - arm-clang-14-shmobile_defconfig - arm-clang-14-tinyconfig - arm-clang-14-u8500_defconfig - arm-clang-14-vexpress_defconfig - arm-clang-nightly-allnoconfig - arm-clang-nightly-at91_dt_defconfig - arm-clang-nightly-axm55xx_defconfig - arm-clang-nightly-clps711x_defconfig - arm-clang-nightly-davinci_all_defconfig - arm-clang-nightly-defconfig - arm-clang-nightly-exynos_defconfig - arm-clang-nightly-footbridge_defconfig - arm-clang-nightly-imx_v4_v5_defconfig - arm-clang-nightly-imx_v6_v7_defconfig - arm-clang-nightly-integrator_defconfig - arm-clang-nightly-ixp4xx_defconfig - arm-clang-nightly-keystone_defconfig - arm-clang-nightly-lpc32xx_defconfig - arm-clang-nightly-mini2440_defconfig - arm-clang-nightly-multi_v5_defconfig - arm-clang-nightly-mxs_defconfig - arm-clang-nightly-nhk8815_defconfig - arm-clang-nightly-omap1_defconfig - arm-clang-nightly-omap2plus_defconfig - arm-clang-nightly-orion5x_defconfig - arm-clang-nightly-pxa910_defconfig - arm-clang-nightly-s3c2410_defconfig - arm-clang-nightly-s3c6400_defconfig - arm-clang-nightly-s5pv210_defconfig - arm-clang-nightly-sama5_defconfig - arm-clang-nightly-shmobile_defconfig - arm-clang-nightly-tinyconfig - arm-clang-nightly-u8500_defconfig - arm-clang-nightly-vexpress_defconfig
The Clang failures look like this (here's lpc32xx_defconfig with clang-11):
ld.lld: error: ./arch/arm/kernel/vmlinux.lds:98: AT expected, but got NOCROSSREFS
__vectors_lma = .; OVERLAY 0xffff0000 : NOCROSSREFS AT(__vectors_lma) { .vectors { *(.vectors) } .vectors.bhb.loop8 { *(.vectors.bhb.loop8) } .vectors.bhb.bpiall { *(.vectors.bhb.bpiall) } } __vectors_start = LOADADDR(.vectors); __vectors_end = LOADADDR(.vectors) + SIZEOF(.vectors); __vectors_bhb_loop8_start = LOADADDR(.vectors.bhb.loop8); __vectors_bhb_loop8_end = LOADADDR(.vectors.bhb.loop8) + SIZEOF(.vectors.bhb.loop8); __vectors_bhb_bpiall_start = LOADADDR(.vectors.bhb.bpiall); __vectors_bhb_bpiall_end = LOADADDR(.vectors.bhb.bpiall) + SIZEOF(.vectors.bhb.bpiall); . = __vectors_lma + SIZEOF(.vectors) + SIZEOF(.vectors.bhb.loop8) + SIZEOF(.vectors.bhb.bpiall); __stubs_lma = .; .stubs ADDR(.vectors) + 0x1000 : AT(__stubs_lma) { *(.stubs) } __stubs_start = LOADADDR(.stubs); __stubs_end = LOADADDR(.stubs) + SIZEOF(.stubs); . = __stubs_lma + SIZEOF(.stubs); PROVIDE(vector_fiq_offset = vector_fiq - ADDR(.vectors)); ^
make[1]: *** [/builds/linux/Makefile:1050: vmlinux] Error 1
A GCC failure (bcm2835_defconfig with gcc-9):
/builds/linux/arch/arm/kernel/entry-common.S: Assembler messages: /builds/linux/arch/arm/kernel/entry-common.S:178: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/kernel/entry-common.S:187: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/kernel/entry-common.o] Error 1 /builds/linux/arch/arm/common/secure_cntvoff.S: Assembler messages: /builds/linux/arch/arm/common/secure_cntvoff.S:24: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/common/secure_cntvoff.S:27: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/common/secure_cntvoff.S:29: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/common/secure_cntvoff.o] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [/builds/linux/Makefile:1070: arch/arm/common] Error 2 /builds/linux/arch/arm/kernel/entry-armv.S: Assembler messages: /builds/linux/arch/arm/kernel/entry-armv.S:1117: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/kernel/entry-armv.S:1140: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/kernel/entry-armv.S:1163: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/kernel/entry-armv.S:1186: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/kernel/entry-armv.S:1225: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/kernel/entry-armv.o] Error 1 /builds/linux/arch/arm/mm/cache-v7.S: Assembler messages: /builds/linux/arch/arm/mm/cache-v7.S:64: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/mm/cache-v7.S:137: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/mm/cache-v7.S:171: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/mm/cache-v7.S:299: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/mm/cache-v7.o] Error 1 /builds/linux/arch/arm/mm/tlb-v7.S: Assembler messages: /builds/linux/arch/arm/mm/tlb-v7.S:88: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/mm/tlb-v7.o] Error 1 /builds/linux/arch/arm/mm/proc-v7-2level.S: Assembler messages: /builds/linux/arch/arm/mm/proc-v7-2level.S:58: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/mm/proc-v7-2level.S:60: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' /builds/linux/arch/arm/mm/proc-v7.S:62: Error: co-processor register expected -- `mcr p15,0,r0,c7,r5,4' make[2]: *** [/builds/linux/scripts/Makefile.build:403: arch/arm/mm/proc-v7.o] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [/builds/linux/Makefile:1070: arch/arm/mm] Error 2
The following x86_64/i386 combinations failed to build: - i386-gcc-8-allnoconfig - i386-gcc-8-i386_defconfig - i386-gcc-8-tinyconfig - i386-gcc-9-allnoconfig - i386-gcc-9-i386_defconfig - i386-gcc-9-tinyconfig - i386-gcc-10-allnoconfig - i386-gcc-10-defconfig - i386-gcc-10-tinyconfig - i386-gcc-11-allnoconfig - i386-gcc-11-defconfig - i386-gcc-11-tinyconfig - x86_64-gcc-8-allnoconfig - x86_64-gcc-8-tinyconfig - x86_64-gcc-8-x86_64_defconfig - x86_64-gcc-9-allnoconfig - x86_64-gcc-9-tinyconfig - x86_64-gcc-9-x86_64_defconfig - x86_64-gcc-10-allnoconfig - x86_64-gcc-10-defconfig - x86_64-gcc-10-tinyconfig - x86_64-gcc-11-allnoconfig - x86_64-gcc-11-defconfig - x86_64-gcc-11-tinyconfig - x86_64-clang-11-allnoconfig - x86_64-clang-11-tinyconfig - x86_64-clang-11-x86_64_defconfig - x86_64-clang-12-allnoconfig - x86_64-clang-12-tinyconfig - x86_64-clang-12-x86_64_defconfig - x86_64-clang-13-allnoconfig - x86_64-clang-13-tinyconfig - x86_64-clang-13-x86_64_defconfig - x86_64-clang-14-allnoconfig - x86_64-clang-14-tinyconfig - x86_64-clang-14-x86_64_defconfig - x86_64-clang-nightly-allnoconfig - x86_64-clang-nightly-tinyconfig - x86_64-clang-nightly-x86_64_defconfig
An x86_64 failure (defconfig + LKFT sauce on gcc-11):
/builds/linux/arch/x86/entry/entry_64.S: Assembler messages: /builds/linux/arch/x86/entry/entry_64.S:1738: Warning: no instruction mnemonic suffix given and no register operands; using default for `sysret' /builds/linux/arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': /builds/linux/arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled()) | ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [/builds/linux/scripts/Makefile.build:303: arch/x86/kernel/cpu/bugs.o] Error 1 make[4]: Target '__build' not remade because of errors. make[3]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel/cpu] Error 2 make[3]: Target '__build' not remade because of errors. make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [/builds/linux/Makefile:1070: arch/x86] Error 2 /builds/linux/drivers/crypto/ccp/sp-platform.c:37:34: warning: array 'sp_of_match' assumed to have one element 37 | static const struct of_device_id sp_of_match[]; | ^~~~~~~~~~~ /builds/linux/drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_check_mst_status': /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: warning: 'drm_dp_channel_eq_ok' reading 6 bytes from a region of size 4 [-Wstringop-overread] 4129 | !drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: note: referencing argument 1 of type 'const u8 *' {aka 'const unsigned char *'} In file included from /builds/linux/drivers/gpu/drm/i915/intel_dp.c:39: /builds/linux/include/drm/drm_dp_helper.h:954:6: note: in a call to function 'drm_dp_channel_eq_ok' 954 | bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE], | ^~~~~~~~~~~~~~~~~~~~ make[1]: Target '_all' not remade because of errors. make: *** [Makefile:146: sub-make] Error 2
And a similar i386 failure (defconfig + LKFT sauce on gcc-11):
/builds/linux/arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation': /builds/linux/arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of function 'unprivileged_ebpf_enabled' [-Werror=implicit-function-declaration] 973 | if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled()) | ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [/builds/linux/scripts/Makefile.build:303: arch/x86/kernel/cpu/bugs.o] Error 1 make[4]: Target '__build' not remade because of errors. make[3]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel/cpu] Error 2 make[3]: Target '__build' not remade because of errors. make[2]: *** [/builds/linux/scripts/Makefile.build:544: arch/x86/kernel] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [/builds/linux/Makefile:1070: arch/x86] Error 2 /builds/linux/drivers/crypto/ccp/sp-platform.c:37:34: warning: array 'sp_of_match' assumed to have one element 37 | static const struct of_device_id sp_of_match[]; | ^~~~~~~~~~~ /builds/linux/drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_check_mst_status': /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: warning: 'drm_dp_channel_eq_ok' reading 6 bytes from a region of size 4 [-Wstringop-overread] 4129 | !drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /builds/linux/drivers/gpu/drm/i915/intel_dp.c:4129:30: note: referencing argument 1 of type 'const u8 *' {aka 'const unsigned char *'} In file included from /builds/linux/drivers/gpu/drm/i915/intel_dp.c:39: /builds/linux/include/drm/drm_dp_helper.h:954:6: note: in a call to function 'drm_dp_channel_eq_ok' 954 | bool drm_dp_channel_eq_ok(const u8 link_status[DP_LINK_STATUS_SIZE], | ^~~~~~~~~~~~~~~~~~~~ make[1]: Target '_all' not remade because of errors. make: *** [Makefile:146: sub-make] Error 2
Greetings!
Daniel Díaz daniel.diaz@linaro.org
On 3/9/22 8:59 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.234-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan skhan@linuxfoundation.org
thanks, -- Shuah
Hi!
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CIP testing is hitting same failures as everyone else:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4...
Best regards, Pavel
On 2022/3/9 23:59, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.234 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.234-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Tested on arm64 and x86 for 4.19.234-rc2,
Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.234-rc2 Commit: 7603caa5cc1196665ba06ded1f0a6f615eeaebf5 Compiler: gcc version 7.3.0 (GCC)
arm64: -------------------------------------------------------------------- Testcase Result Summary: total: 8938 passed: 8938 failed: 0 timeout: 0 --------------------------------------------------------------------
x86: -------------------------------------------------------------------- Testcase Result Summary: total: 8938 passed: 8938 failed: 0 timeout: 0 --------------------------------------------------------------------
Tested-by: Hulk Robot hulkrobot@huawei.com
-
Daniel Díaz -
Greg Kroah-Hartman -
Guenter Roeck -
Pavel Machek -
Samuel Zou -
Shuah Khan -
Sudip Mukherjee