Hello!

On 11/4/21 10:20 AM, Greg Kroah-Hartman wrote:

On Thu, Nov 04, 2021 at 09:53:57AM -0600, Daniel Díaz wrote:

...

Hello!

On 11/4/21 8:12 AM, Greg Kroah-Hartman wrote:

...

This is the start of the stable review cycle for the 5.10.78 release. There are 16 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 06 Nov 2021 14:11:51 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.78-rc1... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below.

thanks,

greg k-h

Regressions detected.

Build failures on all architectures and all toolchains (GCC 8, 9, 10, 11; Clang 10, 11, 12, 13, nightly):

• arc
• arm (32-bits)
• arm (64-bits)
• i386
• mips
• parisc
• ppc
• riscv
• s390
• sh
• sparc
• x86

Failures look like this:

In file included from /builds/linux/include/linux/kernel.h:11, from /builds/linux/include/linux/list.h:9, from /builds/linux/include/linux/smp.h:12, from /builds/linux/include/linux/kernel_stat.h:5, from /builds/linux/mm/memory.c:42: /builds/linux/mm/memory.c: In function 'finish_fault': /builds/linux/mm/memory.c:3929:15: error: implicit declaration of function 'PageHasHWPoisoned'; did you mean 'PageHWPoison'? [-Werror=implicit-function-declaration] 3929 | if (unlikely(PageHasHWPoisoned(page))) | ^~~~~~~~~~~~~~~~~ /builds/linux/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ cc1: some warnings being treated as errors

and this:

/builds/linux/mm/memory.c:3929:15: error: implicit declaration of function 'PageHasHWPoisoned' [-Werror,-Wimplicit-function-declaration] if (unlikely(PageHasHWPoisoned(page))) ^

/builds/linux/mm/page_alloc.c:1237:4: error: implicit declaration of function 'ClearPageHasHWPoisoned' [-Werror,-Wimplicit-function-declaration] ClearPageHasHWPoisoned(page); ^ /builds/linux/mm/page_alloc.c:1237:4: note: did you mean 'ClearPageHWPoison'?

What configuration? This builds for me on x86 here on allmodconfig.

Our main config also works, but defconfig, allnoconfig and tinyconfig all fail. That's across all architectures.

Here's a comprehensive list of failures:

* arc, build - gcc-8-allnoconfig - gcc-8-axs103_defconfig - gcc-8-defconfig - gcc-8-tinyconfig - gcc-8-vdk_hs38_smp_defconfig - gcc-9-allnoconfig - gcc-9-axs103_defconfig - gcc-9-defconfig - gcc-9-tinyconfig - gcc-9-vdk_hs38_smp_defconfig

* arm, build - clang-10-allnoconfig - clang-10-at91_dt_defconfig - clang-10-axm55xx_defconfig - clang-10-bcm2835_defconfig - clang-10-clps711x_defconfig - clang-10-davinci_all_defconfig - clang-10-defconfig - clang-10-exynos_defconfig - clang-10-footbridge_defconfig - clang-10-imx_v4_v5_defconfig - clang-10-imx_v6_v7_defconfig - clang-10-integrator_defconfig - clang-10-ixp4xx_defconfig - clang-10-keystone_defconfig - clang-10-lpc32xx_defconfig - clang-10-mini2440_defconfig - clang-10-multi_v5_defconfig - clang-10-mxs_defconfig - clang-10-nhk8815_defconfig - clang-10-omap1_defconfig - clang-10-omap2plus_defconfig - clang-10-orion5x_defconfig - clang-10-pxa910_defconfig - clang-10-s3c2410_defconfig - clang-10-s3c6400_defconfig - clang-10-s5pv210_defconfig - clang-10-sama5_defconfig - clang-10-shmobile_defconfig - clang-10-tinyconfig - clang-10-u8500_defconfig - clang-10-vexpress_defconfig - clang-11-allnoconfig - clang-11-at91_dt_defconfig - clang-11-axm55xx_defconfig - clang-11-bcm2835_defconfig - clang-11-clps711x_defconfig - clang-11-davinci_all_defconfig - clang-11-defconfig - clang-11-exynos_defconfig - clang-11-footbridge_defconfig - clang-11-imx_v4_v5_defconfig - clang-11-imx_v6_v7_defconfig - clang-11-integrator_defconfig - clang-11-ixp4xx_defconfig - clang-11-keystone_defconfig - clang-11-lpc32xx_defconfig - clang-11-mini2440_defconfig - clang-11-multi_v5_defconfig - clang-11-mxs_defconfig - clang-11-nhk8815_defconfig - clang-11-omap1_defconfig - clang-11-omap2plus_defconfig - clang-11-orion5x_defconfig - clang-11-pxa910_defconfig - clang-11-s3c2410_defconfig - clang-11-s3c6400_defconfig - clang-11-s5pv210_defconfig - clang-11-sama5_defconfig - clang-11-shmobile_defconfig - clang-11-tinyconfig - clang-11-u8500_defconfig - clang-11-vexpress_defconfig - clang-12-allnoconfig - clang-12-at91_dt_defconfig - clang-12-axm55xx_defconfig - clang-12-bcm2835_defconfig - clang-12-clps711x_defconfig - clang-12-davinci_all_defconfig - clang-12-defconfig - clang-12-defconfig-50bba0f5 - clang-12-exynos_defconfig - clang-12-footbridge_defconfig - clang-12-imx_v4_v5_defconfig - clang-12-imx_v6_v7_defconfig - clang-12-integrator_defconfig - clang-12-ixp4xx_defconfig - clang-12-keystone_defconfig - clang-12-lpc32xx_defconfig - clang-12-mini2440_defconfig - clang-12-multi_v5_defconfig - clang-12-mxs_defconfig - clang-12-nhk8815_defconfig - clang-12-omap1_defconfig - clang-12-omap2plus_defconfig - clang-12-orion5x_defconfig - clang-12-pxa910_defconfig - clang-12-s3c2410_defconfig - clang-12-s3c6400_defconfig - clang-12-s5pv210_defconfig - clang-12-sama5_defconfig - clang-12-shmobile_defconfig - clang-12-tinyconfig - clang-12-u8500_defconfig - clang-12-vexpress_defconfig - clang-13-allnoconfig - clang-13-at91_dt_defconfig - clang-13-axm55xx_defconfig - clang-13-bcm2835_defconfig - clang-13-clps711x_defconfig - clang-13-davinci_all_defconfig - clang-13-defconfig - clang-13-defconfig-50bba0f5 - clang-13-exynos_defconfig - clang-13-footbridge_defconfig - clang-13-imx_v4_v5_defconfig - clang-13-imx_v6_v7_defconfig - clang-13-integrator_defconfig - clang-13-ixp4xx_defconfig - clang-13-keystone_defconfig - clang-13-lpc32xx_defconfig - clang-13-mini2440_defconfig - clang-13-multi_v5_defconfig - clang-13-mxs_defconfig - clang-13-nhk8815_defconfig - clang-13-omap1_defconfig - clang-13-omap2plus_defconfig - clang-13-orion5x_defconfig - clang-13-pxa910_defconfig - clang-13-s3c2410_defconfig - clang-13-s3c6400_defconfig - clang-13-s5pv210_defconfig - clang-13-sama5_defconfig - clang-13-shmobile_defconfig - clang-13-tinyconfig - clang-13-u8500_defconfig - clang-13-vexpress_defconfig - clang-nightly-allnoconfig - clang-nightly-at91_dt_defconfig - clang-nightly-axm55xx_defconfig - clang-nightly-bcm2835_defconfig - clang-nightly-clps711x_defconfig - clang-nightly-davinci_all_defconfig - clang-nightly-defconfig - clang-nightly-defconfig-50bba0f5 - clang-nightly-exynos_defconfig - clang-nightly-footbridge_defconfig - clang-nightly-imx_v4_v5_defconfig - clang-nightly-imx_v6_v7_defconfig - clang-nightly-integrator_defconfig - clang-nightly-ixp4xx_defconfig - clang-nightly-keystone_defconfig - clang-nightly-lpc32xx_defconfig - clang-nightly-mini2440_defconfig - clang-nightly-multi_v5_defconfig - clang-nightly-mxs_defconfig - clang-nightly-nhk8815_defconfig - clang-nightly-omap1_defconfig - clang-nightly-omap2plus_defconfig - clang-nightly-orion5x_defconfig - clang-nightly-pxa910_defconfig - clang-nightly-s3c2410_defconfig - clang-nightly-s3c6400_defconfig - clang-nightly-s5pv210_defconfig - clang-nightly-sama5_defconfig - clang-nightly-shmobile_defconfig - clang-nightly-tinyconfig - clang-nightly-u8500_defconfig - clang-nightly-vexpress_defconfig - gcc-10-allnoconfig - gcc-10-at91_dt_defconfig - gcc-10-axm55xx_defconfig - gcc-10-bcm2835_defconfig - gcc-10-clps711x_defconfig - gcc-10-davinci_all_defconfig - gcc-10-defconfig - gcc-10-defconfig-493f0879 - gcc-10-defconfig-50bba0f5 - gcc-10-defconfig-5a3a4204 - gcc-10-defconfig-6830ede0 - gcc-10-defconfig-883c3502 - gcc-10-defconfig-a05dd807 - gcc-10-defconfig-c58d92d2 - gcc-10-defconfig-ced87bbf - gcc-10-exynos_defconfig - gcc-10-footbridge_defconfig - gcc-10-imx_v4_v5_defconfig - gcc-10-imx_v6_v7_defconfig - gcc-10-integrator_defconfig - gcc-10-ixp4xx_defconfig - gcc-10-keystone_defconfig - gcc-10-lpc32xx_defconfig - gcc-10-mini2440_defconfig - gcc-10-multi_v5_defconfig - gcc-10-mxs_defconfig - gcc-10-nhk8815_defconfig - gcc-10-omap1_defconfig - gcc-10-omap2plus_defconfig - gcc-10-orion5x_defconfig - gcc-10-pxa910_defconfig - gcc-10-s3c2410_defconfig - gcc-10-s3c6400_defconfig - gcc-10-s5pv210_defconfig - gcc-10-sama5_defconfig - gcc-10-shmobile_defconfig - gcc-10-tinyconfig - gcc-10-u8500_defconfig - gcc-10-vexpress_defconfig - gcc-11-allnoconfig - gcc-11-at91_dt_defconfig - gcc-11-axm55xx_defconfig - gcc-11-bcm2835_defconfig - gcc-11-clps711x_defconfig - gcc-11-davinci_all_defconfig - gcc-11-defconfig - gcc-11-exynos_defconfig - gcc-11-footbridge_defconfig - gcc-11-imx_v4_v5_defconfig - gcc-11-imx_v6_v7_defconfig - gcc-11-integrator_defconfig - gcc-11-ixp4xx_defconfig - gcc-11-keystone_defconfig - gcc-11-lpc32xx_defconfig - gcc-11-mini2440_defconfig - gcc-11-multi_v5_defconfig - gcc-11-mxs_defconfig - gcc-11-nhk8815_defconfig - gcc-11-omap1_defconfig - gcc-11-omap2plus_defconfig - gcc-11-orion5x_defconfig - gcc-11-pxa910_defconfig - gcc-11-s3c2410_defconfig - gcc-11-s3c6400_defconfig - gcc-11-s5pv210_defconfig - gcc-11-sama5_defconfig - gcc-11-shmobile_defconfig - gcc-11-tinyconfig - gcc-11-u8500_defconfig - gcc-11-vexpress_defconfig - gcc-8-allnoconfig - gcc-8-at91_dt_defconfig - gcc-8-axm55xx_defconfig - gcc-8-bcm2835_defconfig - gcc-8-clps711x_defconfig - gcc-8-davinci_all_defconfig - gcc-8-defconfig - gcc-8-exynos_defconfig - gcc-8-footbridge_defconfig - gcc-8-imx_v4_v5_defconfig - gcc-8-imx_v6_v7_defconfig - gcc-8-integrator_defconfig - gcc-8-ixp4xx_defconfig - gcc-8-keystone_defconfig - gcc-8-lpc32xx_defconfig - gcc-8-mini2440_defconfig - gcc-8-multi_v5_defconfig - gcc-8-mxs_defconfig - gcc-8-nhk8815_defconfig - gcc-8-omap1_defconfig - gcc-8-omap2plus_defconfig - gcc-8-orion5x_defconfig - gcc-8-pxa910_defconfig - gcc-8-s3c2410_defconfig - gcc-8-s3c6400_defconfig - gcc-8-s5pv210_defconfig - gcc-8-sama5_defconfig - gcc-8-shmobile_defconfig - gcc-8-tinyconfig - gcc-8-u8500_defconfig - gcc-8-vexpress_defconfig - gcc-9-allnoconfig - gcc-9-at91_dt_defconfig - gcc-9-axm55xx_defconfig - gcc-9-bcm2835_defconfig - gcc-9-clps711x_defconfig - gcc-9-davinci_all_defconfig - gcc-9-defconfig - gcc-9-exynos_defconfig - gcc-9-footbridge_defconfig - gcc-9-imx_v4_v5_defconfig - gcc-9-imx_v6_v7_defconfig - gcc-9-integrator_defconfig - gcc-9-ixp4xx_defconfig - gcc-9-keystone_defconfig - gcc-9-lpc32xx_defconfig - gcc-9-mini2440_defconfig - gcc-9-multi_v5_defconfig - gcc-9-mxs_defconfig - gcc-9-nhk8815_defconfig - gcc-9-omap1_defconfig - gcc-9-omap2plus_defconfig - gcc-9-orion5x_defconfig - gcc-9-pxa910_defconfig - gcc-9-s3c2410_defconfig - gcc-9-s3c6400_defconfig - gcc-9-s5pv210_defconfig - gcc-9-sama5_defconfig - gcc-9-shmobile_defconfig - gcc-9-tinyconfig - gcc-9-u8500_defconfig - gcc-9-vexpress_defconfig

* arm64, build - clang-10-allnoconfig - clang-10-tinyconfig - clang-11-allnoconfig - clang-11-tinyconfig - clang-12-allnoconfig - clang-12-tinyconfig - clang-13-allnoconfig - clang-13-tinyconfig - clang-nightly-allnoconfig - clang-nightly-tinyconfig - gcc-10-allnoconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-tinyconfig - gcc-9-allnoconfig - gcc-9-tinyconfig

* i386, build - clang-10-allnoconfig - clang-10-defconfig - clang-10-tinyconfig - clang-11-allnoconfig - clang-11-defconfig - clang-11-tinyconfig - clang-12-allnoconfig - clang-12-defconfig - clang-12-tinyconfig - clang-13-allnoconfig - clang-13-defconfig - clang-13-tinyconfig - clang-nightly-allnoconfig - clang-nightly-defconfig - clang-nightly-tinyconfig - gcc-10-allnoconfig - gcc-10-defconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-defconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-i386_defconfig - gcc-8-tinyconfig - gcc-9-allnoconfig - gcc-9-i386_defconfig - gcc-9-tinyconfig

* mips, build - clang-10-allnoconfig - clang-10-defconfig - clang-10-tinyconfig - clang-11-allnoconfig - clang-11-defconfig - clang-11-tinyconfig - clang-12-allnoconfig - clang-12-defconfig - clang-12-tinyconfig - clang-13-allnoconfig - clang-13-defconfig - clang-13-tinyconfig - clang-nightly-allnoconfig - clang-nightly-defconfig - clang-nightly-tinyconfig - gcc-10-allnoconfig - gcc-10-ar7_defconfig - gcc-10-ath79_defconfig - gcc-10-bcm47xx_defconfig - gcc-10-bcm63xx_defconfig - gcc-10-defconfig - gcc-10-e55_defconfig - gcc-10-malta_defconfig - gcc-10-rt305x_defconfig - gcc-10-tinyconfig - gcc-8-allnoconfig - gcc-8-ar7_defconfig - gcc-8-ath79_defconfig - gcc-8-bcm47xx_defconfig - gcc-8-bcm63xx_defconfig - gcc-8-defconfig - gcc-8-e55_defconfig - gcc-8-malta_defconfig - gcc-8-rt305x_defconfig - gcc-8-tinyconfig

* parisc, build - gcc-10-allnoconfig - gcc-10-defconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-defconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-defconfig - gcc-8-tinyconfig - gcc-9-allnoconfig - gcc-9-defconfig - gcc-9-tinyconfig

* powerpc, build - gcc-10-allnoconfig - gcc-10-cell_defconfig - gcc-10-maple_defconfig - gcc-10-mpc83xx_defconfig - gcc-10-ppc64e_defconfig - gcc-10-ppc6xx_defconfig - gcc-10-tinyconfig - gcc-10-tqm8xx_defconfig - gcc-11-allnoconfig - gcc-11-cell_defconfig - gcc-11-maple_defconfig - gcc-11-mpc83xx_defconfig - gcc-11-ppc64e_defconfig - gcc-11-ppc6xx_defconfig - gcc-11-tinyconfig - gcc-11-tqm8xx_defconfig - gcc-8-allnoconfig - gcc-8-cell_defconfig - gcc-8-maple_defconfig - gcc-8-mpc83xx_defconfig - gcc-8-ppc64e_defconfig - gcc-8-ppc6xx_defconfig - gcc-8-tinyconfig - gcc-8-tqm8xx_defconfig - gcc-9-allnoconfig - gcc-9-cell_defconfig - gcc-9-maple_defconfig - gcc-9-mpc83xx_defconfig - gcc-9-ppc64e_defconfig - gcc-9-ppc6xx_defconfig - gcc-9-tinyconfig - gcc-9-tqm8xx_defconfig

* riscv, build - clang-11-allnoconfig - clang-11-defconfig - clang-11-tinyconfig - clang-12-allnoconfig - clang-12-defconfig - clang-12-tinyconfig - clang-13-allnoconfig - clang-13-defconfig - clang-13-tinyconfig - clang-nightly-allnoconfig - clang-nightly-defconfig - clang-nightly-tinyconfig - gcc-10-allnoconfig - gcc-10-defconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-defconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-defconfig - gcc-8-tinyconfig - gcc-9-allnoconfig - gcc-9-defconfig - gcc-9-tinyconfig

* s390, build - clang-13-allnoconfig - clang-13-tinyconfig - clang-nightly-allnoconfig - clang-nightly-tinyconfig - gcc-10-allnoconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-tinyconfig - gcc-9-allnoconfig - gcc-9-tinyconfig

* sh, build - gcc-10-allnoconfig - gcc-10-defconfig - gcc-10-dreamcast_defconfig - gcc-10-microdev_defconfig - gcc-10-shx3_defconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-defconfig - gcc-11-dreamcast_defconfig - gcc-11-microdev_defconfig - gcc-11-shx3_defconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-defconfig - gcc-8-dreamcast_defconfig - gcc-8-microdev_defconfig - gcc-8-shx3_defconfig - gcc-8-tinyconfig - gcc-9-allnoconfig - gcc-9-defconfig - gcc-9-dreamcast_defconfig - gcc-9-microdev_defconfig - gcc-9-shx3_defconfig - gcc-9-tinyconfig

* sparc, build - gcc-10-allnoconfig - gcc-10-defconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-defconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-defconfig - gcc-8-tinyconfig - gcc-9-allnoconfig - gcc-9-defconfig - gcc-9-tinyconfig

* x86_64, build - clang-10-allnoconfig - clang-10-defconfig - clang-10-tinyconfig - clang-11-allnoconfig - clang-11-tinyconfig - clang-11-x86_64_defconfig - clang-12-allnoconfig - clang-12-tinyconfig - clang-12-x86_64_defconfig - clang-13-allnoconfig - clang-13-tinyconfig - clang-13-x86_64_defconfig - clang-nightly-allnoconfig - clang-nightly-tinyconfig - clang-nightly-x86_64_defconfig - gcc-10-allnoconfig - gcc-10-defconfig - gcc-10-tinyconfig - gcc-11-allnoconfig - gcc-11-defconfig - gcc-11-tinyconfig - gcc-8-allnoconfig - gcc-8-tinyconfig - gcc-8-x86_64_defconfig - gcc-9-allnoconfig - gcc-9-tinyconfig - gcc-9-x86_64_defconfig

(It would have been easier to list the ones that _passed_ instead! :)

Greetings!

daniel Díaz daniel.diaz@linaro.org

On Thu, Nov 04, 2021 at 09:46:49AM -0700, Guenter Roeck wrote:

On 11/4/21 9:20 AM, Greg Kroah-Hartman wrote:

...

On Thu, Nov 04, 2021 at 09:53:57AM -0600, Daniel Díaz wrote:

...

Hello!

On 11/4/21 8:12 AM, Greg Kroah-Hartman wrote:

...

This is the start of the stable review cycle for the 5.10.78 release. There are 16 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 06 Nov 2021 14:11:51 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.78-rc1... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below.

thanks,

greg k-h

Regressions detected.

Build failures on all architectures and all toolchains (GCC 8, 9, 10, 11; Clang 10, 11, 12, 13, nightly):

• arc
• arm (32-bits)
• arm (64-bits)
• i386
• mips
• parisc
• ppc
• riscv
• s390
• sh
• sparc
• x86

Failures look like this:

In file included from /builds/linux/include/linux/kernel.h:11, from /builds/linux/include/linux/list.h:9, from /builds/linux/include/linux/smp.h:12, from /builds/linux/include/linux/kernel_stat.h:5, from /builds/linux/mm/memory.c:42: /builds/linux/mm/memory.c: In function 'finish_fault': /builds/linux/mm/memory.c:3929:15: error: implicit declaration of function 'PageHasHWPoisoned'; did you mean 'PageHWPoison'? [-Werror=implicit-function-declaration] 3929 | if (unlikely(PageHasHWPoisoned(page))) | ^~~~~~~~~~~~~~~~~ /builds/linux/include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ cc1: some warnings being treated as errors

and this:

/builds/linux/mm/memory.c:3929:15: error: implicit declaration of function 'PageHasHWPoisoned' [-Werror,-Wimplicit-function-declaration] if (unlikely(PageHasHWPoisoned(page))) ^

/builds/linux/mm/page_alloc.c:1237:4: error: implicit declaration of function 'ClearPageHasHWPoisoned' [-Werror,-Wimplicit-function-declaration] ClearPageHasHWPoisoned(page); ^ /builds/linux/mm/page_alloc.c:1237:4: note: did you mean 'ClearPageHWPoison'?

What configuration? This builds for me on x86 here on allmodconfig.

defconfig, and anything with CONFIG_MEMORY_FAILURE=n or CONFIG_TRANSPARENT_HUGEPAGE=n. Fix needs upstream commit e66435936756d (presumably, I did not check).

Odd, no, I don't think that commit will help.

I'll go drop the offending commit now and push out a -rc2.

thanks,

greg k-h