Hello!
On Wed, 22 Apr 2020 at 07:09, Ingo Molnar mingo@kernel.org wrote:
- Arnaldo Carvalho de Melo acme@kernel.org wrote:
Hi Ingo/Thomas,
Please consider pulling,Best regards,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit cd0943357bc7570f081701d005318c20982178b8:
Merge tag 'perf-urgent-for-mingo-5.7-20200414' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2020-04-16 10:21:31 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-5.8-20200420
for you to fetch changes up to 12e89e65f446476951f42aedeef56b6bd6f7f1e6:
perf hist: Add fast path for duplicate entries check (2020-04-18 09:05:01 -0300)
85 files changed, 1851 insertions(+), 513 deletions(-)
Pulled, thanks a lot Arnaldo!
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
This means that there is a new binary pulled in in the shebang line which was unaccounted for: `/usr/bin/sh`. I don't see any other usage of /usr/bin/sh in the kernel tree (does not even exist on my Ubuntu dev machine) but plenty of /bin/sh. This patch is needed: -----8<----------8<----------8<----- diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..a2f3fa25ef81 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/sh perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..b0177355619b 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/sh # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@" ----->8---------->8---------->8-----
Greetings!
Daniel Díaz daniel.diaz@linaro.org
Em Thu, Apr 23, 2020 at 04:28:46PM -0500, Daniel Díaz escreveu:
On Wed, 22 Apr 2020 at 07:09, Ingo Molnar mingo@kernel.org wrote:
85 files changed, 1851 insertions(+), 513 deletions(-)
Pulled, thanks a lot Arnaldo!
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
yeah, the flamegraph scripts are the outliers, there, everything else is using /bin/bash, so I'll switch to that, ok Andreas?
[acme@quaco perf]$ vim tools/perf/scripts/python/bin/* 34 files to edit [acme@quaco perf]$ head -1 tools/perf/scripts/python/bin/* ==> tools/perf/scripts/python/bin/compaction-times-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/compaction-times-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/event_analyzing_sample-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/event_analyzing_sample-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/export-to-postgresql-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/export-to-postgresql-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/export-to-sqlite-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/export-to-sqlite-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/failed-syscalls-by-pid-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/failed-syscalls-by-pid-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/flamegraph-record <== #!/usr/bin/sh
==> tools/perf/scripts/python/bin/flamegraph-report <== #!/usr/bin/sh
==> tools/perf/scripts/python/bin/futex-contention-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/futex-contention-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/intel-pt-events-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/intel-pt-events-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/mem-phys-addr-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/mem-phys-addr-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/netdev-times-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/netdev-times-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/net_dropmonitor-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/net_dropmonitor-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/powerpc-hcalls-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/powerpc-hcalls-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/sched-migration-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/sched-migration-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/sctop-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/sctop-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/stackcollapse-record <== #!/bin/sh
==> tools/perf/scripts/python/bin/stackcollapse-report <== #!/bin/sh
==> tools/perf/scripts/python/bin/syscall-counts-by-pid-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/syscall-counts-by-pid-report <== #!/bin/bash
==> tools/perf/scripts/python/bin/syscall-counts-record <== #!/bin/bash
==> tools/perf/scripts/python/bin/syscall-counts-report <== #!/bin/bash [acme@quaco perf]$
On 24.04.20 15:07, Arnaldo Carvalho de Melo wrote:
Em Thu, Apr 23, 2020 at 04:28:46PM -0500, Daniel Díaz escreveu:
On Wed, 22 Apr 2020 at 07:09, Ingo Molnar mingo@kernel.org wrote:
85 files changed, 1851 insertions(+), 513 deletions(-)
Pulled, thanks a lot Arnaldo!
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
yeah, the flamegraph scripts are the outliers, there, everything else is using /bin/bash, so I'll switch to that, ok Andreas?
Sure, no problem. Thanks!
Cheers, Andreas
Hello!
On Fri, 24 Apr 2020 at 09:10, Andreas Gerstmayr agerstmayr@redhat.com wrote:
On 24.04.20 15:07, Arnaldo Carvalho de Melo wrote:
Em Thu, Apr 23, 2020 at 04:28:46PM -0500, Daniel Díaz escreveu:
On Wed, 22 Apr 2020 at 07:09, Ingo Molnar mingo@kernel.org wrote:
85 files changed, 1851 insertions(+), 513 deletions(-)
Pulled, thanks a lot Arnaldo!
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
yeah, the flamegraph scripts are the outliers, there, everything else is using /bin/bash, so I'll switch to that, ok Andreas?
Sure, no problem. Thanks!
Just a gentle reminder that this can still be fixed in today's linux-next tree (next-20200504).
Greetings!
Daniel Díaz daniel.diaz@linaro.org
Em Mon, May 04, 2020 at 02:07:56PM -0500, Daniel Díaz escreveu:
Hello!
On Fri, 24 Apr 2020 at 09:10, Andreas Gerstmayr agerstmayr@redhat.com wrote:
On 24.04.20 15:07, Arnaldo Carvalho de Melo wrote:
Em Thu, Apr 23, 2020 at 04:28:46PM -0500, Daniel Díaz escreveu:
On Wed, 22 Apr 2020 at 07:09, Ingo Molnar mingo@kernel.org wrote:
85 files changed, 1851 insertions(+), 513 deletions(-)
Pulled, thanks a lot Arnaldo!
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
yeah, the flamegraph scripts are the outliers, there, everything else is using /bin/bash, so I'll switch to that, ok Andreas?
Sure, no problem. Thanks!
Just a gentle reminder that this can still be fixed in today's linux-next tree (next-20200504).
Thanks for the reminder, I've just added this to my tree:
commit c74ab13a30d3bec443c116e25b611255c58f32c0 Author: Arnaldo Carvalho de Melo acme@redhat.com Date: Tue May 5 13:33:12 2020 -0300
perf flamegraph: Use /bin/bash for report script
As all the other tools/perf/scripts/python/bin/*-report scripts, fixing the this problem reported by Daniel Diaz:
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
This means that there is a new binary pulled in in the shebang line which was unaccounted for: `/usr/bin/sh`. I don't see any other usage of /usr/bin/sh in the kernel tree (does not even exist on my Ubuntu dev machine) but plenty of /bin/sh. This patch is needed: -----8<----------8<----------8<----- diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..a2f3fa25ef81 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/sh perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..b0177355619b 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/sh # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@" ----->8---------->8---------->8-----
Fixes: 5287f9269206 ("perf script: Add flamegraph.py script") Reported-by: Daniel Díaz daniel.diaz@linaro.org Cc: Adrian Hunter adrian.hunter@intel.com Cc: Andreas Gerstmayr agerstmayr@redhat.com Cc: Jiri Olsa jolsa@kernel.org Cc: lkft-triage@lists.linaro.org Cc: Namhyung Kim namhyung@kernel.org Link: http://lore.kernel.org/lkml/CAEUSe7_wmKS361mKLTB1eYbzYXcKkXdU26BX5BojdKRz8Mf... Signed-off-by: Arnaldo Carvalho de Melo acme@redhat.com
diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..53c5dc90c87e 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/bash # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@"
Hello!
On Tue, 5 May 2020 at 11:37, Arnaldo Carvalho de Melo arnaldo.melo@gmail.com wrote:
Em Mon, May 04, 2020 at 02:07:56PM -0500, Daniel Díaz escreveu:
Hello!
On Fri, 24 Apr 2020 at 09:10, Andreas Gerstmayr agerstmayr@redhat.com wrote:
On 24.04.20 15:07, Arnaldo Carvalho de Melo wrote:
Em Thu, Apr 23, 2020 at 04:28:46PM -0500, Daniel Díaz escreveu:
On Wed, 22 Apr 2020 at 07:09, Ingo Molnar mingo@kernel.org wrote:
> 85 files changed, 1851 insertions(+), 513 deletions(-)
Pulled, thanks a lot Arnaldo!
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
yeah, the flamegraph scripts are the outliers, there, everything else is using /bin/bash, so I'll switch to that, ok Andreas?
Sure, no problem. Thanks!
Just a gentle reminder that this can still be fixed in today's linux-next tree (next-20200504).
Thanks for the reminder, I've just added this to my tree:
commit c74ab13a30d3bec443c116e25b611255c58f32c0 Author: Arnaldo Carvalho de Melo acme@redhat.com Date: Tue May 5 13:33:12 2020 -0300
perf flamegraph: Use /bin/bash for report script As all the other tools/perf/scripts/python/bin/*-report scripts, fixing the this problem reported by Daniel Diaz: Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps] This means that there is a new binary pulled in in the shebang line which was unaccounted for: `/usr/bin/sh`. I don't see any other usage of /usr/bin/sh in the kernel tree (does not even exist on my Ubuntu dev machine) but plenty of /bin/sh. This patch is needed: -----8<----------8<----------8<----- diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..a2f3fa25ef81 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/sh perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..b0177355619b 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/sh # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@" ----->8---------->8---------->8----- Fixes: 5287f9269206 ("perf script: Add flamegraph.py script") Reported-by: Daniel Díaz <daniel.diaz@linaro.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Andreas Gerstmayr <agerstmayr@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: lkft-triage@lists.linaro.org Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lore.kernel.org/lkml/CAEUSe7_wmKS361mKLTB1eYbzYXcKkXdU26BX5BojdKRz8MfPCw@mail.gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..53c5dc90c87e 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/bash # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@"
What about flamegraph-record?
Thanks and greetings!
Daniel Díaz daniel.diaz@linaro.org
Em Tue, May 05, 2020 at 11:57:18AM -0500, Daniel Díaz escreveu:
Hello!
On Tue, 5 May 2020 at 11:37, Arnaldo Carvalho de Melo arnaldo.melo@gmail.com wrote:
Em Mon, May 04, 2020 at 02:07:56PM -0500, Daniel Díaz escreveu:
Hello!
On Fri, 24 Apr 2020 at 09:10, Andreas Gerstmayr agerstmayr@redhat.com wrote:
On 24.04.20 15:07, Arnaldo Carvalho de Melo wrote:
Em Thu, Apr 23, 2020 at 04:28:46PM -0500, Daniel Díaz escreveu:
On Wed, 22 Apr 2020 at 07:09, Ingo Molnar mingo@kernel.org wrote: >> 85 files changed, 1851 insertions(+), 513 deletions(-)
> Pulled, thanks a lot Arnaldo!
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
yeah, the flamegraph scripts are the outliers, there, everything else is using /bin/bash, so I'll switch to that, ok Andreas?
Sure, no problem. Thanks!
Just a gentle reminder that this can still be fixed in today's linux-next tree (next-20200504).
Thanks for the reminder, I've just added this to my tree:
commit c74ab13a30d3bec443c116e25b611255c58f32c0 Author: Arnaldo Carvalho de Melo acme@redhat.com Date: Tue May 5 13:33:12 2020 -0300
perf flamegraph: Use /bin/bash for report script As all the other tools/perf/scripts/python/bin/*-report scripts, fixing the this problem reported by Daniel Diaz: Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps] This means that there is a new binary pulled in in the shebang line which was unaccounted for: `/usr/bin/sh`. I don't see any other usage of /usr/bin/sh in the kernel tree (does not even exist on my Ubuntu dev machine) but plenty of /bin/sh. This patch is needed: -----8<----------8<----------8<----- diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..a2f3fa25ef81 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/sh perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..b0177355619b 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/sh # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@" ----->8---------->8---------->8----- Fixes: 5287f9269206 ("perf script: Add flamegraph.py script") Reported-by: Daniel Díaz <daniel.diaz@linaro.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Andreas Gerstmayr <agerstmayr@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: lkft-triage@lists.linaro.org Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lore.kernel.org/lkml/CAEUSe7_wmKS361mKLTB1eYbzYXcKkXdU26BX5BojdKRz8MfPCw@mail.gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..53c5dc90c87e 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/bash # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@"
What about flamegraph-record?
oops, make that this instead:
commit b3a63d0c17e6e1d23a6b44502b55f066adfd8e6a Author: Arnaldo Carvalho de Melo acme@redhat.com Date: Tue May 5 13:33:12 2020 -0300
perf flamegraph: Use /bin/bash for report and record scripts
As all the other tools/perf/scripts/python/bin/*-{report,record} scripts, fixing the this problem reported by Daniel Diaz:
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
This means that there is a new binary pulled in in the shebang line which was unaccounted for: `/usr/bin/sh`. I don't see any other usage of /usr/bin/sh in the kernel tree (does not even exist on my Ubuntu dev machine) but plenty of /bin/sh. This patch is needed: -----8<----------8<----------8<----- diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..a2f3fa25ef81 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/sh perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..b0177355619b 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/sh # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@" ----->8---------->8---------->8-----
Fixes: 5287f9269206 ("perf script: Add flamegraph.py script") Reported-by: Daniel Díaz daniel.diaz@linaro.org Acked-by: Andreas Gerstmayr agerstmayr@redhat.com Cc: Adrian Hunter adrian.hunter@intel.com Cc: Jiri Olsa jolsa@kernel.org Cc: lkft-triage@lists.linaro.org Cc: Namhyung Kim namhyung@kernel.org Link: http://lore.kernel.org/lkml/CAEUSe7_wmKS361mKLTB1eYbzYXcKkXdU26BX5BojdKRz8Mf... Link: http://lore.kernel.org/lkml/20200505163745.GD3777@redhat.com Signed-off-by: Arnaldo Carvalho de Melo acme@redhat.com
diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..7df5a19c0163 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/bash perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..53c5dc90c87e 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/bash # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@"
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 19ce2321739da5fc27f6a5ed1e1cb15e384ad030 Gitweb: https://git.kernel.org/tip/19ce2321739da5fc27f6a5ed1e1cb15e384ad030 Author: Arnaldo Carvalho de Melo acme@redhat.com AuthorDate: Tue, 05 May 2020 13:33:12 -03:00 Committer: Arnaldo Carvalho de Melo acme@redhat.com CommitterDate: Tue, 05 May 2020 16:35:32 -03:00
perf flamegraph: Use /bin/bash for report and record scripts
As all the other tools/perf/scripts/python/bin/*-{report,record} scripts, fixing the this problem reported by Daniel Diaz:
Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps]
This means that there is a new binary pulled in in the shebang line which was unaccounted for: `/usr/bin/sh`. I don't see any other usage of /usr/bin/sh in the kernel tree (does not even exist on my Ubuntu dev machine) but plenty of /bin/sh. This patch is needed: -----8<----------8<----------8<----- diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..a2f3fa25ef81 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/sh perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..b0177355619b 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/sh # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@" ----->8---------->8---------->8-----
Fixes: 5287f9269206 ("perf script: Add flamegraph.py script") Reported-by: Daniel Díaz daniel.diaz@linaro.org Acked-by: Andreas Gerstmayr agerstmayr@redhat.com Cc: Adrian Hunter adrian.hunter@intel.com Cc: Jiri Olsa jolsa@kernel.org Cc: lkft-triage@lists.linaro.org Cc: Namhyung Kim namhyung@kernel.org Link: http://lore.kernel.org/lkml/CAEUSe7_wmKS361mKLTB1eYbzYXcKkXdU26BX5BojdKRz8Mf... Link: http://lore.kernel.org/lkml/20200505170320.GZ30487@kernel.org Signed-off-by: Arnaldo Carvalho de Melo acme@redhat.com --- tools/perf/scripts/python/bin/flamegraph-record | 2 +- tools/perf/scripts/python/bin/flamegraph-report | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e..7df5a19 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/bash perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79af..53c5dc9 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/bash # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@"
-
Andreas Gerstmayr -
Arnaldo Carvalho de Melo -
Daniel Díaz -
tip-bot2 for Arnaldo Carvalho de Melo