This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 5.15.108-rc1
Xi Ruoyao xry111@xry111.site nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs
Yanteng Si siyanteng01@gmail.com counter: Add the necessary colons and indents to the comments of counter_compi
Randy Dunlap rdunlap@infradead.org counter: fix docum. build problems after filename change
Valentin Schneider vschneid@redhat.com panic, kexec: make __crash_kexec() NMI safe
Valentin Schneider vschneid@redhat.com kexec: turn all kexec_mutex acquisitions into trylocks
Waiman Long longman@redhat.com cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
Waiman Long longman@redhat.com cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly
Waiman Long longman@redhat.com cgroup/cpuset: Skip spread flags update on v2
Duy Truong dory@dory.moe nvme-pci: add NVME_QUIRK_BOGUS_NID for T-FORCE Z330 SSD
Juraj Pecigos kernel@juraj.dev nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN
Abhijit abhijit@abhijittomar.com nvme-pci: add NVME_QUIRK_BOGUS_NID for Lexar NM760
Shyamin Ayesh me@shyamin.com nvme-pci: add NVME_QUIRK_BOGUS_NID for Lexar NM610
Tobias Gruetzmacher tobias-git@23.gs nvme-pci: Crucial P2 has bogus namespace ids
Ning Wang ningwang35@outlook.com nvme-pci: avoid the deepest sleep state on ZHITAI TiPro7000 SSDs
Stefan Reiter stefan@pimaker.at nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50
Alyssa Ross hi@alyssa.is purgatory: fix disabling debug info
Masahiro Yamada masahiroy@kernel.org kbuild: use more subdir- for visiting subdirectories while cleaning
Masahiro Yamada masahiroy@kernel.org sh: remove meaningless archclean line
Gregor Herburger gregor.herburger@tq-group.com i2c: ocores: generate stop condition after timeout in polling mode
Matija Glavinic Pecotic matija.glavinic-pecotic.ext@nokia.com x86/rtc: Remove __init for runtime functions
Vincent Guittot vincent.guittot@linaro.org sched/fair: Fix imbalance overflow
zgpeng zgpeng.linux@gmail.com sched/fair: Move calculate of avg_load to a better location
Aneesh Kumar K.V aneesh.kumar@linux.ibm.com powerpc/papr_scm: Update the NUMA distance table for the target node
ZhaoLong Wang wangzhaolong1@huawei.com ubi: Fix deadlock caused by recursively holding work_sem
Zhihao Cheng chengzhihao1@huawei.com ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size
Paolo Abeni pabeni@redhat.com mptcp: stricter state check in mptcp_worker
Paolo Abeni pabeni@redhat.com mptcp: use mptcp_schedule_work instead of open-coding it
Waiman Long longman@redhat.com cgroup/cpuset: Wake up cpuset_attach_wq tasks in cpuset_cancel_attach()
Basavaraj Natikar Basavaraj.Natikar@amd.com x86/PCI: Add quirk for AMD XHCI controller that loses MSI-X state in D3hot
Jiri Kosina jkosina@suse.cz scsi: ses: Handle enclosure with just a primary component gracefully
Radu Pirea (OSS) radu-nicolae.pirea@oss.nxp.com net: phy: nxp-c45-tja11xx: fix unsigned long multiplication overflow
Radu Pirea (OSS) radu-nicolae.pirea@oss.nxp.com net: phy: nxp-c45-tja11xx: add remove callback
Ivan Bornyakov i.bornyakov@metrotek.ru net: sfp: initialize sfp->i2c_block_size at sfp allocation
Mathis Salmen mathis.salmen@matsal.de riscv: add icache flush for nommu sigreturn trampoline
Alexandre Ghiti alexghiti@rivosinc.com riscv: Do not set initial_boot_params to the linear address of the dtb
Min Li lm0963hack@gmail.com drm/i915: fix race condition UAF in i915_perf_add_config_ioctl
Umesh Nerlige Ramappa umesh.nerlige.ramappa@intel.com i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call
Steven Rostedt (Google) rostedt@goodmis.org tracing: Have tracing_snapshot_instance_cond() write errors to the appropriate instance
Steven Rostedt (Google) rostedt@goodmis.org tracing: Add trace_array_puts() to write into instance
William Breathitt Gray william.gray@linaro.org counter: 104-quad-8: Fix Synapse action reported for Index signals
William Breathitt Gray vilhelm.gray@gmail.com counter: Internalize sysfs interface code
William Breathitt Gray vilhelm.gray@gmail.com counter: stm32-timer-cnt: Provide defines for slave mode selection
William Breathitt Gray vilhelm.gray@gmail.com counter: stm32-lptimer-cnt: Provide defines for clock polarities
Aymeric Wibo obiwac@gmail.com ACPI: resource: Add Medion S17413 to IRQ override quirk
Johannes Berg johannes.berg@intel.com wifi: iwlwifi: mvm: fix mvmtxq->stopped handling
Robbie Harwood rharwood@redhat.com asymmetric_keys: log on fatal failures in PE/pkcs7
Robbie Harwood rharwood@redhat.com verify_pefile: relax wrapper length check
Hans de Goede hdegoede@redhat.com drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F
Hans de Goede hdegoede@redhat.com efi: sysfb_efi: Add quirk for Lenovo Yoga Book X91F/L
Yicong Yang yangyicong@hisilicon.com i2c: hisi: Avoid redundant interrupts
Alexander Stein alexander.stein@ew.tq-group.com i2c: imx-lpi2c: clean rx/tx buffers upon new message
Krzysztof Kozlowski krzysztof.kozlowski@linaro.org wifi: mwifiex: mark OF related data as maybe unused
Grant Grundler grundler@chromium.org power: supply: cros_usbpd: reclassify "default case!" as debug
Andrew Jeffery andrew@aj.id.au ARM: 9290/1: uaccess: Fix KASAN false-positives
Andrii Nakryiko andrii@kernel.org libbpf: Fix single-line struct definition output in btf_dump
Liang Chen liangchen.linux@gmail.com skbuff: Fix a race between coalescing and releasing SKBs
Roman Gushchin roman.gushchin@linux.dev net: macb: fix a memory corruption in extended buffer descriptor mode
Eric Dumazet edumazet@google.com udp6: fix potential access to stale information
Saravanan Vajravel saravanan.vajravel@broadcom.com RDMA/core: Fix GID entry ref leak when create_ah fails
Xin Long lucien.xin@gmail.com sctp: fix a potential overflow in sctp_ifwdtsn_skip
Ziyang Xuan william.xuanziyang@huawei.com net: qrtr: Fix an uninit variable access bug in qrtr_tx_resume()
Denis Plotnikov den-plotnikov@yandex-team.ru qlcnic: check pci_reset_function result
Christophe JAILLET christophe.jaillet@wanadoo.fr drm/armada: Fix a potential double free in an error handling path
YueHaibing yuehaibing@huawei.com tcp: restrict net.ipv4.tcp_app_win
Harshit Mogalapalli harshit.m.mogalapalli@oracle.com niu: Fix missing unwind goto in niu_alloc_channels()
Zheng Wang zyytlz.wz@163.com 9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition
Martin KaFai Lau martin.lau@kernel.org bpf: tcp: Use sock_gen_put instead of sock_put in bpf_iter_tcp
Mark Zhang markzhang@nvidia.com RDMA/cma: Allow UD qp_type to join multicast only
Maher Sanalla msanalla@nvidia.com IB/mlx5: Add support for 400G_8X lane speed
Tatyana Nikolova tatyana.e.nikolova@intel.com RDMA/irdma: Add ipv4 check to irdma_find_listener()
Mustafa Ismail mustafa.ismail@intel.com RDMA/irdma: Increase iWARP CM default rexmit count
Mustafa Ismail mustafa.ismail@intel.com RDMA/irdma: Fix memory leak of PBLE objects
Chunyan Zhang chunyan.zhang@unisoc.com clk: sprd: set max_register according to mapping range
Jani Nikula jani.nikula@intel.com drm/i915/dsi: fix DSS CTL register offsets for TGL+
Reiji Watanabe reijiw@google.com KVM: arm64: PMU: Restore the guest's EL0 event counting after migration
Christophe Kerello christophe.kerello@foss.st.com mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min
Christophe Kerello christophe.kerello@foss.st.com mtd: rawnand: stm32_fmc2: remove unsupported EDO mode
Arseniy Krasnov avkrasnov@sberdevices.ru mtd: rawnand: meson: fix bitmask for length in command word
Bang Li libang.linuxer@gmail.com mtdblock: tolerate corrected bit-flips
Daniel Vetter daniel.vetter@ffwll.ch fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace
Christoph Hellwig hch@lst.de btrfs: fix fast csum implementation detection
David Sterba dsterba@suse.com btrfs: print checksum type and implementation at mount time
Min Li lm0963hack@gmail.com Bluetooth: Fix race condition in hidp_session_thread
Luiz Augusto von Dentz luiz.von.dentz@intel.com Bluetooth: L2CAP: Fix use-after-free in l2cap_disconnect_{req,rsp}
Oswald Buddenhagen oswald.buddenhagen@gmx.de ALSA: hda/sigmatel: fix S/PDIF out on Intel D*45* motherboards
Oswald Buddenhagen oswald.buddenhagen@gmx.de ALSA: emu10k1: don't create old pass-through playback device on Audigy
Xu Biang xubiang@hust.edu.cn ALSA: firewire-tascam: add missing unwind goto in snd_tscm_stream_start_duplex()
Oswald Buddenhagen oswald.buddenhagen@gmx.de ALSA: i2c/cs8427: fix iec958 mixer control deactivation
Oswald Buddenhagen oswald.buddenhagen@gmx.de ALSA: hda/sigmatel: add pin overrides for Intel DP45SG motherboard
Oswald Buddenhagen oswald.buddenhagen@gmx.de ALSA: emu10k1: fix capture interrupt handler unlinking
Kornel Dulęba korneld@chromium.org Revert "pinctrl: amd: Disable and mask interrupts on resume"
-------------
Diffstat:
Documentation/driver-api/generic-counter.rst | 2 +- Documentation/kbuild/makefiles.rst | 17 +- Documentation/networking/ip-sysctl.rst | 2 + Documentation/sound/hd-audio/models.rst | 2 +- MAINTAINERS | 1 - Makefile | 4 +- arch/alpha/Kbuild | 3 + arch/alpha/Makefile | 3 - arch/arc/Kbuild | 3 + arch/arc/Makefile | 3 - arch/arm/Kbuild | 3 + arch/arm/Makefile | 4 - arch/arm/lib/uaccess_with_memcpy.c | 4 +- arch/arm64/Kbuild | 3 + arch/arm64/Makefile | 7 - arch/arm64/kernel/Makefile | 3 + arch/arm64/kvm/pmu-emul.c | 1 + arch/arm64/kvm/sys_regs.c | 1 - arch/csky/Kbuild | 3 + arch/csky/Makefile | 3 - arch/h8300/Kbuild | 3 + arch/h8300/Makefile | 3 - arch/ia64/Makefile | 2 - arch/m68k/Makefile | 4 +- arch/microblaze/Kbuild | 3 + arch/microblaze/Makefile | 3 - arch/mips/Kbuild | 3 + arch/mips/Makefile | 8 +- arch/mips/boot/Makefile | 3 + arch/nds32/Kbuild | 3 + arch/nds32/Makefile | 3 - arch/nios2/Kbuild | 3 + arch/nios2/Makefile | 6 +- arch/openrisc/Kbuild | 3 + arch/openrisc/Makefile | 7 +- arch/parisc/Kbuild | 3 + arch/parisc/Makefile | 7 +- arch/powerpc/Kbuild | 3 + arch/powerpc/Makefile | 7 +- arch/powerpc/mm/numa.c | 1 + arch/powerpc/platforms/pseries/papr_scm.c | 7 + arch/riscv/Kbuild | 3 + arch/riscv/Makefile | 7 +- arch/riscv/kernel/setup.c | 5 +- arch/riscv/kernel/signal.c | 9 +- arch/s390/Kbuild | 3 + arch/s390/Makefile | 8 +- arch/sh/Kbuild | 3 + arch/sh/Makefile | 4 - arch/sparc/Kbuild | 3 + arch/sparc/Makefile | 3 - arch/x86/Kbuild | 3 + arch/x86/Makefile | 2 - arch/x86/kernel/x86_init.c | 4 +- arch/x86/pci/fixup.c | 21 + arch/x86/purgatory/Makefile | 3 +- arch/xtensa/Makefile | 4 +- crypto/asymmetric_keys/pkcs7_verify.c | 10 +- crypto/asymmetric_keys/verify_pefile.c | 32 +- drivers/acpi/resource.c | 7 + drivers/clk/sprd/common.c | 9 +- drivers/counter/104-quad-8.c | 451 +++---- drivers/counter/Makefile | 1 + drivers/counter/counter-core.c | 142 ++ drivers/counter/counter-sysfs.c | 849 ++++++++++++ drivers/counter/counter-sysfs.h | 13 + drivers/counter/counter.c | 1496 --------------------- drivers/counter/ftm-quaddec.c | 60 +- drivers/counter/intel-qep.c | 146 +- drivers/counter/interrupt-cnt.c | 62 +- drivers/counter/microchip-tcb-capture.c | 91 +- drivers/counter/stm32-lptimer-cnt.c | 212 ++- drivers/counter/stm32-timer-cnt.c | 195 ++- drivers/counter/ti-eqep.c | 180 +-- drivers/firmware/efi/sysfb_efi.c | 8 + drivers/gpu/drm/armada/armada_drv.c | 1 - drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +- drivers/gpu/drm/i915/display/icl_dsi.c | 20 +- drivers/gpu/drm/i915/i915_perf.c | 155 ++- drivers/i2c/busses/i2c-hisi.c | 7 + drivers/i2c/busses/i2c-imx-lpi2c.c | 2 + drivers/i2c/busses/i2c-ocores.c | 35 +- drivers/infiniband/core/cma.c | 60 +- drivers/infiniband/core/verbs.c | 2 + drivers/infiniband/hw/irdma/cm.c | 16 +- drivers/infiniband/hw/irdma/cm.h | 2 +- drivers/infiniband/hw/irdma/hw.c | 3 + drivers/infiniband/hw/mlx5/main.c | 4 + drivers/mtd/mtdblock.c | 12 +- drivers/mtd/nand/raw/meson_nand.c | 6 +- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 + drivers/mtd/ubi/build.c | 21 +- drivers/mtd/ubi/wl.c | 4 +- drivers/net/ethernet/cadence/macb_main.c | 4 + drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 8 +- drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/phy/nxp-c45-tja11xx.c | 14 +- drivers/net/phy/sfp.c | 13 +- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 5 +- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 4 +- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 5 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 4 +- drivers/net/wireless/marvell/mwifiex/pcie.c | 2 +- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- drivers/nvme/host/pci.c | 15 + drivers/pinctrl/pinctrl-amd.c | 36 +- drivers/power/supply/cros_usbpd-charger.c | 2 +- drivers/scsi/ses.c | 20 +- drivers/video/fbdev/core/fbmem.c | 2 + fs/btrfs/disk-io.c | 17 + fs/btrfs/super.c | 2 - include/linux/counter.h | 658 ++++----- include/linux/counter_enum.h | 45 - include/linux/kexec.h | 2 +- include/linux/mfd/stm32-lptimer.h | 5 + include/linux/mfd/stm32-timers.h | 4 + include/linux/trace.h | 12 + kernel/cgroup/cpuset.c | 166 ++- kernel/kexec.c | 11 +- kernel/kexec_core.c | 28 +- kernel/kexec_file.c | 4 +- kernel/kexec_internal.h | 15 +- kernel/ksysfs.c | 7 +- kernel/sched/fair.c | 15 +- kernel/trace/trace.c | 41 +- net/9p/trans_xen.c | 4 + net/bluetooth/hidp/core.c | 2 +- net/bluetooth/l2cap_core.c | 24 +- net/core/skbuff.c | 16 +- net/ipv4/sysctl_net_ipv4.c | 3 + net/ipv4/tcp_ipv4.c | 4 +- net/ipv6/udp.c | 8 +- net/mptcp/options.c | 5 +- net/mptcp/protocol.c | 2 +- net/mptcp/subflow.c | 18 +- net/qrtr/af_qrtr.c | 8 +- net/sctp/stream_interleave.c | 3 +- sound/firewire/tascam/tascam-stream.c | 2 +- sound/i2c/cs8427.c | 7 +- sound/pci/emu10k1/emupcm.c | 14 +- sound/pci/hda/patch_sigmatel.c | 10 + tools/lib/bpf/btf_dump.c | 7 +- 142 files changed, 2785 insertions(+), 3094 deletions(-)
On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below.
thanks,
greg k-h
Following patch causing build break on stable-rc 5.15
Waiman Long longman@redhat.com cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build error: kernel/cgroup/cpuset.c: In function 'cpuset_can_fork': kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared (first use in this function); did you mean 'cgroup_put'? 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is reported only once for each function it appears in 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15....
-- Linaro LKFT https://lkft.linaro.org
Hi Greg,
On 18/04/23 8:17 pm, Naresh Kamboju wrote:
On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below.
thanks,
greg k-h
Following patch causing build break on stable-rc 5.15
Waiman Long longman@redhat.com cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build error: kernel/cgroup/cpuset.c: In function 'cpuset_can_fork': kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared (first use in this function); did you mean 'cgroup_put'? 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is reported only once for each function it appears in 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
We observed same build error.(5.15.108-rc1), and investigated about this.
Please see the below findings.
With defconfig --> build breaks. With allmodconfig --> build succeeds.
From the above we know that this is something related to CONFIG.
In 5.15.y --> cgroup_mutex is defined like this in include/linux/cgroup.h
#ifdef CONFIG_PROVE_RCU extern struct mutex cgroup_mutex;
In 6.2.y --> include/linux/cgroup.h
extern struct mutex cgroup_mutex;
-- We don't have that ifdef in 6.2.y.
Tom Saeger identified that the below commit moves it out of ifdef.
commit 354ed597442952fb680c9cafc7e4eb8a76f9514c Author: Yu Zhao yuzhao@google.com Date: Sun Sep 18 02:00:07 2022 -0600
mm: multi-gen LRU: kill switch
Given that we don't have this commit in 5.15.y and 5.10.y we are seeing this build problem.
on allmodconfig:
~/linux$ grep "CONFIG_PROVE_RCU" .config CONFIG_PROVE_RCU=y CONFIG_PROVE_RCU_LIST=y
on defconfig: ~/linux$ grep "CONFIG_PROVE_RCU" .config -- No match
This explains the failure on defconfig and a build success on allmodconfig.
Thanks, Harshit
build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15....
-- Linaro LKFT https://lkft.linaro.org
On Tue, Apr 18, 2023 at 09:47:33PM +0530, Harshit Mogalapalli wrote:
Hi Greg,
On 18/04/23 8:17 pm, Naresh Kamboju wrote:
On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below.
thanks,
greg k-h
Following patch causing build break on stable-rc 5.15
Waiman Long longman@redhat.com cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build error: kernel/cgroup/cpuset.c: In function 'cpuset_can_fork': kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared (first use in this function); did you mean 'cgroup_put'? 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is reported only once for each function it appears in 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
We observed same build error.(5.15.108-rc1), and investigated about this.
Please see the below findings.
With defconfig --> build breaks. With allmodconfig --> build succeeds.
From the above we know that this is something related to CONFIG.
In 5.15.y --> cgroup_mutex is defined like this in include/linux/cgroup.h
#ifdef CONFIG_PROVE_RCU extern struct mutex cgroup_mutex;
In 6.2.y --> include/linux/cgroup.h
extern struct mutex cgroup_mutex;
-- We don't have that ifdef in 6.2.y.
Tom Saeger identified that the below commit moves it out of ifdef.
commit 354ed597442952fb680c9cafc7e4eb8a76f9514c Author: Yu Zhao yuzhao@google.com Date: Sun Sep 18 02:00:07 2022 -0600
mm: multi-gen LRU: kill switchGiven that we don't have this commit in 5.15.y and 5.10.y we are seeing this build problem.
on allmodconfig:
~/linux$ grep "CONFIG_PROVE_RCU" .config CONFIG_PROVE_RCU=y CONFIG_PROVE_RCU_LIST=y
on defconfig: ~/linux$ grep "CONFIG_PROVE_RCU" .config -- No match
This explains the failure on defconfig and a build success on allmodconfig.
Thanks, Harshit
FWIW - partially backporting (location of cgroup_mutex extern) from: 354ed5974429 ("mm: multi-gen LRU: kill switch")
fixes x86_64 build for me.
Regards,
--Tom
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 45cdb12243e3..460ba084888a 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -433,6 +433,8 @@ static inline void cgroup_put(struct cgroup *cgrp) css_put(&cgrp->self); }
+extern struct mutex cgroup_mutex; + /** * task_css_set_check - obtain a task's css_set with extra access conditions * @task: the task to obtain css_set for @@ -447,7 +449,6 @@ static inline void cgroup_put(struct cgroup *cgrp) * as locks used during the cgroup_subsys::attach() methods. */ #ifdef CONFIG_PROVE_RCU -extern struct mutex cgroup_mutex; extern spinlock_t css_set_lock; #define task_css_set_check(task, __c) \ rcu_dereference_check((task)->cgroups, \ diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h index d8fcc139ac05..28c32a01da7d 100644 --- a/kernel/cgroup/cgroup-internal.h +++ b/kernel/cgroup/cgroup-internal.h @@ -165,7 +165,6 @@ struct cgroup_mgctx { #define DEFINE_CGROUP_MGCTX(name) \ struct cgroup_mgctx name = CGROUP_MGCTX_INIT(name)
-extern struct mutex cgroup_mutex; extern spinlock_t css_set_lock; extern struct cgroup_subsys *cgroup_subsys[]; extern struct list_head cgroup_roots;
On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
Tom Saeger identified that the below commit moves it out of ifdef.
commit 354ed597442952fb680c9cafc7e4eb8a76f9514c Author: Yu Zhao yuzhao@google.com Date: Sun Sep 18 02:00:07 2022 -0600
mm: multi-gen LRU: kill switchFWIW - partially backporting (location of cgroup_mutex extern) from: 354ed5974429 ("mm: multi-gen LRU: kill switch")
fixes x86_64 build for me.
Regards,
--Tom
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 45cdb12243e3..460ba084888a 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -433,6 +433,8 @@ static inline void cgroup_put(struct cgroup *cgrp) css_put(&cgrp->self); }
+extern struct mutex cgroup_mutex;
/**
- task_css_set_check - obtain a task's css_set with extra access conditions
- @task: the task to obtain css_set for
@@ -447,7 +449,6 @@ static inline void cgroup_put(struct cgroup *cgrp)
- as locks used during the cgroup_subsys::attach() methods.
*/ #ifdef CONFIG_PROVE_RCU -extern struct mutex cgroup_mutex; extern spinlock_t css_set_lock; #define task_css_set_check(task, __c) \ rcu_dereference_check((task)->cgroups, \ diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h index d8fcc139ac05..28c32a01da7d 100644 --- a/kernel/cgroup/cgroup-internal.h +++ b/kernel/cgroup/cgroup-internal.h @@ -165,7 +165,6 @@ struct cgroup_mgctx { #define DEFINE_CGROUP_MGCTX(name) \ struct cgroup_mgctx name = CGROUP_MGCTX_INIT(name)
-extern struct mutex cgroup_mutex; extern spinlock_t css_set_lock; extern struct cgroup_subsys *cgroup_subsys[]; extern struct list_head cgroup_roots;
Yu, would you like to provide formal backport? Or maybe take Tom's diff above and ACK it?
On Tue, Apr 18, 2023 at 10:18 PM Bagas Sanjaya bagasdotme@gmail.com wrote:
On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
Tom Saeger identified that the below commit moves it out of ifdef.
commit 354ed597442952fb680c9cafc7e4eb8a76f9514c Author: Yu Zhao yuzhao@google.com Date: Sun Sep 18 02:00:07 2022 -0600
mm: multi-gen LRU: kill switchFWIW - partially backporting (location of cgroup_mutex extern) from: 354ed5974429 ("mm: multi-gen LRU: kill switch")
fixes x86_64 build for me.
Regards,
--Tom
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
...
Yu, would you like to provide formal backport?
Are you suggesting backporting the entire MGLRU patchset (>30 patches)?
I do have the backport ready for 5.15 and multiple distros have taken it. But I don't think Greg would welcome it. I'd be happy to be wrong though.
On Tue, Apr 18, 2023 at 10:56:22PM -0600, Yu Zhao wrote:
On Tue, Apr 18, 2023 at 10:18 PM Bagas Sanjaya bagasdotme@gmail.com wrote:
On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
Tom Saeger identified that the below commit moves it out of ifdef.
commit 354ed597442952fb680c9cafc7e4eb8a76f9514c Author: Yu Zhao yuzhao@google.com Date: Sun Sep 18 02:00:07 2022 -0600
mm: multi-gen LRU: kill switchFWIW - partially backporting (location of cgroup_mutex extern) from: 354ed5974429 ("mm: multi-gen LRU: kill switch")
fixes x86_64 build for me.
Regards,
--Tom
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
...
Yu, would you like to provide formal backport?
Are you suggesting backporting the entire MGLRU patchset (>30 patches)?
I do have the backport ready for 5.15 and multiple distros have taken it. But I don't think Greg would welcome it. I'd be happy to be wrong though.
I'm just going to drop all of these patches from the queues now, and let the original submitter resend them after they are fixed up properly.
thanks,
greg k-h
Hi!
I'm just going to drop all of these patches from the queues now, and let the original submitter resend them after they are fixed up properly.
Build errors are gone in 5.10.178-rc2:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/84...
and 5.15108-rc2 is okay too:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/84...
Best regards, Pavel
On Tue, Apr 18, 2023 at 10:56:22PM -0600, Yu Zhao wrote:
On Tue, Apr 18, 2023 at 10:18 PM Bagas Sanjaya bagasdotme@gmail.com wrote:
On Tue, Apr 18, 2023 at 10:51:05AM -0600, Tom Saeger wrote:
Tom Saeger identified that the below commit moves it out of ifdef.
commit 354ed597442952fb680c9cafc7e4eb8a76f9514c Author: Yu Zhao yuzhao@google.com Date: Sun Sep 18 02:00:07 2022 -0600
mm: multi-gen LRU: kill switchFWIW - partially backporting (location of cgroup_mutex extern) from: 354ed5974429 ("mm: multi-gen LRU: kill switch")
fixes x86_64 build for me.
Regards,
--Tom
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
...
Yu, would you like to provide formal backport?
Nah - an easier fix was suggested by Waiman (remove the lockdep_assert_held line) and confirmed here:
https://lore.kernel.org/stable/20230418192807.n3hggjak25tnat7i@oracle.com/
Are you suggesting backporting the entire MGLRU patchset (>30 patches)?
I do have the backport ready for 5.15 and multiple distros have taken it.
However, I am interested in testing 5.15 backport of MGLRU. Where might I find that?
--Tom
On Tue, Apr 18, 2023 at 08:17:12PM +0530, Naresh Kamboju wrote:
On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below.
thanks,
greg k-h
Following patch causing build break on stable-rc 5.15
Waiman Long longman@redhat.com cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build error: kernel/cgroup/cpuset.c: In function 'cpuset_can_fork': kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared (first use in this function); did you mean 'cgroup_put'? 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is reported only once for each function it appears in 2979 | lockdep_assert_held(&cgroup_mutex); | ^~~~~~~~~~~~ include/linux/lockdep.h:415:61: note: in definition of macro 'lockdep_assert_held' 415 | #define lockdep_assert_held(l) do { (void)(l); } while (0) | ^ make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15....
-- Linaro LKFT https://lkft.linaro.org
I've now dropped the offending patches and pushed out -rc2 releases for this, and the 5.10.y tree.
thanks,
greg k-h
On 4/18/2023 5:21 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below.
thanks,
greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on BMIPS_GENERIC:
Tested-by: Florian Fainelli f.fainelli@gmail.com
On 4/18/23 06:21, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan skhan@linuxfoundation.org
Note - I didn't see any build errors.
thanks, -- Shuah
On Tue, Apr 18, 2023 at 02:21:04PM +0200, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000. Anything received after that time might be too late.
Build results: total: 160 pass: 146 fail: 14 Failed builds: alpha:allmodconfig arm:omap2plus_defconfig arm:vexpress_defconfig arm64:defconfig i386:defconfig ia64:defconfig mips:defconfig parisc:allmodconfig parisc64:generic-64bit_defconfig powerpc:defconfig powerpc:ppc64e_defconfig powerpc:cell_defconfig s390:defconfig x86_64:defconfig Qemu test results: total: 499 pass: 452 fail: 47 Failed tests: mipsel64:64r6el_defconfig:notests:nonet:smp:ide:hd mipsel64:64r6el_defconfig:notests:nonet:smp:ide:hd mipsel64:64r6el_defconfig:notests:nonet:smp:ide:cd <all riscv32, riscv64, s390>
Build failures:
kernel/cgroup/cpuset.c: In function 'cpuset_can_fork': kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared
riscv32/riscv64 images crash.
[ 0.000000] Linux version 5.15.108-rc1-00092-g0b6a5617247c (groeck@server.roeck-us.net) (riscv32-linux-gcc (GCC) 11.3.0, GNU ld (GNU Binutils) 2.39) #1 SMP Tue Apr 18 14:19:32 PDT 2023 [ 0.000000] random: crng init done [ 0.000000] OF: fdt: Ignoring memory range 0x80000000 - 0x80400000 [ 0.000000] Machine model: riscv-virtio,qemu [ 0.000000] earlycon: uart8250 at MMIO 0x10000000 (options '115200') [ 0.000000] printk: bootconsole [uart8250] enabled [ 0.000000] efi: UEFI not found. [ 0.000000] Unable to handle kernel paging request at virtual address 00600001 [ 0.000000] Oops [#1] [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.15.108-rc1-00092-g0b6a5617247c #1 [ 0.000000] Hardware name: riscv-virtio,qemu (DT) [ 0.000000] epc : fdt_check_header+0x6/0x1ac [ 0.000000] ra : __unflatten_device_tree+0x32/0x106 [ 0.000000] epc : c04cf1dc ra : c0859f08 sp : c1c01f30 [ 0.000000] gp : c1d6dca8 tp : c1c0a9c0 t0 : 00000000 [ 0.000000] t1 : c100f4fc t2 : 00000000 s0 : c1c01f40 [ 0.000000] s1 : c0c25000 a0 : 00600000 a1 : 00000000 [ 0.000000] a2 : c1d74044 a3 : c0c253ae a4 : 00000000 [ 0.000000] a5 : c173a000 a6 : c1c01f2c a7 : 00000001 [ 0.000000] s2 : 00600000 s3 : c1d74044 s4 : c0c253ae [ 0.000000] s5 : 00000000 s6 : 00000000 s7 : 8001b020 [ 0.000000] s8 : 00002000 s9 : 800312e4 s10: 00000000 [ 0.000000] s11: 00000000 t3 : 00000000 t4 : 00000000 [ 0.000000] t5 : a0000000 t6 : 80400000 [ 0.000000] status: 00000100 badaddr: 00600001 cause: 0000000d [ 0.000000] [<c04cf1dc>] fdt_check_header+0x6/0x1ac [ 0.000000] ---[ end trace 6977e3ccdb629cdf ]--- [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
Bisect points to
08ace525df14 riscv: Do not set initial_boot_params to the linear address of the dtb
This is not surprising, because that commit says:
"early_init_dt_verify() is already called in parse_dtb() and since the dtb address does not change anymore (it is now in the fixmap region), no need to reset initial_boot_params by calling early_init_dt_verify() again. "
However, the patch which actually moves the early dtb mapping into the fixmap region was not backported (and looks quite invasive to me). That makes me wonder ... why is this a stable release candidate in the first place ?
Guenter
On Tue, Apr 18, 2023 at 02:21:04PM +0200, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 5.15.108 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
I have also encountered the same build error as Naresh has reported [1] when cross-compiling for arm64 (bcm2711_defconfig, GCC 10.2.0). powerpc (ps3_defconfig, GCC 12.2.0) build isn't affected.
Reported-by: Bagas Sanjaya bagasdotme@gmail.com
[1]: https://lore.kernel.org/lkml/CA+G9fYs9sHnfhn4hSFP=AmOfgj-zvoK9vmBejRvzKPj4uX...
-
Bagas Sanjaya -
Florian Fainelli -
Greg Kroah-Hartman -
Guenter Roeck -
Harshit Mogalapalli -
Naresh Kamboju -
Pavel Machek -
Shuah Khan -
Tom Saeger -
Yu Zhao