Sched-tools

sched-tools@lists.linaro.org

94 discussions

by Vincent Guittot

add a template.json file that can be used by tune_json.py to create use cases with various type a load Signed-off-by: Vincent Guittot <vincent.guittot(a)linaro.org> --- doc/examples/template.json | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 doc/examples/template.json diff --git a/doc/examples/template.json b/doc/examples/template.json new file mode 100644 index 0000000..5ed3215 --- /dev/null +++ b/doc/examples/template.json @@ -0,0 +1,28 @@ +{ + /* + * Simple use case which creates 10% load + * for 6 seconds. + * A "sleep" : 0 has been added so the file can be used by tune_json.py to + * use a sleep event instead of the timer. In this latter case, you need + * to set the timer's period to 0 + */ + "tasks" : { + "thread0" : { + "instance" : 1, + "loop" : -1, + "run" : 10000, + "sleep" : 0, + "timer" : { "ref" : "unique", "period" : 100000 } + } + }, + "global" : { + "duration" : 6, + "calibration" : "CPU0", + "default_policy" : "SCHED_OTHER", + "pi_enabled" : false, + "lock_pages" : false, + "logdir" : "./", + "log_basename" : "rt-app2", + "gnuplot" : true + } +} -- 1.9.1

8 years, 11 months

Re: [Sched-tools] [PATCH v2] rt-app: Add IO-bounded and memory-bounded events.

by Vincent Guittot

with the new list @ On 29 May 2015 at 11:19, Vincent Guittot <vincent.guittot(a)linaro.org> wrote: > Hi Pi-cheng, > > On 16 December 2014 at 04:57, pi-cheng.chen <pi-cheng.chen(a)linaro.org> wrote: >> Add 2 new kind of event for running a memory or a io bounded load. >> "mem" name for a load is memory bounded, and "iorun" name for a load is io >> bounded. The default file to be written to create the load is /dev/null and >> the device/file could be specified with "io_device" key in "global" section. >> The size of per-thread memory buffer to create IO/memory load could also be >> specified with "mem_buffer_size" in the same section. >> >> E.g. >> "tasks" : { >> "thread0" : >> { "sleep" : 1000, "run" : 100, "mem" : 1000, "sleep" 10000, "iorun" : 1000 } >> }, >> "global" : { "io_device" : "/dev/ttyS0", "mem_buffer_size" : 1048576 } >> >> changes v1 to v2: >> Allocate per-thread memory buffer. Add "mem_buffer_size" in global section to >> set the size of memory buffer to be allocated. And fix possible buffer overrun >> when creating IO-bounded load. >> >> Signed-off-by: pi-cheng.chen <pi-cheng.chen(a)linaro.org> >> --- >> src/rt-app.c | 104 +++++++++++++++++++++++++++++++++++++++++++++- >> src/rt-app_parse_config.c | 27 ++++++++++++ >> src/rt-app_types.h | 11 +++++ >> 3 files changed, 140 insertions(+), 2 deletions(-) >> >> diff --git a/src/rt-app.c b/src/rt-app.c >> index 3cd601d..16bbe48 100644 >> --- a/src/rt-app.c >> +++ b/src/rt-app.c >> @@ -33,7 +33,9 @@ static volatile int continue_running; >> static pthread_t *threads; >> static int nthreads; >> static int p_load; >> +static int io_fd; >> rtapp_options_t opts; >> +static iomem_buf_t *iomem_buf; > > You should better create a iomem_buf_t iomem_buf field into the thread > struct so you don't have to allocate additionnal array beside > >> >> static ftrace_data_t ft_data = { >> .debugfs = "/sys/kernel/debug", >> @@ -110,8 +112,57 @@ static inline loadwait(unsigned long exec) >> return load_count; >> } >> >> +static void ioload(unsigned long count, iomem_buf_t *iomem) >> +{ >> + ssize_t ret; >> + >> + while (count != 0) { >> + unsigned long size; >> + >> + if (count > iomem->size) >> + size = iomem->size; >> + else >> + size = count; > > Why can't we loop on the buffer and write more than it's size in the io ? > >> + >> + if (size > (iomem->size - iomem->pos)) >> + size = iomem->size - iomem->pos; >> + >> + ret = write(io_fd, iomem->buf + iomem->pos, size); >> + if (ret == -1) { >> + perror("write"); >> + return; >> + } >> + count -= ret; >> + iomem->pos += ret; >> + if (iomem->pos >= iomem->size) >> + iomem->pos -= iomem->size; >> + } >> +} >> + >> +static void memload(unsigned long count, iomem_buf_t *iomem) >> +{ >> + while (count > 0) { >> + unsigned long size; >> + >> + if (count > iomem->size) >> + size = iomem->size; >> + else >> + size = count; > > same question as for io > >> + >> + if (size > (iomem->size - iomem->pos)) >> + size = iomem->size - iomem->pos; >> + >> + memset(iomem->buf + iomem->pos, 0, size); >> + count -= size; >> + iomem->pos += size; >> + if (iomem->pos >= iomem->size) >> + iomem->pos -= iomem->size; >> + } >> +} >> + >> static int run_event(event_data_t *event, int dry_run, >> - unsigned long *perf, unsigned long *duration, rtapp_resource_t *resources) >> + unsigned long *perf, unsigned long *duration, >> + rtapp_resource_t *resources, int ind) >> { >> rtapp_resource_t *rdata = &(resources[event->res]); >> rtapp_resource_t *ddata = &(resources[event->dep]); >> @@ -196,6 +247,18 @@ static int run_event(event_data_t *event, int dry_run, >> pthread_mutex_unlock(&(ddata->res.mtx.obj)); >> break; >> } >> + case rtapp_mem: >> + { >> + log_debug("mem %d", event->count); >> + memload(event->count, &iomem_buf[ind]); >> + } >> + break; >> + case rtapp_iorun: >> + { >> + log_debug("iorun %d", event->count); >> + ioload(event->count, &iomem_buf[ind]); >> + } >> + break; >> } >> >> return lock; >> @@ -218,7 +281,8 @@ int run(int ind, event_data_t *events, >> log_ftrace(ft_data.marker_fd, >> "[%d] locking %d", >> ind, events[i].type); >> - lock += run_event(&events[i], !continue_running, &perf, duration, resources); >> + lock += run_event(&events[i], !continue_running, &perf, >> + duration, resources, ind); >> } >> >> return perf; >> @@ -488,6 +552,35 @@ int main(int argc, char* argv[]) >> >> parse_command_line(argc, argv, &opts); >> >> + /* >> + * allocate per-thread memory buffers for memory-bound and IO-bound >> + * busy loops >> + */ >> + iomem_buf = malloc(sizeof(iomem_buf_t) * opts.nthreads); >> + if (!iomem_buf) { >> + log_error("Cannot allocate memory for IO/memory buffer struct"); >> + exit(EXIT_FAILURE); >> + } >> + for (i = 0; i < opts.nthreads; i++) { >> + iomem_buf_t *iomem = &iomem_buf[i]; >> + >> + iomem->size = opts.mem_buffer_size; >> + iomem->buf = malloc(iomem->size); >> + if (!iomem->buf) { >> + log_error("Cannot allocate memory for memory-bounded" >> + "and IO-bounded busy loops"); >> + exit(EXIT_FAILURE); >> + } >> + iomem->pos = 0; >> + } >> + >> + /* open file for IO-bound busy loops */ >> + io_fd = open(opts.io_device, O_CREAT | O_WRONLY, 0644); >> + if (io_fd < 0) { >> + log_error("Cannot open io_device file %s", opts.io_device); >> + exit(EXIT_FAILURE); >> + } >> + >> /* allocated threads */ >> nthreads = opts.nthreads; >> threads = malloc(nthreads * sizeof(pthread_t)); >> @@ -713,6 +806,13 @@ int main(int argc, char* argv[]) >> close(ft_data.trace_fd); >> close(ft_data.marker_fd); >> } >> + >> + close(io_fd); >> + >> + for (i = 0; i < nthreads; i++) >> + free(iomem_buf[i].buf); >> + free(iomem_buf); >> + >> exit(EXIT_SUCCESS); >> >> >> diff --git a/src/rt-app_parse_config.c b/src/rt-app_parse_config.c >> index e062f79..9bdf38a 100644 >> --- a/src/rt-app_parse_config.c >> +++ b/src/rt-app_parse_config.c >> @@ -27,6 +27,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. >> #define PIN2 PIN" " >> #define PIN3 PIN2" " >> #define JSON_FILE_BUF_SIZE 4096 >> +#define DEFAULT_MEM_BUF_SIZE (4 * 1024 * 1024) >> >> /* redefine foreach as in <json/json_object.h> but to be ANSI >> * compatible */ >> @@ -320,6 +321,22 @@ parse_thread_event_data(char *name, struct json_object *obj, >> return; >> } >> >> + if (!strncmp(name, "mem", strlen("mem")) || >> + !strncmp(name, "iorun", strlen("iorun"))) { >> + if (!json_object_is_type(obj, json_type_int)) >> + goto unknown_event; >> + >> + data->count = json_object_get_int(obj); >> + >> + if (!strncmp(name, "mem", strlen("mem"))) >> + data->type = rtapp_mem; >> + else >> + data->type = rtapp_iorun; >> + >> + log_info(PIN2 "type %d count %d", data->type, data->count); >> + return; >> + } >> + >> if (!strncmp(name, "lock", strlen("lock")) || >> !strncmp(name, "unlock", strlen("unlock"))) { >> >> @@ -493,6 +510,10 @@ obj_is_event(char *name) >> return rtapp_suspend; >> if (!strncmp(name, "resume", strlen("resume"))) >> return rtapp_resume; >> + if (!strncmp(name, "mem", strlen("mem"))) >> + return rtapp_mem; >> + if (!strncmp(name, "iorun", strlen("iorun"))) >> + return rtapp_iorun; >> >> return 0; >> } >> @@ -677,6 +698,8 @@ parse_global(struct json_object *global, rtapp_options_t *opts) >> opts->logbasename = strdup("rt-app"); >> opts->ftrace = 0; >> opts->pi_enabled = 0; >> + opts->io_device = strdup("/dev/null"); >> + opts->mem_buffer_size = DEFAULT_MEM_BUF_SIZE; >> return; >> } >> >> @@ -719,6 +742,10 @@ parse_global(struct json_object *global, rtapp_options_t *opts) >> TRUE, "rt-app"); >> opts->ftrace = get_bool_value_from(global, "ftrace", TRUE, 0); >> opts->pi_enabled = get_bool_value_from(global, "pi_enabled", TRUE, 0); >> + opts->io_device = get_string_value_from(global, "io_device", TRUE, >> + "/dev/null"); >> + opts->mem_buffer_size = get_int_value_from(global, "mem_buffer_size", >> + TRUE, DEFAULT_MEM_BUF_SIZE); >> >> } >> >> diff --git a/src/rt-app_types.h b/src/rt-app_types.h >> index cefb3a6..d230d45 100644 >> --- a/src/rt-app_types.h >> +++ b/src/rt-app_types.h >> @@ -65,6 +65,8 @@ typedef enum resource_t >> rtapp_timer, >> rtapp_suspend, >> rtapp_resume, >> + rtapp_mem, >> + rtapp_iorun, >> } resource_t; >> >> struct _rtapp_mutex { >> @@ -103,6 +105,7 @@ typedef struct _event_data_t { >> int res; >> int dep; >> int duration; >> + int count; >> } event_data_t; >> >> typedef struct _phase_data_t { >> @@ -165,6 +168,8 @@ typedef struct _rtapp_options_t { >> >> int ftrace; >> int die_on_dmiss; >> + char *io_device; >> + int mem_buffer_size; >> } rtapp_options_t; >> >> typedef struct _timing_point_t { >> @@ -177,4 +182,10 @@ typedef struct _timing_point_t { >> __u64 rel_start_time; >> } timing_point_t; >> >> +typedef struct { >> + char *buf; >> + int pos; >> + int size; >> +} iomem_buf_t; >> + >> #endif // _RTAPP_TYPES_H_ >> -- >> 1.9.1 >>

8 years, 11 months

[PATCH] rt-app: fix calibration issue on mt8173

by Vincent Guittot

Calibration sequence fails to get the right ns per loop value when the calibration is done on the A57 cluster of the mt8173evb. A new calibration has been added that adds a sleep period between each each calibration loop. This idle phase enable rt-app to get the to get the right ns per loop value for such kind of HW. The calibration sequence finally uses the lowest value of the calibration methods which match with the highest compute capacity Reported-by: Koan-Sin Tan <freedom.tan(a)linaro.org> Signed-off-by: Vincent Guittot <vincent.guittot(a)linaro.org> --- src/rt-app.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 75 insertions(+), 5 deletions(-) diff --git a/src/rt-app.c b/src/rt-app.c index 97aee0f..37e9892 100644 --- a/src/rt-app.c +++ b/src/rt-app.c @@ -62,12 +62,14 @@ void waste_cpu_cycles(int load_loops) } /* -* calibrate_cpu_cycles() -* collects the time that waste_cycles runs. +* calibrate_cpu_cycles_1() +* 1st method to calibrate the ns per loop value +* We alternate idle period and run period in order to not trig some hw +* protection mechanism like thermal mitgation */ -int calibrate_cpu_cycles(int clock) +int calibrate_cpu_cycles_1(int clock) { - struct timespec start, stop; + struct timespec start, stop, sleep; int max_load_loop = 10000; unsigned int diff; int nsec_per_loop, avg_per_loop = 0; @@ -75,6 +77,10 @@ int calibrate_cpu_cycles(int clock) while (cal_trial) { cal_trial--; + sleep.tv_sec = 1; + sleep.tv_nsec = 0; + + clock_nanosleep(CLOCK_MONOTONIC, 0, &sleep, NULL); clock_gettime(clock, &start); waste_cpu_cycles(max_load_loop); @@ -100,6 +106,69 @@ int calibrate_cpu_cycles(int clock) return 0; } +/* +* calibrate_cpu_cycles_2() +* 2nd method to calibrate the ns per loop value +* We continously runs something to ensure that CPU is set to max freq by the +* governor +*/ +int calibrate_cpu_cycles_2(int clock) +{ + struct timespec start, stop, sleep; + int max_load_loop = 10000; + unsigned int diff; + int nsec_per_loop, avg_per_loop = 0; + int ret, cal_trial = 1000; + + while (cal_trial) { + cal_trial--; + + clock_gettime(clock, &start); + waste_cpu_cycles(max_load_loop); + clock_gettime(clock, &stop); + + diff = (int)timespec_sub_to_ns(&stop, &start); + nsec_per_loop = diff / max_load_loop; + avg_per_loop = (avg_per_loop + nsec_per_loop) >> 1; + + /* collect a critical mass of samples.*/ + if ((abs(nsec_per_loop - avg_per_loop) * 50) < avg_per_loop) + return avg_per_loop; + + /* + * use several loop duration in order to be sure to not + * fall into a specific platform loop duration + *(like the cpufreq period) + */ + /*randomize the number of loops and recheck 1000 times*/ + max_load_loop += 33333; + max_load_loop %= 1000000; + } + return 0; +} + +/* +* calibrate_cpu_cycles() +* Use several methods to calibrate the ns per loop and get the min value which +* correspond to the highest achievable compute capacity. +*/ +int calibrate_cpu_cycles(int clock) +{ + int calib1, calib2; + + /* Run 1st method */ + calib1 = calibrate_cpu_cycles_1(clock); + + /* Run 2nd method */ + calib2 = calibrate_cpu_cycles_2(clock); + + if (calib1 < calib2) + return calib1; + else + return calib2; + +} + static inline loadwait(unsigned long exec) { unsigned long load_count; @@ -531,13 +600,14 @@ int main(int argc, char* argv[]) /* Needs to calibrate 'calib_cpu' core */ if (opts.calib_ns_per_loop == 0) { + log_notice("Calibrate ns per loop"); cpu_set_t calib_set; CPU_ZERO(&calib_set); CPU_SET(opts.calib_cpu, &calib_set); sched_getaffinity(0, sizeof(cpu_set_t), &orig_set); sched_setaffinity(0, sizeof(cpu_set_t), &calib_set); - p_load = calibrate_cpu_cycles(CLOCK_THREAD_CPUTIME_ID); + p_load = calibrate_cpu_cycles(CLOCK_MONOTONIC); sched_setaffinity(0, sizeof(cpu_set_t), &orig_set); log_notice("pLoad = %dns : calib_cpu %d", p_load, opts.calib_cpu); } else { -- 1.9.1

8 years, 11 months

[PATCH] Add a script to tune parameters in json file.

by pi-cheng.chen

This scripts strips all comments in the input JSON file, modifies the parameters according to commnad line arguments, and write the content to a new JSON file. Signed-off-by: pi-cheng.chen <pi-cheng.chen(a)linaro.org> --- doc/tune_json.py | 131 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+) create mode 100755 doc/tune_json.py diff --git a/doc/tune_json.py b/doc/tune_json.py new file mode 100755 index 0000000..7e2ca82 --- /dev/null +++ b/doc/tune_json.py @@ -0,0 +1,131 @@ +#!/usr/bin/env python + +import argparse +import collections +import json +import os +import re +import shutil +import sys +import tempfile + + +def find_dict_by_key(doc, key): + if key in doc and type(doc[key]) is collections.OrderedDict: + return doc[key] + + for k in doc: + if type(doc[k]) is collections.OrderedDict: + return find_dict_by_key(doc[k], key) + + +def dict_find_and_replace_value(dic, key, val): + for k in dic: + if type(dic[k]) is collections.OrderedDict: + dict_find_and_replace_value(dic[k], key, val) + if k == key: + dic[k] = val + + +def dict_of_loading(dic): + if not 'run' in dic: + return False, None + + for k in dic: + if 'timer' in k and 'period' in dic[k]: + return True, k + else: + return False, None + + +def calculate_and_update_loading(dic, loading): + of_loading, timer_id = dict_of_loading(dic) + + if of_loading: + period = dic[timer_id]['period'] + run = period * loading / 100 + dic['run'] = run + + for k in dic: + if type(dic[k]) is collections.OrderedDict: + calculate_and_update_loading(dic[k], loading) + + +# strip comments in json file and load the file as a dict +def load_json_file(filename): + try: + f = open(filename, 'r') + except: + print 'ERROR: Unable to open %s' %filename + sys.exit(2) + + comment_re = re.compile( + '(^)?[^\S\n]*/(?:\*(.*?)\*/[^\S\n]*|/[^\n]*)($)?', + re.DOTALL | re.MULTILINE) + + content = ''.join(f.readlines()) + f.close() + + match = comment_re.search(content) + while match: + content = content[:match.start()] + content[match.end():] + match = comment_re.search(content) + + return json.JSONDecoder(object_pairs_hook=collections.OrderedDict).decode(content) + + +def dump_json_file(doc, outfile): + tmp = tempfile.NamedTemporaryFile(delete=False) + json.dump(doc, tmp, indent=4, sort_keys=False) + tmp.close() + + shutil.move(tmp.name, outfile) + + +if __name__ == '__main__': + parser = argparse.ArgumentParser() + + parser.add_argument('-f', '--file', dest='infile', default='', help='input json filename') + parser.add_argument('-o', '--out', dest='outfile', default='workload.json', help='output json filename'); + parser.add_argument('--instance', default=0, type=int, help='number of thread instance') + parser.add_argument('--period', default=0, type=int, help='period of each thread/phase (ms)') + parser.add_argument('--run', default=0, type=int, help='run time of each thread/phase (ms)') + parser.add_argument('--sleep', default=0, type=int, help='sleep time of each thread/phase (ms)') + parser.add_argument('--loop', default=0,type=int, help='loop count of each thread/phase (-1 as infinite loop)') + parser.add_argument('--loading', default=0, type=int, help='loading of each thread (%%)') + parser.add_argument('--key', type=str, help='the key id of thread/phase in which the parameters will be changed') + + args = parser.parse_args() + + if not os.path.isfile(args.infile): + print 'ERROR: input file %s does not exist\n' %args.infile + parser.print_help() + sys.exit(2) + + doc = target = load_json_file(args.infile) + + if args.key: + target = find_dict_by_key(doc, args.key) + if not target: + print 'ERROR: key id %s is not found' %args.key + sys.exit(2) + + if args.instance > 0: + dict_find_and_replace_value(target, 'instance', args.instance) + + if args.period > 0: + dict_find_and_replace_value(target, 'period', args.period * 1000) + + if args.run > 0: + dict_find_and_replace_value(target, 'run', args.run * 1000) + + if args.sleep > 0: + dict_find_and_replace_value(target, 'sleep', args.sleep * 1000) + + if args.loop > 0 or args.loop == -1: + dict_find_and_replace_value(target, 'loop', args.loop) + + if args.loading > 0: + calculate_and_update_loading(target, args.loading); + + dump_json_file(doc, args.outfile) -- 1.9.1

8 years, 11 months

[PATCH v2] idlestat: add regression test functions for idlestat

by Zhaoyang Huang

This commit add regression test for idlestat and add mmap function for mapping the trace file to process memory.Please find bellowing message for how to use. eg: import the mytrace file and compare it with previous mytrace_old file to see if they match each other make reg_trace eg: import mytrace file and export the report file as myreport_new. compare the myreport_new with myreport_old to see if they match with each other make reg_output eg: set the store format of ftrace as bin and mmap it to userspace ./idlestat --trace -f ./mytrace -t 10 -m --- Makefile | 5 ++ idlestat.c | 211 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- idlestat.h | 7 +- topology.c | 19 ++++++ topology.h | 1 + trace.h | 1 + utils.c | 12 ++++ utils.h | 1 + 8 files changed, 255 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 42f16d7..1eb8f68 100644 --- a/Makefile +++ b/Makefile @@ -47,5 +47,10 @@ install: idlestat idlestat.1 install -D -t /usr/local/bin idlestat install -D -t /usr/local/man/man1 idlestat.1 +reg_trace: idlestat + ./idlestat --regression -f ./mytrace -b ./mytrace_old -T +reg_output: idlestat + ./idlestat --regression -f ./mytrace -p -c -w -o ./myreport_new -b ./myreport_old -O + rm ./myreport_new clean: rm -f $(OBJS) idlestat diff --git a/idlestat.c b/idlestat.c index 4d773f4..d84fae5 100644 --- a/idlestat.c +++ b/idlestat.c @@ -41,6 +41,13 @@ #ifdef ANDROID #include <libgen.h> #endif +#include <sys/mman.h> /* for mmap and munmap */ +#include <sys/types.h> /* for open */ +#include <sys/stat.h> /* for open */ +#include <fcntl.h> /* for open */ +#include <unistd.h> /* for lseek and write */ +#include <stdio.h> +#include <string.h> /* for memcpy */ #include "idlestat.h" #include "utils.h" @@ -1074,6 +1081,7 @@ int getoptions(int argc, char *argv[], struct program_options *options) struct option long_options[] = { { "trace", no_argument, &options->mode, TRACE }, { "import", no_argument, &options->mode, IMPORT }, + { "regression", no_argument, &options->mode, REGRESSION }, { "baseline-trace", required_argument, NULL, 'b' }, { "idle", no_argument, NULL, 'c' }, { "energy-model-file", required_argument, NULL, 'e' }, @@ -1090,6 +1098,9 @@ int getoptions(int argc, char *argv[], struct program_options *options) { "poll-interval", required_argument, NULL, 'I' }, { "buffer-size", required_argument, NULL, 'S' }, { "version", no_argument, NULL, 'V' }, + { "mmap", optional_argument, NULL, 'm' }, + { "trace file compare", no_argument, NULL, 'T' }, + { "output file compare", no_argument, NULL, 'O' }, { 0, 0, 0, 0 } }; int c; @@ -1103,7 +1114,7 @@ int getoptions(int argc, char *argv[], struct program_options *options) int optindex = 0; - c = getopt_long(argc, argv, ":b:ce:f:ho:pr:t:vwBCI:S:V", + c = getopt_long(argc, argv, ":b:ce:f:ho:pr:t:vwBCI:S:VmTO", long_options, &optindex); if (c == -1) break; @@ -1174,6 +1185,15 @@ int getoptions(int argc, char *argv[], struct program_options *options) case 'S': options->tbs.percpu_buffer_size = atoi(optarg); break; + case 'm': + options->mmap_flag = true; + break; + case 'T': + options->tracefile_comp_flag = true; + break; + case 'O': + options->output_comp_flag = true; + break; case 0: /* getopt_long() set a variable, just keep going */ break; case ':': /* missing option argument */ @@ -1197,6 +1217,21 @@ int getoptions(int argc, char *argv[], struct program_options *options) return -1; } + if (options->mode == REGRESSION) { + if ((options->filename == NULL) + &&(options->outfilename == NULL)) { + fprintf(stderr, "expected file name for regression test\n"); + return -1; + } + if (options->filename && bad_filename(options->filename)) + return -1; + + if (options->outfilename && bad_filename(options->outfilename)) + return -1; + + return optind; + } + if (NULL == options->filename) { fprintf(stderr, "expected -f <trace filename>\n"); return -1; @@ -1401,6 +1436,136 @@ static int execute(int argc, char *argv[], char *const envp[], return -1; } +int binary_compare(struct program_options * options,char *const envp[]) +{ + char * argv[4]; + int ret = 0; + + argv[0] = "diff"; + argv[1] = options->filename; + argv[2] = options->baseline_filename; + argv[3] = "-s"; + + ret = execvpe(argv[0], argv, envp); + if(ret){ + perror("execvpe"); + printf("binary compare error\n"); + } + +} + +int output_compare(struct program_options * options,char *const envp[]) +{ + struct report_ops *output_handler = NULL; + void *report_data = NULL; + struct cpu_topology *cpu_topo = NULL; + struct cpuidle_datas *datas; + char * tmp_filename; + int ret = 0; + /* Load the idle states information */ + datas = idlestat_load(options->filename); + + if (is_err(datas)) + return 1; + + cpu_topo = datas->topo; + + output_handler = get_report_ops(options->report_type_name); + if (is_err(output_handler)) + return 1; + + if (output_handler->open_report_file(options->outfilename, report_data)) + return 1; + + if (options->display & IDLE_DISPLAY) { + output_handler->cstate_table_header(report_data); + dump_cpu_topo_info(output_handler, report_data, + display_cstates, cpu_topo, 1); + output_handler->cstate_table_footer(report_data); + } + + if (options->display & FREQUENCY_DISPLAY) { + output_handler->pstate_table_header(report_data); + dump_cpu_topo_info(output_handler, report_data, + display_pstates, cpu_topo, 0); + output_handler->pstate_table_footer(report_data); + } + + if (options->display & WAKEUP_DISPLAY) { + output_handler->wakeup_table_header(report_data); + dump_cpu_topo_info(output_handler, report_data, + display_wakeup, cpu_topo, 1); + output_handler->wakeup_table_footer(report_data); + } + + restore_stdout(); + + /*backup the filename*/ + tmp_filename = options->filename; + + /*compare the new output file with the old one*/ + options->filename = options->outfilename; + ret = binary_compare(options,envp); + + if(ret) + printf("output file comparsion of %s and %s failed\n",options->filename,options->baseline_filename); + else + printf("[IDLE_STAT REGRESSION TEST] <output_compare success>\n"); + /*restore the file name*/ + options->filename = tmp_filename; + + + return ret; + +} + +int regression(struct program_options * options,char *const envp[]) +{ + struct cpuidle_datas *datas; + struct cpu_topology *cpu_topo = NULL; + struct report_ops *output_handler = NULL; + int ret = 0; + + char topo_info[512]; + + output_handler = get_report_ops(options->report_type_name); + if (is_err(output_handler)) + return 1; + + if (output_handler->check_options && + output_handler->check_options(options) < 0) + return 1; + + /* Load the idle states information */ + datas = idlestat_load(options->filename); + + if (is_err(datas)){ + fprintf(stderr, "[IDLE_STAT REGRESSION TEST] <trace file import failed>\n"); + ret = -1; + } + else + printf("[IDLE_STAT REGRESSION TEST] <trace file import success>\n"); + + cpu_topo = read_sysfs_cpu_topo(); + if (is_err(cpu_topo)) { + fprintf(stderr, "Failed to read CPU topology info from" + " sysfs.\n"); + ret = -1; + } + else{ + outstr_topo_info(topo_info,cpu_topo); + printf("%s",topo_info); + printf("[IDLE_STAT REGRESSION TEST] <CPU topology info read success>\n"); + } + + if(options->tracefile_comp_flag) + ret = binary_compare(options, envp); + if(options->output_comp_flag) + ret = output_compare(options, envp); + + return ret; +} + int main(int argc, char *argv[], char *const envp[]) { struct cpuidle_datas *datas; @@ -1414,10 +1579,24 @@ int main(int argc, char *argv[], char *const envp[]) struct trace_options *saved_trace_options = NULL; void *report_data = NULL; + int fd; + int flength; + struct stat statbuff; + args = getoptions(argc, argv, &options); if (args <= 0) return 1; + if (options.mode == REGRESSION){ + if (regression(&options,envp)){ + printf("regression failed\n"); + } + else{ + printf("regression success\n"); + } + return 0; + } + /* Tracing requires manipulation of some files only accessible * to root */ if ((options.mode == TRACE) && getuid()) { @@ -1497,6 +1676,16 @@ int main(int argc, char *argv[], char *const envp[]) initp = build_init_pstates(cpu_topo); + /* + set the trace file format to bin + */ + if(options.mmap_flag){ + FILE * file; + file = fopen(TRACE_OPTIONS, "r+"); + perror(__func__); + printf("%s open %p\n",TRACE_OPTIONS,file); + store_line("bin",(void *)file); + } /* Start the recording */ if (idlestat_trace_enable(true)) goto err_restore_trace_options; @@ -1532,6 +1721,26 @@ int main(int argc, char *argv[], char *const envp[]) initp, cpu_topo)) goto err_restore_trace_options; + if(options.mmap_flag){ + fd = open(options.filename, O_RDONLY); + if((fd == -1) || fstat(fd, &statbuff)){ + perror(__func__); + printf("[idlestat] file length get failed\n"); + close(fd); + return 1; + } + flength = statbuff.st_size; + printf("[idlestat]: mmaped file is %s fd %x length %d\n",options.filename,fd,flength); + options.mapped_mem = mmap(NULL, flength, PROT_READ,MAP_PRIVATE,fd,0); + if((int)(void *)options.mapped_mem == (int)-1){ + perror(__func__); + close(fd); + return 1; + } + //printf("%s\n", options.mapped_mem); + close(fd); + } + /* Restore original kernel ftrace options */ if (idlestat_restore_trace_options(saved_trace_options)) return 1; diff --git a/idlestat.h b/idlestat.h index e030f6a..1ca9748 100644 --- a/idlestat.h +++ b/idlestat.h @@ -121,7 +121,8 @@ struct cpuidle_datas { enum modes { TRACE = 0, - IMPORT + IMPORT, + REGRESSION }; struct trace_buffer_settings { @@ -140,6 +141,10 @@ struct program_options { int verbose; char *energy_model_filename; char *report_type_name; + bool mmap_flag; + bool tracefile_comp_flag; + bool output_comp_flag; + char * mapped_mem; }; #define IDLE_DISPLAY 0x1 diff --git a/topology.c b/topology.c index 39b07bd..ee00bfe 100644 --- a/topology.c +++ b/topology.c @@ -280,6 +280,25 @@ int outfile_topo_info(FILE *f, struct cpu_topology *topo_list) return 0; } +int outstr_topo_info(char *s, struct cpu_topology *topo_list) +{ + struct cpu_physical *s_phy; + struct cpu_core *s_core; + struct cpu_cpu *s_cpu; + + list_for_each_entry(s_phy, &topo_list->physical_head, list_physical) { + sprintf(s, "cluster%c:\n", s_phy->physical_id + 'A'); + list_for_each_entry(s_core, &s_phy->core_head, list_core) { + sprintf(s, "\tcore%d\n", s_core->core_id); + list_for_each_entry(s_cpu, &s_core->cpu_head, list_cpu){ + sprintf(s, "\t\tcpu%d\n", s_cpu->cpu_id); + } + } + } + + return 0; +} + struct cpu_cpu *find_cpu_point(struct cpu_topology *topo_list, int cpuid) { struct cpu_physical *s_phy; diff --git a/topology.h b/topology.h index 84e5bc1..4c7964e 100644 --- a/topology.h +++ b/topology.h @@ -115,5 +115,6 @@ extern int core_get_highest_freq(struct cpu_core *core); core_get_highest_freq(cpu_to_core(cpuid, topo)) extern int setup_topo_states(struct cpuidle_datas *datas); +extern int outstr_topo_info(char *s, struct cpu_topology *topo_list); #endif diff --git a/trace.h b/trace.h index a2f5867..29b4d93 100644 --- a/trace.h +++ b/trace.h @@ -34,6 +34,7 @@ #define TRACE_FREE TRACE_PATH "/free_buffer" #define TRACE_FILE TRACE_PATH "/trace" #define TRACE_STAT_FILE TRACE_PATH "/per_cpu/cpu0/stats" +#define TRACE_OPTIONS TRACE_PATH "/trace_options" #define TRACE_IDLE_NRHITS_PER_SEC 10000 #define TRACE_IDLE_LENGTH 196 #define TRACE_CPUFREQ_NRHITS_PER_SEC 100 diff --git a/utils.c b/utils.c index 48be965..931829b 100644 --- a/utils.c +++ b/utils.c @@ -210,14 +210,17 @@ out_free: return ret; } +int std_fd; int redirect_stdout_to_file(const char *path) { int ret = 0; int fd; if (path) { + std_fd = dup(STDOUT_FILENO); fd = open(path, O_RDWR | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR | S_IRGRP |S_IROTH); + if (fd < 0) { fprintf(stderr, "%s: failed to open '%s'\n", __func__, path); return -1; @@ -237,6 +240,15 @@ int redirect_stdout_to_file(const char *path) return 0; } +int restore_stdout() +{ + int ret = -1; + if(std_fd != NULL) + ret = dup2(std_fd,STDOUT_FILENO); + printf("%s %d \n",__func__,ret); + return ret; +} + void display_factored_time(double time, int align) { char buffer[128]; diff --git a/utils.h b/utils.h index ee7a9a2..6b8808c 100644 --- a/utils.h +++ b/utils.h @@ -49,5 +49,6 @@ extern int check_window_size(void); extern int error(const char *str); extern void *ptrerror(const char *str); extern int is_err(const void *ptr); +extern int restore_stdout(); #endif -- 1.7.9.5

8 years, 11 months

[PATCH] idlestat: add regression test functions for idlestat

by Zhaoyang Huang

This commit add regression test for idlestat.Please find bellowing message for how to use. eg: import the mytrace file and compare it with previous mytrace_old file to see if they match each other ./idlestat --regression -f ./mytrace -t 10 -p -c -w -b ./mytrace_old -T eg: import mytrace file and export the report file as myreport_new. compare the myreport_new with myreport_old to see if they match with each other ./idlestat --regression -f ./mytrace -t 10 -p -c -w -o ./myreport_new -b ./myreport_old -O eg: set the store format of ftrace as bin and mmap it to userspace ./idlestat --trace -f ./mytrace -t 10 -m Signed-off-by: Zhaoyang Huang <zhaoyang.huang(a)linaro.org> --- idlestat.c | 233 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- idlestat.h | 7 +- topology.c | 19 +++++ topology.h | 1 + trace.h | 1 + utils.c | 10 +++ utils.h | 1 + 7 files changed, 270 insertions(+), 2 deletions(-) diff --git a/idlestat.c b/idlestat.c index 4d773f4..cb481c9 100644 --- a/idlestat.c +++ b/idlestat.c @@ -41,6 +41,13 @@ #ifdef ANDROID #include <libgen.h> #endif +#include <sys/mman.h> /* for mmap and munmap */ +#include <sys/types.h> /* for open */ +#include <sys/stat.h> /* for open */ +#include <fcntl.h> /* for open */ +#include <unistd.h> /* for lseek and write */ +#include <stdio.h> +#include <string.h> /* for memcpy */ #include "idlestat.h" #include "utils.h" @@ -1074,6 +1081,7 @@ int getoptions(int argc, char *argv[], struct program_options *options) struct option long_options[] = { { "trace", no_argument, &options->mode, TRACE }, { "import", no_argument, &options->mode, IMPORT }, + { "regression", no_argument, &options->mode, REGRESSION }, { "baseline-trace", required_argument, NULL, 'b' }, { "idle", no_argument, NULL, 'c' }, { "energy-model-file", required_argument, NULL, 'e' }, @@ -1090,6 +1098,9 @@ int getoptions(int argc, char *argv[], struct program_options *options) { "poll-interval", required_argument, NULL, 'I' }, { "buffer-size", required_argument, NULL, 'S' }, { "version", no_argument, NULL, 'V' }, + { "mmap", optional_argument, NULL, 'm' }, + { "trace file compare", no_argument, NULL, 'T' }, + { "output file compare", no_argument, NULL, 'O' }, { 0, 0, 0, 0 } }; int c; @@ -1103,7 +1114,7 @@ int getoptions(int argc, char *argv[], struct program_options *options) int optindex = 0; - c = getopt_long(argc, argv, ":b:ce:f:ho:pr:t:vwBCI:S:V", + c = getopt_long(argc, argv, ":b:ce:f:ho:pr:t:vwBCI:S:VmTO", long_options, &optindex); if (c == -1) break; @@ -1174,6 +1185,15 @@ int getoptions(int argc, char *argv[], struct program_options *options) case 'S': options->tbs.percpu_buffer_size = atoi(optarg); break; + case 'm': + options->mmap_flag = true; + break; + case 'T': + options->tracefile_comp_flag = true; + break; + case 'O': + options->output_comp_flag = true; + break; case 0: /* getopt_long() set a variable, just keep going */ break; case ':': /* missing option argument */ @@ -1197,6 +1217,21 @@ int getoptions(int argc, char *argv[], struct program_options *options) return -1; } + if (options->mode == REGRESSION) { + if ((options->filename == NULL) + &&(options->outfilename == NULL)) { + fprintf(stderr, "expected file name for regression test\n"); + return -1; + } + if (options->filename && bad_filename(options->filename)) + return -1; + + if (options->outfilename && bad_filename(options->outfilename)) + return -1; + + return optind; + } + if (NULL == options->filename) { fprintf(stderr, "expected -f <trace filename>\n"); return -1; @@ -1401,6 +1436,158 @@ static int execute(int argc, char *argv[], char *const envp[], return -1; } +int binary_compare(struct program_options * options) +{ + FILE * fp; + FILE * fp_baseline; + char * file; + char * file_baseline; + int file_size; + int ret; + + printf("running binary_compare\n"); + fp = fopen(options->filename,"r"); + fseek( fp , 0 , SEEK_END ); + file_size = ftell( fp ); + printf( "%s %d\n" ,options->filename, file_size ); + fseek( fp , 0 , SEEK_SET); + file = (char *)malloc( file_size * sizeof( char ) ); + fread( file , file_size , sizeof(char) , fp); + + fp_baseline = fopen(options->baseline_filename,"r"); + fseek( fp_baseline , 0 , SEEK_END ); + file_size = ftell(fp_baseline); + printf( "%s %d\n" ,options->baseline_filename, file_size ); + fseek( fp_baseline , 0 , SEEK_SET); + file_baseline = (char *)malloc( file_size * sizeof( char ) ); + fread( file_baseline , file_size , sizeof(char) , fp_baseline); + + ret = strcmp(file,file_baseline); + if(ret) + fprintf(stderr, "[IDLE_STAT REGRESSION TEST] <binary_compare failed>\n"); + else + printf( "[IDLE_STAT REGRESSION TEST] <binary_compare success>\n"); + + fclose(fp); + fclose(fp_baseline); + free(file); + free(file_baseline); + return ret; +} + +int output_compare(struct program_options * options) +{ + struct report_ops *output_handler = NULL; + void *report_data = NULL; + struct cpu_topology *cpu_topo = NULL; + struct cpuidle_datas *datas; + char * tmp_filename; + int ret = 0; + /* Load the idle states information */ + datas = idlestat_load(options->filename); + + if (is_err(datas)) + return 1; + + cpu_topo = datas->topo; + + output_handler = get_report_ops(options->report_type_name); + if (is_err(output_handler)) + return 1; + + if (output_handler->open_report_file(options->outfilename, report_data)) + return 1; + + if (options->display & IDLE_DISPLAY) { + output_handler->cstate_table_header(report_data); + dump_cpu_topo_info(output_handler, report_data, + display_cstates, cpu_topo, 1); + output_handler->cstate_table_footer(report_data); + } + + if (options->display & FREQUENCY_DISPLAY) { + output_handler->pstate_table_header(report_data); + dump_cpu_topo_info(output_handler, report_data, + display_pstates, cpu_topo, 0); + output_handler->pstate_table_footer(report_data); + } + + if (options->display & WAKEUP_DISPLAY) { + output_handler->wakeup_table_header(report_data); + dump_cpu_topo_info(output_handler, report_data, + display_wakeup, cpu_topo, 1); + output_handler->wakeup_table_footer(report_data); + } + + restore_stdout(); + + /*backup the filename*/ + tmp_filename = options->filename; + + /*compare the new output file with the old one*/ + options->filename = options->outfilename; + ret = binary_compare(options); + + if(ret) + printf("output file comparsion of %s and %s failed\n",options->filename,options->baseline_filename); + else + printf("[IDLE_STAT REGRESSION TEST] <output_compare success>\n"); + /*restore the file name*/ + options->filename = tmp_filename; + + + return ret; + +} + +int regression(struct program_options * options) +{ + struct cpuidle_datas *datas; + struct cpu_topology *cpu_topo = NULL; + struct report_ops *output_handler = NULL; + int ret = 0; + + char topo_info[512]; + + output_handler = get_report_ops(options->report_type_name); + if (is_err(output_handler)) + return 1; + + if (output_handler->check_options && + output_handler->check_options(options) < 0) + return 1; + + /* Load the idle states information */ + datas = idlestat_load(options->filename); + + if (is_err(datas)){ + fprintf(stderr, "[IDLE_STAT REGRESSION TEST] <trace file import failed>\n"); + ret = -1; + } + else + printf("[IDLE_STAT REGRESSION TEST] <trace file import success>\n"); + + cpu_topo = read_sysfs_cpu_topo(); + if (is_err(cpu_topo)) { + fprintf(stderr, "Failed to read CPU topology info from" + " sysfs.\n"); + ret = -1; + } + else{ + outstr_topo_info(topo_info,cpu_topo); + printf("%s",topo_info); + printf("[IDLE_STAT REGRESSION TEST] <CPU topology info read success>\n"); + } + + if(options->tracefile_comp_flag) + ret = binary_compare(options); + + if(options->output_comp_flag) + ret = output_compare(options); + + return ret; +} + int main(int argc, char *argv[], char *const envp[]) { struct cpuidle_datas *datas; @@ -1414,10 +1601,24 @@ int main(int argc, char *argv[], char *const envp[]) struct trace_options *saved_trace_options = NULL; void *report_data = NULL; + int fd; + int flength; + struct stat statbuff; + args = getoptions(argc, argv, &options); if (args <= 0) return 1; + if (options.mode == REGRESSION){ + if (regression(&options)){ + printf("regression failed\n"); + } + else{ + printf("regression success\n"); + } + return 0; + } + /* Tracing requires manipulation of some files only accessible * to root */ if ((options.mode == TRACE) && getuid()) { @@ -1497,6 +1698,16 @@ int main(int argc, char *argv[], char *const envp[]) initp = build_init_pstates(cpu_topo); + /* + set the trace file format to bin + */ + if(options.mmap_flag){ + FILE * file; + file = fopen(TRACE_OPTIONS, "r+"); + perror(__func__); + printf("%s open %p\n",TRACE_OPTIONS,file); + store_line("bin",(void *)file); + } /* Start the recording */ if (idlestat_trace_enable(true)) goto err_restore_trace_options; @@ -1532,6 +1743,26 @@ int main(int argc, char *argv[], char *const envp[]) initp, cpu_topo)) goto err_restore_trace_options; + if(options.mmap_flag){ + fd = open(options.filename, O_RDONLY); + if((fd == -1) || fstat(fd, &statbuff)){ + perror(__func__); + printf("[idlestat] file length get failed\n"); + close(fd); + return 1; + } + flength = statbuff.st_size; + printf("[idlestat]: mmaped file is %s fd %x length %d\n",options.filename,fd,flength); + options.mapped_mem = mmap(NULL, flength, PROT_READ,MAP_PRIVATE,fd,0); + if((int)(void *)options.mapped_mem == (int)-1){ + perror(__func__); + close(fd); + return 1; + } + //printf("%s\n", options.mapped_mem); + close(fd); + } + /* Restore original kernel ftrace options */ if (idlestat_restore_trace_options(saved_trace_options)) return 1; diff --git a/idlestat.h b/idlestat.h index e030f6a..1ca9748 100644 --- a/idlestat.h +++ b/idlestat.h @@ -121,7 +121,8 @@ struct cpuidle_datas { enum modes { TRACE = 0, - IMPORT + IMPORT, + REGRESSION }; struct trace_buffer_settings { @@ -140,6 +141,10 @@ struct program_options { int verbose; char *energy_model_filename; char *report_type_name; + bool mmap_flag; + bool tracefile_comp_flag; + bool output_comp_flag; + char * mapped_mem; }; #define IDLE_DISPLAY 0x1 diff --git a/topology.c b/topology.c index 39b07bd..ee00bfe 100644 --- a/topology.c +++ b/topology.c @@ -280,6 +280,25 @@ int outfile_topo_info(FILE *f, struct cpu_topology *topo_list) return 0; } +int outstr_topo_info(char *s, struct cpu_topology *topo_list) +{ + struct cpu_physical *s_phy; + struct cpu_core *s_core; + struct cpu_cpu *s_cpu; + + list_for_each_entry(s_phy, &topo_list->physical_head, list_physical) { + sprintf(s, "cluster%c:\n", s_phy->physical_id + 'A'); + list_for_each_entry(s_core, &s_phy->core_head, list_core) { + sprintf(s, "\tcore%d\n", s_core->core_id); + list_for_each_entry(s_cpu, &s_core->cpu_head, list_cpu){ + sprintf(s, "\t\tcpu%d\n", s_cpu->cpu_id); + } + } + } + + return 0; +} + struct cpu_cpu *find_cpu_point(struct cpu_topology *topo_list, int cpuid) { struct cpu_physical *s_phy; diff --git a/topology.h b/topology.h index 84e5bc1..4c7964e 100644 --- a/topology.h +++ b/topology.h @@ -115,5 +115,6 @@ extern int core_get_highest_freq(struct cpu_core *core); core_get_highest_freq(cpu_to_core(cpuid, topo)) extern int setup_topo_states(struct cpuidle_datas *datas); +extern int outstr_topo_info(char *s, struct cpu_topology *topo_list); #endif diff --git a/trace.h b/trace.h index a2f5867..29b4d93 100644 --- a/trace.h +++ b/trace.h @@ -34,6 +34,7 @@ #define TRACE_FREE TRACE_PATH "/free_buffer" #define TRACE_FILE TRACE_PATH "/trace" #define TRACE_STAT_FILE TRACE_PATH "/per_cpu/cpu0/stats" +#define TRACE_OPTIONS TRACE_PATH "/trace_options" #define TRACE_IDLE_NRHITS_PER_SEC 10000 #define TRACE_IDLE_LENGTH 196 #define TRACE_CPUFREQ_NRHITS_PER_SEC 100 diff --git a/utils.c b/utils.c index 48be965..1c6bc96 100644 --- a/utils.c +++ b/utils.c @@ -210,14 +210,17 @@ out_free: return ret; } +int std_fd; int redirect_stdout_to_file(const char *path) { int ret = 0; int fd; if (path) { + std_fd = dup(STDOUT_FILENO); fd = open(path, O_RDWR | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR | S_IRGRP |S_IROTH); + if (fd < 0) { fprintf(stderr, "%s: failed to open '%s'\n", __func__, path); return -1; @@ -237,6 +240,13 @@ int redirect_stdout_to_file(const char *path) return 0; } +int restore_stdout() +{ + int ret = 0; + ret = dup2(std_fd,STDOUT_FILENO); + printf("%s %d \n",__func__,ret); +} + void display_factored_time(double time, int align) { char buffer[128]; diff --git a/utils.h b/utils.h index ee7a9a2..6b8808c 100644 --- a/utils.h +++ b/utils.h @@ -49,5 +49,6 @@ extern int check_window_size(void); extern int error(const char *str); extern void *ptrerror(const char *str); extern int is_err(const void *ptr); +extern int restore_stdout(); #endif -- 1.7.9.5

8 years, 11 months

[PATCH 1/2] rt-app: add new spreading-tasks.json

by Xunlei Pang

From: Xunlei Pang <pang.xunlei(a)linaro.org> Add new spreading-tasks.json in doc/examples. It create 2 threads made of a 1st phase with small load (10% as an example) followed by a phase with a large load (70% as an example). Each phase lasts 6sec to let system stabilize. Signed-off-by: Xunlei Pang <pang.xunlei(a)linaro.org> --- doc/examples/spreading-tasks.json | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 doc/examples/spreading-tasks.json diff --git a/doc/examples/spreading-tasks.json b/doc/examples/spreading-tasks.json new file mode 100644 index 0000000..844db44 --- /dev/null +++ b/doc/examples/spreading-tasks.json @@ -0,0 +1,26 @@ +{ + "tasks" : { + "thread" : { + "instance" : 2, + "loop" : -1, + "phases" : { + "light" : { + "loop" : 600, + "run" : 1000, + "timer" : { "ref" : "unique", "period" : 10000 } + }, + "heavy" : { + "loop" : 600, + "run" : 7000, + "timer" : { "ref" : "unique", "period" : 10000 } + } + } + } + }, + "global" : { + "duration" : 60, + "default_policy" : "SCHED_OTHER", + "calibration" : "CPU0" + } +} + -- 1.9.1

9 years

[PATCH 00/14] rt-app: fixes/changes patches of rt-app

by pi-cheng.chen

These series includes fixes/changes that have been done. These patches mainly fixed some typos or moves code but should not change the behavior of rt-app. Those patches are also found in the branch: https://git.linaro.org/people/picheng.chen/rt-app.git fix Chris Muller (1): Update thread name Ivan T. Ivanov (1): fixup json-c dependencies Vincent Guittot (12): Minor clean up fix deadline print format consolidate trace and debug point update .gitignore fix inconsistency in delay unit fix cpu affinity string info deadline: set deadline field to deadline parameter reorder the start sequence of threads cleanup of doc directory remove useless json_object_put remove conditional compilation of json Remove useless --with-json rt-app: remove use of deprecated json interface .gitignore | 8 ++ README.in | 7 +- autogen.sh | 2 +- configure.ac | 17 ++-- doc/taskset.yml | 53 ----------- src/Makefile.am | 8 +- src/rt-app.c | 227 ++++++++++++++++++++++++++-------------------- src/rt-app_args.c | 77 ++++++++-------- src/rt-app_parse_config.c | 51 +++++++---- src/rt-app_parse_config.h | 2 +- src/rt-app_utils.c | 3 + src/rt-app_utils.h | 4 +- 12 files changed, 228 insertions(+), 231 deletions(-) delete mode 100644 doc/taskset.yml -- 1.9.1

9 years

[PATCH] Add a script to tune parameters in json file.

by pi-cheng.chen

This scripts strips all comments in the input JSON file, modifies the parameters according to commnad line arguments, and write the content to a new JSON file. Fix a small error and re-send again. Signed-off-by: pi-cheng.chen <pi-cheng.chen(a)linaro.org> --- doc/tune_json.py | 130 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100755 doc/tune_json.py diff --git a/doc/tune_json.py b/doc/tune_json.py new file mode 100755 index 0000000..a859085 --- /dev/null +++ b/doc/tune_json.py @@ -0,0 +1,130 @@ +#!/usr/bin/env python + +import argparse +import collections +import json +import os +import re +import sys +import tempfile + + +def find_dict_by_key(doc, key): + if key in doc and type(doc[key]) is collections.OrderedDict: + return doc[key] + + for k in doc: + if type(doc[k]) is collections.OrderedDict: + return find_dict_by_key(doc[k], key) + + +def dict_find_and_replace_value(dic, key, val): + for k in dic: + if type(dic[k]) is collections.OrderedDict: + dict_find_and_replace_value(dic[k], key, val) + if k == key: + dic[k] = val + + +def dict_of_loading(dic): + if not 'run' in dic: + return False, None + + for k in dic: + if 'timer' in k and 'period' in dic[k]: + return True, k + else: + return False, None + + +def calculate_and_update_loading(dic, loading): + of_loading, timer_id = dict_of_loading(dic) + + if of_loading: + period = dic[timer_id]['period'] + run = period * loading / 100 + dic['run'] = run + + for k in dic: + if type(dic[k]) is collections.OrderedDict: + calculate_and_update_loading(dic[k], loading) + + +# strip comments in json file and load the file as a dict +def load_json_file(filename): + try: + f = open(filename, 'r') + except: + print 'ERROR: Unable to open %s' %filename + sys.exit(2) + + comment_re = re.compile( + '(^)?[^\S\n]*/(?:\*(.*?)\*/[^\S\n]*|/[^\n]*)($)?', + re.DOTALL | re.MULTILINE) + + content = ''.join(f.readlines()) + f.close() + + match = comment_re.search(content) + while match: + content = content[:match.start()] + content[match.end():] + match = comment_re.search(content) + + return json.JSONDecoder(object_pairs_hook=collections.OrderedDict).decode(content) + + +def dump_json_file(doc, outfile): + tmp = tempfile.NamedTemporaryFile(delete=False) + json.dump(doc, tmp, indent=4, sort_keys=False) + tmp.close() + + os.rename(tmp.name, outfile) + + +if __name__ == '__main__': + parser = argparse.ArgumentParser() + + parser.add_argument('-f', '--file', dest='infile', default='', help='input json filename') + parser.add_argument('-o', '--out', dest='outfile', default='workload.json', help='output json filename'); + parser.add_argument('--instance', default=0, type=int, help='number of thread instance') + parser.add_argument('--period', default=0, type=int, help='period of each thread/phase (ms)') + parser.add_argument('--run', default=0, type=int, help='run time of each thread/phase (ms)') + parser.add_argument('--sleep', default=0, type=int, help='sleep time of each thread/phase (ms)') + parser.add_argument('--loop', default=0,type=int, help='loop count of each thread/phase (-1 as infinite loop)') + parser.add_argument('--loading', default=0, type=int, help='loading of each thread (%%)') + parser.add_argument('--key', type=str, help='the key id of thread/phase in which the parameters will be changed') + + args = parser.parse_args() + + if not os.path.isfile(args.infile): + print 'ERROR: input file %s does not exist\n' %args.infile + parser.print_help() + sys.exit(2) + + doc = target = load_json_file(args.infile) + + if args.key: + target = find_dict_by_key(doc, args.key) + if not target: + print 'ERROR: key id %s is not found' %args.key + sys.exit(2) + + if args.instance > 0: + dict_find_and_replace_value(target, 'instance', args.instance) + + if args.period > 0: + dict_find_and_replace_value(target, 'period', args.period * 1000) + + if args.run > 0: + dict_find_and_replace_value(target, 'run', args.run * 1000) + + if args.sleep > 0: + dict_find_and_replace_value(target, 'sleep', args.sleep * 1000) + + if args.loop > 0 or args.loop == -1: + dict_find_and_replace_value(target, 'loop', args.loop) + + if args.loading > 0: + calculate_and_update_loading(target, args.loading); + + dump_json_file(doc, args.outfile) -- 1.9.1

9 years, 1 month

[PATCH] rt-app: fix mem leak

by Vincent Guittot

Free string allocated by get_string_value_from once not use anymore Signed-off-by: Vincent Guittot <vincent.guittot(a)linaro.org> --- src/rt-app_parse_config.c | 43 ++++++++++++++++++++++++++++++++++++++----- 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/src/rt-app_parse_config.c b/src/rt-app_parse_config.c index 6751511..96e5517 100644 --- a/src/rt-app_parse_config.c +++ b/src/rt-app_parse_config.c @@ -231,6 +231,12 @@ parse_resource_data(const char *name, struct json_object *obj, int idx, exit(EXIT_INV_CONFIG); } + /* + * get_string_value_from allocate the string so with have to free it + * once useless + */ + free(type); + init_resource_data(name, data->type, idx, opts); } @@ -306,7 +312,7 @@ parse_thread_event_data(char *name, struct json_object *obj, { rtapp_resource_t *rdata, *ddata; char unique_name[22]; - const char *ref; + const char *ref, *tmp; int i; if (!strncmp(name, "run", strlen("run")) || @@ -382,11 +388,21 @@ parse_thread_event_data(char *name, struct json_object *obj, ref = get_string_value_from(obj, "ref", TRUE, "unknown"); i = get_resource_index(ref, rtapp_wait, opts); + /* + * get_string_value_from allocate the string so with have to free it + * once useless + */ + free(ref); data->res = i; ref = get_string_value_from(obj, "mutex", TRUE, "unknown"); i = get_resource_index(ref, rtapp_mutex, opts); + /* + * get_string_value_from allocate the string so with have to free it + * once useless + */ + free(ref); data->dep = i; @@ -399,13 +415,20 @@ parse_thread_event_data(char *name, struct json_object *obj, if (!strncmp(name, "timer", strlen("timer"))) { - ref = get_string_value_from(obj, "ref", TRUE, "unknown"); - if (!strncmp(ref, "unique", strlen("unique"))) { - ref = create_unique_name(unique_name, sizeof(unique_name), ref, tag); - } + tmp = get_string_value_from(obj, "ref", TRUE, "unknown"); + if (!strncmp(tmp, "unique", strlen("unique"))) + ref = create_unique_name(unique_name, sizeof(unique_name), tmp, tag); + else + ref = tmp; i = get_resource_index(ref, rtapp_timer, opts); + /* + * get_string_value_from allocate the string so with have to free it + * once useless + */ + free(tmp); + data->res = i; data->duration = get_int_value_from(obj, "period", TRUE, 0); @@ -698,6 +721,11 @@ parse_global(struct json_object *global, rtapp_options_t *opts) log_critical(PFX "Invalid policy %s", policy); exit(EXIT_INV_CONFIG); } + /* + * get_string_value_from allocate the string so with have to free it + * once useless + */ + free(policy); cal_obj = get_in_object(global, "calibration", TRUE); if (cal_obj == NULL) { @@ -715,6 +743,11 @@ parse_global(struct json_object *global, rtapp_options_t *opts) cal_str = get_string_value_from(global, "calibration", TRUE, "CPU0"); scan_cnt = sscanf(cal_str, "CPU%d", &opts->calib_cpu); + /* + * get_string_value_from allocate the string so with have to free it + * once useless + */ + free(cal_str); if (!scan_cnt) { log_critical(PFX "Invalid calibration CPU%d", opts->calib_cpu); exit(EXIT_INV_CONFIG); -- 1.9.1

9 years, 1 month

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

Sched-tools