Re: [Sched-tools] [PATCH v2 12/14] rt-app: add configured run (c_run) to log metrics

On 17 November 2016 at 17:34, Juri Lelli juri.lelli@arm.com wrote:

Add c_run (the run value that comes from json configuration file). This is handy for post-processing logs.

Signed-off-by: Juri Lelli juri.lelli@arm.com

src/rt-app.c | 6 ++++-- src/rt-app_types.h | 2 ++ src/rt-app_utils.c | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/rt-app.c b/src/rt-app.c index cd3483f25deb..2354d423bcd2 100644 --- a/src/rt-app.c +++ b/src/rt-app.c @@ -288,6 +288,7 @@ static int run_event(event_data_t *event, int dry_run, { struct timespec t_start, t_end; log_debug("run %d ", event->duration);

•                   ldata->c_run = event->duration;
  

The events are run by phase so you should aad the duration of all run event of the phase and reset it when we start a new phase

should we also add the runtime event as well ?

                    clock_gettime(CLOCK_MONOTONIC, &t_start);
                    *perf += loadwait(event->duration);
                    clock_gettime(CLOCK_MONOTONIC, &t_end);

@@ -587,10 +588,10 @@ void *thread_body(void *arg)

    log_notice("[%d] starting thread ...\n", data->ind);

•   fprintf(data->log_handler, "%s %8s %8s %8s %15s %15s %15s %10s %10s %10s\n",
  

•   fprintf(data->log_handler, "%s %8s %8s %8s %15s %15s %15s %10s %10s %10s %10s\n",
                               "#idx", "perf", "run", "period",
                               "start", "end", "rel_st", "slack",
  

•                              "c_period", "wu_lat");
  

•                              "c_run", "c_period", "wu_lat");
  
    if (opts.ftrace)
            log_ftrace(ft_data.marker_fd, "[%d] starts", data->ind);
  

@@ -645,6 +646,7 @@ void *thread_body(void *arg) curr_timing->wu_latency = ldata.wu_latency; curr_timing->slack = ldata.slack; curr_timing->c_period = ldata.c_period;

•           curr_timing->c_run = ldata.c_run;
  
            if (opts.logsize && !timings && continue_running)
                    log_timing(data->log_handler, curr_timing);
  

diff --git a/src/rt-app_types.h b/src/rt-app_types.h index 276bce02d1e6..5a1d87c24e78 100644 --- a/src/rt-app_types.h +++ b/src/rt-app_types.h @@ -164,6 +164,7 @@ typedef struct _log_data_t { unsigned long perf; unsigned long duration; unsigned long wu_latency;

•   unsigned long c_run;
    unsigned long c_period;
    long slack;
  

} log_data_t; @@ -199,6 +200,7 @@ typedef struct _timing_point_t { unsigned long perf; unsigned long duration; unsigned long period;

•   unsigned long c_run;
    unsigned long c_period;
    unsigned long wu_latency;
    long slack;
  

diff --git a/src/rt-app_utils.c b/src/rt-app_utils.c index ea5724d8c523..c40eed55109d 100644 --- a/src/rt-app_utils.c +++ b/src/rt-app_utils.c @@ -140,7 +140,7 @@ void log_timing(FILE *handler, timing_point_t *t) { fprintf(handler,

•           "%4d %8lu %8lu %8lu %15llu %15llu %15llu %10ld %10lu %10lu",
  

•           "%4d %8lu %8lu %8lu %15llu %15llu %15llu %10ld %10lu %10lu %10lu",
            t->ind,
            t->perf,
            t->duration,
  

@@ -149,6 +149,7 @@ log_timing(FILE *handler, timing_point_t *t) t->end_time, t->rel_start_time, t->slack,

•           t->c_run,
            t->c_period,
            t->wu_latency
    );
  

-- 2.10.0