greybus-dev January 2018

greybus-dev@lists.linaro.org

4 participants
4 discussions

[PATCH v3 0/8] staging: greybus: Fix few issues reported by checkpatch

by Kamal Heib

This patch set include multiple fixes for the issues reported by checkpatch.pl Cc: greybus-dev(a)lists.linaro.org Cc: Viresh Kumar <vireshk(a)kernel.org> Cc: Vaibhav Agarwal <vaibhav.sr(a)gmail.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Changes from v2: - [2/8] Restore the original alignment. Changes from v1: - Rebase the changes on top staging-next. - Add greybus-dev mailing list. Kamal Heib (8): staging: greybus: authentication.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c: Cleanup blank lines staging: greybus: audio_codec.c: Space required around ':' staging: greybus: audio_codec.c: Logical continuations should be on the previous line staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t' staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t' staging: greybus: audio_codec.h Fix alignment should match open parenthesis drivers/staging/greybus/audio_codec.c | 23 ++++++++++------------- drivers/staging/greybus/audio_codec.h | 12 ++++++------ drivers/staging/greybus/authentication.c | 2 +- 3 files changed, 17 insertions(+), 20 deletions(-) -- 2.14.3

6 years, 8 months

[PATCH v2 0/8] staging: greybus: Fix few issues reported by checkpatch

by Kamal Heib

This patch set include multiple fixes for the issues reported by checkpatch.pl Cc: greybus-dev(a)lists.linaro.org Cc: Viresh Kumar <vireshk(a)kernel.org> Cc: Vaibhav Agarwal <vaibhav.sr(a)gmail.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Changes from v1: - Rebase the changes on top staging-next. - Add greybus-dev mailing list. Kamal Heib (8): staging: greybus: authentication.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c: Cleanup blank lines staging: greybus: audio_codec.c: Space required around ':' staging: greybus: audio_codec.c: Logical continuations should be on the previous line staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t' staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t' staging: greybus: audio_codec.h Fix alignment should match open parenthesis drivers/staging/greybus/audio_codec.c | 31 ++++++++++++++----------------- drivers/staging/greybus/audio_codec.h | 12 ++++++------ drivers/staging/greybus/authentication.c | 2 +- 3 files changed, 21 insertions(+), 24 deletions(-) -- 2.14.3

6 years, 8 months

[PATCH v2] Staging: greybus: camera: cleanup multiple checks for null pointers

by Sumit Pundir

Fixed coding style issue regarding null comparison at multiple lines. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumit11(a)gmail.com> --- v2: Updated the patch title and description. drivers/staging/greybus/camera.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index f13f16b..07ebfb8 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -918,7 +918,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* Retrieve number of streams to configure */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &nstreams); @@ -929,7 +929,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, return -EINVAL; token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &flags); @@ -946,7 +946,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* width */ token = strsep(&buf, ";"); - if (token == NULL) { + if (!token) { ret = -EINVAL; goto done; } @@ -956,7 +956,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* height */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) goto done; ret = kstrtouint(token, 10, &stream->height); @@ -965,7 +965,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* Image format code */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) goto done; ret = kstrtouint(token, 16, &stream->format); @@ -1009,7 +1009,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, /* Request id */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &request_id); if (ret < 0) @@ -1017,7 +1017,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, /* Stream mask */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 16, &streams_mask); if (ret < 0) @@ -1025,7 +1025,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, /* number of frames */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &num_frames); if (ret < 0) -- 2.7.4

6 years, 9 months

[PATCH] Staging: greybus: Fix multiple checks for null pointers

by Sumit Pundir

Fixes the following coding style issue as noted by checkpatch.pl at multiple lines: Comparison to NULL could be written "!token" Signed-off-by: Sumit Pundir <pundirsumit11(a)gmail.com> --- drivers/staging/greybus/camera.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index f13f16b..07ebfb8 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -918,7 +918,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* Retrieve number of streams to configure */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &nstreams); @@ -929,7 +929,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, return -EINVAL; token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &flags); @@ -946,7 +946,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* width */ token = strsep(&buf, ";"); - if (token == NULL) { + if (!token) { ret = -EINVAL; goto done; } @@ -956,7 +956,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* height */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) goto done; ret = kstrtouint(token, 10, &stream->height); @@ -965,7 +965,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, /* Image format code */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) goto done; ret = kstrtouint(token, 16, &stream->format); @@ -1009,7 +1009,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, /* Request id */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &request_id); if (ret < 0) @@ -1017,7 +1017,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, /* Stream mask */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 16, &streams_mask); if (ret < 0) @@ -1025,7 +1025,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, /* number of frames */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &num_frames); if (ret < 0) -- 2.7.4

6 years, 9 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev January 2018