greybus-dev May 2025

greybus-dev@lists.linaro.org

9 participants
8 discussions

[PATCH] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

by rujra

To ensuring that the firmware_tag is properly null-terminated. When copying firmware tag strings to prevent buffer overflows and ensure data integrity. The maximum size of tag is GB_FIRMWARE_U_TAG_MAX_SIZE = 10 bytes, and it may or may not be NULL-terminated. included in "greybus_firmware.h" changes has been made at 3 positions: 1: update firmware tag 2: backend update firmware tag 3: backend update firmware tag with unipro Signed-off-by: Rujra Bhatt <braker.noob.kernel(a)gmail.com> --- drivers/staging/greybus/Documentation/firmware/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 765d69faa..f37904b91 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,7 +63,7 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strscpy((char *)&intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); @@ -101,7 +101,7 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strscpy((char *)&backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: @@ -129,7 +129,7 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, + strscpy((char *)&backend_update.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: -- 2.43.0

1 week, 4 days

[PATCH v2] greybus: Avoid fake flexible array for response data

by clingfei

We want to get rid of zero size arrays and use flexible arrays instead. However, in this case the struct is just one flexible array of u8 which adds no value. Just use a pointer instead. v1: https://lore.kernel.org/all/202505262032.507AD8E0DC@keescook/ Signed-off-by: clingfei <clf700383(a)gmail.com> --- drivers/staging/greybus/i2c.c | 12 ++++-------- include/linux/greybus/greybus_protocols.h | 3 --- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c index 14f1ff6d448c..b248d6717b71 100644 --- a/drivers/staging/greybus/i2c.c +++ b/drivers/staging/greybus/i2c.c @@ -144,15 +144,14 @@ gb_i2c_operation_create(struct gb_connection *connection, } static void gb_i2c_decode_response(struct i2c_msg *msgs, u32 msg_count, - struct gb_i2c_transfer_response *response) + u8 *data) { struct i2c_msg *msg = msgs; - u8 *data; u32 i; - if (!response) + if (!data) return; - data = response->data; + for (i = 0; i < msg_count; i++) { if (msg->flags & I2C_M_RD) { memcpy(msg->buf, data, msg->len); @@ -188,10 +187,7 @@ static int gb_i2c_transfer_operation(struct gb_i2c_device *gb_i2c_dev, ret = gb_operation_request_send_sync(operation); if (!ret) { - struct gb_i2c_transfer_response *response; - - response = operation->response->payload; - gb_i2c_decode_response(msgs, msg_count, response); + gb_i2c_decode_response(msgs, msg_count, operation->response->payload); ret = msg_count; } else if (!gb_i2c_expected_transfer_error(ret)) { dev_err(dev, "transfer operation failed (%d)\n", ret); diff --git a/include/linux/greybus/greybus_protocols.h b/include/linux/greybus/greybus_protocols.h index 820134b0105c..6a35c78b967b 100644 --- a/include/linux/greybus/greybus_protocols.h +++ b/include/linux/greybus/greybus_protocols.h @@ -678,9 +678,6 @@ struct gb_i2c_transfer_request { __le16 op_count; struct gb_i2c_transfer_op ops[]; /* op_count of these */ } __packed; -struct gb_i2c_transfer_response { - __u8 data[0]; /* inbound data */ -} __packed; /* GPIO */ -- 2.34.1

2 weeks, 2 days

[PATCH] greybus: Avoid fake flexible array for response data

by clingfei

As https://lore.kernel.org/all/20240304211940.it.083-kees@kernel.org/ pointed out, to enforce the 0-sized destinations, the remaining 0-sized destinations need to be handled. Thus the struct gb_control_get_manifest_response and struct gb_i2c_transfer_response are removed. Signed-off-by: clingfei <clf700383(a)gmail.com> --- drivers/staging/greybus/i2c.c | 9 ++++----- include/linux/greybus/greybus_protocols.h | 9 --------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c index 14f1ff6d448c..2857c2834206 100644 --- a/drivers/staging/greybus/i2c.c +++ b/drivers/staging/greybus/i2c.c @@ -144,15 +144,14 @@ gb_i2c_operation_create(struct gb_connection *connection, } static void gb_i2c_decode_response(struct i2c_msg *msgs, u32 msg_count, - struct gb_i2c_transfer_response *response) + u8 *data) { struct i2c_msg *msg = msgs; - u8 *data; u32 i; - if (!response) + if (!data) return; - data = response->data; + for (i = 0; i < msg_count; i++) { if (msg->flags & I2C_M_RD) { memcpy(msg->buf, data, msg->len); @@ -188,7 +187,7 @@ static int gb_i2c_transfer_operation(struct gb_i2c_device *gb_i2c_dev, ret = gb_operation_request_send_sync(operation); if (!ret) { - struct gb_i2c_transfer_response *response; + u8 *response; response = operation->response->payload; gb_i2c_decode_response(msgs, msg_count, response); diff --git a/include/linux/greybus/greybus_protocols.h b/include/linux/greybus/greybus_protocols.h index 820134b0105c..14395f9300d6 100644 --- a/include/linux/greybus/greybus_protocols.h +++ b/include/linux/greybus/greybus_protocols.h @@ -110,11 +110,6 @@ struct gb_control_get_manifest_size_response { __le16 size; } __packed; -/* Control protocol manifest get request has no payload */ -struct gb_control_get_manifest_response { - __u8 data[0]; -} __packed; - /* Control protocol [dis]connected request */ struct gb_control_connected_request { __le16 cport_id; @@ -678,10 +673,6 @@ struct gb_i2c_transfer_request { __le16 op_count; struct gb_i2c_transfer_op ops[]; /* op_count of these */ } __packed; -struct gb_i2c_transfer_response { - __u8 data[0]; /* inbound data */ -} __packed; - /* GPIO */ -- 2.34.1

2 weeks, 2 days

[PATCH] greybus: Remove gb_control_get_manifest_response struct

by clingfei

The gb_control_get_manifest_response struct is not used. So we delete it in this commit. Signed-off-by: clingfei <clf700383(a)gmail.com> --- include/linux/greybus/greybus_protocols.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/include/linux/greybus/greybus_protocols.h b/include/linux/greybus/greybus_protocols.h index 820134b0105c..dd09dc691dda 100644 --- a/include/linux/greybus/greybus_protocols.h +++ b/include/linux/greybus/greybus_protocols.h @@ -110,11 +110,6 @@ struct gb_control_get_manifest_size_response { __le16 size; } __packed; -/* Control protocol manifest get request has no payload */ -struct gb_control_get_manifest_response { - __u8 data[0]; -} __packed; - /* Control protocol [dis]connected request */ struct gb_control_connected_request { __le16 cport_id; -- 2.34.1

2 weeks, 3 days

Re: [RFC net-next 00/15] Add support for Silicon Labs CPC

by Andrew Lunn

On Sun, May 11, 2025 at 09:27:33PM -0400, Damien Riégel wrote: > Hi, > > > This patchset brings initial support for Silicon Labs CPC protocol, > standing for Co-Processor Communication. This protocol is used by the > EFR32 Series [1]. These devices offer a variety for radio protocols, > such as Bluetooth, Z-Wave, Zigbee [2]. Before we get too deep into the details of the patches, please could you do a compare/contrast to Greybus. The core of Greybus is already in the kernel, with some more bits being in staging. I don't know it too well, but at first glance it looks very similar. We should not duplicate that. Also, this patch adds Bluetooth, you talk about Z-Wave and Zigbee. But the EFR32 is a general purpose SoC, with I2C, SPI, PWM, UART. Greybus has support for these, although the code is current in staging. But for staging code, it is actually pretty good. Why should we add a vendor implementation when we already appear to have something which does most of what is needed? Andrew

2 weeks, 4 days

[PATCH V1] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

by Rujra Bhatt

---------------------------------------------------------- This is the new Patch for the earlier Patch hence made V1. [Note: there will be no significant changes.] ---------------------------------------------------------- Changes: To ensuring that the firmware tag is properly null-terminated. When copying firmware tag strings to prevent buffer overflows and ensure data integrity. Changes has been made in 3 positions: 1: update firmware tag 2: backend update firmware tag 3: backend update firmware tag with unipro Signed-off-by: Rujra Bhatt <braker.noob.kernel(a)gmail.com> --- drivers/staging/greybus/Documentation/firmware/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 765d69faa..f37904b91 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,7 +63,7 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strscpy((char *)&intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); @@ -101,7 +101,7 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strscpy((char *)&backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: @@ -129,7 +129,7 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, + strscpy((char *)&backend_update.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: -- 2.43.0

3 weeks, 1 day

Re: [PATCH RESEND] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

by Rujra Bhatt

On Wed, May 21, 2025 at 09:06:00AM +0200, Greg KH wrote: > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > > http://daringfireball.net/2007/07/on_top > > On Wed, May 21, 2025 at 11:11:26AM +0530, rujra wrote: > > Hi greg, > > > > why is this a RESEND ?: > > > > >> I had sent the same patch 4 days ago and didn't get any reply , hence tried to resend the same patch for the same, > > here is earlier mail : > > https://mail.google.com/mail/u/1/?ik=f63b03515e&view=om&permmsgid=msg-a:s:1… > > That is a link to _your_ account, not a public record of your email :( > > > , > > > > line does not match this: > > >> sorry , i could not get it what it is exactly ?, if possible can you share some insights or example so that from in future i would get it right. > > Your "From:" line in your email does not match with the signed-off-by > line. This has been addressed successfully, Kindly preview it. is this the way correct about the reply email ? , kindly let me know as I have tried to get more and more answers and solved issues, and thank you so much for your guidance and will be keep in mind about the process and will not fail next time onwards. thank you, regards, Rujra Bhatt On Wed, May 21, 2025 at 2:02 PM Greg KH <gregkh(a)linuxfoundation.org> wrote: > > On Wed, May 21, 2025 at 01:30:44PM +0530, Rujra Bhatt wrote: > > <snip> > > For some reason you sent this only to me, which is a bit rude to > everyone else on the mailing list. I'll be glad to respond if you > resend it to everyone. > > thanks, > > greg k-h

3 weeks, 1 day

[PATCH RESEND] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()

by rujra

To ensure that the firmware tag is properly null-terminated. When copying firmware tag strings to prevent buffer overflows and ensure data integrity. changes has been made in 3 positions: 1: update firmware tag 2: backend update firmware tag 3: backend update firmware tag with unipro Signed-off-by: Rujra Bhatt <braker.noob.kernel(a)gmail.com> --- drivers/staging/greybus/Documentation/firmware/firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 765d69faa..f37904b91 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,7 +63,7 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strscpy((char *)&intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); @@ -101,7 +101,7 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strscpy((char *)&backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: @@ -129,7 +129,7 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, + strscpy((char *)&backend_update.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: -- 2.43.0

3 weeks, 1 day

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev May 2025