greybus-dev August 2018

greybus-dev@lists.linaro.org

3 participants
1 discussions

Start a nNew thread

[PATCH] staging: greybus: Fix null pointer dereference

by Ding Xiang

If fw is null then fw->size will trigger null pointer dereference Signed-off-by: Ding Xiang <dingxiang(a)cmss.chinamobile.com> --- drivers/staging/greybus/bootrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index e85ffae..3af28a0 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -297,7 +297,7 @@ static int gb_bootrom_get_firmware(struct gb_operation *op) queue_work: /* Refresh timeout */ - if (!ret && (offset + size == fw->size)) + if (!ret && fw && (offset + size == fw->size)) next_request = NEXT_REQ_READY_TO_BOOT; else next_request = NEXT_REQ_GET_FIRMWARE; -- 1.8.3.1

5 years, 8 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev August 2018