greybus-dev October 2023

greybus-dev@lists.linaro.org

13 participants
17 discussions

[PATCH] greybus: BeaglePlay driver needs CRC_CCITT

by Randy Dunlap

The gb-beagleplay driver uses crc_ccitt(), so it should select CRC_CCITT to make sure that the function is available. Fixes these build errors: s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8': gb-beagleplay.c:(.text+0x2c0): undefined reference to `crc_ccitt' s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_rx_frame': gb-beagleplay.c:(.text+0x6a0): undefined reference to `crc_ccitt' Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver") Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Ayush Singh <ayushdevel1325(a)gmail.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Johan Hovold <johan(a)kernel.org> Cc: Alex Elder <elder(a)kernel.org> Cc: greybus-dev(a)lists.linaro.org --- drivers/greybus/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig --- a/drivers/greybus/Kconfig +++ b/drivers/greybus/Kconfig @@ -20,6 +20,7 @@ if GREYBUS config GREYBUS_BEAGLEPLAY tristate "Greybus BeaglePlay driver" depends on SERIAL_DEV_BUS + select CRC_CCITT help Select this option if you have a BeaglePlay where CC1352 co-processor acts as Greybus SVC.

1 year, 2 months

[PATCH v2 0/3] staging: greybus: Coding style cleanup patches

by Nandha Kumar Singaram

This patchset performs code cleanup in greybus driver as per linux coding style and may be applied in any sequence. v2: Ammended wording in subject line for all the patches Suggested by Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Nandha Kumar Singaram (3): staging: greybus: camera: Alignment should match open parenthesis staging: greybus: camera: Modify lines end with a '(' staging: greybus: bootrom: fixed prefer using ftrace warning drivers/staging/greybus/bootrom.c | 2 -- drivers/staging/greybus/camera.c | 13 ++++++------- 2 files changed, 6 insertions(+), 9 deletions(-) -- 2.25.1

1 year, 2 months

[PATCH v9 0/3] greybus: Add BeaglePlay Greybus Driver

by Ayush Singh

BeagleConnect is both a technology concept and a line of board designs that implement the technology. Born from Greybus, a mechanism for dynamically extending a Linux system with embedded peripherals, BeagleConnect adds two key elements: a 6LoWPAN transport and mikroBUS manifests. The 6LoWPAN transport provides for arbitrary connections, including the IEEE802.15.4g long-range wireless transport supported between BeaglePlay and BeagleConnect Freedom (the first BeagleConnect board design). The mikroBUS manifests provide for rapid prototyping and low-node-count production with sensor boards following the mikroBUS freely-licensable embedded bus standard such that existing Linux drivers can be loaded upon Greybus discovery of the nodes. This patch set provides the Linux-side hooks required for the 6LoWPAN transport for BeagleConnect on BeaglePlay. Also adds required devicetree additions. Tested over `next-20230825`. Link: https://programmershideaway.xyz/tags/gsoc23/ GSoC23 Blog Link: https://git.beagleboard.org/gsoc/greybus/cc1352-firmware Zephyr App Link: https://github.com/Ayush1325/linux/tree/gb-beagleplay GitHub Branch Link: https://docs.beagleboard.org/latest/boards/beagleconnect/index.html BeagleConnect Link: https://docs.beagleboard.org/latest/boards/beagleplay/index.html BeaglePlay Link: https://github.com/Ayush1325/linux/tree/gb-beagleplay Github Repo Link: https://lists.linaro.org/archives/list/greybus-dev@lists.linaro.org/thread/… Patch v8 Changes in Patch v9 v8 -> v9: - Some capitalization in dt-bindings - add reset-gpios and vdds-supply to beagleplay device tree v7 -> v8: - fix clocks - fix reset-gpios - depend on serdev v6 -> v7: - Drop speed variable - Fix commit message - add clock-names and descriptions - fix power lines v5 -> v6: - Rename compatible to `ti,cc1352p7` - Fix formatting - Use kerneldoc - Add clocks, power-gpios, reset-gpios to dt bindings v4 -> v5: - Move DT Bindings to net - Rename compatible to `beagle,play-cc1352` - Expose CC1352 as MCU - Remove redundant tracing messages - Fix memory leaks v3 -> v4: - Add DT Bindings - Reorder commits - Improve commit messages v2 -> v3: - Move gb-beagleplay out of staging v1 -> v2: - Combine the driver into a single file - Remove redundant code - Fix Checkpatch complaints - Other suggested changes Ayush Singh (3): dt-bindings: net: Add ti,cc1352p7 greybus: Add BeaglePlay Linux Driver dts: ti: k3-am625-beagleplay: Add beaglecc1352 .../devicetree/bindings/net/ti,cc1352p7.yaml | 51 ++ MAINTAINERS | 7 + .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 6 + drivers/greybus/Kconfig | 10 + drivers/greybus/Makefile | 2 + drivers/greybus/gb-beagleplay.c | 501 ++++++++++++++++++ 6 files changed, 577 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml create mode 100644 drivers/greybus/gb-beagleplay.c base-commit: 6269320850097903b30be8f07a5c61d9f7592393 -- 2.41.0

1 year, 2 months

[PATCH 0/3] staging: greybus: Coding style cleanup patches

by Nandha Kumar Singaram

This patchset performs code cleanup in greybus driver as per linux coding style and may be applied in any sequence. Nandha Kumar Singaram (3): staging: greybus: Modify lines end with a '(' staging: greybus: Alignment should match open parenthesis staging: greybus: fixed prefer using ftrace warning drivers/staging/greybus/bootrom.c | 2 -- drivers/staging/greybus/camera.c | 13 ++++++------- 2 files changed, 6 insertions(+), 9 deletions(-) -- 2.25.1

1 year, 2 months

[PATCH] staging: greybus: avoid macro argument precedence issues

by Nandha Kumar Singaram

Adhere to linux coding style, added parentheses around macro argument 'gcam'. CHECK: Macro argument 'gcam' may be better as '(gcam)' to avoid precedence issues Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram(a)gmail.com> --- drivers/staging/greybus/camera.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index cdbb42cd413b..ae49e37a87e9 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt) #define GB_CAMERA_MAX_SETTINGS_SIZE 8192 -#define gcam_dbg(gcam, format...) dev_dbg(&gcam->bundle->dev, format) -#define gcam_info(gcam, format...) dev_info(&gcam->bundle->dev, format) -#define gcam_err(gcam, format...) dev_err(&gcam->bundle->dev, format) +#define gcam_dbg(gcam, format...) dev_dbg(&(gcam)->bundle->dev, format) +#define gcam_info(gcam, format...) dev_info(&(gcam)->bundle->dev, format) +#define gcam_err(gcam, format...) dev_err(&(gcam)->bundle->dev, format) static int gb_camera_operation_sync_flags(struct gb_connection *connection, int type, unsigned int flags, -- 2.25.1

1 year, 2 months

Re: [PATCH] staging: greybus: Alignment should match open parenthesis

by Nandha Kumar Singaram

greybus-dev(a)lists.linaro.org, linux-staging(a)lists.linux.dev, linux-kernel(a)vger.kernel.org, kumaran.4353(a)gmail.com Bcc: Subject: Re: [PATCH] staging: greybus: Alignment should match open parenthesis Reply-To: In-Reply-To: <2023102131-slacker-lily-28ff@gregkh> On Sat, Oct 21, 2023 at 11:48:32AM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2023 at 02:39:49PM -0700, Nandha Kumar Singaram wrote: > > Adhere to linux coding style. Reported by checkpatch.pl: > > CHECK: Alignment should match open parenthesis > > > > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram(a)gmail.com> > > --- > > drivers/staging/greybus/camera.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > > index cdbb42cd413b..405c8e78aa72 100644 > > --- a/drivers/staging/greybus/camera.c > > +++ b/drivers/staging/greybus/camera.c > > @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection, > > } > > > > static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, > > - struct gb_camera_configure_streams_response *resp) > > + struct gb_camera_configure_streams_response *resp) > > { > > unsigned int max_pkt_size = 0; > > unsigned int i; > > @@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, > > * Validate the stream configuration response verifying padding is correctly > > * set and the returned number of streams is supported > > */ > > -static const int gb_camera_configure_streams_validate_response( > > - struct gb_camera *gcam, > > +static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam, > > Why change this line? > did these Code change to fix CHECK: Lines should not end with a '(' reported by checkpatch.pl > It's fine, but then: > > > struct gb_camera_configure_streams_response *resp, > > unsigned int nstreams) > > These lines are not fixed up? > > thanks, > > greg k-h Fixing these lines results in another checkpatch check(CHECK: line length of 113 exceeds 100 columns) so didn't added any change Thanks, Nandha Kumar

1 year, 2 months

[PATCH] staging: greybus: Alignment should match open parenthesis

by Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Alignment should match open parenthesis Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram(a)gmail.com> --- drivers/staging/greybus/camera.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index cdbb42cd413b..405c8e78aa72 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -220,7 +220,7 @@ static int gb_camera_operation_sync_flags(struct gb_connection *connection, } static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, - struct gb_camera_configure_streams_response *resp) + struct gb_camera_configure_streams_response *resp) { unsigned int max_pkt_size = 0; unsigned int i; @@ -267,8 +267,7 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam, * Validate the stream configuration response verifying padding is correctly * set and the returned number of streams is supported */ -static const int gb_camera_configure_streams_validate_response( - struct gb_camera *gcam, +static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam, struct gb_camera_configure_streams_response *resp, unsigned int nstreams) { @@ -378,8 +377,8 @@ struct ap_csi_config_request { #define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000U static int gb_camera_setup_data_connection(struct gb_camera *gcam, - struct gb_camera_configure_streams_response *resp, - struct gb_camera_csi_params *csi_params) + struct gb_camera_configure_streams_response *resp, + struct gb_camera_csi_params *csi_params) { struct ap_csi_config_request csi_cfg; struct gb_connection *conn; @@ -783,8 +782,9 @@ static ssize_t gb_camera_op_capabilities(void *priv, char *data, size_t len) } static int gb_camera_op_configure_streams(void *priv, unsigned int *nstreams, - unsigned int *flags, struct gb_camera_stream *streams, - struct gb_camera_csi_params *csi_params) + unsigned int *flags, + struct gb_camera_stream *streams, + struct gb_camera_csi_params *csi_params) { struct gb_camera *gcam = priv; struct gb_camera_stream_config *gb_streams; -- 2.25.1

1 year, 2 months

Re: [PATCH] staging: greybus: camera: fixes alignment should match open parenthesis

by Greg KH

On Fri, Oct 20, 2023 at 11:12:03PM +0800, Chen Shuo wrote: > This patch fixes the checks reported by checkpatch.pl > for alignment should match open parenthesis No it does not, sorry. Also, any reaason you did not also cc: the proper maintainers as scripts/get_maintainer.pl told you to? thanks, greg k-h

1 year, 2 months

Re: [PATCH] staging: greybus: camera: fixes alignment should match open parenthesis

by Dan Carpenter

On Fri, Oct 20, 2023 at 11:12:03PM +0800, Chen Shuo wrote: > This patch fixes the checks reported by checkpatch.pl > for alignment should match open parenthesis > > Signed-off-by: Chen Shuo <1289151713(a)qq.com> > --- > drivers/staging/greybus/camera.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > index cdbb42cd413b..ed9e16bab4cc 100644 > --- a/drivers/staging/greybus/camera.c > +++ b/drivers/staging/greybus/camera.c > @@ -378,7 +378,7 @@ struct ap_csi_config_request { > #define GB_CAMERA_CSI_CLK_FREQ_MARGIN 150000000U > > static int gb_camera_setup_data_connection(struct gb_camera *gcam, > - struct gb_camera_configure_streams_response *resp, > + struct gb_camera_configure_streams_response *resp, > struct gb_camera_csi_params *csi_params) > { Just leave it as-is. The original was fine. I know that these days we can go over the 80 character mark but, really, does this make things easier to read? regards, dan carpenter

1 year, 2 months

[PATCH] staging: greybus: Modify lines end with a '('

by Nandha Kumar Singaram

Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Lines should not end with a '(' Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram(a)gmail.com> --- drivers/staging/greybus/audio_manager_private.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_private.h b/drivers/staging/greybus/audio_manager_private.h index 2b3a766c7de7..daca5b48b986 100644 --- a/drivers/staging/greybus/audio_manager_private.h +++ b/drivers/staging/greybus/audio_manager_private.h @@ -12,10 +12,9 @@ #include "audio_manager.h" -int gb_audio_manager_module_create( - struct gb_audio_manager_module **module, - struct kset *manager_kset, - int id, struct gb_audio_manager_module_descriptor *desc); +int gb_audio_manager_module_create(struct gb_audio_manager_module **module, + struct kset *manager_kset, int id, + struct gb_audio_manager_module_descriptor *desc); /* module destroyed via kobject_put */ -- 2.25.1

1 year, 2 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev October 2023