If condition and spin_unlock_...() call is split into two lines, merge
them to form a single line.
Suggested-by: Deepak R Varma drv(a)mailo.com
Signed-off-by: Khadija Kamran <kamrankhadijadj(a)gmail.com>
---
Changes in v3:
- Removing tab to fix line length results in a new checkpatch warning,
so let the fix length be as it is.
Changes in v2:
- Rephrased he subject and description
- Merged if_condition() and spin_unlock...() into one line
- Link to patch:
https://lore.kernel.org/outreachy/ZAusnKYVTGvO5zoi@khadija-virtual-machine/
Link to first patch:
https://lore.kernel.org/outreachy/ZAtkW6g6DwPg%2FpDp@khadija-virtual-machin…
drivers/staging/greybus/arche-platform.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index fcbd5f71eff2..6890710afdfc 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -176,12 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
* Check we are not in middle of irq thread
* already
*/
- if (arche_pdata->wake_detect_state !=
- WD_STATE_COLDBOOT_START) {
+ if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) {
arche_platform_set_wake_detect_state(arche_pdata,
WD_STATE_COLDBOOT_TRIG);
- spin_unlock_irqrestore(&arche_pdata->wake_lock,
- flags);
+ spin_unlock_irqrestore(&arche_pdata->wake_lock, flags);
return IRQ_WAKE_THREAD;
}
}
--
2.34.1
This patchset includes change happened in greybus driver in three
different files two of them patch one and three related to
checkpatch issue and in second patch convert two
`container_of` macros into inline functions.
Menna Mahmoud (3):
staging: greybus: remove unnecessary blank line
staging: greybus: use inline function for macros
staging: greybus: remove unnecessary blank line
drivers/staging/greybus/gbphy.h | 10 ++++++++--
drivers/staging/greybus/greybus_authentication.h | 1 -
drivers/staging/greybus/pwm.c | 1 -
3 files changed, 8 insertions(+), 4 deletions(-)
--
2.34.1
In file drivers/staging/greybus/arche-platform.c,
- Length of line 181 exceeds 100 columns, fix by removing tabs from the
line.
- If condition and spin_unlock_...() call is split into two lines, join
them to form a single line.
Signed-off-by: Khadija Kamran <kamrankhadijadj(a)gmail.com>
---
Changes in v2:
- Change the subject and log message
- Merge if condition and spin_unlock...() from two lines to one
drivers/staging/greybus/arche-platform.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index fcbd5f71eff2..00ed5dfd7915 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -176,12 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
* Check we are not in middle of irq thread
* already
*/
- if (arche_pdata->wake_detect_state !=
- WD_STATE_COLDBOOT_START) {
+ if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) {
arche_platform_set_wake_detect_state(arche_pdata,
- WD_STATE_COLDBOOT_TRIG);
- spin_unlock_irqrestore(&arche_pdata->wake_lock,
- flags);
+ WD_STATE_COLDBOOT_TRIG);
+ spin_unlock_irqrestore(&arche_pdata->wake_lock, flags);
return IRQ_WAKE_THREAD;
}
}
--
2.34.1
