March 2023 - greybus-dev - lists.linaro.org

[PATCH v4] staging: greybus: remove unnecessary blank line

by Menna Mahmoud

Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> --- change in v4: add version of the patch. change in v3: add patches that have same edit in sigle commit. change in v2: add patches that have same edit in sigle patch. --- drivers/staging/greybus/greybus_authentication.h | 1 - drivers/staging/greybus/pwm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h index 7edc7295b7ab..48b4a9794d3c 100644 --- a/drivers/staging/greybus/greybus_authentication.h +++ b/drivers/staging/greybus/greybus_authentication.h @@ -41,7 +41,6 @@ #define CAP_AUTH_RESULT_CR_NO_KEY 0x03 #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04 - /* IOCTL support */ struct cap_ioc_get_endpoint_uid { __u8 uid[8]; diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c index 3fda172239d2..26d39e08c3b6 100644 --- a/drivers/staging/greybus/pwm.c +++ b/drivers/staging/greybus/pwm.c @@ -24,7 +24,6 @@ struct gb_pwm_chip { #define pwm_chip_to_gb_pwm_chip(chip) \ container_of(chip, struct gb_pwm_chip, chip) - static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc) { struct gb_pwm_count_response response; -- 2.34.1

1 year, 9 months

2
1
0 0

[PATCH RESEND] staging: greybus: remove unnecessary blank line

by Menna Mahmoud

Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> --- drivers/staging/greybus/greybus_authentication.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h index 7edc7295b7ab..48b4a9794d3c 100644 --- a/drivers/staging/greybus/greybus_authentication.h +++ b/drivers/staging/greybus/greybus_authentication.h @@ -41,7 +41,6 @@ #define CAP_AUTH_RESULT_CR_NO_KEY 0x03 #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04 - /* IOCTL support */ struct cap_ioc_get_endpoint_uid { __u8 uid[8]; -- 2.34.1

1 year, 9 months

2
1
0 0

[PATCH] staging: greybus: remove unnecessary blank line

by Menna Mahmoud

Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> --- drivers/staging/greybus/greybus_authentication.h | 1 - drivers/staging/greybus/pwm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h index 7edc7295b7ab..48b4a9794d3c 100644 --- a/drivers/staging/greybus/greybus_authentication.h +++ b/drivers/staging/greybus/greybus_authentication.h @@ -41,7 +41,6 @@ #define CAP_AUTH_RESULT_CR_NO_KEY 0x03 #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04 - /* IOCTL support */ struct cap_ioc_get_endpoint_uid { __u8 uid[8]; diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c index 3fda172239d2..26d39e08c3b6 100644 --- a/drivers/staging/greybus/pwm.c +++ b/drivers/staging/greybus/pwm.c @@ -24,7 +24,6 @@ struct gb_pwm_chip { #define pwm_chip_to_gb_pwm_chip(chip) \ container_of(chip, struct gb_pwm_chip, chip) - static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc) { struct gb_pwm_count_response response; -- 2.34.1

1 year, 9 months

2
2
0 0

[PATCH v3] staging: greybus: merge split lines

by Khadija Kamran

If condition and spin_unlock_...() call is split into two lines, merge them to form a single line. Suggested-by: Deepak R Varma drv(a)mailo.com Signed-off-by: Khadija Kamran <kamrankhadijadj(a)gmail.com> --- Changes in v3: - Removing tab to fix line length results in a new checkpatch warning, so let the fix length be as it is. Changes in v2: - Rephrased he subject and description - Merged if_condition() and spin_unlock...() into one line - Link to patch: https://lore.kernel.org/outreachy/ZAusnKYVTGvO5zoi@khadija-virtual-machine/ Link to first patch: https://lore.kernel.org/outreachy/ZAtkW6g6DwPg%2FpDp@khadija-virtual-machin… drivers/staging/greybus/arche-platform.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index fcbd5f71eff2..6890710afdfc 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -176,12 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) * Check we are not in middle of irq thread * already */ - if (arche_pdata->wake_detect_state != - WD_STATE_COLDBOOT_START) { + if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) { arche_platform_set_wake_detect_state(arche_pdata, WD_STATE_COLDBOOT_TRIG); - spin_unlock_irqrestore(&arche_pdata->wake_lock, - flags); + spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); return IRQ_WAKE_THREAD; } } -- 2.34.1

1 year, 9 months

3
3
0 0

[PATCH v2 1/2] staging: greybus: remove unnecessary blank line

by Menna Mahmoud

Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> --- change in v2: add patches that have same edit in sigle patch. --- drivers/staging/greybus/greybus_authentication.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h index 7edc7295b7ab..48b4a9794d3c 100644 --- a/drivers/staging/greybus/greybus_authentication.h +++ b/drivers/staging/greybus/greybus_authentication.h @@ -41,7 +41,6 @@ #define CAP_AUTH_RESULT_CR_NO_KEY 0x03 #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04 - /* IOCTL support */ struct cap_ioc_get_endpoint_uid { __u8 uid[8]; -- 2.34.1 From 6f56ebcda89f91cdfe6e64c0707dc476ebc1e819 Mon Sep 17 00:00:00 2001 From: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> Date: Tue, 21 Mar 2023 00:03:32 +0200 Subject: [PATCH v2 2/2] staging: greybus: remove unnecessary blank line Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> --- change in v2: add patches that have same edit in sigle patch. --- drivers/staging/greybus/pwm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c index 3fda172239d2..26d39e08c3b6 100644 --- a/drivers/staging/greybus/pwm.c +++ b/drivers/staging/greybus/pwm.c @@ -24,7 +24,6 @@ struct gb_pwm_chip { #define pwm_chip_to_gb_pwm_chip(chip) \ container_of(chip, struct gb_pwm_chip, chip) - static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc) { struct gb_pwm_count_response response; -- 2.34.1

1 year, 9 months

2
1
0 0

[PATCH 0/3] edits in greybus driver

by Menna Mahmoud

This patchset includes change happened in greybus driver in three different files two of them patch one and three related to checkpatch issue and in second patch convert two `container_of` macros into inline functions. Menna Mahmoud (3): staging: greybus: remove unnecessary blank line staging: greybus: use inline function for macros staging: greybus: remove unnecessary blank line drivers/staging/greybus/gbphy.h | 10 ++++++++-- drivers/staging/greybus/greybus_authentication.h | 1 - drivers/staging/greybus/pwm.c | 1 - 3 files changed, 8 insertions(+), 4 deletions(-) -- 2.34.1

1 year, 9 months

4
17
0 0

[PATCH v2] staging: greybus: remove tabs to fix line length and merge lines

by Khadija Kamran

In file drivers/staging/greybus/arche-platform.c, - Length of line 181 exceeds 100 columns, fix by removing tabs from the line. - If condition and spin_unlock_...() call is split into two lines, join them to form a single line. Signed-off-by: Khadija Kamran <kamrankhadijadj(a)gmail.com> --- Changes in v2: - Change the subject and log message - Merge if condition and spin_unlock...() from two lines to one drivers/staging/greybus/arche-platform.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index fcbd5f71eff2..00ed5dfd7915 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -176,12 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) * Check we are not in middle of irq thread * already */ - if (arche_pdata->wake_detect_state != - WD_STATE_COLDBOOT_START) { + if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) { arche_platform_set_wake_detect_state(arche_pdata, - WD_STATE_COLDBOOT_TRIG); - spin_unlock_irqrestore(&arche_pdata->wake_lock, - flags); + WD_STATE_COLDBOOT_TRIG); + spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); return IRQ_WAKE_THREAD; } } -- 2.34.1

1 year, 9 months

5
9
0 0

[PATCH] Staging: greybus: Fix lines ending with '('

by Sumitra Sharma

The coding style used to limit lines to 80 characters, which led to splitting of these function headers into multiple lines and ends the first line with a '('. Such splits causes checks reported by the checkpatch. Place the function parameters of each function immediately after '(' in a single line to align the function headers. Signed-off-by: Sumitra Sharma <sumitraartsy(a)gmail.com> --- .../staging/greybus/audio_manager_module.c | 40 +++++++++---------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index 0a0f0a394c84..81b4ba607a0e 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj) kfree(module); } -static ssize_t gb_audio_module_name_show( - struct gb_audio_manager_module *module, - struct gb_audio_manager_module_attribute *attr, char *buf) +static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module, + struct gb_audio_manager_module_attribute *attr, char *buf) { return sprintf(buf, "%s", module->desc.name); } @@ -80,9 +79,8 @@ static ssize_t gb_audio_module_name_show( static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = __ATTR(name, 0664, gb_audio_module_name_show, NULL); -static ssize_t gb_audio_module_vid_show( - struct gb_audio_manager_module *module, - struct gb_audio_manager_module_attribute *attr, char *buf) +static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module, + struct gb_audio_manager_module_attribute *attr, char *buf) { return sprintf(buf, "%d", module->desc.vid); } @@ -90,9 +88,8 @@ static ssize_t gb_audio_module_vid_show( static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = __ATTR(vid, 0664, gb_audio_module_vid_show, NULL); -static ssize_t gb_audio_module_pid_show( - struct gb_audio_manager_module *module, - struct gb_audio_manager_module_attribute *attr, char *buf) +static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module, + struct gb_audio_manager_module_attribute *attr, char *buf) { return sprintf(buf, "%d", module->desc.pid); } @@ -100,9 +97,9 @@ static ssize_t gb_audio_module_pid_show( static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute = __ATTR(pid, 0664, gb_audio_module_pid_show, NULL); -static ssize_t gb_audio_module_intf_id_show( - struct gb_audio_manager_module *module, - struct gb_audio_manager_module_attribute *attr, char *buf) +static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *module, + struct gb_audio_manager_module_attribute *attr, + char *buf) { return sprintf(buf, "%d", module->desc.intf_id); } @@ -111,9 +108,9 @@ static struct gb_audio_manager_module_attribute gb_audio_module_intf_id_attribute = __ATTR(intf_id, 0664, gb_audio_module_intf_id_show, NULL); -static ssize_t gb_audio_module_ip_devices_show( - struct gb_audio_manager_module *module, - struct gb_audio_manager_module_attribute *attr, char *buf) +static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *module, + struct gb_audio_manager_module_attribute *attr, + char *buf) { return sprintf(buf, "0x%X", module->desc.ip_devices); } @@ -122,9 +119,9 @@ static struct gb_audio_manager_module_attribute gb_audio_module_ip_devices_attribute = __ATTR(ip_devices, 0664, gb_audio_module_ip_devices_show, NULL); -static ssize_t gb_audio_module_op_devices_show( - struct gb_audio_manager_module *module, - struct gb_audio_manager_module_attribute *attr, char *buf) +static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *module, + struct gb_audio_manager_module_attribute *attr, + char *buf) { return sprintf(buf, "0x%X", module->desc.op_devices); } @@ -181,10 +178,9 @@ static void send_add_uevent(struct gb_audio_manager_module *module) kobject_uevent_env(&module->kobj, KOBJ_ADD, envp); } -int gb_audio_manager_module_create( - struct gb_audio_manager_module **module, - struct kset *manager_kset, - int id, struct gb_audio_manager_module_descriptor *desc) +int gb_audio_manager_module_create(struct gb_audio_manager_module **module, + struct kset *manager_kset, + int id, struct gb_audio_manager_module_descriptor *desc) { int err; struct gb_audio_manager_module *m; -- 2.25.1

1 year, 9 months

2
1
0 0

[PATCH] staging: greybus: remove unnecessary blank line

by Menna Mahmoud

Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> --- drivers/staging/greybus/pwm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c index 3fda172239d2..26d39e08c3b6 100644 --- a/drivers/staging/greybus/pwm.c +++ b/drivers/staging/greybus/pwm.c @@ -24,7 +24,6 @@ struct gb_pwm_chip { #define pwm_chip_to_gb_pwm_chip(chip) \ container_of(chip, struct gb_pwm_chip, chip) - static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc) { struct gb_pwm_count_response response; -- 2.34.1

1 year, 9 months

2
2
0 0

[PATCH] staging: greybus: add blank line after struct

by Menna Mahmoud

add blank line after struct for readability as reported by checkpatch script " CHECK: Please use a blank line after function/struct/union/enum declarations" Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm(a)gmail.com> --- drivers/staging/greybus/gbphy.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h index d4a225b76338..1de510499480 100644 --- a/drivers/staging/greybus/gbphy.h +++ b/drivers/staging/greybus/gbphy.h @@ -15,6 +15,7 @@ struct gbphy_device { struct list_head list; struct device dev; }; + #define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev) static inline void *gb_gbphy_get_data(struct gbphy_device *gdev) @@ -43,6 +44,7 @@ struct gbphy_driver { struct device_driver driver; }; + #define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver) int gb_gbphy_register_driver(struct gbphy_driver *driver, -- 2.34.1

1 year, 9 months

1
2
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev March 2023