August 2023 - greybus-dev - lists.linaro.org

[PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"

by Uwe Kleine-König

while working on an extension for the pwm framework, I noticed that some drivers and even the core only nearly consistently named all variables and struct members holding a pointer to a struct pwm_chip "chip": $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n 1 struct pwm_chip *pwm 1 struct pwm_chip pwm 1 struct pwm_chip pwm_chip 2 struct pwm_chip *_chip 4 struct pwm_chip *c 8 struct pwm_chip *pc 57 struct pwm_chip chip 358 struct pwm_chip *chip With this series applied these are all called "chip" with one exception: The led driver drivers/leds/rgb/leds-qcom-lpg.c uses "pwm". Maybe "pwmchip" would be a better name, but I'm not sure that using "chip" was an improvement there as this isn't a pure pwm driver. I'm not touching that one. The first offenders I found were the core and the atmel-hlcdc driver. After I found these I optimistically assumed these were the only ones with the unusual names and send patches for these out individually before checking systematically. The atmel-hlcdc patch is included here unchanged, the core patch now also adapted the declaration of the changed functions in <linux/pwm.h>. I marked these two as "superseded" in patchwork already. All patches in this series are pairwise independent of each other. I don't know if the staging patch should better go in via the greybus tree or via pwm. Both is possible without needing coordination. Best regards Uwe Uwe Kleine-König (10): pwm: Use a consistent name for pwm_chip pointers in the core pwm: atmel-hlcdc: Use consistent variable naming pwm: bcm-kona: Consistenly name pwm_chip variables "chip" pwm: crc: Consistenly name pwm_chip variables "chip" pwm: cros-ec: Consistenly name pwm_chip variables "chip" pwm: lp3943: Consistenly name pwm_chip variables "chip" pwm: rockchip: Consistenly name pwm_chip variables "chip" pwm: sifive: Consistenly name pwm_chip variables "chip" pwm: sl28cpld: Consistenly name pwm_chip variables "chip" staging: greybus: pwm: Consistenly name pwm_chip variables "chip" drivers/pwm/core.c | 28 +++++++-------- drivers/pwm/pwm-atmel-hlcdc.c | 64 +++++++++++++++++------------------ drivers/pwm/pwm-bcm-kona.c | 4 +-- drivers/pwm/pwm-crc.c | 4 +-- drivers/pwm/pwm-cros-ec.c | 10 +++--- drivers/pwm/pwm-lp3943.c | 4 +-- drivers/pwm/pwm-rockchip.c | 4 +-- drivers/pwm/pwm-sifive.c | 4 +-- drivers/pwm/pwm-sl28cpld.c | 10 +++--- drivers/staging/greybus/pwm.c | 12 +++---- include/linux/pwm.h | 6 ++-- 11 files changed, 75 insertions(+), 75 deletions(-) base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 -- 2.39.2

1 year, 3 months

4
8
0 0

[PATCH v3 0/2] greybus: Add BeaglePlay Greybus Driver

by Ayush Singh

This driver can be used in any Greybus setup where SVC and Linux Host are connected over UART. This driver has been tested on BeaglePlay by BeagleBoard.org. It communicates with BeaglePlay CC1352 co-processor which serves as Greybus SVC. This replaces the old setup with bcfserial, wpanusb and GBridge. This driver also contains async HDLC code since communication with SVC take place over UART using HDLC. This patchset also introduces a compatible property for the UART that is connected to CC1352 in BeaglePlay. I am not quite sure if it needs its own DT Schema file under `Documentation/devicetree/bindings/serial`. This driver has been created as a part of my Google Summer of Code 2023. For more information, take a look at my blog. This patchset has been tested over `next-20230825`. My GSoC23 Blog: https://programmershideaway.xyz/tags/gsoc23/ Zephyr App: https://git.beagleboard.org/gsoc/greybus/cc1352-firmware GitHub Branch: https://github.com/Ayush1325/linux/tree/gb-beagleplay Video Demo: https://youtu.be/GVuIB7i5pjk This the v3 of this patch v2 -> v3: - Move gb-beagleplay out of staging v1 -> v2: - Combine the driver into a single file - Remove redundant code - Fix Checkpatch complaints - Other suggested changes Ayush Singh (2): dts: Add beaglecc1352 to devicetree greybus: Add BeaglePlay Linux Driver MAINTAINERS | 5 + .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 + drivers/greybus/Kconfig | 10 + drivers/greybus/Makefile | 3 +- drivers/greybus/gb-beagleplay.c | 494 ++++++++++++++++++ 5 files changed, 515 insertions(+), 1 deletion(-) create mode 100644 drivers/greybus/gb-beagleplay.c -- 2.41.0

1 year, 3 months

2
3
0 0

[PATCH 0/2] staging/greybus: Add BeaglePlay Greybus Driver

by Ayush Singh

This driver can be used in any Greybus setup where SVC and Linux Host are connected over UART. This driver has been tested on BeaglePlay by BeagleBoard.org. It communicates with BeaglePlay CC1352 co-processor which serves as Greybus SVC. This replaces the old setup with bcfserial, wpanusb and GBridge. This driver also contains async HDLC code since communication with SVC take place over UART using HDLC. This patchset also introduces a compatible property for the UART that is connected to CC1352 in BeaglePlay. I am not quite sure if it needs its own DT Schema file under `Documentation/devicetree/bindings/serial`. This driver has been created as a part of my Google Summer of Code 2023. For more information, take a look at my blog. I have made most of the changes requested in the first version of this patch and simplified the code as well. This patchset has been tested over `next-20230825`. My GSoC23 Blog: https://programmershideaway.xyz/tags/gsoc23/ Zephyr Application: https://git.beagleboard.org/gsoc/greybus/cc1352-firmware GitHub Branch: https://github.com/Ayush1325/linux/tree/gb-beagleplay Video Demo: https://youtu.be/GVuIB7i5pjk Ayush Singh (2): dts: Add beaglecc1352 to devicetree staging/greybus: Add BeaglePlay Linux Driver MAINTAINERS | 5 + .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 + drivers/staging/greybus/Kconfig | 9 + drivers/staging/greybus/Makefile | 3 + drivers/staging/greybus/gb-beagleplay.c | 493 ++++++++++++++++++ 5 files changed, 514 insertions(+) create mode 100644 drivers/staging/greybus/gb-beagleplay.c -- 2.41.0

1 year, 4 months

2
8
0 0

[PATCH 0/4] BeaglePlay Greybus Driver

by Ayush Singh

This driver is for BeaglePlay by BeagleBoard.org. It communicates with BeaglePlay CC1352 co-processor which serves as Greybus SVC [1]. This replaces the old setup with bcfserial, wpanusb and GBridge. This driver also contains async HDLC code since communication with CC1352 take place over UART using HDLC. Since this is my first driver, I expect there to be some mistakes, so feel free to give feedback and point out things I might have missed or might not be aware of. This driver has been created as a part of my Google Summer of Code 2023. For more information, take a look at my blog [2] [1]: https://git.beagleboard.org/gsoc/greybus/cc1352-firmware [2]: https://programmershideaway.xyz/tags/gsoc23/ Ayush Singh (4): Add beagleplaygreybus to devicetree Add beagleplay greybus driver Add HDLC helper for beagleplay driver Allow building beagleplay greybus driver .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 + drivers/staging/greybus/Kconfig | 9 + drivers/staging/greybus/Makefile | 5 + .../greybus/beagleplay-greybus-driver.c | 264 ++++++++++++++++++ .../greybus/beagleplay-greybus-driver.h | 28 ++ drivers/staging/greybus/hdlc.c | 229 +++++++++++++++ drivers/staging/greybus/hdlc.h | 137 +++++++++ 7 files changed, 676 insertions(+) create mode 100644 drivers/staging/greybus/beagleplay-greybus-driver.c create mode 100644 drivers/staging/greybus/beagleplay-greybus-driver.h create mode 100644 drivers/staging/greybus/hdlc.c create mode 100644 drivers/staging/greybus/hdlc.h -- 2.41.0

1 year, 4 months

2
12
0 0

[PATCH -next] greybus: svc: Remove unused declarations

by Yue Haibing

Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency") removed these implementations but not the declarations. Signed-off-by: Yue Haibing <yuehaibing(a)huawei.com> --- include/linux/greybus/svc.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h index 5afaf5f06856..da547fb9071b 100644 --- a/include/linux/greybus/svc.h +++ b/include/linux/greybus/svc.h @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc); int gb_svc_watchdog_enable(struct gb_svc *svc); int gb_svc_watchdog_disable(struct gb_svc *svc); -int gb_svc_protocol_init(void); -void gb_svc_protocol_exit(void); - #endif /* __SVC_H */ -- 2.34.1

1 year, 4 months

3
3
0 0

[PATCH -next] staging: greybus: arche-apb-ctrl: remove unnecessary platform_set_drvdata()

by Yang Yingliang

Remove unnecessary platform_set_drvdata(..., NULL) in ->remove(), the driver_data will be cleared in device_unbind_cleanup() after calling ->remove() in driver call code. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- drivers/staging/greybus/arche-apb-ctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index 8541995008da..5c77c1813214 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -423,7 +423,6 @@ static void arche_apb_ctrl_remove(struct platform_device *pdev) { device_remove_file(&pdev->dev, &dev_attr_state); poweroff_seq(pdev); - platform_set_drvdata(pdev, NULL); } static int __maybe_unused arche_apb_ctrl_suspend(struct device *dev) -- 2.25.1

1 year, 4 months

2
1
0 0

[PATCH] staging: greybus: fix alignment of open parenthesis

by Rohit Chavan

Fixed all CHECK: Alignment should match open parenthesis as reported by checkpatch to adhere to the Linux kernel coding-style guidelines. Signed-off-by: Rohit Chavan <roheetchavan(a)gmail.com> --- drivers/staging/greybus/fw-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 57bebf24636b..0fb15a60412f 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, } connection = gb_connection_create(bundle, cport_id, - gb_fw_mgmt_request_handler); + gb_fw_mgmt_request_handler); if (IS_ERR(connection)) { ret = PTR_ERR(connection); dev_err(&bundle->dev, @@ -110,7 +110,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, } connection = gb_connection_create(bundle, cport_id, - gb_fw_download_request_handler); + gb_fw_download_request_handler); if (IS_ERR(connection)) { dev_err(&bundle->dev, "failed to create download connection (%ld)\n", PTR_ERR(connection)); -- 2.30.2

1 year, 4 months

1
0
0 0

[PATCH v2 0/2] pwm: Manage owner assignment implicitly for drivers

by Uwe Kleine-König

1 year, 4 months

10
10
0 0

[PATCH] staging: greybus: Refactor gb_audio_gb_get_topology() into separate calls

by Madhumitha Prabakaran

Refactor gb_audio_gb_get_topology() into separate calls for better modularity. Signed-off-by: Madhumitha Prabakaran <madhumithabiw(a)gmail.com> --- drivers/staging/greybus/audio_gb.c | 67 +++++++++++++++++++----------- 1 file changed, 42 insertions(+), 25 deletions(-) diff --git a/drivers/staging/greybus/audio_gb.c b/drivers/staging/greybus/audio_gb.c index 9d8994fdb41a..a48ddadd6f1e 100644 --- a/drivers/staging/greybus/audio_gb.c +++ b/drivers/staging/greybus/audio_gb.c @@ -8,39 +8,56 @@ #include <linux/greybus.h> #include "audio_codec.h" -/* TODO: Split into separate calls */ -int gb_audio_gb_get_topology(struct gb_connection *connection, - struct gb_audio_topology **topology) +int gb_audio_gb_get_topology_size(struct gb_connection *connection, u16 *size) { - struct gb_audio_get_topology_size_response size_resp; - struct gb_audio_topology *topo; - u16 size; - int ret; + struct gb_audio_get_topology_size_response size_resp; + int ret; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, - NULL, 0, &size_resp, sizeof(size_resp)); - if (ret) - return ret; + ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, + NULL, 0, &size_resp, sizeof(size_resp)); + if (ret) + return ret; - size = le16_to_cpu(size_resp.size); - if (size < sizeof(*topo)) - return -ENODATA; + *size = le16_to_cpu(size_resp.size); + return 0; +} - topo = kzalloc(size, GFP_KERNEL); - if (!topo) - return -ENOMEM; +struct gb_audio_topology *gb_audio_gb_alloc_topology(u16 size) +{ + struct gb_audio_topology *topo; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, NULL, 0, - topo, size); - if (ret) { - kfree(topo); - return ret; - } + if (size < sizeof(struct gb_audio_topology)) + return NULL; - *topology = topo; + topo = kzalloc(size, GFP_KERNEL); + return topo; +} - return 0; +int gb_audio_gb_get_topology(struct gb_connection *connection, + struct gb_audio_topology **topology) +{ + u16 size; + int ret; + + ret = gb_audio_gb_get_topology_size(connection, &size); + if (ret) + return ret; + + *topology = gb_audio_gb_alloc_topology(size); + if (!*topology) + return -ENOMEM; + + ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, + NULL, 0, *topology, size); + if (ret) { + kfree(*topology); + *topology = NULL; + return ret; + } + + return 0; } + EXPORT_SYMBOL_GPL(gb_audio_gb_get_topology); int gb_audio_gb_get_control(struct gb_connection *connection, -- 2.25.1

1 year, 4 months

3
2
0 0

[PATCH v2] staging: greybus: Refactor gb_audio_gb_get_topology() into separate calls

by Madhumitha Prabakaran

Refactor gb_audio_gb_get_topology() into separate calls for better modularity Signed-off-by: Madhumitha Prabakaran <madhumithabiw(a)gmail.com> ---- Changes in v2: Include prototype in the /audio_codec.h, as Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308050511.y5Yb9otW-lkp@intel.com/ --- drivers/staging/greybus/audio_codec.h | 4 ++ drivers/staging/greybus/audio_gb.c | 67 +++++++++++++++++---------- 2 files changed, 46 insertions(+), 25 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index ce15e800e607..356143f3e241 100644 --- a/drivers/staging/greybus/audio_codec.h +++ b/drivers/staging/greybus/audio_codec.h @@ -176,7 +176,11 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, int gbaudio_register_module(struct gbaudio_module_info *module); void gbaudio_unregister_module(struct gbaudio_module_info *module); +struct gb_audio_topology *gb_audio_gb_alloc_topology(u16 size); + /* protocol related */ +int gb_audio_gb_get_topology_size(struct gb_connection *connection, + u16 *size); int gb_audio_gb_get_topology(struct gb_connection *connection, struct gb_audio_topology **topology); int gb_audio_gb_get_control(struct gb_connection *connection, diff --git a/drivers/staging/greybus/audio_gb.c b/drivers/staging/greybus/audio_gb.c index 9d8994fdb41a..a48ddadd6f1e 100644 --- a/drivers/staging/greybus/audio_gb.c +++ b/drivers/staging/greybus/audio_gb.c @@ -8,39 +8,56 @@ #include <linux/greybus.h> #include "audio_codec.h" -/* TODO: Split into separate calls */ -int gb_audio_gb_get_topology(struct gb_connection *connection, - struct gb_audio_topology **topology) +int gb_audio_gb_get_topology_size(struct gb_connection *connection, u16 *size) { - struct gb_audio_get_topology_size_response size_resp; - struct gb_audio_topology *topo; - u16 size; - int ret; + struct gb_audio_get_topology_size_response size_resp; + int ret; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, - NULL, 0, &size_resp, sizeof(size_resp)); - if (ret) - return ret; + ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, + NULL, 0, &size_resp, sizeof(size_resp)); + if (ret) + return ret; - size = le16_to_cpu(size_resp.size); - if (size < sizeof(*topo)) - return -ENODATA; + *size = le16_to_cpu(size_resp.size); + return 0; +} - topo = kzalloc(size, GFP_KERNEL); - if (!topo) - return -ENOMEM; +struct gb_audio_topology *gb_audio_gb_alloc_topology(u16 size) +{ + struct gb_audio_topology *topo; - ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, NULL, 0, - topo, size); - if (ret) { - kfree(topo); - return ret; - } + if (size < sizeof(struct gb_audio_topology)) + return NULL; - *topology = topo; + topo = kzalloc(size, GFP_KERNEL); + return topo; +} - return 0; +int gb_audio_gb_get_topology(struct gb_connection *connection, + struct gb_audio_topology **topology) +{ + u16 size; + int ret; + + ret = gb_audio_gb_get_topology_size(connection, &size); + if (ret) + return ret; + + *topology = gb_audio_gb_alloc_topology(size); + if (!*topology) + return -ENOMEM; + + ret = gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, + NULL, 0, *topology, size); + if (ret) { + kfree(*topology); + *topology = NULL; + return ret; + } + + return 0; } + EXPORT_SYMBOL_GPL(gb_audio_gb_get_topology); int gb_audio_gb_get_control(struct gb_connection *connection, -- 2.25.1

1 year, 4 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev August 2023