greybus-dev December 2024

greybus-dev@lists.linaro.org

2 participants
1 discussions

[PATCH] staging: greybus: Remove module from list before freeing in gb_audio_module_release

by Atharva Tiwari

Previously,the module was freed without detaching it from the list which could lead to memory leak this patch uses list_del to safely remove the module from the list Signed-off-by: Atharva Tiwari <evepolonium(a)gmail.com> --- drivers/staging/greybus/audio_manager_module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index 4a4dfb42f50f..7e52c3f95692 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -69,7 +69,8 @@ static void gb_audio_module_release(struct kobject *kobj) struct gb_audio_manager_module *module = to_gb_audio_module(kobj); pr_info("Destroying audio module #%d\n", module->id); - /* TODO -> delete from list */ + if (module->list.prev && module->list.next) + list_del(&module->list); kfree(module); } -- 2.39.5

1 week, 4 days

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev December 2024