On Thu, Nov 13, 2025 at 10:12:00PM +0800, Chang Junzheng wrote:
> From: Chang Junzheng <guagua210311(a)outlook.com>
>
> Fix checkpatch.pl warning by changing envp array declaration to
> static const char * const. This improves code safety and follows
> kernel coding style recommendations.
>
> Signed-off-by: Chang Junzheng <guagua210311(a)qq.com>
> Changes in v2:
> - Restored original indentation of array elements
> - Only changed the array declaration as originally intended
The "Changes" goes below the --- line, as per the documentation.
thanks,
greg k-h
On Thu, Nov 13, 2025 at 09:39:54PM +0800, cjz_VM wrote:
> Hi Greg,
>
> Thanks for reviewing my patch!
>
> For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all.
Then that should have been a v2 patch :)
> For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis.
>
> If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend.
You did not document your change, and it had nothing really to do with
the const change, so I would not recommend doing this.
Also, please do not top-post, and be sure to properly wrap your lines in
your email client.
thanks,
greg k-h
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
This change adds a new WQ_PERCPU flag to explicitly request
alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified.
With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU.
Once migration is complete, WQ_UNBOUND can be removed and unbound will
become the implicit default.
Suggested-by: Tejun Heo <tj(a)kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari(a)suse.com>
Reviewed-by: Johan Hovold <johan(a)kernel.org>
---
Changes in v2:
- updated commit log removing two paragraph not strictly related to
the work.
- subject changed removing "drivers/" before the actual prefix.
---
drivers/greybus/operation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
index 54ccc434a1f7..7e12ffb2dd60 100644
--- a/drivers/greybus/operation.c
+++ b/drivers/greybus/operation.c
@@ -1238,7 +1238,7 @@ int __init gb_operation_init(void)
goto err_destroy_message_cache;
gb_operation_completion_wq = alloc_workqueue("greybus_completion",
- 0, 0);
+ WQ_PERCPU, 0);
if (!gb_operation_completion_wq)
goto err_destroy_operation_cache;
--
2.51.1
Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.
This lack of consistency cannot be addressed without refactoring the API.
alloc_workqueue() treats all queues as per-CPU by default, while unbound
workqueues must opt-in via WQ_UNBOUND.
This default is suboptimal: most workloads benefit from unbound queues,
allowing the scheduler to place worker threads where they’re needed and
reducing noise when CPUs are isolated.
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
This change adds a new WQ_PERCPU flag to explicitly request
alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified.
With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU.
Once migration is complete, WQ_UNBOUND can be removed and unbound will
become the implicit default.
Suggested-by: Tejun Heo <tj(a)kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari(a)suse.com>
---
drivers/greybus/operation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
index 54ccc434a1f7..7e12ffb2dd60 100644
--- a/drivers/greybus/operation.c
+++ b/drivers/greybus/operation.c
@@ -1238,7 +1238,7 @@ int __init gb_operation_init(void)
goto err_destroy_message_cache;
gb_operation_completion_wq = alloc_workqueue("greybus_completion",
- 0, 0);
+ WQ_PERCPU, 0);
if (!gb_operation_completion_wq)
goto err_destroy_operation_cache;
--
2.51.1
How to Add a Child to an Existing Cathay Pacific Booking
Need to add a child to your Cathay Pacific reservation? Call 1-833-341-5261 to speak with a live agent who can update your booking quickly and correctly.
📞 Step 1: Prepare Your Booking Details
Have ready:
• Reservation number
• Full names of all passengers
• Child’s age and seating preference (lap or own seat)
• Any special requests (bassinet, meal, guardian seating)
📞 Step 2: Call Cathay Pacific
Dial 1-833-341-5261 to reach a customer support agent. Call early to avoid long wait times.
📞 Step 3: Request to Add the Child
• Provide the child’s details and seating preference
• Mention any extras (bassinet, special seating, meals)
• Agent will confirm seat availability and any fare difference
✅ Step 4: Confirm the Update
• Receive an updated itinerary by email
• Review all details and fare changes
• Follow up with the agent if confirmation isn’t received
✨ Tips
• Call early to secure the best seats
• Ask about required travel documents for infants or minors
• Keep your confirmation handy for check-in
Calling 1-833-341-5261 ensures a smooth, family-friendly booking update.
How to Add a Child to an Existing Cathay Pacific Booking
Need to add a child to your Cathay Pacific reservation? Call 1-833-341-5261 to speak with a live agent who can update your booking quickly and correctly.
📞 Step 1: Prepare Your Booking Details
Have ready:
• Reservation number
• Full names of all passengers
• Child’s age and seating preference (lap or own seat)
• Any special requests (bassinet, meal, guardian seating)
📞 Step 2: Call Cathay Pacific
Dial 1-833-341-5261 to reach a customer support agent. Call early to avoid long wait times.
📞 Step 3: Request to Add the Child
• Provide the child’s details and seating preference
• Mention any extras (bassinet, special seating, meals)
• Agent will confirm seat availability and any fare difference
✅ Step 4: Confirm the Update
• Receive an updated itinerary by email
• Review all details and fare changes
• Follow up with the agent if confirmation isn’t received
✨ Tips
• Call early to secure the best seats
• Ask about required travel documents for infants or minors
• Keep your confirmation handy for check-in
Calling 1-833-341-5261 ensures a smooth, family-friendly booking update.
How to Add a Child to an Existing British Airways Booking
Need to add a child to your British Airways reservation? Call 1-833-341-5261 to speak with a live agent who can update your booking quickly and correctly.
📞 Step 1: Prepare Your Booking Details
Have ready:
• Reservation number
• Full names of all passengers
• Child’s age and seating preference (lap or own seat)
• Any special requests (bassinet, meal, guardian seating)
📞 Step 2: Call British Airways
Dial 1-833-341-5261 to reach a customer support agent. Call early to avoid long wait times.
📞 Step 3: Request to Add the Child
• Provide the child’s details and seating preference
• Mention any extras (bassinet, special seating, meals)
• Agent will confirm seat availability and any fare difference
✅ Step 4: Confirm the Update
• Receive an updated itinerary by email
• Review all details and fare changes
• Follow up with the agent if confirmation isn’t received
✨ Tips
• Call early to secure the best seats
• Ask about required travel documents for infants or minors
• Keep your confirmation handy for check-in
Calling 1-833-341-5261 ensures a smooth, family-friendly booking update.
How to Add a Child to an Existing Avianca Airlines Booking
Need to add a child to your Avianca Airlines reservation? Call 1-833-341-5261 to speak with a live agent who can update your booking quickly and correctly.
📞 Step 1: Prepare Your Booking Details
Have ready:
• Reservation number
• Full names of all passengers
• Child’s age and seating preference (lap or own seat)
• Any special requests (bassinet, meal, guardian seating)
📞 Step 2: Call Avianca Airlines
Dial 1-833-341-5261 to reach a customer support agent. Call early to avoid long wait times.
📞 Step 3: Request to Add the Child
• Provide the child’s details and seating preference
• Mention any extras (bassinet, special seating, meals)
• Agent will confirm seat availability and any fare difference
✅ Step 4: Confirm the Update
• Receive an updated itinerary by email
• Review all details and fare changes
• Follow up with the agent if confirmation isn’t received
✨ Tips
• Call early to secure the best seats
• Ask about required travel documents for infants or minors
• Keep your confirmation handy for check-in
Calling 1-833-341-5261 ensures a smooth, family-friendly booking update.