greybus-dev October 2026

greybus-dev@lists.linaro.org

39 participants
60 discussions

[syzbot] [greybus?] WARNING: ODEBUG bug in gb_operation_sync_timeout

by syzbot

Hello, syzbot found the following issue on: HEAD commit: 2f2f7eeef8b0 Merge tag 'soc-fixes-7.3-3' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=157b1bd1580000 kernel config: https://syzkaller.appspot.com/x/.config?x=c4b098695335c89f dashboard link: https://syzkaller.appspot.com/bug?extid=a2e50fb40695811c2dab compiler: Debian clang version 22.1.8 (1~deb13u4), Debian LLD 22.1.8 Unfortunately, I don't have any reproducer for this issue yet. Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/e46a243fa39c/disk-2f2f7eee.raw… vmlinux: https://storage.googleapis.com/syzbot-assets/04a37a0099c0/vmlinux-2f2f7eee.… kernel image: https://storage.googleapis.com/syzbot-assets/c2964fdca34d/bzImage-2f2f7eee.… IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+a2e50fb40695811c2dab(a)syzkaller.appspotmail.com greybus greybus1: 0/0:0: synchronous operation id 0x0002 of type 0x10 failed: -71 ------------[ cut here ]------------ ODEBUG: free active (active state 0) object: ffff888087f2c878 object type: timer_list hint: gb_operation_timeout+0x0/0x110 drivers/greybus/operation.c:1265 WARNING: lib/debugobjects.c:632 at debug_print_object+0xec/0x230 lib/debugobjects.c:629, CPU#1: kworker/u8:19/14610 Modules linked in: CPU: 1 UID: 0 PID: 14610 Comm: kworker/u8:19 Tainted: G L syzkaller #0 PREEMPT(full) Tainted: [L]=SOFTLOCKUP Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/07/2026 Workqueue: greybus1:svc gb_svc_process_deferred_request RIP: 0010:debug_print_object+0x18a/0x230 lib/debugobjects.c:629 Code: f8 48 c1 e8 03 80 3c 18 00 74 08 4c 89 ff e8 4d 99 4c fd 4d 8b 0f 4c 89 ef 48 8b 74 24 08 48 89 ea 44 89 e1 4d 89 f0 ff 34 24 <67> 48 0f b9 3a 48 83 c4 08 ff 05 f3 4c 8e 0c 48 83 c4 10 5b 41 5c RSP: 0018:ffffc9000767f7e0 EFLAGS: 00010246 RAX: 1ffffffff181f08c RBX: dffffc0000000000 RCX: 0000000000000000 RDX: ffffffff8c6de740 RSI: ffffffff8c6de1c0 RDI: ffffffff91859a20 RBP: ffffffff8c6de740 R08: ffff888087f2c878 R09: ffffffff8c0f97c0 R10: dffffc0000000000 R11: ffffffff81b3f760 R12: 0000000000000000 R13: ffffffff91859a20 R14: ffff888087f2c878 R15: ffffffff8c0f8460 FS: 0000000000000000(0000) GS:ffff888123bbf000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000000110c25d909 CR3: 0000000071620000 CR4: 00000000003526f0 Call Trace: <TASK> __debug_check_no_obj_freed lib/debugobjects.c:1171 [inline] debug_check_no_obj_freed+0x2e3/0x450 lib/debugobjects.c:1201 slab_free_hook mm/slub.c:2679 [inline] slab_free mm/slub.c:6509 [inline] kmem_cache_free+0xfd/0x650 mm/slub.c:6636 gb_operation_sync_timeout+0x1c7/0x270 drivers/greybus/operation.c:1172 gb_operation_sync include/linux/greybus/operation.h:203 [inline] gb_svc_intf_set_power_mode drivers/greybus/svc.c:584 [inline] gb_svc_process_hello_deferred drivers/greybus/svc.c:936 [inline] gb_svc_process_deferred_request+0x5f3/0x1150 drivers/greybus/svc.c:1102 process_one_work kernel/workqueue.c:3396 [inline] process_scheduled_works+0xc3d/0x1630 kernel/workqueue.c:3479 worker_thread+0xa47/0xfb0 kernel/workqueue.c:3560 kthread+0x38b/0x480 kernel/kthread.c:436 ret_from_fork+0x514/0xb70 arch/x86/kernel/process.c:158 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245 </TASK> ---------------- Code disassembly (best guess): 0: f8 clc 1: 48 c1 e8 03 shr $0x3,%rax 5: 80 3c 18 00 cmpb $0x0,(%rax,%rbx,1) 9: 74 08 je 0x13 b: 4c 89 ff mov %r15,%rdi e: e8 4d 99 4c fd call 0xfd4c9960 13: 4d 8b 0f mov (%r15),%r9 16: 4c 89 ef mov %r13,%rdi 19: 48 8b 74 24 08 mov 0x8(%rsp),%rsi 1e: 48 89 ea mov %rbp,%rdx 21: 44 89 e1 mov %r12d,%ecx 24: 4d 89 f0 mov %r14,%r8 27: ff 34 24 push (%rsp) * 2a: 67 48 0f b9 3a ud1 (%edx),%rdi <-- trapping instruction 2f: 48 83 c4 08 add $0x8,%rsp 33: ff 05 f3 4c 8e 0c incl 0xc8e4cf3(%rip) # 0xc8e4d2c 39: 48 83 c4 10 add $0x10,%rsp 3d: 5b pop %rbx 3e: 41 5c pop %r12 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. If the report is already addressed, let syzbot know by replying with: #syz fix: exact-commit-title If you want to overwrite report's subsystems, reply with: #syz set subsystems: new-subsystem (See the list of subsystem names on the web dashboard) If the report is a duplicate of another one, reply with: #syz dup: exact-subject-of-another-report If you want to undo deduplication, reply with: #syz undup

3 weeks, 3 days

[PATCH] staging: greybus: uart: fix argument alignment

by Okhuomon Ajayi

Align the msecs_to_jiffies() argument with the opening parenthesis of wait_for_completion_timeout() to address the checkpatch alignment warning. Signed-off-by: Okhuomon Ajayi <okhuomonajayi54(a)gmail.com> --- drivers/staging/greybus/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index d47f00751e7a..2448fc9098d6 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -317,7 +317,7 @@ static int gb_uart_wait_for_all_credits(struct gb_tty *gb_tty) return 0; ret = wait_for_completion_timeout(&gb_tty->credits_complete, - msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); + msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); if (!ret) { dev_err(&gb_tty->gbphy_dev->dev, "time out waiting for credits\n"); -- 2.43.0

3 weeks, 4 days

[PATCH v3] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

by Jeremy Dean Clifton

Commit 3228900f80c2 ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'") removed a function definition but did not remove the function prototype. Remove the prototype. Signed-off-by: Jeremy Dean Clifton <deaner92(a)yahoo.com> --- v3: Change to imperative mood and write in proper English (Julia Lawall). v2: Fix grammar and spelling in commit message. drivers/staging/greybus/firmware.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h index 5d2564462ffc..04a67d2d5b8f 100644 --- a/drivers/staging/greybus/firmware.h +++ b/drivers/staging/greybus/firmware.h @@ -22,7 +22,6 @@ /* Firmware Management Protocol specific functions */ int fw_mgmt_init(void); void fw_mgmt_exit(void); -struct gb_connection *to_fw_mgmt_connection(struct device *dev); int gb_fw_mgmt_request_handler(struct gb_operation *op); int gb_fw_mgmt_connection_init(struct gb_connection *connection); void gb_fw_mgmt_connection_exit(struct gb_connection *connection); -- 2.43.0

3 weeks, 4 days

[PATCH v3] staging: greybus: replace PTR_ERR() with %pe in error messages

by pavankumaryalagada＠gmail.com

From: Yalagada Pavan Kumar <pavankumaryalagada(a)gmail.com> Use %pe to print error pointers directly and display their error names. Keep PTR_ERR() calls when the numeric error value is needed for returning the error code. Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada(a)gmail.com> --- v3: - Extend the %pe conversion throughout Greybus, as suggested by Alex Elder. v2: - Use %pe in the firmware management case, as suggested by Jeremy Clifton, to match the other cases. v1: https://lore.kernel.org/outreachy/as0nhVbagZa8Birm@user/T/#t --- drivers/staging/greybus/arche-apb-ctrl.c | 18 +++++++++--------- drivers/staging/greybus/arche-platform.c | 8 ++++---- drivers/staging/greybus/fw-core.c | 16 ++++++++-------- drivers/staging/greybus/uart.c | 2 +- 4 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index 4302c2226126..fa4d2d88dc3f 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -145,8 +145,8 @@ static int fw_flashing_seq(struct platform_device *pdev) apb->spi_en = devm_gpiod_get(dev, "spi-en", flags); if (IS_ERR(apb->spi_en)) { ret = PTR_ERR(apb->spi_en); - dev_err(dev, "Failed requesting SPI bus en GPIO: %d\n", - ret); + dev_err(dev, "Failed requesting SPI bus en GPIO: %pe\n", + apb->spi_en); return ret; } } @@ -323,14 +323,14 @@ static int apb_ctrl_get_fw_data(struct platform_device *pdev, apb->resetn = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(apb->resetn)) { ret = PTR_ERR(apb->resetn); - dev_err(dev, "Failed requesting reset GPIO: %d\n", ret); + dev_err(dev, "Failed requesting reset GPIO: %pe\n", apb->resetn); return ret; } apb->boot_ret = devm_gpiod_get(dev, "boot-ret", GPIOD_OUT_LOW); if (IS_ERR(apb->boot_ret)) { ret = PTR_ERR(apb->boot_ret); - dev_err(dev, "Failed requesting bootret GPIO: %d\n", ret); + dev_err(dev, "Failed requesting bootret GPIO: %pe\n", apb->boot_ret); return ret; } @@ -338,7 +338,7 @@ static int apb_ctrl_get_fw_data(struct platform_device *pdev, apb->pwroff = devm_gpiod_get_optional(dev, "pwr-off", GPIOD_IN); if (IS_ERR(apb->pwroff)) { ret = PTR_ERR(apb->pwroff); - dev_err(dev, "Failed requesting pwroff_n GPIO: %d\n", ret); + dev_err(dev, "Failed requesting pwroff_n GPIO: %pe\n", apb->pwroff); return ret; } @@ -346,14 +346,14 @@ static int apb_ctrl_get_fw_data(struct platform_device *pdev, apb->clk_en = devm_gpiod_get_optional(dev, "clock-en", GPIOD_OUT_LOW); if (IS_ERR(apb->clk_en)) { ret = PTR_ERR(apb->clk_en); - dev_err(dev, "Failed requesting APB clock en GPIO: %d\n", ret); + dev_err(dev, "Failed requesting APB clock en GPIO: %pe\n", apb->clk_en); return ret; } apb->pwrdn = devm_gpiod_get(dev, "pwr-down", GPIOD_OUT_LOW); if (IS_ERR(apb->pwrdn)) { ret = PTR_ERR(apb->pwrdn); - dev_warn(dev, "Failed requesting power down GPIO: %d\n", ret); + dev_warn(dev, "Failed requesting power down GPIO: %pe\n", apb->pwrdn); return ret; } @@ -368,12 +368,12 @@ static int apb_ctrl_get_fw_data(struct platform_device *pdev, apb->pinctrl = devm_pinctrl_get(&pdev->dev); if (IS_ERR(apb->pinctrl)) { - dev_err(&pdev->dev, "could not get pinctrl handle\n"); + dev_err(&pdev->dev, "could not get pinctrl handle: %pe\n", apb->pinctrl); return PTR_ERR(apb->pinctrl); } apb->pin_default = pinctrl_lookup_state(apb->pinctrl, "default"); if (IS_ERR(apb->pin_default)) { - dev_err(&pdev->dev, "could not get default pin state\n"); + dev_err(&pdev->dev, "could not get default pin state: %pe\n", apb->pin_default); return PTR_ERR(apb->pin_default); } diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index de5de59ea8ab..a97ac59c6f01 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -445,7 +445,7 @@ static int arche_platform_probe(struct platform_device *pdev) arche_pdata->svc_reset = devm_gpiod_get(dev, "svc,reset", flags); if (IS_ERR(arche_pdata->svc_reset)) { ret = PTR_ERR(arche_pdata->svc_reset); - dev_err(dev, "failed to request svc-reset GPIO: %d\n", ret); + dev_err(dev, "failed to request svc-reset GPIO: %pe\n", arche_pdata->svc_reset); return ret; } arche_platform_set_state(arche_pdata, ARCHE_PLATFORM_STATE_OFF); @@ -454,7 +454,7 @@ static int arche_platform_probe(struct platform_device *pdev) GPIOD_OUT_LOW); if (IS_ERR(arche_pdata->svc_sysboot)) { ret = PTR_ERR(arche_pdata->svc_sysboot); - dev_err(dev, "failed to request sysboot0 GPIO: %d\n", ret); + dev_err(dev, "failed to request sysboot0 GPIO: %pe\n", arche_pdata->svc_sysboot); return ret; } @@ -471,7 +471,7 @@ static int arche_platform_probe(struct platform_device *pdev) arche_pdata->svc_ref_clk = devm_clk_get(dev, "svc_ref_clk"); if (IS_ERR(arche_pdata->svc_ref_clk)) { ret = PTR_ERR(arche_pdata->svc_ref_clk); - dev_err(dev, "failed to get svc_ref_clk: %d\n", ret); + dev_err(dev, "failed to get svc_ref_clk: %pe\n", arche_pdata->svc_ref_clk); return ret; } @@ -484,7 +484,7 @@ static int arche_platform_probe(struct platform_device *pdev) GPIOD_IN); if (IS_ERR(arche_pdata->wake_detect)) { ret = PTR_ERR(arche_pdata->wake_detect); - dev_err(dev, "Failed requesting wake_detect GPIO: %d\n", ret); + dev_err(dev, "Failed requesting wake_detect GPIO: %pe\n", arche_pdata->wake_detect); return ret; } diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 2016a74f137f..78321be80013 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -93,8 +93,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, if (IS_ERR(connection)) { ret = PTR_ERR(connection); dev_err(&bundle->dev, - "failed to create management connection (%d)\n", - ret); + "failed to create management connection (%pe)\n", + connection); goto err_destroy_connections; } @@ -112,8 +112,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, gb_fw_download_request_handler); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create download connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create download connection (%pe)\n", + connection); } else { fw_core->download_connection = connection; } @@ -131,8 +131,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, NULL); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create SPI connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create SPI connection (%pe)\n", + connection); } else { fw_core->spi_connection = connection; } @@ -149,8 +149,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, NULL); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create Authentication connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create Authentication connection (%pe)\n", + connection); } else { fw_core->cap_connection = connection; } diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 172cf900eaf0..59a112cf47a0 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -951,7 +951,7 @@ static int gb_tty_init(void) TTY_DRIVER_DYNAMIC_DEV | TTY_DRIVER_RESET_SAVED_TERMIOS); if (IS_ERR(gb_tty_driver)) { - pr_err("Can not allocate tty driver\n"); + pr_err("Can not allocate tty driver: %pe\n", gb_tty_driver); retval = PTR_ERR(gb_tty_driver); goto fail_unregister_dev; } -- 2.43.0

3 weeks, 5 days

[PATCH v2] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

by Jeremy Dean Clifton

Previous commit removing a function definition did not remove the function prototype. commit 3228900f80c2 ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'") Function header declaration needs to be removed after definition removal. There is no definition of this function nor is there any place where it is called. Signed-off-by: Jeremy Dean Clifton <deaner92(a)yahoo.com> --- v2: Fix grammar and spelling in commit message. drivers/staging/greybus/firmware.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h index 5d2564462ffc..04a67d2d5b8f 100644 --- a/drivers/staging/greybus/firmware.h +++ b/drivers/staging/greybus/firmware.h @@ -22,7 +22,6 @@ /* Firmware Management Protocol specific functions */ int fw_mgmt_init(void); void fw_mgmt_exit(void); -struct gb_connection *to_fw_mgmt_connection(struct device *dev); int gb_fw_mgmt_request_handler(struct gb_operation *op); int gb_fw_mgmt_connection_init(struct gb_connection *connection); void gb_fw_mgmt_connection_exit(struct gb_connection *connection); -- 2.43.0

3 weeks, 5 days

[PATCH v2] staging: greybus: replace PTR_ERR() with %pe in error messages

by pavankumaryalagada＠gmail.com

From: Yalagada Pavan Kumar <pavankumaryalagada(a)gmail.com> Use %pe to print error pointers directly and display their error names. Keep the other PTR_ERR() call because its return value is needed for ret. Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada(a)gmail.com> --- v2: - Use %pe in the firmware management case, as suggested by Jeremy Clifton, to match the other cases. v1: https://lore.kernel.org/outreachy/as0nhVbagZa8Birm@user/T/#t --- drivers/staging/greybus/fw-core.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 2016a74f137f..78321be80013 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -93,8 +93,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, if (IS_ERR(connection)) { ret = PTR_ERR(connection); dev_err(&bundle->dev, - "failed to create management connection (%d)\n", - ret); + "failed to create management connection (%pe)\n", + connection); goto err_destroy_connections; } @@ -112,8 +112,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, gb_fw_download_request_handler); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create download connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create download connection (%pe)\n", + connection); } else { fw_core->download_connection = connection; } @@ -131,8 +131,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, NULL); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create SPI connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create SPI connection (%pe)\n", + connection); } else { fw_core->spi_connection = connection; } @@ -149,8 +149,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, NULL); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create Authentication connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create Authentication connection (%pe)\n", + connection); } else { fw_core->cap_connection = connection; } -- 2.43.0

3 weeks, 5 days

[PATCH] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

by Jeremy Dean Clifton

commit 3228900f80c2 ("staging: greybus: Remove unused function 'to_fw_mgmt_connection'") Function header declaration needs to be removed after it's declaration. There is no declaration of this function nor is there any place where it is called. Signed-off-by: Jeremy Dean Clifton <deaner92(a)yahoo.com> --- drivers/staging/greybus/firmware.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h index 5d2564462ffc..04a67d2d5b8f 100644 --- a/drivers/staging/greybus/firmware.h +++ b/drivers/staging/greybus/firmware.h @@ -22,7 +22,6 @@ /* Firmware Management Protocol specific functions */ int fw_mgmt_init(void); void fw_mgmt_exit(void); -struct gb_connection *to_fw_mgmt_connection(struct device *dev); int gb_fw_mgmt_request_handler(struct gb_operation *op); int gb_fw_mgmt_connection_init(struct gb_connection *connection); void gb_fw_mgmt_connection_exit(struct gb_connection *connection); -- 2.43.0

3 weeks, 5 days

[PATCH] staging: greybus: Remove unused function 'to_fw_mgmt_connection'

by Jeremy Dean Clifton

Remove unused function from greybus driver to_fw_mgmt_connection. This function is not exported or called from anywhere tree-wide. Confirmed with git grep and cscope. Signed-off-by: Jeremy Dean Clifton <deaner92(a)yahoo.com> --- drivers/staging/greybus/fw-core.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 78321be80013..46b35ef55090 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -21,13 +21,6 @@ struct gb_fw_core { static struct spilib_ops *spilib_ops; -struct gb_connection *to_fw_mgmt_connection(struct device *dev) -{ - struct gb_fw_core *fw_core = dev_get_drvdata(dev); - - return fw_core->mgmt_connection; -} - static int gb_fw_spi_connection_init(struct gb_connection *connection) { int ret; -- 2.43.0

3 weeks, 6 days

[PATCH] staging: greybus: replace PTR_ERR() with %pe in error messages

by pavankumaryalagada＠gmail.com

From: Yalagada Pavan Kumar <pavankumaryalagada(a)gmail.com> Use %pe to print error pointers directly and display their error names. Keep the other PTR_ERR() call because its return value is needed for ret. Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada(a)gmail.com> --- drivers/staging/greybus/fw-core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c index 2016a74f137f..7053afa9ab3e 100644 --- a/drivers/staging/greybus/fw-core.c +++ b/drivers/staging/greybus/fw-core.c @@ -112,8 +112,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, gb_fw_download_request_handler); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create download connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create download connection (%pe)\n", + connection); } else { fw_core->download_connection = connection; } @@ -131,8 +131,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, NULL); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create SPI connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create SPI connection (%pe)\n", + connection); } else { fw_core->spi_connection = connection; } @@ -149,8 +149,8 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, connection = gb_connection_create(bundle, cport_id, NULL); if (IS_ERR(connection)) { - dev_err(&bundle->dev, "failed to create Authentication connection (%ld)\n", - PTR_ERR(connection)); + dev_err(&bundle->dev, "failed to create Authentication connection (%pe)\n", + connection); } else { fw_core->cap_connection = connection; } -- 2.43.0

4 weeks

[PATCH 00/13] PM: runtime: Convert pm_runtime_put_autosuspend() and friends to a void function

by Brian Norris

Similar to this effort: Subject: [PATCH v1 00/23] PM: runtime: Convert pm_runtime_put() to a void function https://lore.kernel.org/all/6245770.lOV4Wx5bFT@rafael.j.wysocki/ i.e., commit 3afd8df02433 ("PM: runtime: Change pm_runtime_put() return type to void") and friends. As with pm_runtime_put(), there is very little value in return-code checking for any of the other async __pm_runtime_suspend() and __pm_runtime_idle() APIs: pm_runtime_put_autosuspend() pm_request_idle() pm_request_autosuspend() Checking the return code is more likely to produce a race condition (fighting with user space writing "on" to the "control" attribute) than to tell a consumer useful info. Nobody outside KUnit tests checks pm_request_idle() or pm_request_autosuspend() return codes, but there are a number of pm_runtime_put_autosuspend() callers that check its return code. Thus, this series largely deals with pm_runtime_put_autosuspend(). Patches 1-11 are independent of each other, and similarly to the last series, I expect the respective maintainers can pick them up. We can apply patch 12 later. Patch 13 is also independent, but included in this topic for completeness. It can be applied any time. This touches a lot of trees/maintainers, so I tried to keep CC's only for the relevant patch(es), plus the cover letter. I hope that's not too noisy. - Brian Brian Norris (13): hwrng: cctrng: Discard pm_runtime_put_autosuspend() return value drm: Discard pm_runtime_put_autosuspend() return values iio: Discard pm_runtime_put_autosuspend() return values media: venus: Discard pm_runtime_put_autosuspend() return values pinctrl: qcom: lpass-lpi: Discard pm_runtime_put_autosuspend() return values spi: ti-qspi: Discard pm_runtime_put_autosuspend() return value greybus: Discard pm_runtime_put_autosuspend() return value ALSA: hda: Discard pm_runtime_put_autosuspend() return value ASoC: codecs: lpass: Discard pm_runtime_put_autosuspend() return values ASoC: intel: atom: Discard pm_runtime_put_autosuspend() return value ASoC: SOF: Discard pm_runtime_put_autosuspend() return values PM: runtime: Drop pm_runtime_put_autosuspend() return code PM: runtime: Drop pm_request_{idle,autosuspend}() return codes drivers/base/power/runtime-test.c | 8 --- drivers/char/hw_random/cctrng.c | 6 +- drivers/gpu/drm/panel/panel-simple.c | 8 +-- drivers/gpu/drm/tidss/tidss_drv.c | 7 +-- drivers/gpu/drm/v3d/v3d_drv.h | 4 +- drivers/iio/accel/bmc150-accel-core.c | 14 ++--- drivers/iio/accel/fxls8962af-core.c | 11 +--- drivers/iio/accel/kxcjk-1013.c | 15 ++--- drivers/iio/accel/mma8452.c | 15 +++-- drivers/iio/accel/mma9551_core.c | 15 +++-- drivers/iio/adc/rcar-gyroadc.c | 4 +- drivers/iio/adc/ti-ads1015.c | 8 +-- drivers/iio/chemical/atlas-sensor.c | 4 +- .../common/hid-sensors/hid-sensor-trigger.c | 14 ++--- drivers/iio/gyro/bmg160_core.c | 17 +++-- drivers/iio/gyro/fxas21002c_core.c | 12 ++-- drivers/iio/imu/kmx61.c | 17 +++-- drivers/iio/light/apds9960.c | 2 +- drivers/iio/light/isl29028.c | 15 +---- drivers/iio/light/pa12203001.c | 3 +- drivers/iio/light/rpr0521.c | 15 +++-- drivers/iio/light/tsl2583.c | 27 ++------ drivers/iio/light/us5182d.c | 3 +- drivers/media/platform/qcom/venus/vdec.c | 10 ++- drivers/media/platform/qcom/venus/venc.c | 10 ++- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 16 +++-- drivers/spi/spi-ti-qspi.c | 6 +- drivers/staging/greybus/power_supply.c | 8 +-- include/linux/greybus/bundle.h | 12 +--- include/linux/pm_runtime.h | 63 +++---------------- include/sound/hdaudio.h | 8 +-- sound/hda/core/device.c | 13 ++-- sound/soc/codecs/lpass-rx-macro.c | 4 +- sound/soc/codecs/lpass-tx-macro.c | 4 +- sound/soc/codecs/lpass-va-macro.c | 17 ++--- sound/soc/codecs/lpass-wsa-macro.c | 8 +-- sound/soc/intel/atom/sst/sst.h | 2 +- sound/soc/intel/atom/sst/sst_drv_interface.c | 4 +- sound/soc/intel/atom/sst/sst_pvt.c | 9 +-- sound/soc/sof/control.c | 6 +- sound/soc/sof/sof-client-ipc-flood-test.c | 5 +- .../soc/sof/sof-client-ipc-kernel-injector.c | 4 +- sound/soc/sof/sof-client-ipc-msg-injector.c | 6 +- sound/soc/sof/sof-client-probes.c | 18 ++---- 44 files changed, 152 insertions(+), 325 deletions(-) -- 2.56.0.360.g66cac248cb-goog

1 month

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev October 2026