From 9114eb9d60f2c4a52f05e3a33b0d6b8ca4856cac Mon Sep 17 00:00:00 2001
From: Kurmapu Sai Devansh Prasad <btech10487.26(a)bitmesra.ac.in>
Date: Mon, 2 Nov 2026 19:11:09 +0530
Subject: [PATCH] staging: greybus: fix string termination in firmware sample
The firmware_tag string copied via strncpy() is not guaranteed to be
NUL-terminated if the source string is exactly the size of the destination
buffer. This can lead to a buffer over-read.
Since alternatives like strscpy_pad cannot be used in user space
sample code, we can make it safer by limiting the copy size to
MAX_SIZE - 1 and explicitly assigning the last byte to be a NUL
terminator. This ensures the string is always
safely terminated before being passed to the ioctl.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-n…
This is my very first patch to the Linux kernel! I've been learning the
process and would deeply appreciate any feedback from the maintainers.
Signed-off-by: Kurmapu Sai Devansh Prasad <btech10487.26(a)bitmesra.ac.in>
---
.../greybus/Documentation/firmware/firmware.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c
b/drivers/staging/greybus/Documentation/firmware/firmware.c
index 3b35ef6d4adb..a6a0988ad6fe 100644
--- a/drivers/staging/greybus/Documentation/firmware/firmware.c
+++ b/drivers/staging/greybus/Documentation/firmware/firmware.c
@@ -64,7 +64,9 @@ static int update_intf_firmware(int fd)
intf_load.minor = 0;
strncpy((char *)&intf_load.firmware_tag, firmware_tag,
- GB_FIRMWARE_U_TAG_MAX_SIZE);
+ GB_FIRMWARE_U_TAG_MAX_SIZE - 1);
+ ((char *)&intf_load.firmware_tag)[GB_FIRMWARE_U_TAG_MAX_SIZE - 1] =
+ '\0';
ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load);
if (ret < 0) {
@@ -102,7 +104,9 @@ static int update_backend_firmware(int fd)
printf("Getting Backend Firmware Version\n");
strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag,
- GB_FIRMWARE_U_TAG_MAX_SIZE);
+ GB_FIRMWARE_U_TAG_MAX_SIZE - 1);
+ ((char *)&backend_fw_info.firmware_tag)[GB_FIRMWARE_U_TAG_MAX_SIZE
- 1] =
+ '\0';
retry_fw_version:
ret = ioctl(fd, FW_MGMT_IOC_GET_BACKEND_FW, &backend_fw_info);
@@ -130,7 +134,9 @@ static int update_backend_firmware(int fd)
printf("Updating Backend Firmware\n");
strncpy((char *)&backend_update.firmware_tag, firmware_tag,
- GB_FIRMWARE_U_TAG_MAX_SIZE);
+ GB_FIRMWARE_U_TAG_MAX_SIZE - 1);
+ ((char *)&backend_update.firmware_tag)[GB_FIRMWARE_U_TAG_MAX_SIZE - 1] =
+ '\0';
retry_fw_update:
backend_update.status = 0;
--
2.56.0
fw_mgmt_ioctl() copies struct fw_mgmt_ioc_get_backend_version,
struct fw_mgmt_ioc_intf_load_and_validate and
struct fw_mgmt_ioc_backend_fw_update directly from userspace via
copy_from_user(). Each of these contains a fixed-size
firmware_tag[GB_FIRMWARE_U_TAG_MAX_SIZE] array that is never checked
for NUL-termination before being used.
While the array is eventually copied into a Greybus request via
strscpy_pad(), which safely bounds its read and always NUL-terminates
its destination, three error paths print the original, unterminated
userspace buffer directly with "%s":
fw_mgmt_backend_fw_version_operation():
dev_err(..., "failed to get version of %s backend firmware (%d)\n",
fw_info->firmware_tag, ret);
dev_err(..., "Firmware with tag %s is not supported by Interface\n",
fw_info->firmware_tag);
fw_mgmt_backend_fw_update_operation():
dev_err(..., "backend %s firmware update request failed (%d)\n",
tag, ret);
If a caller supplies exactly GB_FIRMWARE_U_TAG_MAX_SIZE non-NUL bytes,
"%s" has no terminator inside the array and reads past it into
adjacent kernel stack memory until it happens to find a zero byte,
leaking that memory into dmesg.
Reject the ioctl up front when firmware_tag is not NUL-terminated,
mirroring the existing check already used for the equivalent
Greybus-module-supplied field in fw_download_find_firmware().
Fixes: 013e66537273 ("greybus: fw-management: Add firmware-management protocol driver")
Signed-off-by: Maritu Hone <marehone12(a)gmail.com>
---
drivers/staging/greybus/fw-management.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
index 5d01da6b6eb9..2ee609dd67fb 100644
--- a/drivers/staging/greybus/fw-management.c
+++ b/drivers/staging/greybus/fw-management.c
@@ -419,6 +419,11 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
sizeof(backend_fw_info)))
return -EFAULT;
+ if (strnlen(backend_fw_info.firmware_tag,
+ GB_FIRMWARE_U_TAG_MAX_SIZE) ==
+ GB_FIRMWARE_U_TAG_MAX_SIZE)
+ return -EINVAL;
+
ret = fw_mgmt_backend_fw_version_operation(fw_mgmt,
&backend_fw_info);
if (ret)
@@ -433,6 +438,11 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
if (copy_from_user(&intf_load, buf, sizeof(intf_load)))
return -EFAULT;
+ if (strnlen(intf_load.firmware_tag,
+ GB_FIRMWARE_U_TAG_MAX_SIZE) ==
+ GB_FIRMWARE_U_TAG_MAX_SIZE)
+ return -EINVAL;
+
ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
intf_load.load_method, intf_load.firmware_tag);
if (ret)
@@ -457,6 +467,11 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
sizeof(backend_update)))
return -EFAULT;
+ if (strnlen(backend_update.firmware_tag,
+ GB_FIRMWARE_U_TAG_MAX_SIZE) ==
+ GB_FIRMWARE_U_TAG_MAX_SIZE)
+ return -EINVAL;
+
ret = fw_mgmt_backend_fw_update_operation(fw_mgmt,
backend_update.firmware_tag);
if (ret)
--
2.43.0