Add a comment to the mutex definition in struct gb_camera to
describe what it protects, satisfying a checkpatch.pl CHECK.
Signed-off-by: Jose A. Perez de Azpillaga <azpijr(a)gmail.com>
---
Hi,
I noticed a CHECK for alignment in this file on line 267. However,
fixing it pushed the line over 100 characters. I felt that adding
extreme indentation might add more noise than value, so I've only
included the mutex comment fix here.
I'd appreciate your guidance on whether you prefer strict alignment
even if it breaks the 100-column rule in these specific cases.
---
drivers/staging/greybus/camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index 62b55bb28408..a6f3637b8871 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -53,7 +53,7 @@ struct gb_camera {
struct gb_connection *data_connection;
u16 data_cport_id;
- struct mutex mutex;
+ struct mutex mutex; /* Protects camera state */
enum gb_camera_state state;
struct {
--
2.53.0
Changes in v2:
- Resent using git-send-email (previous submission had incorrect formatting).
- No code changes.
This series contains two small fixes for the Greybus audio manager:
1) Fix a NULL dereference in gb_audio_manager_get_module().
2) Drop a stale TODO in the module release callback.
Both are correctness / cleanup fixes with no functional change beyond preventing crashes.
Thanks,
Hardik
Hardik Phalet (2):
staging: greybus: audio: fix NULL dereference in
gb_audio_manager_get_module()
staging: greybus: audio: drop stale TODO in module release
drivers/staging/greybus/audio_manager.c | 3 ++-
drivers/staging/greybus/audio_manager_module.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.53.0
From: Tomasz Unger <tomasz.unger(a)yahoo.pl>
Replace 'busses' with 'buses' in help text.
Found using codespell.
Signed-off-by: Tomasz Unger <tomasz.unger(a)yahoo.pl>
---
drivers/staging/greybus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/Kconfig b/drivers/staging/greybus/Kconfig
index 1e745a8d439c..7635f3e850fa 100644
--- a/drivers/staging/greybus/Kconfig
+++ b/drivers/staging/greybus/Kconfig
@@ -123,7 +123,7 @@ menuconfig GREYBUS_BRIDGED_PHY
help
Select this option to pick from a variety of Greybus Bridged
PHY class drivers. These drivers emulate a number of
- different "traditional" busses by tunneling them over Greybus.
+ different "traditional" buses by tunneling them over Greybus.
Examples of this include serial, SPI, USB, and others.
To compile this code as a module, chose M here: the module
--
2.53.0