greybus-dev

greybus-dev@lists.linaro.org

1 participants
650 discussions

[PATCH] staging: greybus: replace strncpy() with strlcpy() in firmware test tool

by Dharanitharan R

The sample userspace firmware-management tool uses strncpy() to copy firmware tags. strncpy() does not guarantee null-termination and can leave buffers unterminated. For userspace code, strlcpy() is the recommended safe alternative. Replace all strncpy() calls with strlcpy(). Signed-off-by: Dharanitharan <dharanitharan725(a)gmail.com> --- .../greybus/Documentation/firmware/firmware.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 3b35ef6d4adb..224eb8f4e39c 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,8 +63,9 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(intf_load.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); + ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); if (ret < 0) { @@ -101,8 +102,9 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(backend_fw_info.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); + retry_fw_version: ret = ioctl(fd, FW_MGMT_IOC_GET_BACKEND_FW, &backend_fw_info); @@ -129,8 +131,8 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(backend_update.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: backend_update.status = 0; -- 2.43.0

2 weeks, 2 days

[PATCH v2] staging: greybus: replace strncpy() with strlcpy() in firmware test tool

by Dharanitharan R

v2: Fix indentation issues pointed out by Greg KH. Signed-off-by:Dharanitharan R <dharanitharan725(a)gmail.com> --- .../staging/greybus/Documentation/firmware/firmware.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c index 3b35ef6d4adb..6f6410878ee6 100644 --- a/drivers/staging/greybus/Documentation/firmware/firmware.c +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c @@ -63,9 +63,11 @@ static int update_intf_firmware(int fd) intf_load.major = 0; intf_load.minor = 0; - strncpy((char *)&intf_load.firmware_tag, firmware_tag, + strlcpy(intf_load.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); ret = ioctl(fd, FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE, &intf_load); if (ret < 0) { printf("Failed to load interface firmware: %s (%d)\n", fwdev, @@ -101,9 +103,10 @@ static int update_backend_firmware(int fd) /* Get Backend Firmware Version */ printf("Getting Backend Firmware Version\n"); - strncpy((char *)&backend_fw_info.firmware_tag, firmware_tag, + strlcpy(backend_fw_info.firmware_tag, firmware_tag, GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_version: ret = ioctl(fd, FW_MGMT_IOC_GET_BACKEND_FW, &backend_fw_info); if (ret < 0) { @@ -129,8 +132,8 @@ static int update_backend_firmware(int fd) /* Try Backend Firmware Update over Unipro */ printf("Updating Backend Firmware\n"); - strncpy((char *)&backend_update.firmware_tag, firmware_tag, - GB_FIRMWARE_U_TAG_MAX_SIZE); + strlcpy(backend_update.firmware_tag, firmware_tag, + GB_FIRMWARE_U_TAG_MAX_SIZE); retry_fw_update: backend_update.status = 0; -- 2.43.0

2 weeks, 2 days

Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const

by Greg Kroah-Hartman

On Fri, Nov 14, 2025 at 09:40:43AM +0800, Chang Junzheng wrote: > From: Chang Junzheng <guagua210311(a)outlook.com> > > Fix checkpatch.pl warning by changing envp array declaration to > static const char * const. This improves code safety and follows > kernel coding style recommendations. > > Signed-off-by: Chang Junzheng <guagua210311(a)qq.com> > --- > Changes in v2: > - Restored original indentation of array elements > - Only changed the array declaration as originally intended > > drivers/staging/greybus/audio_manager_module.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c > index 4a4dfb42f50f..78013d59fc93 100644 > --- a/drivers/staging/greybus/audio_manager_module.c > +++ b/drivers/staging/greybus/audio_manager_module.c > @@ -159,14 +159,14 @@ static void send_add_uevent(struct gb_audio_manager_module *module) > char ip_devices_string[64]; > char op_devices_string[64]; > > - char *envp[] = { > - name_string, > - vid_string, > - pid_string, > - intf_id_string, > - ip_devices_string, > - op_devices_string, > - NULL > + static const char * const envp[] = { Did you test build this change? Why not?

2 weeks, 4 days

Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const

by Greg Kroah-Hartman

2 weeks, 4 days

[PATCH] staging: greybus: uart: check return values during probe

by Nirbhay Sharma

Check the return values of send_control() and send_line_coding() during device initialization in gb_uart_probe(). If these operations fail, the device will be left in an inconsistent state, so propagate the error to properly fail the probe. Both functions call gb_operation_sync() which can fail with errors such as -ENOMEM, -ENODEV, or -ETIMEDOUT. Ignoring these errors means the TTY device would be registered despite incomplete initialization. Signed-off-by: Nirbhay Sharma <nirbhay.lkd(a)gmail.com> --- drivers/staging/greybus/uart.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 10df5c37c83e..5cece0a6606f 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -879,14 +879,18 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev, if (retval) goto exit_put_port; - send_control(gb_tty, gb_tty->ctrlout); + retval = send_control(gb_tty, gb_tty->ctrlout); + if (retval) + goto exit_connection_disable; /* initialize the uart to be 9600n81 */ gb_tty->line_coding.rate = cpu_to_le32(9600); gb_tty->line_coding.format = GB_SERIAL_1_STOP_BITS; gb_tty->line_coding.parity = GB_SERIAL_NO_PARITY; gb_tty->line_coding.data_bits = 8; - send_line_coding(gb_tty); + retval = send_line_coding(gb_tty); + if (retval) + goto exit_connection_disable; retval = gb_connection_enable(connection); if (retval) -- 2.48.1

2 weeks, 5 days

Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const

by kernel test robot

Hi Chang, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Chang-Junzheng/staging-greyb… base: staging/staging-testing patch link: https://lore.kernel.org/r/tencent_3725607DD617A567779DEB1BEC7C3B335208%40qq… patch subject: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const config: arm-randconfig-001-20251114 (https://download.01.org/0day-ci/archive/20251114/202511140945.OPHTq1yc-lkp@…) compiler: arm-linux-gnueabi-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511140945.OPHTq1yc-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202511140945.OPHTq1yc-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/staging/greybus/audio_manager_module.c: In function 'send_add_uevent': >> drivers/staging/greybus/audio_manager_module.c:163:9: error: initializer element is not constant 163 | name_string, | ^~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:163:9: note: (near initialization for 'envp[0]') drivers/staging/greybus/audio_manager_module.c:164:9: error: initializer element is not constant 164 | vid_string, | ^~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:164:9: note: (near initialization for 'envp[1]') drivers/staging/greybus/audio_manager_module.c:165:9: error: initializer element is not constant 165 | pid_string, | ^~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:165:9: note: (near initialization for 'envp[2]') drivers/staging/greybus/audio_manager_module.c:166:9: error: initializer element is not constant 166 | intf_id_string, | ^~~~~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:166:9: note: (near initialization for 'envp[3]') drivers/staging/greybus/audio_manager_module.c:167:9: error: initializer element is not constant 167 | ip_devices_string, | ^~~~~~~~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:167:9: note: (near initialization for 'envp[4]') drivers/staging/greybus/audio_manager_module.c:168:9: error: initializer element is not constant 168 | op_devices_string, | ^~~~~~~~~~~~~~~~~ drivers/staging/greybus/audio_manager_module.c:168:9: note: (near initialization for 'envp[5]') >> drivers/staging/greybus/audio_manager_module.c:181:53: error: passing argument 3 of 'kobject_uevent_env' from incompatible pointer type [-Wincompatible-pointer-types] 181 | kobject_uevent_env(&module->kobj, KOBJ_ADD, envp); | ^~~~ | | | const char * const* In file included from drivers/staging/greybus/audio_manager.h:11, from drivers/staging/greybus/audio_manager_module.c:10: include/linux/kobject.h:216:31: note: expected 'char **' but argument is of type 'const char * const*' 216 | char *envp[]); | ~~~~~~^~~~~~ vim +163 drivers/staging/greybus/audio_manager_module.c 8db00736d365b7 Svetlin Ankov 2016-01-13 152 8db00736d365b7 Svetlin Ankov 2016-01-13 153 static void send_add_uevent(struct gb_audio_manager_module *module) 8db00736d365b7 Svetlin Ankov 2016-01-13 154 { 8db00736d365b7 Svetlin Ankov 2016-01-13 155 char name_string[128]; 8db00736d365b7 Svetlin Ankov 2016-01-13 156 char vid_string[64]; 8db00736d365b7 Svetlin Ankov 2016-01-13 157 char pid_string[64]; d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 158 char intf_id_string[64]; a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 159 char ip_devices_string[64]; a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 160 char op_devices_string[64]; 8db00736d365b7 Svetlin Ankov 2016-01-13 161 9af5fbe96477a4 Chang Junzheng 2025-11-13 162 static const char * const envp[] = { 8db00736d365b7 Svetlin Ankov 2016-01-13 @163 name_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 164 vid_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 165 pid_string, d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 166 intf_id_string, a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 167 ip_devices_string, a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 168 op_devices_string, 8db00736d365b7 Svetlin Ankov 2016-01-13 169 NULL 8db00736d365b7 Svetlin Ankov 2016-01-13 170 }; 8db00736d365b7 Svetlin Ankov 2016-01-13 171 8db00736d365b7 Svetlin Ankov 2016-01-13 172 snprintf(name_string, 128, "NAME=%s", module->desc.name); 8db00736d365b7 Svetlin Ankov 2016-01-13 173 snprintf(vid_string, 64, "VID=%d", module->desc.vid); 8db00736d365b7 Svetlin Ankov 2016-01-13 174 snprintf(pid_string, 64, "PID=%d", module->desc.pid); d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16 175 snprintf(intf_id_string, 64, "INTF_ID=%d", module->desc.intf_id); a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 176 snprintf(ip_devices_string, 64, "I/P DEVICES=0x%X", a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 177 module->desc.ip_devices); a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 178 snprintf(op_devices_string, 64, "O/P DEVICES=0x%X", a9234bfd6cec44 Vaibhav Agarwal 2016-03-30 179 module->desc.op_devices); 8db00736d365b7 Svetlin Ankov 2016-01-13 180 8db00736d365b7 Svetlin Ankov 2016-01-13 @181 kobject_uevent_env(&module->kobj, KOBJ_ADD, envp); 8db00736d365b7 Svetlin Ankov 2016-01-13 182 } 8db00736d365b7 Svetlin Ankov 2016-01-13 183 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

2 weeks, 6 days

Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const

by Greg Kroah-Hartman

On Thu, Nov 13, 2025 at 10:12:00PM +0800, Chang Junzheng wrote: > From: Chang Junzheng <guagua210311(a)outlook.com> > > Fix checkpatch.pl warning by changing envp array declaration to > static const char * const. This improves code safety and follows > kernel coding style recommendations. > > Signed-off-by: Chang Junzheng <guagua210311(a)qq.com> > Changes in v2: > - Restored original indentation of array elements > - Only changed the array declaration as originally intended The "Changes" goes below the --- line, as per the documentation. thanks, greg k-h

2 weeks, 6 days

Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const

by Greg Kroah-Hartman

On Thu, Nov 13, 2025 at 09:39:54PM +0800, cjz_VM wrote: > Hi Greg, > > Thanks for reviewing my patch! > > For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all. Then that should have been a v2 patch :) > For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis. > > If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend. You did not document your change, and it had nothing really to do with the const change, so I would not recommend doing this. Also, please do not top-post, and be sure to properly wrap your lines in your email client. thanks, greg k-h

2 weeks, 6 days

Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const

by Greg Kroah-Hartman

On Thu, Nov 13, 2025 at 09:01:46PM +0800, Chang Junzheng wrote: > From: Chang Junzheng <guagua210311(a)outlook.com> > > The envp array in send_add_uevent() function is declared as a non-const > local array, which triggers the following checkpatch.pl warning: > > WARNING: char * array declaration might be better as static const > > Change the declaration to 'static const char * const' to improve code > safety by making the array read-only and allow for better compiler > optimization. This follows the kernel coding style recommendations. > > Signed-off-by: Chang Junzheng <guagua210311(a)qq.com> You sent this twice? > --- > drivers/staging/greybus/audio_manager_module.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c > index 4a4dfb42f50f..ca6a2cd0bc4f 100644 > --- a/drivers/staging/greybus/audio_manager_module.c > +++ b/drivers/staging/greybus/audio_manager_module.c > @@ -159,14 +159,14 @@ static void send_add_uevent(struct gb_audio_manager_module *module) > char ip_devices_string[64]; > char op_devices_string[64]; > > - char *envp[] = { > - name_string, > - vid_string, > - pid_string, > - intf_id_string, > - ip_devices_string, > - op_devices_string, > - NULL > + static const char * const envp[] = { > + name_string, > + vid_string, > + pid_string, > + intf_id_string, > + ip_devices_string, > + op_devices_string, > + NULL Why did you indent this? thanks, greg k-h

2 weeks, 6 days

[PATCH v2] greybus: add WQ_PERCPU to alloc_workqueue users

by Marco Crivellari

This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo <tj(a)kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari(a)suse.com> Reviewed-by: Johan Hovold <johan(a)kernel.org> --- Changes in v2: - updated commit log removing two paragraph not strictly related to the work. - subject changed removing "drivers/" before the actual prefix. --- drivers/greybus/operation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c index 54ccc434a1f7..7e12ffb2dd60 100644 --- a/drivers/greybus/operation.c +++ b/drivers/greybus/operation.c @@ -1238,7 +1238,7 @@ int __init gb_operation_init(void) goto err_destroy_message_cache; gb_operation_completion_wq = alloc_workqueue("greybus_completion", - 0, 0); + WQ_PERCPU, 0); if (!gb_operation_completion_wq) goto err_destroy_operation_cache; -- 2.51.1

3 weeks

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev