- greybus-dev - lists.linaro.org

[PATCH] Staging: greybus: Cleanup in header file control.h

by Madhumitha Prabakaran

Fix a blank line after function/struct/union/enum declarations. Also, convert to_gb_control() macro into an inline function in order to maintain Linux kernel coding style based on which the inline function is preferable over the macro. Signed-off-by: Madhumitha Prabakaran <madhumithabiw(a)gmail.com> --- drivers/staging/greybus/control.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h index 3a29ec05f631..a681ef74e7fe 100644 --- a/drivers/staging/greybus/control.h +++ b/drivers/staging/greybus/control.h @@ -24,7 +24,11 @@ struct gb_control { char *vendor_string; char *product_string; }; -#define to_gb_control(d) container_of(d, struct gb_control, dev) + +static inline struct gb_control *to_gb_control(struct device *d) +{ + return container_of(d, struct gb_control, dev); +} struct gb_control *gb_control_create(struct gb_interface *intf); int gb_control_enable(struct gb_control *control); -- 2.17.1

5 years, 1 month

3
6
0 0

[PATCH] Staging: greybus: Fix spinlock_t definition without comment

by Madhumitha Prabakaran

Fix spinlock_t definition without comment. Signed-off-by: Madhumitha Prabakaran <madhumithabiw(a)gmail.com> --- drivers/staging/greybus/connection.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/connection.h b/drivers/staging/greybus/connection.h index 5ca3befc0636..0aedd246e94a 100644 --- a/drivers/staging/greybus/connection.h +++ b/drivers/staging/greybus/connection.h @@ -47,7 +47,7 @@ struct gb_connection { unsigned long flags; struct mutex mutex; - spinlock_t lock; + spinlock_t lock; /* Protect structure fields */ enum gb_connection_state state; struct list_head operations; -- 2.17.1

5 years, 1 month

5
5
0 0

[PATCH] Staging: greybus: usb: Fixed a coding style error

by Will Cunningham

Line was >80 characters. Signed-off-by: Will Cunningham <wjcunningham7(a)gmail.com> --- drivers/staging/greybus/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c index 1c246c73a085..5b4cbec88159 100644 --- a/drivers/staging/greybus/usb.c +++ b/drivers/staging/greybus/usb.c @@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev, return -ENOMEM; connection = gb_connection_create(gbphy_dev->bundle, - le16_to_cpu(gbphy_dev->cport_desc->id), - NULL); + le16_to_cpu(gbphy_dev->cport_desc->id), + NULL); if (IS_ERR(connection)) { retval = PTR_ERR(connection); goto exit_usb_put; -- 2.19.2

5 years, 1 month

4
5
0 0

[PATCH] staging: greybus: power_supply: Use struct_size() helper

by Gustavo A. R. Silva

Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace code of the following form: sizeof(*resp) + props_count * sizeof(struct gb_power_supply_props_desc) with: struct_size(resp, props, props_count) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo(a)embeddedor.com> --- drivers/staging/greybus/power_supply.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c index 0529e5628c24..40cc2d462ba0 100644 --- a/drivers/staging/greybus/power_supply.c +++ b/drivers/staging/greybus/power_supply.c @@ -520,8 +520,8 @@ static int gb_power_supply_prop_descriptors_get(struct gb_power_supply *gbpsy) op = gb_operation_create(connection, GB_POWER_SUPPLY_TYPE_GET_PROP_DESCRIPTORS, - sizeof(req), sizeof(*resp) + props_count * - sizeof(struct gb_power_supply_props_desc), + sizeof(req), + struct_size(resp, props, props_count), GFP_KERNEL); if (!op) return -ENOMEM; -- 2.21.0

5 years, 1 month

3
5
0 0

[PATCH] staging: greybus: power_supply: fix prop-descriptor request size

by Johan Hovold

Since moving the message buffers off the stack, the dynamically allocated get-prop-descriptor request buffer is incorrectly sized due to using the pointer rather than request-struct size when creating the operation. Fortunately, the pointer size is always larger than this one-byte request, but this could still cause trouble on the remote end due to the unexpected message size. Fixes: 9d15134d067e ("greybus: power_supply: rework get descriptors") Cc: stable <stable(a)vger.kernel.org> # 4.9 Cc: Rui Miguel Silva <rui.silva(a)linaro.org> Signed-off-by: Johan Hovold <johan(a)kernel.org> --- drivers/staging/greybus/power_supply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c index 0529e5628c24..ae5c0285a942 100644 --- a/drivers/staging/greybus/power_supply.c +++ b/drivers/staging/greybus/power_supply.c @@ -520,7 +520,7 @@ static int gb_power_supply_prop_descriptors_get(struct gb_power_supply *gbpsy) op = gb_operation_create(connection, GB_POWER_SUPPLY_TYPE_GET_PROP_DESCRIPTORS, - sizeof(req), sizeof(*resp) + props_count * + sizeof(*req), sizeof(*resp) + props_count * sizeof(struct gb_power_supply_props_desc), GFP_KERNEL); if (!op) -- 2.21.0

5 years, 1 month

2
1
0 0

Please get back to me if interested.

by Djamila Salif

Greetings to you my dear. It’s my pleasure to contact you through this media. Excuse my interruption into your private life without your prior permission. I hope my mail will not cause you much embarrassment as I write to you in good faith. I know this message might come to you as a surprise because you don’t know me in person but it is only God that brought us together. My names are is Ms. Djamila Salif I am the regional chief account manager of one of the Prime Bank herein Burkina Faso. I am 31 years old lady, single. I am a young woman of peace and I don't want problems in my life. I have packaged a financial transaction that will benefit both of us. As the regional account manager of the Ecobank Plc Burkina Faso branch. It is my duty to send in a financial report of my customers to our head office in the capital at the end of each year. But in the course of the last year 2018 fiscal report, I discovered that one of my foreign customer late (Hon. Mr. Ghazi al-Sadiq Abdel Rahim) who died during the Sudan crash on 9 August 2012, you can read more about the crash through this site: https://www.bbc.co.uk/news/world-africa-19310609 My head office are not aware of it and it will never be aware of this transaction. He was a business magnate & Sudanese government's religion minister. He deposited the sum of $18.500, 000.00. This fund have been placed in what we call "escrow call" account with no beneficiary. As an officer of this bank I cannot be directly connected to this money, so my aim of contacting you is for you to assist me to receive this money in your country through your bank account, and get 50% of the total funds as commission/share while 50% for me. Since you are from another country outside Burkina Faso, I need your cooperation to stand as the next of kin to the defunct customer of our bank who died in the crash. I have made every attempt to searching for his blood relation or any family member who can stand to inherit the money without any fruitful result. To be very honest with you, this money I have opened-up to you is totally genuine no complications and is 100% risk-free. I am absolutely assuring you that no problem involved in this fund either in the short-run or in the long-run of this transaction. I have every information about this money and I will be backing you up with information that can make you claim the money from our bank but you will not tell anybody in my bank that the information is from my side. By virtue of my position, I can guarantee you that we stand a great chance of success in this transaction, If you are interested, please indicate your willingness to initiate the process by contacting me via email to enable us discuss the terms and conditions under which this transaction would be carried out. (1) Please my dear do you also have any business Idea where we can invest the fund? (2) Do we invest the fund in your company or in your business? (3) Or Maybe we should register a new company? Reply me If only you are interested in this deal, I will give you further details of the transaction Yours Sincerely Ms.Djamila Salif, Regional account manager Ecobank Plc Burkina Faso.

5 years, 1 month

1
0
0 0

[PATCH] staging: greybus: bundle.c fix comparison to NULL

by Dominik Adamski

Fix checkpatch issue: Comparison to NULL could be written "!bundle->state" Signed-off-by: Dominik Adamski <adamski.dominik(a)gmail.com> --- drivers/staging/greybus/bundle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c index e97b2b87ba47..3f702db9e098 100644 --- a/drivers/staging/greybus/bundle.c +++ b/drivers/staging/greybus/bundle.c @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, { struct gb_bundle *bundle = to_gb_bundle(dev); - if (bundle->state == NULL) + if (!bundle->state) return sprintf(buf, "\n"); return sprintf(buf, "%s\n", bundle->state); -- 2.19.1

5 years, 2 months

2
1
0 0

[PATCH v7 0/3] greybus: gpio: Switch to the gpio descriptor interface

by Nishad Kamdar

This patch series converts uses of the old GPIO API to the GPIO descriptor API. It also converts the GPIO driver to use the GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing the same. Chnages in v7: - Combine the three patches together. Changes in v6: - Patchset now contains two patches as the patch 1 has been accepted. - Changes mentioned in individual patches of the set. Changes in v5: - Drop the patch which uses gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller() as of now. - This is because it currently breaks the driver, since gpiochip_add() sets the data pointer to NULL. Changes in v4: - Changes mentioned in individual patches of the set. Changes in v3: - Combines the latest versions of the three greybus patches together in a patch series. Nishad Kamdar (3): staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface staging: greybus: arche-platform: Switch to the gpio descriptor interface drivers/staging/greybus/Kconfig | 1 + drivers/staging/greybus/TODO | 2 - drivers/staging/greybus/arche-apb-ctrl.c | 152 +++++++++------------- drivers/staging/greybus/arche-platform.c | 124 ++++++------------ drivers/staging/greybus/gpio.c | 156 ++--------------------- 5 files changed, 113 insertions(+), 322 deletions(-) -- 2.17.1

5 years, 4 months

3
6
0 0

[PATCH v6 0/2] greybus: gpio: Switch to the gpio descriptor interface

by Nishad Kamdar

This patch series converts uses of the old GPIO API to the GPIO descriptor API. It also converts the GPIO driver to use the GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing the same. Changes in v6: - Patchset now contains two patches as the patch 1 has been accepted. - Changes mentioned in individual patches of the set. Changes in v5: - Drop the patch which uses gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller() as of now. - This is because it currently breaks the driver, since gpiochip_add() sets the data pointer to NULL. Changes in v4: - Changes mentioned in individual patches of the set. Changes in v3: - Combines the latest versions of the three greybus patches together in a patch series. Nishad Kamdar (2): staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface staging: greybus: arche-platform: Switch to the gpio descriptor interface drivers/staging/greybus/arche-apb-ctrl.c | 152 +++++++++-------------- drivers/staging/greybus/arche-platform.c | 124 ++++++------------ 2 files changed, 102 insertions(+), 174 deletions(-) -- 2.17.1

5 years, 4 months

2
4
0 0

[PATCH v5 0/3] greybus: gpio: Switch to the gpio descriptor interface

by Nishad Kamdar

This patch series converts uses of the old GPIO API to the GPIO descriptor API. It also converts the GPIO driver to use the GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing the same. Changes in v5: - Drop the patch which uses gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller() as of now. - This is because it currently breaks the driver, since gpiochip_add() sets the data pointer to NULL. Changes in v4: - Changes mentioned in individual patches of the set. Changes in v3: - Combines the latest versions of the three greybus patches together in a patch series. Nishad Kamdar (3): staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface staging: greybus: arche-platform: Switch to the gpio descriptor interface drivers/staging/greybus/Kconfig | 1 + drivers/staging/greybus/TODO | 2 - drivers/staging/greybus/arche-apb-ctrl.c | 154 +++++++++------------- drivers/staging/greybus/arche-platform.c | 124 ++++++------------ drivers/staging/greybus/gpio.c | 156 ++--------------------- 5 files changed, 115 insertions(+), 322 deletions(-) -- 2.17.1

5 years, 4 months

2
8
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev