greybus-dev

greybus-dev@lists.linaro.org

3 participants
578 discussions

[PATCH] staging: greybus: mark PM functions as __maybe_unused

by Arnd Bergmann

Enabling the arche platform for compile testing showed a harmless warning with CONFIG_PM=n: drivers/staging/greybus/arche-platform.c:632:12: error: 'arche_platform_resume' defined but not used [-Werror=unused-function] drivers/staging/greybus/arche-platform.c:618:12: error: 'arche_platform_suspend' defined but not used [-Werror=unused-function] This marks the functions as __maybe_unused to shut up the warnings. Fixes: 2eccd4aa19fc ("staging: greybus: enable compile testing of arche driver") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/staging/greybus/arche-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 5bce5e039596..eced2d26467b 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -615,7 +615,7 @@ static int arche_platform_remove(struct platform_device *pdev) return 0; } -static int arche_platform_suspend(struct device *dev) +static __maybe_unused int arche_platform_suspend(struct device *dev) { /* * If timing profile premits, we may shutdown bridge @@ -629,7 +629,7 @@ static int arche_platform_suspend(struct device *dev) return 0; } -static int arche_platform_resume(struct device *dev) +static __maybe_unused int arche_platform_resume(struct device *dev) { /* * Atleast for ES2 we have to meet the delay requirement between -- 2.9.0

8 years, 1 month

[PATCH v2 0/2] staging: greybus: fix arche driver compilation

by Johan Hovold

The arche driver currently depends on the out-of-tree usb3613 driver and this prevented a recent compile breakage after removing the timesync code from being detected. These patches remove the remaining timesync bits, and enable compile testing of the arche driver to avoid further unintended breakage. Johan Changes in v2 - fix usb3613 Kconfig dependency (Randy Dunlap) Johan Hovold (2): staging: greybus: arche: remove timesync remains staging: greybus: enable compile testing of arche driver drivers/staging/greybus/Kconfig | 10 +++ drivers/staging/greybus/Makefile | 2 +- drivers/staging/greybus/arche-apb-ctrl.c | 11 +-- drivers/staging/greybus/arche-platform.c | 150 ++----------------------------- drivers/staging/greybus/arche_platform.h | 8 -- 5 files changed, 21 insertions(+), 160 deletions(-) -- 2.13.0

8 years, 1 month

[PATCH 0/2] staging: greybus: fix arche driver compilation

by Johan Hovold

The arche driver currently depends on the out-of-tree usb3613 driver and this prevented a recent compile breakage after removing the timesync code from being detected. These patches remove the remaining timesync bits, and enable compile testing of the arche driver to avoid further unintended breakage. Johan Johan Hovold (2): staging: greybus: arche: remove timesync remains staging: greybus: enable compile testing of arche driver drivers/staging/greybus/Kconfig | 10 +++ drivers/staging/greybus/Makefile | 2 +- drivers/staging/greybus/arche-apb-ctrl.c | 11 +-- drivers/staging/greybus/arche-platform.c | 150 ++----------------------------- drivers/staging/greybus/arche_platform.h | 8 -- 5 files changed, 21 insertions(+), 160 deletions(-) -- 2.13.0

8 years, 1 month

[PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

by JB Van Puyvelde

According to checkpatch.pl, kcalloc should be preferred to kzalloc with multiply. Signed-off-by: JB Van Puyvelde <jbvanpuyvelde(a)gmail.com> --- drivers/staging/greybus/power_supply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c index e85c988b7034..20cac20518d7 100644 --- a/drivers/staging/greybus/power_supply.c +++ b/drivers/staging/greybus/power_supply.c @@ -944,7 +944,7 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies) if (ret < 0) goto out; - supplies->supply = kzalloc(supplies->supplies_count * + supplies->supply = kcalloc(supplies->supplies_count, sizeof(struct gb_power_supply), GFP_KERNEL); -- 2.11.0

8 years, 1 month

[PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

by JB Van Puyvelde

8 years, 1 month

[PATCH] Staging: greybus: Prefer kcalloc over kzalloc

by karthik＠techveda.org

From: Karthik Tummala <karthik(a)techveda.org> Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as arugment in kzalloc, prefer kcalloc. Signed-off-by: Karthik Tummala <karthik(a)techveda.org> --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 1681362..861a249 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1030,7 +1030,7 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); - light->channels = kzalloc(light->channels_count * + light->channels = kcalloc(light->channels_count, sizeof(struct gb_channel), GFP_KERNEL); if (!light->channels) return -ENOMEM; @@ -1167,7 +1167,7 @@ static int gb_lights_create_all(struct gb_lights *glights) if (ret < 0) goto out; - glights->lights = kzalloc(glights->lights_count * + glights->lights = kcalloc(glights->lights_count, sizeof(struct gb_light), GFP_KERNEL); if (!glights->lights) { ret = -ENOMEM; -- 1.9.1

8 years, 1 month

[PATCH 0/3] Add the Generic Netlink controller

by Alexandre Bailon

Currently, only the es2 hd controller is supported, which restrict the usage of greybus to few products. This series intents to add a support of new hd controllers. The driver doesn't support any hardware. Actually, the controller is just a bridge between Greybus kernel and userspace. The real driver must be implemented in userspace. This give the ability to support any kind of transport layer (such as Bluetooth, WiFi, Ethernet). The controller uses Generic Netlink. My original intent was to implement a TCP/IP controller but it was very slow, unstable. In addition, some features such as SVC or module discovery were to add to implement in kernel side. With the generic netlink controller, we can easily add support of new controller. It also helps to deal with all the project ARA legacy such as SVC. I have started to implement an application which is able to emulate the SVC, a module (like gbsim but only support control and loopback protcols), TCP/IP, Bluetooth and UART. It is still under development but it was stable enough to test this series. The application can found here: https://github.com/anobli/gbridge Alexandre Bailon (3): staging greybus: make cport_quiesce() method optional staging: greybus: Add Greybus netlink driver staging: greybus: netlink: Add a way to "hot remove" SVC drivers/staging/greybus/Kconfig | 9 ++ drivers/staging/greybus/Makefile | 2 + drivers/staging/greybus/connection.c | 3 + drivers/staging/greybus/gb_netlink.h | 38 ++++++ drivers/staging/greybus/netlink.c | 256 +++++++++++++++++++++++++++++++++++ 5 files changed, 308 insertions(+) create mode 100644 drivers/staging/greybus/gb_netlink.h create mode 100644 drivers/staging/greybus/netlink.c -- 2.10.2

8 years, 1 month

[PATCH 1/2] staging: greybus: light.c: Remove include linux/version.h

by Darryl T. Agostinelli

Fixes: $ make versioncheck | grep staging ./drivers/staging/greybus/light.c: 15 linux/version.h not needed. Signed-off-by: Darryl T. Agostinelli <dagostinelli(a)gmail.com> --- drivers/staging/greybus/light.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 8dffd8a..1681362 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -12,7 +12,6 @@ #include <linux/led-class-flash.h> #include <linux/module.h> #include <linux/slab.h> -#include <linux/version.h> #include <media/v4l2-flash-led-class.h> #include "greybus.h" -- 2.9.3

8 years, 2 months

[PATCH] staging: greybus: compress return logic

by Arushi Singhal

Simplify function returns by merging assignment and return. Signed-off-by: Arushi Singhal <arushisinghal19971997(a)gmail.com> --- drivers/staging/greybus/loopback.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index aaf29a5fac83..08e255884206 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -365,11 +365,8 @@ static void gb_loopback_calculate_stats(struct gb_loopback *gb, bool error); static u32 gb_loopback_nsec_to_usec_latency(u64 elapsed_nsecs) { - u32 lat; - do_div(elapsed_nsecs, NSEC_PER_USEC); - lat = elapsed_nsecs; - return lat; + return elapsed_nsecs; } static u64 __gb_loopback_calc_latency(u64 t1, u64 t2) -- 2.11.0

8 years, 2 months

greybus file names

by Tobin C. Harding

Is there a technical reason why greybus files mix hyphen and underscore in their names? $ ls drivers/staging/greybus/arch* arche-apb-ctrl.c arche-platform.c arche_platform.h thanks, Tobin.

8 years, 3 months

← Newer
1
...
49
50
51
52
53
54
55
...
58
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

greybus-dev