Re: [greybus-dev] [PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

On 11-05-17, 01:20, JB Van Puyvelde wrote:

According to checkpatch.pl, kcalloc should be preferred to kzalloc with multiply.

Signed-off-by: JB Van Puyvelde jbvanpuyvelde@gmail.com

drivers/staging/greybus/power_supply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c index e85c988b7034..20cac20518d7 100644 --- a/drivers/staging/greybus/power_supply.c +++ b/drivers/staging/greybus/power_supply.c @@ -944,7 +944,7 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies) if (ret < 0) goto out;

• supplies->supply = kzalloc(supplies->supplies_count *

• supplies->supply = kcalloc(supplies->supplies_count, sizeof(struct gb_power_supply), GFP_KERNEL);

Acked-by: Viresh Kumar viresh.kumar@linaro.org