Re: [greybus-dev] [PATCH 01/25] tty: Change return type to void

On Wed, Sep 5, 2018 at 2:57 PM Jiri Slaby jslaby@suse.cz wrote:

On 09/05/2018, 03:08 AM, Jaejoong Kim wrote:

...

> @@ -688,7 +688,7 @@ extern int tty_port_close_start(struct
tty_port *port,
>   extern void tty_port_close_end(struct tty_port *port, struct
tty_struct *tty);
>   extern void tty_port_close(struct tty_port *port,
>                               struct tty_struct *tty, struct file
*filp);
> -extern int tty_port_install(struct tty_port *port, struct
tty_driver *driver,
> +extern void tty_port_install(struct tty_port *port, struct
tty_driver *driver,
>                               struct tty_struct *tty);

    You need to update all the callers in the same patch -- the
kernel must
remain buildable after each patch but you seem to have spread that
update
among a lot of patches..

OK. I will make several patches as one patch.

You don't have to. Just reorder the patches as suggested by Sam. (First, make everybody ignore the return value, then change these return types to void.)

I should have waited more.. I already made V2 and it will be drop. :)

BTW you can mention in this commit log, that this change is possible after a3123fd0a4a5. That commit made tty_standard_install to always return 0.

OK. Thanks for the guide line. I will come back with V3.

Jaejoong

thanks,

js suse labs