On Sun, Oct 16, 2022 at 11:50:45AM -0400, Deepak R Varma wrote:
On Sun, Oct 16, 2022 at 05:40:59PM +0200, Greg KH wrote:
On Sun, Oct 16, 2022 at 11:27:30AM -0400, Deepak R Varma wrote:
On Sun, Oct 16, 2022 at 05:10:17PM +0200, Julia Lawall wrote:
On Sun, 16 Oct 2022, Deepak R Varma wrote:
On Sun, Oct 16, 2022 at 04:51:09PM +0200, Julia Lawall wrote:
On Sun, 16 Oct 2022, Deepak R Varma wrote:
> Include multiple statements of macro definition inside do-while{0} loop > to avoid possible partial program execution. Issue reported by > checkpatch script: > > ERROR: Macros with multiple statements should be enclosed in a do - while loop
I don't think this change will compile. See if you can figure out why not.
It did compile. I built the greybus driver and loaded it as well with the modinfo tool. Can you please tell why you think it won't compile?
Do you have a .o file for the .c file that you changed?
I see many .o files and a greybus.ko as well, but not the loopback.o Am I missing anything with my configuration? I did set Greybus Support to (M) in the menuconfig.
CONFIG_GREYBUS_LOOPBACK has to be enabled in order to build the drivers/staging/greybus/loopback.c file.
A simple check would be to do: make drivers/staging/greybus/loopback.o
does that work with your change?
No, it did not. I understand why it did not. My apologies for not looking into the build of loopback.o file when the greybus module was rebuilt.
Please ignore my patch.
I just received a message from Kernel Test Robot that this patch failed to compile. I had requested to drop/ignore this patch. However, looks like it included in the staging-testing tree????
Let me know anything required from me to fix the bot complaint. Thank you.
Thank you Julia and Greg for the feedback. ./drv
thanks,
greg k-h