On 2024-07-20 at 03:09:55, Alex Elder (elder@ieee.org) wrote:
On 7/19/24 2:15 PM, Andrew Lunn wrote:
drivers/greybus/Kconfig | 1 + drivers/greybus/gb-beagleplay.c | 625 +++++++++++++++++++++++++++++++++++++++-
+static u8 csum8(const u8 *data, size_t size, u8 base) +{
- size_t i;
- u8 sum = base;
follow reverse x-mas tree
Since this is not networking, even thought it was posted to the netdev list, this comment might not be correct. I had a quick look at some greybus code and reverse x-mas tree is not strictly used.
Please see what the Graybus Maintainers say.
Andrew is correct. The Greybus code does not strictly follow the "reverse christmas tree" convention, so there is no need to do that here. Please understand that, while checkpatch.pl offers good and well-intentioned advice, not everything it warns about must be fixed, and in some cases it suggests things certain maintainers don't agree with.
-AlexAndrew
Ok got it.