[greybus-dev] Re: [PATCH v4 2/2] staging: greybus: resolved checkpatch checks for light.c

On Sat, Mar 07, 2026 at 02:09:25PM +0000, Rachit Dhar wrote:

Added comments to mutex declarations, to resolve the associated checkpatch.pl checks:

CHECK: struct mutex definition without comment

•   struct mutex                    lock;
  
  

CHECK: struct mutex definition without comment

•   struct mutex            lights_lock;
  
  

Signed-off-by: Rachit Dhar rchtdhr@gmail.com

These kinds of things require more than a two word explanation. It should probably be a paragraph. But first do a proper review of the locking. When do we start needing to worry about concurrent accesses? How is it accessed? What would happen if the locking were not there? Is the unregister sequence correct?

regards, dan carpenter